haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
30,848 Commits 9 Branches 105 Tags 1.3 GiB
Commit Graph

336 Commits

Author SHA1 Message Date
Seth Hillbrand a444addd89 Default eeschema strings to wide 
Prevents stack bug on MacOS
 2022-02-08 15:14:54 -08:00
Marek Roszko 50d3a507d0 Mark some limits as constexpr 
gcc doesn't need it and computes during compile regardless, but experimenting in godbolt, both clang and MSVC actually do need it or else it's partially computed at runtime


(cherry picked from commit ca7840334c)
 2022-02-04 12:50:54 +00:00
Seth Hillbrand dcb8f29317 Handle rotated symbol rectangles in Eagle import 
Fixes https://gitlab.com/kicad/code/kicad/issues/10360
 2022-01-12 15:10:42 -08:00
Seth Hillbrand 71e7b4b77b Use 'special' escaping for certain fields 
Most fields are escaped using the `\` notation.  But the VALUE field and
the symbol name need to be escaped using braces notation.

Fixes https://gitlab.com/kicad/code/kicad/issues/10097
 2022-01-05 17:18:39 -08:00
Steffen Mauch 7afe188a29 eeschema: automatic generated symbol library from EAGLE plugin does not include footprint reference 
Fixes https://gitlab.com/kicad/code/kicad/issues/10262

(cherry picked from commit 3ced3afa68)
 2022-01-05 15:28:05 -05:00
Steffen Mauch d60e77176f eeschema: EAGLE plugin does not reference footprint with library suffix 
Fixes https://gitlab.com/kicad/code/kicad/issues/10261

(cherry picked from commit 502e34349e)
 2022-01-05 14:39:43 -05:00
Seth Hillbrand a05ec04ee8 Set readable flags correctly on open 
Missing files may be thrown during open.  These should have existence
and readable flags set correctly
 2022-01-05 09:54:10 -08:00
Jon Evans ea99c42df6 Move duplicate field handling into field parser 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/10130
 2022-01-02 13:19:31 -05:00
dsa-t f2ad8bffe0 Fix a mistake in Altium parser 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/10011
 2021-12-16 05:49:39 +03:00
Wayne Stambaugh 067fa65756 Eeschema: fix a multitude of LIB_FIELD object comparison and index bugs. 
It is no longer acceptable to set a LIB_FIELD index to -1.  This was
trashing the sorting on load cause all kinds of false field comparison
failures.  There are now assertions when attempting to use -1 as a field
index.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/9811
 2021-12-12 17:06:32 -05:00
Seth Hillbrand 91dace3e5e Update Eagle importer 
Fixes arc orientation
Sets root schematic and page numbers

Fixes https://gitlab.com/kicad/code/kicad/issues/9907
 2021-12-10 15:41:25 -08:00
Wayne Stambaugh af280f80e0 Fix debug assertion in Altium and CADSTAR schematic importers. 2021-12-09 12:56:03 +00:00
Wayne Stambaugh b7af66e3f9 Eeschema: fix broken page numbers when renaming a sheet file name. 
Always use full sheet paths when storing sheet instances.  Partial sheet
paths cannot be full resolved resulting in lost page numbers when renaming
sheet file name.

Fixes #9782
 2021-12-09 12:56:03 +00:00
Wayne Stambaugh a03e6e4926 Revert "Eeschema: fix broken page numbers when renaming a sheet file name." 
This reverts commit a468a79948.
 2021-12-06 07:47:18 -05:00
jean-pierre charras 3a00d76207 Fix a compil warning (shadowed var) and add a comment. 2021-12-01 11:05:16 +01:00
dsa-t bfe595819a Prevent error when loading bitmaps from some old schematics 2021-12-01 09:54:48 +00:00
Wayne Stambaugh a468a79948 Eeschema: fix broken page numbers when renaming a sheet file name. 
Remove duplicate instance data saved in both root SCH_SCREEN and SCH_SHEET
objects that was causing them to be out of sync.  All sheet instance data
is stored in the SCH_SHEET object itself and rebuilt on the fly so it is
always current.

Remove Get/SetPageNumber from SCH_SHEET_PATH object so it doesn't obfuscate
where the actual sheet page number information exists.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/9782
 2021-11-30 08:11:24 -05:00
Mikolaj Wielgus 9bb370e6b4 SCH_SHEET_PIN: Rename GetEdge, SetEdge to GetSide, SetSide 2021-11-28 20:07:06 +01:00
Jeff Young 58b5ac4970 Don't create SCH_LINE till we know the layer. 
The CTOR makes some decisions on initialization based on the layer.
 2021-11-28 17:09:24 +00:00
Roberto Fernandez Bautista 3660597082 Use canonical names when saving sheet name and filename fields 2021-11-27 20:38:51 +00:00
Jeff Young 228edd4121 Don't generate duplicate IDs in line/wire/bus tool. 
Also cleans up existing duplicate IDs when reading.

Fixes https://gitlab.com/kicad/code/kicad/issues/9749
 2021-11-24 13:20:44 +00:00
Jeff Young b052d56c7b R/W uuids for junctions. 2021-11-24 13:20:44 +00:00
Jeff Young 025d9f82ea Remove atrophied schematic default wire and bus widths. 
(They're now in the netclasses, and specifically the default netclass
if no other netclass is assigned.)

Fixes https://gitlab.com/kicad/code/kicad/issues/9628
 2021-11-13 22:56:50 +00:00
Wayne Stambaugh 80c5b1efb1 File formatting improvements and fixes. 
Symbol library IDs included the library nickname which is incorrect
and meaningless since it will be overwritten by the symbol library
table code.  This is not a file format change as there are no behavioral
differences.
 2021-11-13 12:57:18 -05:00
Jeff Young 54e00569d8 Don't fetch the root sheet's UUID out of the sheet instances. 
1) we're storing it now anyway
2) the root sheet UUID is the one UUID that's *not* in the instance
array, and previously we were erroneously grabbing the first sub-sheet's
UUID (producing duplicate UUIDs).
 2021-11-09 16:07:30 +00:00
Seth Hillbrand cf6b18ec7e Remove escaped double-quotes 
For some reason, escaped double quotes in wxString::Format cause issues
on Mac.  We can replace them with single quotes in most places without
loss of clarity
 2021-11-03 17:03:14 -07:00
Jeff Young c2371f3943 Revert e4b61de792. 
It doesn't seem to fix the testcase on Linux, and the tests pass on
my machine in either configuration.
 2021-11-03 10:30:34 +00:00
Jeff Young e4b61de792 Special case sheet ordering in file. 2021-11-02 23:14:01 +00:00
Seth Hillbrand 7cf72aaa41 Fix bezier import in Altium schematics 2021-11-02 15:45:30 -07:00
Jeff Young 4d46445ce1 Fix Bezier reading. 
Fixes https://gitlab.com/kicad/code/kicad/issues/9512
 2021-11-02 22:19:41 +00:00
Jeff Young 4acff58c7a Implement a forced ordering for LIB_ITEMs until we have UUIDs. 
(Once we read/write the UUIDs, we should just compare the type
and then the UUID like we do for SCH_ITEMs.)
 2021-11-02 20:07:34 +00:00
Jeff Young eaf10a04dd Improved naming. 2021-11-02 20:07:34 +00:00
Jeff Young af95a4b424 Fix duplicate stroke when formatting circles. 
Fixes https://gitlab.com/kicad/code/kicad/issues/9507
 2021-11-01 21:29:46 +00:00
Roberto Fernandez Bautista b6c12b6b55 CADSTAR Sch: Fix positioning of symbol fields when the symbol is mirrored 
The text aligment needs to be rotated and/or mirrored depending on whether
the text field is vertical or horizontal.
 2021-10-31 16:12:08 +00:00
Roberto Fernandez Bautista 8367c7f238 CADSTAR Sch: Fix calculation of page size 
Don't attempt to calculate bounding box of text variables. We do not
know the resolution of the text variable inside the importer. The
resolved text could be shorter than the text variable (e.g. ${#}
page number)
 2021-10-30 21:49:34 +01:00
Roberto Fernandez Bautista 0aba025d66 CADSTAR Sch: Autoplace intersheet references (instead of 0,0) 2021-10-30 21:49:34 +01:00
Roberto Fernandez Bautista 18e36155a5 CADSTAR sch: Include gate in error message when symbols are scaled 2021-10-30 21:49:34 +01:00
Roberto Fernandez Bautista 52a936ac61 CADSTAR Sch: Fix spurious pin length and orientation of some symbols 
Ensure deterministic sorting of std::map in fixUpLibraryPins
 2021-10-30 21:49:34 +01:00
Roberto Fernandez Bautista c1515dd31c CADSTAR Sch: Fix block names - load as stand-alone text items instead 
KiCad doesn't support multi-line text in fields, so we can't load it as
a text field (even if that would be the closest thing).

We should update this when KiCad supports multi-line text in fields.
 2021-10-30 18:14:23 +01:00
Jeff Young 0cdffa16d4 Fix off-by-one error in fill mode writing. 
Fixes https://gitlab.com/kicad/code/kicad/issues/9111
 2021-10-28 19:29:47 +01:00
Jeff Young 8fdfc0e63d Replace legacy sch writing code for rescue functionality. 2021-10-28 15:11:15 +01:00
Jeff Young cb1709b4ca Improve Eagle importer's label positioning. 
Fixes https://gitlab.com/kicad/code/kicad/issues/9466
 2021-10-27 13:49:13 +01:00
Roberto Fernandez Bautista 3ea3d5274c CADSTAR Schematic: Hide all KiCad sheet properties 
Sheet name/filename not applicable in CADSTAR so displaying it just
makes the import look messy.
 2021-10-23 10:58:15 +01:00
Roberto Fernandez Bautista d6d800ccbb CADSTAR Schematic: Fix crash when trying to fix library pins 
Need to copy the chain as we might have deleted it.
 2021-10-17 17:57:51 +01:00
Jeff Young a1c1f60665 Coverity fixes. 2021-10-16 16:27:35 +01:00
Jeff Young ce55dd2893 Fix botched merge. 2021-10-15 21:27:16 +01:00
Jeff Young f9861b4a6c Finish arc rework and push out to file formats. 2021-10-15 12:45:43 +01:00
Jeff Young b52529521e Replace individual LIB_* shapes with LIB_SHAPE (based on EDA_SHAPE). 
Also moves to more capable FILL_T model that can be shared.
 2021-10-15 12:45:43 +01:00
Jeff Young 9b9e379aa0 Overhaul arc internal model to not over-specify information. 2021-10-15 12:45:43 +01:00
Wayne Stambaugh c61af21da8 Eeschema: don't stat files when updating title bar text. 
The tests for file existence and write status perform two file stats
which cause performance issues on slow network shares.  Now the file
state is determined at load time and stored in the SCH_SCREEN object
so file access is no longer required.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/9343
 2021-10-14 10:52:58 -04:00