54b20cb049
Fix overflow vulnerability in Gerbview
...
Corrects an unguarded read that could lead to arbitrary code execution
in specifically crafted gerber files.
Fixes https://gitlab.com/kicad/code/kicad/issues/10700
2022-02-01 15:50:27 -08:00
0634cf261a
Don't try to move bounding box caches.
2022-02-01 21:55:09 +00:00
6fcc6f7c9d
Factor out common legacy schematic and symbol library parser code.
2022-02-01 16:30:15 -05:00
61b2b0ff0c
EAGLE plugin: use specified RATIO value for text size calculation
2022-02-01 17:58:09 +00:00
e560e765e6
PCB_TEXT::Rotate(): ensure the final orientation is -180 ... +180 deg
2022-02-01 18:07:14 +01:00
1440c0a2d2
minor fix
2022-02-01 18:07:14 +01:00
bebfbce9b2
Move pcb file rep of text_boxes to strokes.
2022-02-01 16:29:59 +00:00
0faf3a8bf5
Get rid of FP_TEXTBOX::ViewBBox(). We want to inherit FP_SHAPE's.
2022-02-01 12:49:28 +00:00
63a3b1e20a
Estimate outline font thickness for DRC readability checks.
2022-02-01 12:01:04 +00:00
a1009d7899
Fix assertion failure for labels.
2022-02-01 12:01:04 +00:00
1f8c29c395
Coverity fixup.
2022-02-01 12:01:04 +00:00
56d204c4c9
Revise transferDataToPad to return False on failure
...
When the data doesn't allow the pad to be drawn, we return false and
skip the redraw/update steps. This allows updating with invalid values
while typing
Fixes https://gitlab.com/kicad/code/kicad/issues/10684
2022-01-31 17:02:10 -08:00
59e43527a0
Add dummy defaults for textbox
2022-01-31 16:26:37 -08:00
4243d7b055
Bug fixes for color handling.
2022-02-01 00:21:08 +00:00
803675195d
Be more diligent in preventing drag line errors
...
They can happen even when there are no collisions, so we need to reset
the 'ok' flag before using the line again.
Fixes https://gitlab.com/kicad/code/kicad/issues/9555
(cherry picked from commit 833ce19221
2022-01-31 16:13:53 -08:00
82ceaf0d9b
Try not to Simplify lines to a single point
2022-01-31 16:13:27 -08:00
098e8f7d9b
Revert "cmake: adding KICAD_MACOSX_APP_BUNDLE option"
...
This reverts commit ea9f960cc1
2022-01-31 15:57:56 -08:00
88a58803ca
Revert "Mark unbundled mac apps as unsupported"
...
This reverts commit 68a0b99835
2022-01-31 15:57:14 -08:00
f3cd36d1d7
Bring EEschema textboxes in line with PCBNew's.
...
Also adds Border checkboxes and fixes a bunch of bugs.
2022-01-31 21:46:40 +00:00
5739505aa3
TextBoxes for PCBNew.
2022-01-31 20:00:47 +00:00
60bcfd1bf1
Bug fixes in arc & textbox printing.
...
Also removal of the no-longer-used clipping code from GR*.
2022-01-31 20:00:47 +00:00
25a7de730c
eeschema/CMakeLists.txt Sort sources alphabetically
2022-01-31 19:51:01 +00:00
c494274b2e
export D356 netlist: fix incorrect id for pads type connectors.
...
these pads are similar to SMD pads and should have the same id.
Fixes #10694
https://gitlab.com/kicad/code/kicad/issues/10694
2022-01-31 19:53:02 +01:00
7b01530eca
EDA_ANGLE: use existing Normalize180 function here
2022-01-31 18:16:49 +00:00
14c5f744ff
Fix missing navlib pcbcommon dependency declaration.
...
The 3d-viewer_navlib didn't have a proper dependency chain. It
relies on headers that come from pcbcommon.
2022-01-31 16:07:55 +00:00
f846f6f704
PCB_CONTROL::unfilledZoneCheck(): skip rule areas: they are not filled by definition.
...
Fixes #10691
https://gitlab.com/kicad/code/kicad/issues/10691
2022-01-31 17:01:52 +01:00
4c4089e836
Allow overlay scrolling on GTK, except for GAL canvases.
...
This prevents glitches when both scrollbars
are visible and scrolling to the end.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/10559
Fixes https://gitlab.com/kicad/code/kicad/-/issues/9988
2022-01-31 18:45:47 +03:00
a8486c5296
Fix warning: declaration shadows a previous local [-Wshadow].
2022-01-31 10:41:51 +00:00
e9ffea83fd
Cross-probing: Do not center/zoom on empty BBox
2022-01-31 10:17:59 +03:00
419010ec46
teardrop: add filtering to skip teardrops when pad/vias and tracks have similar sizes
2022-01-30 15:39:28 +01:00
3a66f33d96
TEARDROP_MANAGER: add option to add teardrops on pads in zones.
2022-01-30 15:39:27 +01:00
8393e02524
text boxes: remember to add the original newline characters back in!
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/10665
2022-01-30 14:35:55 +00:00
6cf170c2c9
Text boxes: Return full word even if it doesn't fit in the column width
...
It does mean that the text now can be outside the text box, but this is
better than an infinite loop.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/10668
2022-01-30 14:35:55 +00:00
64f2adbc31
SCH_PAINTER, draw filled LIB_SHAPE: fix incorrect selection of fill color.
2022-01-30 10:20:49 +01:00
b4826ce304
LIB_TEXT: fix incorrect position of the drawn text.
...
Fixes #10654
https://gitlab.com/kicad/code/kicad/issues/10654
2022-01-30 09:11:16 +01:00
cc2a897e2b
very minor fix
2022-01-30 09:08:21 +01:00
38706fdd95
Fully select a line for transformation
...
When not trying to select points, we need to ensure that the full
line is selected for transformation
Fixes https://gitlab.com/kicad/code/kicad/issues/10566
(cherry picked from commit 70d00689ca
2022-01-29 17:37:30 -08:00
b36e31c49f
Factor out common and remove dead legacy symbol library code.
2022-01-29 14:13:00 -05:00
aef665b1e2
PCB_TARGET: add missing TransformShapeWithClearanceToPolygon() method.
...
Fixes #10653
https://gitlab.com/kicad/code/kicad/issues/10653
2022-01-29 18:19:22 +01:00
ad84b62b63
Prevent multiple single-point line solutions
...
Suggested by @rivimey, we test the case where both lines return singular
point lines and prevent them leaking into our drag solution
Fixes https://gitlab.com/kicad/code/kicad/issues/9555
(cherry picked from commit 38a4894d92
2022-01-29 07:07:29 -08:00
2900910cdd
fix a qa test after code change.
2022-01-29 15:22:06 +01:00
43f5a7c746
DIALOG_PLOT: use a short living quasimodal dialog instead of a long living window.
...
In this case, a quasimodal dialog is the right way.
Fixes #10650
https://gitlab.com/kicad/code/kicad/issues/10650
2022-01-29 13:14:22 +01:00
98b9600373
nl_3d_viewer_plugin_impl.cpp: remove useless includes
2022-01-29 13:09:35 +01:00
7ec326c003
Fix compilation error
2022-01-28 20:19:42 -05:00
c01e2dcfec
Fix large memory leak in DRC
...
All elements get effective shapes, many of which get triangulated. This
memory needs to be freed when destroying the tree
(cherry picked from commit c2707f3cc0
2022-01-28 17:08:33 -08:00
16e802aff4
Don't count zero-length as duplicate
...
We were checking for duplicate tracks by looking to see if the two
tracks had two shared points. A null track always matched this case,
which removed the valid track. We solve this by avoiding null tracks in
the duplicate checker. They are removed separately in the null track
stage.
This also fixes a GTK-specific tree issue where we require the
BeforeReset()/AfterReset() calls instead of Cleared() to prevent GTK
from dereferencing a parent after freeing
Fixes https://gitlab.com/kicad/code/kicad/issues/10624
(cherry picked from commit 8753051db6
2022-01-28 16:34:34 -08:00
849e979307
Default Spacemouse OFF for now
...
Currently, the SpaceNav library is only implemented for MacOS and
Windows. Until this can be correctly implemented for all supported
platforms, we need to make the option default off
2022-01-28 15:52:17 -08:00
68a0b99835
Mark unbundled mac apps as unsupported
...
We do no track all the various possible issues arising from using
unbundled Mac apps. Users may choose to use KiCad this way but issues
must be recreated on a supported configuration
2022-01-28 15:49:53 -08:00
ea9f960cc1
cmake: adding KICAD_MACOSX_APP_BUNDLE option
...
ADDED: with cmake KICAD_MACOSX_APP_BUNDLE option the user can disable
the macOS app bundle creation when compiling on macOS. This permit to
use/install KiCad like any other *nix platform (/usr/bin, /usr/share,
ecc.). By default, cmake build the app bundle.
2022-01-28 15:49:37 -08:00
7277fd6218
Don't allow degenerate lines in dragger
...
If walkaround returns an invalid line, don't consider it for a track
Fixes https://gitlab.com/kicad/code/kicad/issues/9555
(cherry picked from commit 8ae304dcca
2022-01-28 15:19:06 -08:00
Seth Hillbrand
Jeff Young
Wayne Stambaugh
Steffen Mauch
jean-pierre charras
Roberto Fernandez Bautista
Jonathan Haas
markus-bonk
Alex
Marek Roszko
Davide Gerhard