f06f205886
orcadpcb2 netlist export: fix an issue with duplicated pins in multi-unit symbols.
...
Due to some changes in code, pins common to units were written more than once.
From master branch
2022-09-07 17:56:38 +02:00
5afeb45a84
Eeschema: fix crash when attempting to edit missing library symbol.
...
Disable the edit symbol buttons in the symbol properties dialog when
there is no library symbol to edit.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/11318
2022-09-02 15:48:10 -04:00
45da795668
Units are stored in the instance data
...
At the moment, units are stored in the instance data, so when loading
the file, all symbols will have bbox for the first unit. After calling
`UpdateUnit()`, we need to recache the rtree bounding boxes to get
correct hit tests
Fixes https://gitlab.com/kicad/code/kicad/issues/11681
(cherry picked from commit 939313088e
2022-09-02 12:06:24 +00:00
7f1c2461b5
Fixes inverted Y position in pin table.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11988
(cherry picked from commit 3389e456b1
2022-09-02 10:49:14 +00:00
26104c83ba
Fix wxWidgets sizer assert in SYMBOL_PREVIEW_WIDGET
2022-09-02 12:29:23 +02:00
6d14ce24aa
eeschema: Fixes wrong displayed secondary worksheet
...
Fixes https://gitlab.com/kicad/code/kicad/issues/12017
(cherry picked from commit 02a6566438
2022-09-02 10:03:44 +00:00
e760579828
Fix annotation of incomplete multi-unit symbols and re-annotation of duplicates
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/11496
(cherry picked from commit 55f22c526a
2022-09-02 12:01:33 +02:00
bf272e379f
Run hole-to-hole checks on Edge_Cuts layer.
...
Also makes the flashing logic inside PAD::GetEffectiveShape() easier
to understand.
Fixes https://gitlab.com/kicad/code/kicad/issues/12296
(cherry picked from commit e0f6a6e475
2022-09-02 01:11:20 +01:00
ace0032c82
Fix build error & just completely remove the string instead of guarding
2022-09-01 13:45:40 +02:00
cd30711cf8
Remove additional string from a3da0b9af6
2022-09-01 11:35:22 +02:00
a3da0b9af6
CADSTAR Schematic: Load symbols even if part definition is incomplete
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/11671
(cherry picked from commit 8725c3a35f
2022-09-01 09:25:14 +00:00
32a11e4df0
Eeschema: fix broken instance data when adding new symbol.
...
Pass the current SCHEMATIC object pointer in SCH_SYMBOL ctor so that
newly created symbols will update the current instance data on creation
when the current sheet instance is being displayed.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/12190
2022-08-26 12:47:13 -04:00
9af666ba34
Eeschema: ensure reference field is initialized when adding a new symbol in schematic
2022-08-24 14:30:14 +02:00
9328cf42c5
Don't close blocking dialog in backannotate
...
Back annotate is called from a dialog, so this will close itself but not
exit, locking the UI
(cherry picked from commit 28876bef90https://gitlab.com/kicad/code/kicad/issues/12255
2022-08-22 07:05:30 -07:00
9e9b38ef6a
Revert "cadstar: Report warning that imported text may be different"
...
This reverts commit f637a820b6
2022-08-20 20:09:40 -07:00
39940fe5ab
Fix missing legacy value and footprint field instance data.
...
The legacy and s-expression (prior to version 20200828) file formats only
supported symbol unit and reference fields so the newly added value and
footprint fields must be updated from the original symbol fields.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/12226
(cherry picked from commit 797827b833
2022-08-17 14:24:13 -04:00
cfde5300d7
Fix wxWidgets 3.1 and later deprecated build warnings.
...
wxWidgets 3.1 has deprecated wxPATH_NORM_ALL when normalizing file
paths when calling wxFileName::Normalize(). This change keeps the
existing behavior except in places where our own internal
ExpandEnvVarSubstitutions() to expand environment variables.
(cherry picked from commit 898ec0d094
2022-08-17 14:07:06 -04:00
f637a820b6
cadstar: Report warning that imported text may be different
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/12195
(cherry picked from commit 69d696660b
2022-08-14 21:25:46 +00:00
411d57396c
eeschema: Fix issue when saving labels having more than 50 chars
...
These labels (or global label...) were saved with a erroneous angle.
Fixes #12151
https://gitlab.com/kicad/code/kicad/issues/12151
2022-08-05 13:33:35 +02:00
3bca4f8835
Fix another case of the instance data getting messed up.
...
(Or, more accurately in this case, of the instance data not getting
applied to the current view.)
Fixes https://gitlab.com/kicad/code/kicad/issues/11390
(cherry picked from commit 5295342f42
2022-08-04 09:22:23 +01:00
1f3bb83a06
Make EEschema highlight net consistent with PCBNew.
...
In particular, highlight net on an already highlighted net clears
highlight.
Fixes https://gitlab.com/kicad/code/kicad/issues/11016
(cherry picked from commit e36491f231
2022-08-04 00:08:12 +01:00
efc75047c1
Pay attention to units for page frames.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11408
(cherry picked from commit 404015b0a5
2022-08-04 00:07:24 +01:00
fec9331b48
Handle rotation while moving from move tool.
...
This keeps us from getting CancelInteractive events in the move tool
when the EditTool runs to do the rotate.
Fixes https://gitlab.com/kicad/code/kicad/issues/12004
(cherry picked from commit bdffbbd43b
2022-08-04 00:00:43 +01:00
7f71eef45b
Move sheetpins by their connection point
...
Need to calculate the sheet pin anchor position in order to get it
aligned to the grid while moving
Fixes https://gitlab.com/kicad/code/kicad/issues/12134
(cherry picked from commit 225b03d702
2022-07-31 20:04:29 -07:00
f3caac5bfd
Ensure no string changes for 6.0.x.
2022-07-28 01:14:58 +01:00
7bd073b5cb
Make sure there are no translation changes for 6.0.x.
2022-07-28 01:08:42 +01:00
a5b676fa0e
Avoid crashes when, for some reason, a dll cannot be loaded.
...
In this case a null pointer was returned by the internal code.
This pointer is now tested against nullptr to avoid the application crashing.
Fixes #12080
https://gitlab.com/kicad/code/kicad/issues/12080
2022-07-26 16:04:27 +02:00
d9fef3da72
Don't allow 0 line-width for unfilled shapes.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/12010
(cherry picked from commit d0547cbde7
2022-07-25 21:46:27 +01:00
61bb793324
Save fp browser list widths and apply known hack to work around wxWidgets bug.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11744
Fixes https://gitlab.com/kicad/code/kicad/issues/11745
(cherry picked from commit 0a623bff9f
2022-07-25 21:21:23 +01:00
ccb416eead
Bring symbol editor in line with eeschema for empty text.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11799
(cherry picked from commit d07c6699ce
2022-07-25 21:12:15 +01:00
6e10a496ef
Honour m_resolveTextVars flag for properties as well as fields.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11937
(cherry picked from commit 5479514819
2022-07-25 21:03:47 +01:00
832c689345
Labels can connect directly to symbols, other labels, etc.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11768
(cherry picked from commit c6604e3576
2022-07-25 20:56:11 +01:00
0580fc6819
Add create-wire logic to labels.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11768
(cherry picked from commit 29900cad34
2022-07-25 20:44:50 +01:00
ce92c676e6
Use unit references in status bar.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11854
(cherry picked from commit 45ab15dc95
2022-07-25 19:40:08 +01:00
bb5fd5a2ec
Fix broken logic for hidden pins.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11771
(cherry picked from commit b710982875
2022-07-25 19:36:58 +01:00
41a9293106
Update grid attributes after sorting.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11753
(cherry picked from commit 46fd32b738
2022-07-25 19:36:13 +01:00
3c4f8a335f
Save selection *before* clearing it. Saving after doesn't do much good.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11242
(cherry picked from commit 1751c8e1cf
2022-07-25 19:35:06 +01:00
cd5b4ec8f2
Add edge-exclusions to router (for castellated pads).
...
Fixes https://gitlab.com/kicad/code/kicad/issues/1790
(cherry picked from commit 833dc70bff
2022-07-25 19:30:49 +01:00
58451335cb
Apply DRC fixes to ERC.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11844
(cherry picked from commit 83a2f43661
2022-07-25 19:23:57 +01:00
064a9688c0
Make annotation case-insensitive
...
U1 and u1 are allowed but if they both exist in the same schematic, they
will throw an ERC and annotation error. Reannotating will make them U1
and u2.
Fixes https://gitlab.com/kicad/code/kicad/issues/11862
(cherry picked from commit 00c7b64b13
2022-07-18 09:49:28 -07:00
c1ec63d4f9
Protect the Kiway dereference
...
Also find a few more places where we are reaching into a new frame to
perform actions that need to have dialogs closed.
Running actions should also wait for the next cycle rather than being
immediately executed when we are calling into a new frame. This allow
for the cleanup actions onClose() to happen prior to the next action
starting
Fixes https://gitlab.com/kicad/code/kicad/issues/11891
(cherry picked from commit 93fb00d815
2022-07-18 09:48:50 -07:00
a8c0bc0430
Keep track of blocking windows
...
Allows the calling KiWAY player to send messages to the blocking window
before signaling a separate call
Fixes https://gitlab.com/kicad/code/kicad/issues/11891
Fixes https://gitlab.com/kicad/code/kicad/issues/11772
(cherry picked from commit b5bf1da251
2022-07-18 09:47:32 -07:00
902629c139
Fix name escaping in symbol editor
...
When renaming a symbol, be sure to handle name escaping in all of the
various places that we do renaming (!)
Fixes https://gitlab.com/kicad/code/kicad/issues/11939
(cherry picked from commit 0dab566270
2022-07-18 09:46:57 -07:00
865bb54591
Flag ERC error on non-stacked pins
...
Pins that are explicitly connected in the schematic should not have an
"unconnected pin" ERC error. But stacked pins do not count as
explicitly connected because the schematic designer has not connected
them
2022-07-17 20:16:55 -07:00
d53c6f8abe
Eeschema, DIALOG_SCH_FIND: ensure the search flags actually used are up to date.
...
Flags are encoded using internal wx values, that can change with wxWidgets versions.
They need to be always rebuilt from the displayed options in dialog.
From master branch.
2022-07-12 08:36:15 +02:00
4d1fcff732
Fix compile error in v6
2022-07-07 12:19:38 -07:00
95fcf53353
Handle basic rounding error in schematic import
...
The fractional part of Altium schematic units is an integer number of
1/10000 mil segments, which is 2.54 nm. The internal unit of eeschema
is 10 nm, so each fractional unit in Altium is 0.254 base eeschema
units. To be consistent with
cf33cfcad1https://gitlab.com/kicad/code/kicad/issues/11742
(cherry picked from commit 6fef054c51
2022-07-07 11:14:25 -07:00
042b49ee7b
Update message panel from PCB point editor and SCH drawing tools.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11961
(cherry picked from commit 4f62960334
2022-07-06 19:48:09 -07:00
6a1dfd6e32
Overplot schematic symbol fields and pins
...
In the absence of z-ordering, we need to ensure that pin text and symbol
fields are always visible in plots as they are in the schematic window.
We do this by overplotting the fields/pins when symbols overlap each
other.
This can be removed if/when we implement https://gitlab.com/kicad/code/kicad/-/issues/2211
Fixes https://gitlab.com/kicad/code/kicad/issues/11969
(cherry picked from commit ff54b8c718
2022-07-05 16:47:07 -07:00
761ddcad21
Schematic: Add shift-space hotkey for consistency with PCB editor
...
Already in 7.0/master.
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/10858
2022-06-29 12:54:18 +00:00
jean-pierre charras
Wayne Stambaugh
Seth Hillbrand
passionateengineer
Roberto Fernandez Bautista
BugRepellentExtraStrong
Jeff Young
Mike Williams