Jeff Young
f8f29b55cb
Don't promote to sheet parent when the item itself is a sheet.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15167
2023-07-11 14:52:05 +01:00
Jeff Young
c3d10084b9
ADDED footprint associations dialog.
2023-07-11 14:52:05 +01:00
Alex Shvartzkop
0bc546fa62
LTspice import: fixes for graphical items.
2023-07-11 16:03:29 +05:00
Alex Shvartzkop
a5ba9ccce2
LTspice import: don't try loading .asc files for non-subsheets.
...
Subsheets don't have "Prefix" attribute, components do.
2023-07-11 16:03:29 +05:00
Alex Shvartzkop
ef1a2ff050
LTspice import: text and pin justification, polarity fixes.
2023-07-11 13:00:43 +05:00
Alex Shvartzkop
e80e4ff410
LTspice import: hide pin names with None justification, hide pin numbers
2023-07-11 12:57:56 +05:00
Wayne Stambaugh
929a6a2b99
Coding policy fixes.
2023-07-10 19:24:59 -04:00
Alex Shvartzkop
b957c1ad17
LTspice import: Support VCenter text justification
2023-07-11 04:09:16 +05:00
Alex Shvartzkop
1e149704b8
LTspice import: Fix M270 symbol orientation.
2023-07-11 04:09:16 +05:00
Alex Shvartzkop
cab0db76f8
Clear view before resetting schematic.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15159
2023-07-11 03:00:42 +05:00
Wayne Stambaugh
415dcf82c4
Coverity issue fixes.
...
CIDs 462497, 462496, 462495, 462494
2023-07-10 17:48:27 -04:00
Wayne Stambaugh
aeed542202
Net navigator fixes and improvements.
...
Remove wires, junctions, and bus entries from tree. These objects make
the net tree noisy for complex nets. Until a sane way to group these
objects can be, remove them for now.
Fix tree expansion and debug assertion issues.
2023-07-10 15:34:00 -04:00
Jeff Young
eedf319ba4
Don't double-offset effective text shapes.
...
Also fixes several bugs with intersheet ref fields. (It's possible for
other fields to have an ID of 0.)
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15165
2023-07-10 19:32:00 +01:00
Jeff Young
d2f9994fc5
SCH_SHEET::GetContextualTextVars() will return Project text vars.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15123
2023-07-10 12:40:04 +01:00
jean-pierre charras
6a47fe1e3c
simulator: shows the wxCURSOR_ARROWWAIT cursor only when the sim is running.
...
Reset the mouse cursor to its default shape when the simulation is finished.
2023-07-10 13:30:14 +02:00
Jeff Young
3ba7e7e993
A few baby steps in trying to straighten out LTSPICE_SCHEMATIC::Load().
2023-07-10 11:34:06 +01:00
Jeff Young
229dcde948
Fix a memory leak.
...
There are likely *many* more in this routine, but I can't quite
understand what it's trying to do.
2023-07-10 11:34:06 +01:00
Jeff Young
8f9a67063a
Straighten out some really confusing terminology in simulator GUI.
2023-07-09 23:07:54 +01:00
Jeff Young
7608350bdc
Iron out NewPlot vs EditSimCommand.
...
Also don't confuse SIM_PLOT_PANEL_BASE with SIM_PLOT_PANEL.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15157
2023-07-09 22:38:48 +01:00
Roberto Fernandez Bautista
dfe7051171
LTspice importer fixes
...
- Correctly find the library paths for new and old LTspice versions
- Use case insensitive comparison (store element names as lower case in the map)
- Better search paths
- Allow user to copy contents of LTspice "lib" folder to the same folder as file being imported
Partially addresses https://gitlab.com/kicad/code/kicad/-/issues/15061
2023-07-09 22:53:23 +02:00
Roberto Fernandez Bautista
6539171459
LTspice importer - remove dead code
2023-07-09 22:51:21 +02:00
Jeff Young
5aed30ac79
Handle RepeatLastItem for TwoClickPlace items.
...
(Note that we've always excluded sheet pins from RepeatLastItem.)
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15108
2023-07-09 20:33:33 +01:00
Jeff Young
6182ff4834
Handle delete of sheet pins.
...
SCH_COMMIT::Stage() can handle promoting the parent, but then the pin
needs to be removed first. I think it's probably clearer if we just
do the promotion in the delete routine.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15129
2023-07-09 13:40:27 +01:00
Jeff Young
a66360525a
Broaden "Style footprint fields" to cover graphics as well.
...
Also cleans up the layout of the symbol & fp properties dialogs.
Also fixes the background colour of the link textEdit controls on Mac.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/8161
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15152
2023-07-09 12:45:55 +01:00
Mike Williams
cb01ac53fa
Schematic: allowing swapping sheet pins on same sheet
...
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/15122
2023-07-08 20:26:26 -04:00
Jeff Young
25445d9fe0
Make sure all items managed by their parent get correct handling in SCH_COMMIT.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15129
2023-07-08 20:40:30 +01:00
Jeff Young
d48e7f159c
Re-install tool view items after clearing the view.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15149
2023-07-08 20:40:30 +01:00
jean-pierre charras
9ee21e4eeb
simulator: do not show a message saying a command directive has changed
...
when there is no old command directive.
2023-07-08 20:30:57 +02:00
Jeff Young
12ed015174
Fix selection highlighting of heirarchical labels and sheet pins.
2023-07-08 18:50:04 +01:00
Jeff Young
5bca002567
Swap non-temp and non-edit flags for SCH_ITEMs.
...
This is required to keep selected and brightened state across undo.
It's also probably required for things like IS_SHOWN_AS_BITMAP and
possibly ENTERED. FWIW, most BOARD_ITEMs do a straight swap, including
the temp and edit flags. But that seems like a risky change....
Also removes SyncView() call from Undo/Redo as that does a MODEL_RELOAD
which clears the selection.
2023-07-08 18:37:47 +01:00
Jeff Young
c8e8b71198
TestDanglingEnds needs to test sheet pins as well.
...
Also fixes a bug where zooming doesn't get a redraw until mouse moves.
Also fixes a couple of bugs where dangling markers on SCH_SHEET_PINs
and SCH_HIERLABELs weren't getting drawn.
Also simplifies drawing algorithm by removing aesthetic offset (which
wasn't implemented when pin is drawn as part of selection VIEW_GROUP).
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15129
2023-07-08 12:55:45 +01:00
jean-pierre charras
70ffd971e3
Fix a bug found by Coverity.
2023-07-08 12:51:21 +02:00
Jeff Young
30c2049977
Handle inference of V7 symbol lib DC voltage/current sources.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15127
2023-07-07 16:25:05 +01:00
Jeff Young
534a3efce1
Add a couple of TODOs for SCH_COMMIT.
2023-07-07 15:40:15 +01:00
Jeff Young
922f7128a9
Move item updating and view refresh to SCH_COMMIT::Push().
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15132
2023-07-07 15:40:01 +01:00
Jeff Young
bde9c2cbc5
ADDED FFT analyses.
...
CHANGED abandon the unpredictable behaviour of the Simulation Command
dialog. You now separately add simulation tabs (which have invariant
command types once created), and the dialog edits the current tab.
Also a bunch of bug fixes to make multiple simulation plots actually
work.
2023-07-07 12:33:50 +01:00
Jeff Young
d5d2800b03
Sort out terminology issues between vectors and plots.
2023-07-07 12:33:50 +01:00
Jeff Young
443a5dc3bb
Syntax help for SPICE functions.
2023-07-07 12:33:49 +01:00
jean-pierre charras
27072e52f7
Fix a compil and Coverity warnings
2023-07-07 10:28:01 +02:00
Ian McInerney
0fd2efa283
Give unfold bus a default parameter for hotkey invocation
...
Fixes KICAD-2JN
2023-07-06 23:07:24 +01:00
jean-pierre charras
bc8cc826cc
Eeschema, PlotInteractiveLayer(): do not print useless info in a PDF plot.
...
It makes this info more easily readable.
- Remove duplicate properties/fields
- Do not plot empty properties/fields
2023-07-05 11:08:25 +02:00
Jeff Young
e494017b54
Fix merge error.
2023-07-04 18:53:15 +01:00
Fabien Corona
886a7c2c04
ADDED: S-parameters simulation
2023-07-04 16:01:12 +00:00
Jeff Young
d563d66b86
ADDED Fourier analyses of .tran data.
2023-07-04 16:54:38 +01:00
Jeff Young
492ef62053
ADDED support to save contributions from all noise generators.
...
You must first check the checkbox in the Simulation Command dialog,
after which the signals will appear in the User Defined Signals
autocomplete lists.
2023-07-04 11:05:10 +01:00
Alex Shvartzkop
37772ac29e
Altium schematic: import net label justification.
2023-07-04 10:27:46 +03:00
Jeff Young
7d3fa8fb4e
Plotting for noise simulations.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/2369
2023-07-03 23:12:28 +01:00
Jeff Young
80340c607c
ADDED noise simulation GUI.
2023-07-03 16:26:20 +01:00
Marek Roszko
b5e420c33c
Fix EDA_TEXT creation that worked due to implicit cast
...
A leftover from the units object rework and I forgot to double back. The DEFAULT_SIZE_TEXT is set inside the constructor now
2023-07-03 11:23:30 -04:00
Ian McInerney
247fda80ef
Give schematic editor's placeImage action a default parameter
2023-07-03 11:38:51 +01:00
jean-pierre charras
c00c0cf581
SCH_PLOTTER: fix an issue after plotting a hierarchy (at least 2 sheets)
...
SCH_EDIT_FRAME::SetCurrentSheet( xxx ) was used to switch to a sheet, but
SCH_EDIT_FRAME::SetCurrentSheet() has side effects to the current VIEW
(clear some data used to show the sheet on screen) and does not fully
restore the "old" screen
SCHEMATIC::SetCurrentSheet( xxx ) is now used to switch to a sheet
2023-07-03 10:33:05 +02:00
Alex Shvartzkop
36901bda62
Eeschema: don't plot hiererchical sheet fill when color is transparent.
2023-07-03 02:15:05 +03:00
Alex Shvartzkop
86458ae582
Eeschema printing: fix bg fill when paper orientation or size differs.
2023-07-03 02:15:05 +03:00
Alex Shvartzkop
b242779f3b
Put background color behind transparent bitmaps in eeschema printing.
...
Most virtual printers don't support alpha blending via AlphaBlend (MSW)
properly, nor masks.
2023-07-03 02:15:05 +03:00
Alex Shvartzkop
55b31030c0
Perf: don't search for niluuid items when moving cursor in eeschema.
...
Reduces CPU usage by 60% in some cases.
2023-07-03 02:15:05 +03:00
jean-pierre charras
f5d7edaa73
PANEL_SYM_EDITING_OPTIONS: Fix a focus event issue (perhaps platform specific)
2023-07-02 19:46:56 +02:00
Jeff Young
ec9b2919ba
Allow user-entered repeat pin spacing, but force to grid multiples.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/14207
2023-07-02 17:23:01 +01:00
Jeff Young
03fd9c2086
Fix refresh bug after a symbol reload from the file watcher.
...
Also moves EE_POINT_EDITOR to SCH_COMMIT. (There was another refresh
bug in RollbackSymbolFromUndo() -- whose only caller was the
EE_POINT_EDITOR's old undo code).
Fixes https://gitlab.com/kicad/code/kicad/-/issues/14274
2023-07-02 10:37:50 +01:00
Jeff Young
4cbf512461
Support synchronous move in symbol editor.
...
Also removes duplicate-during-move. It's not really compatibile with
a passed-in SCH_COMMIT, and it was never clear it was worth the code.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/14274
2023-07-02 10:37:50 +01:00
Jon Evans
632e94ef81
Add a few more schematic properties
2023-07-01 22:24:25 -04:00
Jeff Young
efac777f28
Don't DisplayCurrentSheet() if we're already on it.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/14305
2023-07-01 21:57:40 +01:00
jean-pierre charras
f3a0c2b658
netlist_exporter_allegro: fix a compil warning, clearly created by a bug in code.
...
I am not sure the first author wanted to do, but at least the strange
and broken code (clearly due to a too zealous copy/paste) is fixed.
2023-06-30 20:08:13 +02:00
Jeff Young
773e1a1ab6
Actions with a COMMIT must be run synchronously.
...
Note that "immediate" doesn't mean quite the same thing: while it will
enter the tool immediately, it won't necessarily finish the tool during
the call if the tool has an event loop. So for something like Rotate
"immediate" and "synchronous" have the same behaviour, but for something
like Move they do not.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15085
2023-06-30 18:57:37 +01:00
Jon Evans
59495971ee
Properties: fixes to color swatches
2023-06-29 22:53:06 -04:00
Ian McInerney
bb4fb9088f
Gracefully handle no symbols found in change symbols dialog
...
Fixes KICAD-2BJ
2023-06-29 23:21:15 +01:00
Seth Hillbrand
7779a01d48
SIM_VALUE stores significants in 64-bit
...
stol isn't neccesarily 64-bit though, so we use stoll and catch the
overflow if we have bad input data
Fixes KICAD-2EF
2023-06-29 09:50:27 -07:00
jean-pierre charras
3ef757e3b9
EEschema: hide the splash screen before reading a file, to avoid obfuscate
...
a info dialog, if any.
Fixes #15076
https://gitlab.com/kicad/code/kicad/-/issues/15076
2023-06-29 12:34:04 +02:00
Jon Evans
3487124a4a
Properties: Improve color picker UX
2023-06-28 23:54:27 -04:00
Jon Evans
200316d869
Remove duplicate fields block from netlist exporter
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15055
2023-06-28 20:38:10 -04:00
Ian McInerney
c3674e6858
Fix incorrect parameter passing in symbol editor drawing
...
The text box used a different enum than the shapes, so this leads to a
possibility of clashing. The new action framework flagged this problem,
so modify the tool to handle the shape types properly.
Fixes KICAD-2CJ
2023-06-29 00:17:12 +01:00
Youbao
4cb993d872
ADDED: Cadence Allegro PCB Designer netlist exporter
2023-06-28 22:47:30 +00:00
Roberto Fernandez Bautista
6d3f512e15
Ensure symbols in subsheets are added to multi-unit map before re-annotating
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/14918
2023-06-28 23:30:10 +02:00
Fabien Corona
8abb701727
IBIS: model type should not be case sensitive
...
Fixes #15068
2023-06-28 22:49:41 +02:00
Jeff Young
2278f5dbca
Don't try to be smart about enabling the Clear Annotation button.
...
(At a minimum it would need to also handle when the scope changes, but
it's not clear we're adding anything by enabling/disabling it to start
with.)
2023-06-28 14:56:50 +01:00
Ian McInerney
2a940a5f70
Add COMMIT to TOOL_EVENTs instead of passing as a parameter
2023-06-27 00:57:59 +01:00
Ian McInerney
2fb6f19a84
Separate immediate and delayed action dispatch
...
Using a boolean argument just leads to a lot of trailing booleans in the
function calls and is not user friendly. Instead, introduce PostAction()
to send an action that runs after the coroutine (equivalent to passing
false or the default argument), and leave RunAction as the immediate
execution function.
2023-06-27 00:57:59 +01:00
Jeff Young
aa8dbc03a2
Error reporting for missing ltspice symbol (.asy) files.
2023-06-26 21:59:57 +01:00
Jeff Young
29d2265c01
Clean up dead code.
2023-06-26 20:51:58 +01:00
Jeff Young
4f52c69724
Better path handling for importing LTspice files.
2023-06-26 20:51:16 +01:00
Jeff Young
ed6487da1e
Disallow sheet pins from changing sides when edited by point editor.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15057
2023-06-25 19:55:13 +01:00
Jeff Young
40fcfe891d
Move pinnumber above pins if pinnames aren't shown.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/14998
2023-06-25 16:01:35 +01:00
Jeff Young
3a301e50ae
Clear all edit flags when pushing SCH_COMMIT.
2023-06-25 16:01:35 +01:00
Jeff Young
e7ee6e1f26
Modified flags are handled by SCH_COMMIT.
2023-06-25 16:01:35 +01:00
Jeff Young
9854acd9e6
Don't set IS_CHANGED on symbol when modifying LIB_PINs for painting.
2023-06-25 16:01:35 +01:00
Ian McInerney
118b815824
Get proper LINE_MODE type from tool event.
...
Properly fix https://gitlab.com/kicad/code/kicad/-/issues/15053
2023-06-25 13:43:32 +01:00
Ian McInerney
b00361d136
Revert "Don't use TOOL_EVENT parameters for line modes."
...
This reverts commit 84a63f7daa
.
2023-06-25 13:37:58 +01:00
Jeff Young
84a63f7daa
Don't use TOOL_EVENT parameters for line modes.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15053
2023-06-25 11:10:07 +01:00
Jeff Young
493828cc6b
Eradicate a bunch of calls to dyn_cast.
...
Also deletes PAD::GetParent() which fails to look for parent footprint
through groups.
2023-06-25 11:10:07 +01:00
Jeff Young
300a60e88e
Eradicate a bunch of calls to dyn_cast.
2023-06-25 11:10:05 +01:00
Jon Evans
d4b7144448
Properties: expose symbol attributes
...
Flip polarity of exclude-from-BOM and -board for symbols
to match that of footprints and match the GUI display.
2023-06-24 22:03:06 -04:00
Jon Evans
f0d8edae1e
Move sch properties panel to using default AUI pane info struct
2023-06-24 20:09:07 -04:00
Jon Evans
bf2e9f8261
Properties for SCH_LINE
...
Also rename an incongruous setter
2023-06-24 20:08:42 -04:00
Jeff Young
1c1849ec1a
Clear IS_MOVING (as well as IS_NEW) in SCH_COMMIT::Push().
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15051
2023-06-24 17:15:43 +01:00
jean-pierre charras
1094cc5331
Fix issues related to the splash screen when no config file found:
...
- do not show it before the application is actually started.
- hide the splash screen before displaying dialogs.
Fixes #15047
https://gitlab.com/kicad/code/kicad/-/issues/15047
2023-06-24 18:09:43 +02:00
Alex Shvartzkop
bce643feae
Don't draw LIB_PIN and SCH_LINE on OP layers when OP is empty.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15041
2023-06-24 16:01:58 +03:00
Jeff Young
4764606a9d
Sheet pins are owned by their parents, so the parent must go in the SCH_COMMIT.
...
Also collapses a bunch of duplicated code.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15044
2023-06-24 12:35:48 +01:00
jean-pierre charras
830b67ead7
Eeschema: SaveSettings() : save visibility of Properties Panel in config.
2023-06-24 08:44:34 +02:00
Jeff Young
a901247cbd
Rebuilding connectivity must be done after changes are committed.
...
It also needs to be done after undo and redo.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15028
2023-06-23 22:10:17 +01:00
Jeff Young
237cc7eee1
Move TestDanglingEnds() to SCH_COMMIT.
...
Also fixes a bug where Convert Symbol wasn't undoable.
Also cleans up some SetModified() call no longer needed with SCH_COMMIT.
Also fixes bug where revert of a modification didn't update the screen's
RTree.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15030
2023-06-23 19:59:46 +01:00
jean-pierre charras
db8201717d
SCH_FIELD::GetCanonicalName() : the name must be the not translated name,
...
previously, it returned the translated string, by definition not the
canonical name
2023-06-23 17:48:19 +02:00