haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
14,977 Commits 9 Branches 105 Tags 1.3 GiB
Commit Graph

4073 Commits

Author SHA1 Message Date
jean-pierre charras e7fa02a9f0 DIALOG_BOM: fix a few issues. Mainly an annoying issue when a plugin file was not found 
Previously, all the dialog setup was lost.
 2019-01-14 13:14:13 +01:00
Seth Hillbrand a0a4e5e18d libedit: Small edit component cleanup 
Initialize local variables and ensure that the SPICE edit button is not
shown in compiles that do not support it.
 2019-01-12 06:58:40 -08:00
Seth Hillbrand 634d02bd04 libedit: Check proper field grid type 
Fixes segfault where pointers are not zeroed

Fixes: lp:1811519
* https://bugs.launchpad.net/kicad/+bug/1811519
 2019-01-12 06:51:09 -08:00
Seth Hillbrand 353bda6792 eeschema: Add directly connected items to block 
Allow components to connect to both components and junctions

Fixes: lp:1798968
* https://bugs.launchpad.net/kicad/+bug/1798968
 2019-01-10 17:28:29 -08:00
Jeff Young 81a0ab4d7e Don't return wxID_OK from a cancel. 
Also fixes the Save icon not getting enabled/disabled.

Fixes: lp:1810116
* https://bugs.launchpad.net/kicad/+bug/1810116
 2019-01-10 17:41:33 +00:00
Jeff Young 15af0cc43d Don't inherit previously-selected alias properties when deleting. 
Fixes: lp:1810768
* https://bugs.launchpad.net/kicad/+bug/1810768
 2019-01-10 17:41:33 +00:00
Seth Hillbrand 170ff66cbb libedit: Allow SPICE parameter editing 
This fixes a regression to allow SPICE parameters to be added to the
symbol in libedit.

Fixes: lp:1793062
* https://bugs.launchpad.net/kicad/+bug/1793062
 2019-01-09 21:43:23 -08:00
Seth Hillbrand da295a355f qa: Moving eeschema qa to main qa folder 2019-01-09 21:43:23 -08:00
Wayne Stambaugh 906161dcf8 Fix configuration dialog layout issues on GTK. 2019-01-09 17:35:12 -05:00
Seth Hillbrand fe30460aeb gal: Save canvas type unconditionally 
The canvas type might change without the frame being notified.  If this
happens, the user is presented with repeated notifications of OpenGL
issues.  Howver, switching canvas is not an error and should be
presented to the user as an info message to clarify that the system is
still working but it has changed how it renders the screen.

Fixes: lp:1795240
* https://bugs.launchpad.net/kicad/+bug/1795240
 2019-01-09 10:36:01 -08:00
John Beard 658cc8fd96 Wildcards: unify handling of all files wildcards 
Use the AddFileExtListToFilter() to also generate the
wildcard for "all files". This is because:

* Users can use AddFileExtListToFilter for the all files WC
  with the same interface as for any other extensions.
* Users do not need to worry about wxGetTranslation, as the
  _() is applied in the same way as the other *Wildcard() helpers,
  and it is a function just like the others, so it is consistent
* There is a testable interface to document the expected result.
  The test is added.
 2019-01-09 08:57:42 -05:00
jean-pierre charras 1ca3b2c768 Eeschema: DIALOG_FIELDS_EDITOR_GLOBAL: fix missing clearing old highlight when highlighting a new symbol or exiting the dialog 2019-01-09 14:38:44 +01:00
Seth Hillbrand 90ad240660 units: Move common units and add tests 
Centralizing duplicate code from Eeschema and pcbnew and adding unit
tests
 2019-01-08 09:29:32 -08:00
Seth Hillbrand 31ab4e6c9a eeschema: Simplify netlist dialog 
The default filename textbox confusingly could not be edited and the
checkbox for "Use default filename" would also use a default location.
As the netlist export is no longer required in the workflow, we can
simplify the layout to always show the user the file save dialog
allowing them to choose the location and name of the exported netlist
file.
 2019-01-08 09:26:36 -08:00
jean-pierre charras 3f9230fa51 Eeschema: Fix incorrect behavior of cursors when moving cursors by arrow keys. 
Fixes: lp:1810684
https://bugs.launchpad.net/kicad/+bug/1810684
 2019-01-07 10:10:37 +01:00
Seth Hillbrand 0a4812be07 eagle: Set default pin type 
Eagle 7.4 DTD defines pin direction as optional with a default of IO
(bidirectional).

Fixes: lp:1808585
* https://bugs.launchpad.net/kicad/+bug/1808585
 2019-01-06 08:54:14 -08:00
Seth Hillbrand 1e5ba6f1b1 Replace DIM() macro 
The standard DIM() macro was not typesafe as it happily deferred errors
to runtime that can be caught at compile time.  Replacing it with a
generic C++11 constexpr allows for typecasting, comparison and compile
time error checking.
 2019-01-06 08:43:12 -08:00
Seth Hillbrand 3b54a44540 wildcard strings update 
Replace a few other cases where we used Windows-only or *nix specific
wildcard strings
 2019-01-05 20:26:45 -08:00
Seth Hillbrand 02a1bf1de6 eeschema: Use system-dependent default wildcard 
wxWidgets provides a system-dependent string for "*" or "*.*" depending
on the system.  Unfortunately, wxFormBuilder does not use this and
instead defaults to the Windows-only "*.*".  This is an ugly work
around.

Fixes: lp:1810221
* https://bugs.launchpad.net/kicad/+bug/1810221
 2019-01-05 20:18:59 -08:00
jean-pierre charras db7dba96ad Fix a few Coverity warnings. 
Mainly not initialized members, and replace not tested dynamic_cast by static_cast.
 2019-01-04 09:49:21 +01:00
Seth Hillbrand 37967eb685 eeschema: init pin table local var 
Explicitly set modified to false when instantiating
 2019-01-02 19:41:18 -08:00
Seth Hillbrand 6662891f34 string update: Help->List hotkeys 
The hotkey name "Help (this window)" does not describe what the hotkey
and associated action does.  It displays the current hotkey list, so the
action name should reflect that behavior
 2019-01-02 15:44:13 -08:00
jean-pierre charras 6040eee710 fix a minor issue in Eeschema when left clicking on a highlighted symbol. 2018-12-31 14:44:59 +01:00
jean-pierre charras 7ad21fefe5 Cross probing: Trying to fix a crash, certainly due to a call to clear the HIGHLIGHTED flag of a structure that is not a EDA_ITEM. 
Minor enhancement: use a specific message in cross probing to clear the HIGHLIGHTED flag.
 2018-12-31 13:54:26 +01:00
jean-pierre charras fb35a7c8b4 Eeschema highlight symbols (cross probing) fix a few issues. 
Fix highlight not cleared by Pcbnew.
Fix highlight not cleared by Cvpcb (missing code).
Add comments. Remove a few now useless printf used for debug
When clicking on a empty area, clear any highligthed symbols

Fixes: lp:1809977
https://bugs.launchpad.net/kicad/+bug/1809977
 2018-12-29 12:48:24 +01:00
Jeff Young ad0d9f8df0 Save user-defined nicknames. 
While name and path fields would make more sense, this commit
encodes the nickname as an "opts" field so that older versions will
still read the preferences file.
 2018-12-28 20:34:06 +00:00
Jeff Young 72a1052bb9 Make sure parents get redrawn to refresh module text items. 
Fixes: lp:1809912
* https://bugs.launchpad.net/kicad/+bug/1809912
 2018-12-27 18:42:04 +00:00
Maciej Suminski bce4a45ab4 Fixed a crash when trying to highlight a not existing component 2018-12-27 13:45:41 +01:00
Tomasz Włostowski c777eac000 eeschema: improved highlighting of PCB->SCH cross-probed components/labels/pins 
Fixes: lp:1796990
* https://bugs.launchpad.net/kicad/+bug/1796990
 2018-12-24 15:35:25 +01:00
Jeff Young 10887868dc More changes to clean up redraw after an undo. 
Fixes: lp:1803038
* https://bugs.launchpad.net/kicad/+bug/1803038
 2018-12-22 22:13:23 +00:00
Jeff Young 4c184f07a6 Clean up undo when cancelling block operation. 
Fixes: lp:1809444
* https://bugs.launchpad.net/kicad/+bug/1809444
 2018-12-21 22:45:57 +00:00
Jeff Young 51e6f56300 Clean up view when aborting move item. 
Fixes: lp:1809444
* https://bugs.launchpad.net/kicad/+bug/1809444
 2018-12-21 20:32:10 +00:00
Jeff Young 6eca924365 Clear hidden flags on undo. 
Fixes: lp:1803038
* https://bugs.launchpad.net/kicad/+bug/1803038
 2018-12-21 16:39:10 +00:00
Maciej Suminski 24f9bfa13b Fixed memory leaks 
This is commit a9efbf47 with a fix for SWIG to deal with unique_ptr.
 2018-12-20 10:05:58 +01:00
jean-pierre charras 83d851956c classes MARKER rework: remove duplicate code. Better HitTest code (HitTest takes in account the actual shape) 2018-12-19 19:53:27 +01:00
jean-pierre charras 15843ae01a class MARKER rework: fix a few minor issues, remove duplicate code and add comments. 2018-12-19 15:13:31 +01:00
jean-pierre charras 638b4384ec eeschema: fix issue: Moving a hierarchical pin slightly move also other hierarchical pins 
Fixes: lp:1808687
https://bugs.launchpad.net/kicad/+bug/1808687
 2018-12-16 15:31:31 +01:00
Frank Severinsen e2ed0e6557 Move sheet pins in front of sheetedge & move them in by ½ line width 2018-12-15 20:15:19 +00:00
Seth Hillbrand e307d9318b Revert "Fixed memory leaks" 
This reverts commit a9efbf4716.

The commit broke compiles with scripting
 2018-12-11 10:12:44 -08:00
Jeff Young 2c53ab3d8c Fix debug assert. 2018-12-11 17:56:41 +00:00
Maciej Suminski 63d4afb3ee Support autopanning in GALified eeschema 
Fixes: lp:1807234
* https://bugs.launchpad.net/kicad/+bug/1807234
 2018-12-11 17:49:34 +01:00
Maciej Suminski a9efbf4716 Fixed memory leaks 2018-12-11 16:21:43 +01:00
Maciej Suminski 7e1498a46f Set the screen pointer to null before deleting the associated items 
VIEW needs to be cleared before deleting the stored items. Otherwise it
may dereference stale pointers leading to a crash.
 2018-12-11 16:21:43 +01:00
Jeff Young 40dac0ecbb Default sizes for edit frames in case prefs get deleted. 
Fixes: lp:1807676
* https://bugs.launchpad.net/kicad/+bug/1807676
 2018-12-10 12:23:16 +00:00
jean-pierre charras e50d9df76a Eeschema: fix incorrect parsing of line color (r v b values). 
Only the R and V were read, the parsing was stopping before reading the B value.
 2018-12-09 17:59:24 +01:00
Seth Hillbrand fd537c8230 eeschema: Do not clear highlights with NULL screen 
When closing a project, the screen is released, so we need to avoid
cross-probe calls dereferencing the screen pointer.

Fixes: lp:1807501
* https://bugs.launchpad.net/kicad/+bug/1807501
 2018-12-08 07:54:31 -08:00
jean-pierre charras a40cff18d3 PANEL_EESCHEMA_SETTINGS_BASE: very minor cosmetic enhancement. 2018-12-07 11:30:52 +01:00
jean-pierre charras f1c1c5db3f Fix a minor compil warning 2018-12-07 11:22:03 +01:00
Maciej Suminski 766156ed87 Fix for dark mode on macOS Mojave 
Thanks to Scott Rapson and Justace Clutter for the solution.

Fixes: lp:1797989
* https://bugs.launchpad.net/kicad/+bug/1797989
 2018-12-07 09:03:56 +01:00
Jeff Young 3a0dbf48c8 Read Symbol Browser grid settings from Symbol Editor. 2018-12-07 00:26:10 +00:00
Seth Hillbrand ed506dd05e eeschema: Prevent excess link updates 
Refreshing the symbols for each paint is excessive to catch the change
from library loads.  Instead we catch them on the KIWAY MAIL update
 2018-12-06 13:46:52 -08:00
Wayne Stambaugh b8de4e73bf Eeschema: fix schematic symbol parsing bug. 
Schematic symbol library link names are unquoted strings that can
contain non-ascii characters which breaks the parser.  Converting
the line to uft-8 before breaking the string into tokens resolves
the issue.
 2018-12-06 12:44:13 -05:00
Wayne Stambaugh 742961119d Eeschema: fix library symbol pin definition parsing bug. 
Pin names are unquoted strings that can contain non-ascii characters
which breaks the parser.  Converting the line to uft-8 before breaking
the string into tokens resolves the issue.
 2018-12-06 11:47:20 -05:00
D4p0up e94752a6cf Added help string to select buttons. 
Also moved highlight text string to help_common_strings.h

Fixes: lp:1497737
* https://bugs.launchpad.net/kicad/+bug/1497737
 2018-12-05 20:13:03 -08:00
Wayne Stambaugh 07ebc4df14 Fix schematic append clear annotation bug. 
Clear the annotation of only the appended schematic and any sheets in it's
hierarchy.  Do not clear the annotation of the symbols in the target sheet.

Fixes lp:1805695

https://bugs.launchpad.net/kicad/+bug/1805695
 2018-12-05 17:12:11 -05:00
Wayne Stambaugh a61a51f26e Eeschema: fix UTF8 character handling bug in legacy parser. 
Iterating over unquoted strings as ASCII8 fails when ' ' character is
not the LSB of a UTF8 string with wide characters.  Change parsing method
for unquoted strings to convert the entire line as UTF8 and then use
wxStringTokenizer to break the line into tokens at the ' ' characters.

Fixes lp:1806206

https://bugs.launchpad.net/kicad/+bug/1806206
 2018-12-05 13:54:51 -05:00
jean-pierre charras 58036382c1 eeschema: Fix slow redraw on net highlighting (by redrawing only modified items) 
Fixes: lp:1806197
https://bugs.launchpad.net/kicad/+bug/1806197
 2018-12-04 20:55:59 +01:00
Maciej Suminski ca5751fc46 Symbol Editor: update the view after relocating the anchor 2018-12-04 09:42:26 +01:00
Jeff Young 61b749f0b2 Update dangling ends when resizing sheet. 
Fixes: lp:1805127
* https://bugs.launchpad.net/kicad/+bug/1805127
 2018-11-30 21:34:18 +00:00
Jeff Young ff6a3482ec Remove on-kill-focus-validation. 
Fixes: lp:1805361
* https://bugs.launchpad.net/kicad/+bug/1805361
 2018-11-29 19:00:21 +00:00
Maciej Suminski 6d8ca311f8 Fix a crash after clicking 'delete' button with empty Template Field Names grid 2018-11-29 14:09:07 +01:00
Jeff Young 9b7d6a27de Don't show dangling symbols at ends of wires with no-connect flags. 
Fixes: lp:1805255
* https://bugs.launchpad.net/kicad/+bug/1805255
 2018-11-27 14:44:13 +00:00
Jeff Young 6bf0e17036 Fix typo which was keeping rename from working. 
(Renaming the dialog window instead of the libentry doesn't really
do the trick.)
 2018-11-25 01:51:45 +00:00
Jeff Young d2756bedf1 Keep state except when the filter changed. 
(Used to be "except when filtering".)

Fixes: lp:1804293
* https://bugs.launchpad.net/kicad/+bug/1804293
 2018-11-25 01:51:45 +00:00
Jeff Young 239482ec98 Add tooltips to Symbol Properties dialogs. 
Fixes: lp:1804931
* https://bugs.launchpad.net/kicad/+bug/1804931
 2018-11-24 15:06:21 +00:00
Jeff Young 2e1920abad Add tooltips to library manager dialogs. 
Fixes: lp:1804930
* https://bugs.launchpad.net/kicad/+bug/1804930
 2018-11-24 15:06:21 +00:00
Jeff Young b2db49f4ac Add browse buttons to Library Manager dialogs. 
Fixes: lp:1804924
* https://bugs.launchpad.net/kicad/+bug/1804924
 2018-11-24 15:06:21 +00:00
jean-pierre charras db7deff21b DIALOG_SPICE_MODEL_BASE: fix minor wxWidgets alerts. 2018-11-23 10:21:57 +01:00
Jeff Young ed6c68a1e3 Clean up handling of component fields. 
In particular the datasheet field and how its handled with aliases,
but also cleaning up duplicated functionality around aliases and
libids.
 2018-11-22 21:31:45 +00:00
Jeff Young 023a445e9f Make sure original part record always has the write library nickname. 
Fixes: lp:1804293
* https://bugs.launchpad.net/kicad/+bug/1804293
 2018-11-21 19:51:04 +00:00
Jeff Young f934ce653f A bit of safety to prevent dereferencing NULL. 2018-11-21 19:51:04 +00:00
Jeff Young ae6989f3a1 Don't trim entire wires. 
Fixes: lp:1804297
* https://bugs.launchpad.net/kicad/+bug/1804297
 2018-11-20 21:44:35 +00:00
Jeff Young d6ac303a8c Don't dereference NULL when checking current part. 2018-11-20 20:21:29 +00:00
Jeff Young a958b23a11 Remove assert which fires incorrectly when emptying screen. 2018-11-20 20:21:29 +00:00
Jeff Young 9145d6a0a3 Put library name in confirmation dialog when reverting library. 2018-11-20 20:21:29 +00:00
Maciej Suminski 630baa3724 Code formatting 2018-11-20 17:54:10 +01:00
Maciej Suminski d405be95b8 Fix a symbol editor crash when clicking without any symbol loaded 2018-11-20 17:52:58 +01:00
jean-pierre charras ab3ff61faa Eeschema: adjust the working/drawing area size on the page size. 
This makes using Scrollbars more easy to use, especially for "small" page sizes like A or B.
Note also the working/drawing area size is bigger than the page size (3 times)
 2018-11-20 15:11:22 +01:00
Jeff Young 984d3f04ab Update dangling ends after importing schematic content. 
Fixes: lp:1803996
* https://bugs.launchpad.net/kicad/+bug/1803996
 2018-11-19 20:47:31 +00:00
Jeff Young 18dc618a13 Set color before drawing dangling symbols. 
Fixes: lp:1804003
* https://bugs.launchpad.net/kicad/+bug/1804003
 2018-11-19 20:29:48 +00:00
Jeff Young e715835c29 Copy dangling flag when cloning. 
Fixes: lp:1804005
* https://bugs.launchpad.net/kicad/+bug/1804005
 2018-11-19 19:07:40 +00:00
jean-pierre charras 8522baf4a7 bom_plugins.cpp: fix incorrect command line for python scripts on Windows. 
* On Windows, a python command line must be python <script_path>/script.py
and not python <script_path>\script.py
* Fix also a incorrect warning message when a script is not found.
 2018-11-19 17:50:38 +01:00
Maciej Suminski 2ee2d9014a Populate BOM plugins list if the list is empty 
Fixes: lp:1464893
* https://bugs.launchpad.net/kicad/+bug/1464893
 2018-11-19 16:17:53 +01:00
Maciej Suminski 15772e4b0b BOM plugins refactor 
Extended BOM_PLUGIN to a class and moved the plugin construction related code there.
 2018-11-19 15:59:08 +01:00
jean-pierre charras 240051fb26 Worksheet display in GAL mode: fix missing filename and (in Eeschema) sheet full name. 2018-11-19 10:21:28 +01:00
jean-pierre charras c539d6e0be fix incorrect initialization of VIEW::m_boundary. 
This parameter defines the working area (full page) size.

The fix is not perfect, because it does not take in account the page size.
However it is similar to the "old" initialization, before Eeschema GAL.
In Eeschema, a reasonable boundary size is used.
 2018-11-18 20:04:17 +01:00
Jeff Young 0de9cb345c Add shortcuts to setting dialogs for track widths, via sizes and grid sizes. 
Fixes: lp:1803671
* https://bugs.launchpad.net/kicad/+bug/1803671
 2018-11-17 00:35:06 +00:00
jean-pierre charras b35b1bb644 Fix a few minor I18n issues. 
Especially remove trailing and leading spaces in sentences, always annoying in translations, and never useful in sources.
 2018-11-16 18:12:01 +01:00
Maciej Suminski e3bcd31bff Added a dialog to confirm discarding unsaved changes in Pin Table dialog. 2018-11-16 16:10:53 +01:00
Maciej Suminski de1a8abd3e Fix a crash after accepting changes from Pin Table dialog 
Pin Table dialog replaces LIB_ITEMs, while one of them may still
be pointed to as the current library item. Certain wxUpdateUIEvent
will try to dereference the pointer, leading to a crash.
 2018-11-16 14:13:28 +01:00
Jeff Young 4050991d28 Move ERC marker focusing to GAL architecture. 
Fixes: lp:1802537
* https://bugs.launchpad.net/kicad/+bug/1802537
 2018-11-16 10:38:44 +00:00
jean-pierre charras acf696ca2d Eeschema, worksheet view: fix missing initialisation of sheet count and sheet number 
Fixes: lp:1803637
https://bugs.launchpad.net/kicad/+bug/1803637
 2018-11-16 09:36:10 +01:00
jean-pierre charras 1f3d5cee0e Fix a few minor I18n issues. 2018-11-15 09:34:29 +01:00
Jeff Young bcc8c64256 Consider edge cuts items to have zero width when filling zones. 
Fixes: lp:1797787
* https://bugs.launchpad.net/kicad/+bug/1797787
 2018-11-14 23:45:32 +00:00
Jeff Young d65bb73d4e Finish up remaining block operation inconsistencies. 
In particular, don't move block back to start when duplicating,
and don't move crosshair back to start when doing a cut, copy, or
paste.

Also fixes undo for libEdit block duplicate.

Fixes: lp:1740138
* https://bugs.launchpad.net/kicad/+bug/1740138
 2018-11-14 23:45:32 +00:00
Jeff Young ac2e400598 Re-instate schematic-scope to dangling ends. 
Fixes: lp:1803117
* https://bugs.launchpad.net/kicad/+bug/1803117
 2018-11-13 21:03:18 +00:00
Jeff Young a60066115b Move no-connect symbols closer to the front for rendering. 
Fixes: lp:1803124
* https://bugs.launchpad.net/kicad/+bug/1803124
 2018-11-13 21:03:18 +00:00
Maciej Suminski 298a033b9d Fixed a crash on moving down the last field in the Symbol Properties dialog 2018-11-13 14:14:08 +01:00
Maciej Suminski 44424dcbb3 Fixed a crash in Symbol Properties dialog 
Fixes: lp:1802641
* https://bugs.launchpad.net/kicad/+bug/1802641
 2018-11-13 14:02:16 +01:00
jean-pierre charras 436f80a0bb eeschema/dialogs/dialog_lib_edit_pin_base.cpp: fix a minor wxWidgets alert 2018-11-13 13:03:38 +01:00