haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
39,851 Commits 9 Branches 105 Tags 1.3 GiB
Commit Graph

217 Commits

Author SHA1 Message Date
Jeff Young 7bb0275d3c Fix incompatibility with old rubber-band wire algo and new ortho wire drag alog. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11948
 2022-10-03 22:12:23 +01:00
Jeff Young c6284f4835 Formatting. 2022-10-03 22:12:23 +01:00
Jeff Young 83a7ab2449 Initialize resolved status of newly created wires during drag operation. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12522
 2022-09-27 14:12:06 +01:00
Mike Williams 9304607624 TOOL_EVENT: make command string non-optional 
We're getting segfaults in places where this isn't checked. Also, add
some asserts so we can catch bad tool push/pop.

Removes all uses of GetCommandStr() and makes it private.
 2022-09-19 10:23:09 -04:00
Seth Hillbrand b736460e71 Move optional access from value() to *operator 
`value()` throws.  Where we check for existence, we don't need to use
the throwing version and should just use the unprotected variant
 2022-08-30 13:59:39 -07:00
Seth Hillbrand f1261e71d4 Replace boost::optional with std::optional 2022-08-25 15:50:47 -07:00
Jeff Young aa2ad3b44c Move KICAD_T[] to std::initializer_list<KICAD_T>. 2022-08-20 10:28:11 +01:00
Seth Hillbrand 35ac39844f Clean up some auto usage 
Don't make new copies of shared_ptr if we can use references.  Keep auto
usage down to hard-to-type-out sequences
 2022-08-15 11:29:45 -07:00
Jeff Young bdffbbd43b Handle rotation while moving from move tool. 
This keeps us from getting CancelInteractive events in the move tool
when the EditTool runs to do the rotate.

Fixes https://gitlab.com/kicad/code/kicad/issues/12004
 2022-07-22 09:31:09 +01:00
Jeff Young 29900cad34 Add create-wire logic to labels. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11768
 2022-06-10 22:38:01 +01:00
Jeff Young bce1fd337b Second tool hotkey accepts action (ie: acts as click). 
Fixes https://gitlab.com/kicad/code/kicad/issues/11729
 2022-06-09 16:54:04 +01:00
Simon Richter bd7447cff3 Fix variable name 
This is the top left position, not the top right.
 2022-05-05 10:27:19 +00:00
Mike Williams 653baf270c Schematic: drag created / changed segments need junction checks 
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/10844
 2022-04-18 17:24:02 +00:00
Jeff Young 8dc680adbb Implement align-to-grid for sheets. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11201
 2022-03-29 19:31:02 +01:00
Mike Williams 2a726a882f Schematic: new feature, force 45 degree lines 
* New modes to force 45 deg angle at beginning or end of line

* Backspace will undo most recent segment added

* / will toggle posture of 90 and 45 degree lines

* Added alg::signbit for convenience

Fixes: https://gitlab.com/kicad/code/kicad/-/issues/10869
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/9175
 2022-03-28 16:07:23 -04:00
Mike Williams e51ab86225 Schematic Drag: fixes and improvements 
Fixes:
* Various special cases around junctions on pins and dragging.

* Some rotations of endpoints resulting in a 45 degree rotate.

* Some cases where it was possible to get a line with neither
  endpoint selected, and also substractive unselecting only one of two
  selected endpoints unselecting both.

* Use line midpoint for sorting.  Start and endpoints aren't
  consistent in the order they appear on the X or Y axis. So,
  we need to use the midpoint for our position for consistent
  sorting when dragging groups of parallel lines where some
  have the start and end reversed.

Other:
* Rename TEMP_SELECTED TO SELECTED_BY_DRAG. This is the actual meaning
  of the flag, and should reduce confusion as
  to when it should be used.

* Move usage of TEMP_SELECTED as an algorithmic mark to CANDIDATE
  instead.

* Fix mistaken clearing of START_POINT and ENDPOINT.

* Move endpoint setting and clearing out of narrowSelection, and into
  selectPoint and selectMultiple.

* Don't show dangling end warnings on new lines
 2022-03-28 16:02:48 -04:00
Jeff Young 05bca282f7 Re-entrancy blocker for line/wire/bus tool. 
Also clear infobar messages after a cancelInteractive.

Fixes https://gitlab.com/kicad/code/kicad/issues/11155
 2022-03-17 15:27:33 +00:00
Jeff Young a2772b3363 Don't crash on highight net during drag. 
Fixes https://gitlab.com/kicad/code/kicad/issues/10866
 2022-02-21 13:30:15 +00:00
Mike Williams d0749c4e9a Schematic: more drag undo fixes 
Drag was not clearing IS_CHANGED status of items that were moved by the
drag, but weren't selected or created by it.

Fixes: https://gitlab.com/kicad/code/kicad/-/issues/10845
 2022-02-20 11:49:18 +00:00
Seth Hillbrand 24ac516135 Trim wires based on how many pins they intersect 
If a wire intersects more than 2 pins from the same symbol, we don't
trim connections.  If the wire intersects exactly two pins from a single
symbol, we remove the wire between the pins.

We avoided doing this before because we didn't have a good metric for
trimming vs. not.  But the per-symbol calculation feels like the least
surprising option.

Fixes https://gitlab.com/kicad/code/kicad/issues/10909

Fixes https://gitlab.com/kicad/code/kicad/issues/1857

(cherry picked from commit 75a4036e45)
 2022-02-19 16:54:45 -08:00
Mike Williams 97797c44b9 Schematic: added drag wires undo/redo fix 
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/10845
 2022-02-15 19:31:17 +00:00
Seth Hillbrand 45a1a9a715 Replace awkward double cast with binary logic 
The use of XOR with integers here is needed as MSVC doesn't implement
the use of std::signbit for integers and casting up to double just to
get the signbit feels wrong
 2022-02-15 10:13:59 -08:00
Marek Roszko 3129f96686 Add awkward cast to double due to msvc conflict 
https://github.com/microsoft/STL/issues/519
 2022-02-14 21:43:11 -05:00
Mike Williams 9c59c4ee12 Schematic: orthogonal drag bends should depend on move direction 
Prevents overlapping lines when possible.

Fixes: https://gitlab.com/kicad/code/kicad/-/issues/10844
 2022-02-14 22:52:34 +00:00
Mike Williams 21b59b4b6a Eeschema: fix bus label drag adding a line 
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/10822
 2022-02-11 21:30:50 +00:00
Mike Williams a5e8575091 Eeschema: Implement orthogonal dragging 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/1956
 2022-02-10 18:38:40 +00:00
Jeff Young c6a8100d46 Schematic and symbol text boxes. 
Also fixes some plot bugs with arcs.

Also moves polygonization of arcs (when required) in plotting code
from 5 degrees to calculated based on ARC_HIGH_DEF.

Fixes https://gitlab.com/kicad/code/kicad/issues/5017
 2022-01-28 21:38:15 +00:00
Jeff Young 3409783d9f Break sch_text.h/.cpp into sch_text and sch_label. 
Also moves SCH_NETCLASS_FLAG to SCH_DIRECTIVE_LABEL, and remaps Altium
harnesses from SCH_TEXT to SCH_DIRECTIVE_LABEL.
 2022-01-28 21:38:15 +00:00
Marek Roszko 34e90e5045 Silence MSVC warnings about type mismatch and unused var 2022-01-01 14:41:36 -05:00
Marek Roszko c4c56de708 Neurotically update position wxPoint usages 2022-01-01 11:55:51 -05:00
Marek Roszko 347e03363a Convert wxPoint/wxSize starting from EDA_RECT usages 2022-01-01 11:30:33 -05:00
Jeff Young 889970a449 SCH_NETCLASS_FLAGs and SCH_FIELDs for labels. 
ADDED: a new label type for netclass flags.
ADDED: the ability to define fields on labels.
 2021-12-24 16:13:27 +00:00
Seth Hillbrand 85ab4e5886 Don't deselect wires when aligning 
This makes undo/redo look really strange as the other elements get
aligned but the wires do not (or rather their unconnected ends do not)

Fixes https://gitlab.com/kicad/code/kicad/issues/9275
 2021-11-30 16:30:28 -08:00
dsa-t 5750e38102 Re-enable and fix Move+Autoplace Fields 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/9766
 2021-11-29 20:48:16 +00:00
Jeff Young a224d8dd6c Disable autoplace fields when dragging/moving. 
Fixes https://gitlab.com/kicad/code/kicad/issues/9766
 2021-11-28 19:18:08 +00:00
Roberto Fernandez Bautista b572781a8a eeschema: Update anchor position of pasted items after initial move 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/9534
 2021-11-06 16:03:41 +00:00
Jeff Young 996a5b85a6 Overhaul IsJunctionNeeded logic to support all the different cases. 
Several clients were using this with different needs.  The API is
now more explicit (and there are more options under the hood).

Fixes https://gitlab.com/kicad/code/kicad/issues/9518
 2021-11-04 12:57:16 +00:00
Jeff Young b8d193485d Respect selection reference point when set. 
Fixes https://gitlab.com/kicad/code/kicad/issues/8520
 2021-10-18 18:09:40 +01:00
Seth Hillbrand 71602475eb Allow rotate/mirror even when dragging 
Keeps the lines connected but doesn't solve the crossed-wire mixups.
This allows common usage (mirroring labels/rotating segments) and leaves
prevention of the crossed wires to the user.

We can't really prevent crossed wires when rotating e.g. a part with
wires connected to 4 sides and users will not expect that.  But we
should not disable useful features like mirroring multiple parallel
items to avoid a known impossible situation

Also provides an alternative solution to 345f506f0c that allows us to
rotate groups without destroying connections on hover

Fixes https://gitlab.com/kicad/code/kicad/issues/8403

Fixes https://gitlab.com/kicad/code/kicad/issues/8523
 2021-09-23 14:47:49 -07:00
Jeff Young fdfecf5932 Don't push view control settings to the previous active tool. 
See further comments in bug report.

Fixes https://gitlab.com/kicad/code/kicad/issues/9147
 2021-09-13 13:28:05 +01:00
Wayne Stambaugh 8fd83cbb95 Pass wxPoint objects by reference instead of on the stack. 2021-07-26 15:35:33 -04:00
Jeff Young a1a48a4c42 Don't allow rotation/mirroring while dragging. 
Fixes https://gitlab.com/kicad/code/kicad/issues/8523
 2021-06-13 20:22:25 +01:00
Wayne Stambaugh fbc135e69f Rename SCH_COMPONENT to SCH_SYMBOL. 2021-06-10 10:34:49 -04:00
Jon Evans 9ffa2955b7 Fix drag of bus wire creating net wires 2021-06-03 22:29:04 -04:00
Jeff Young 0598c82972 Terminology (use present tense for flags). 2021-05-31 12:26:44 +01:00
Jeff Young 2a856890e6 Allow connections between sheet (pins) and symbols. 
Fixes https://gitlab.com/kicad/code/kicad/issues/8305
 2021-05-12 00:07:17 +01:00
Jeff Young 7356f9568d Move grid disable modifier from ALT to CTRL. 
Also had to move the H/V/45 disable modifier from CTRL to SHIFT.

Fixes https://gitlab.com/kicad/code/kicad/issues/8124
 2021-05-09 20:17:40 +01:00
Jeff Young b78ba12739 Don't allow activation of other tools in the middle of a move. 
Fixes https://gitlab.com/kicad/code/kicad/issues/8116
 2021-05-08 20:49:51 +01:00
Jeff Young 21d4197eab Apply SPECIAL_CASE_LABEL_INFO architecture to one-ended-drag. 
We've been doing this for some time to wires that are attached to
the moving block (and therefore have the other end anchored).  However
we also need to apply it when dragging a single end of a wire.

Fixes https://gitlab.com/kicad/code/kicad/issues/7807
 2021-04-07 14:40:07 +01:00
Jeff Young 30a073c2bb Cleanup. 2021-04-07 14:40:07 +01:00
Wayne Stambaugh 2b86b34124 Eeschema: split out SCH_SHEET_PIN declarations into separate header. 2021-04-06 17:15:49 -04:00
Jeff Young 14e73d24dc Naming conventions. 2021-03-29 11:46:05 +01:00
Jeff Young cf4cbea8a1 Use a more robust storage of items added to drag. 
We kept having various issues of the pointer list going stale.  This
will prevent all permutations of that.

Also while I was in there I fixed the double-move thing (see bug
number).

Fixes https://gitlab.com/kicad/code/kicad/issues/7910
 2021-03-22 13:51:10 +00:00
Jeff Young 573dd36515 Handle <delete> in move and drawing tools. 
Fixes https://gitlab.com/kicad/code/kicad/issues/7924
 2021-03-15 14:23:54 +00:00
Jeff Young 068e85c567 Reset moved flag after completing move. 
Fixes https://gitlab.com/kicad/code/kicad/issues/7818
 2021-03-10 16:00:28 +00:00
Jeff Young 8be3ff5a0a Perform a slightly more aggressive cleanup. 
Also removes the functionality that selects the newly-added item as
we don't do that with any of the other drawing tools.

Fixes https://gitlab.com/kicad/code/kicad/issues/7833
 2021-03-09 21:42:35 +00:00
Wayne Stambaugh 1786ae8773 Eeschema: use symbol nomenclature for object file naming. 2021-02-24 08:48:02 -05:00
Jeff Young 57e043e0e6 Don't allow moving markers. Do allow excluding them. 2021-02-19 19:07:45 +00:00
Seth Hillbrand 02c7fcdc84 Fix BreakWire tool 
Adds ability to start new commit to eeschema, allowing all
AddItemsToUndoList to always append without foreknowledge.  Keeps newly
split wires on the tool until placed

Fixes https://gitlab.com/kicad/code/kicad/issues/7512
 2021-02-12 17:17:12 -08:00
Seth Hillbrand b07c8110c8 Follow grid snapping when moving 2021-02-02 20:23:12 -08:00
Jeff Young b576ccef61 Don't double-up tools on tool stack. 
Also make sure move tool gets cancelled by other tools being
activated.

Fixes https://gitlab.com/kicad/code/kicad/issues/7259
 2021-01-26 10:56:19 +00:00
Jeff Young d770284fa2 Add a bus instead of a wire for bus junctions. 
Fixes https://gitlab.com/kicad/code/kicad/issues/7231
 2021-01-23 17:04:44 +00:00
Jeff Young dc65166ee7 Implement algin-to-grid for fields. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6530
 2021-01-03 22:39:58 +00:00
Jeff Young c16dda4027 Make sure added wires (from junctions) don't get left selected. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6852
 2020-12-27 13:17:03 +00:00
Jeff Young c0e5e8eeee Formatting. 2020-12-27 13:17:03 +00:00
Jeff Young 22a6b36257 Don't allow dbl-click to leak through to other tools. 
This only applies if the tool doesn't handle properties (which also
handles double-click events).

Fixes https://gitlab.com/kicad/code/kicad/issues/6735
 2020-12-14 22:15:43 +00:00
Jeff Young a19028a396 Hook up EE_GRID_HELPER to some more tools. 
Also implements EE_GRID_HELPER layers so that connectable things
snap to connectable things and graphics snap to graphics.

Fixes https://gitlab.com/kicad/code/kicad/issues/5641
 2020-12-03 15:16:34 +00:00
Jeff Young 43fe228367 Hook up a bit more of the EE_GRID_HELPER. 
Fixes https://gitlab.com/kicad/code/kicad/issues/5985
 2020-12-02 23:18:33 +00:00
Jeff Young 8c5c902fa3 Re-write IntersheetRefs on top of SCH_FIELDs and textVars. 
1) Generalize SCH_ITEM owners (SCH_COMPONENT, SCH_SHEET, and now
SCH_GLOBALLABEL)
2) Generalize hypertext items
3) Use SCH_FIELD autoplace infrastructure for placing intersheet
references
4) Use textVar infrastructure for buildin intersheet references.

As an important side-effect this also fixes the undo issues with
intersheet refs.
 2020-11-17 16:05:49 +00:00
Jeff Young 91ba002da7 Make sure move machinery gets initialized if we're going to use it. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6293
 2020-11-06 12:21:31 +00:00
Jeff Young 9065908859 Update SCH_SCREEN's RTree when moving items. 
Or when modifying geometric shape/properties.

Fixes https://gitlab.com/kicad/code/kicad/issues/5922
 2020-10-30 15:26:07 +00:00
Jeff Young 6ce803b77c Push/pop move tool even when there's nothing to move. 
This keeps other tools from having the special-case an empty move.

Fixes https://gitlab.com/kicad/code/kicad/issues/6048
 2020-10-18 12:08:15 +01:00
Marek Roszko b2e9f6987d Split base_struct into eda_item and eda_rect 2020-10-13 21:24:50 -04:00
Jeff Young fd874d8345 Check to see if isolating junction is part of the drag or not. 
Fixes https://gitlab.com/kicad/code/kicad/issues/5960
 2020-10-13 13:52:49 +01:00
Jeff Young 0efe073dec Add wires between selected wires and unselected junctions when dragging. 
Also fixes a bug where the auto-start-wire stuff was messing up the seleciton
when the selection tool wasn't at the top of the tool stack.

Fixes https://gitlab.com/kicad/code/kicad/issues/5960
 2020-10-12 11:46:08 +01:00
Franck Jullien fc93a04751 eeschema: iref: use GetParentLabel instead of GetParent 2020-10-09 02:37:51 +00:00
Mark Roszko d9485129c8 Implement more context specific cursors using both stock and custom cursors. 2020-10-08 00:50:28 +00:00
Jeff Young 44580acee2 Clean up some compiler warnings. 2020-10-03 22:55:34 +01:00
Franck Jullien 2fc49045d1 ADDED: eeschema: Add intersheets references function 
Add a new function to place intersheets references next to
global labels.
 2020-10-01 20:39:32 +00:00
Jeff Young d468618411 Don't eat commands that aren't ours in SCH_MOVE_TOOL. 
Fixes https://gitlab.com/kicad/code/kicad/issues/5692
 2020-09-18 16:45:41 +01:00
PJM c8879d9034 Eeschema: Check if user wants to warp mouse to origin of moved object 
CHANGED: When moving a footprint, Eeschema was always warping the mouse
when moving an item regardless of the state of the "Warp mouse to
origin of moved object" checkbox.  This MR now honors the state of the
checkbox when moving schematic items.

NOTE: Issue 5279 originally only mentioned Pcbnew, but after the fix
for Pcbnew was submitted, a user pointed out it also happened in
Eeschema.  Becuase of this, there are two MRs that "fix" the same issue.

Fixes https://gitlab.com/kicad/code/kicad/issues/5279
 2020-09-18 02:49:59 +00:00
Seth Hillbrand 471f81742f ADDED: Align to Grid function in Eeschema 
Adds tool option to align selected elements to the current grid.

Fixes https://gitlab.com/kicad/code/kicad/issues/5481
 2020-09-17 12:27:43 -07:00
Seth Hillbrand 23a9df8a59 ADDED: Allow Eeschema dragging graphical corners 
This separates the two options (drag/move) into different actions.  Drag
will drag all graphical lines connected.  Move will disconnect the
graphical lines when moving.
 2020-09-11 09:31:38 -07:00
Seth Hillbrand f493e270ea ADDED: Menu option to enable/disable snap to grid 
You can now enable and disable snap to grid when drawing/editing across
all apps.  You can also tie snap to grid to the visibility of the grid
to allow rapid enable/disable via grid display.
 2020-09-10 20:09:30 -07:00
Seth Hillbrand 62433736bc Snap Eeschema moves to nearest anchor 
Fixes https://gitlab.com/kicad/code/kicad/issues/3803
 2020-09-09 10:48:15 -07:00
Seth Hillbrand 4026904cc4 Make grid snapping depend on grid visibility 
Turning the grid view on enables snapping to the grid.  Turning it off
removes the snap and allows free draw
 2020-09-09 10:18:15 -07:00
Seth Hillbrand 173b4ff588 Add snapping to eeschema 
This generalizes both the SetPosition() function and ORIGIN_VIEWITEM
class away from the pcbnew-centric.
 2020-09-09 10:18:15 -07:00
Seth Hillbrand 02a5d47de9 Avoid passing references in EESchema 
This returns the connection list by value.  This allows easier Python
use

Also renames m_End() to GetEnd()
 2020-09-08 06:29:27 -07:00
Mark Roszko 1082402b33 Convert UNDO_REDO_T to an enum class 2020-08-26 18:04:32 +00:00
Jeff Young 1138c32bf3 Don't pass Cancel event where there was a specific action cancelled. 
For instance, if during a move the user hits ESC they only want the
move cancelled, not (for instance) the selection dropped.

Fixes https://gitlab.com/kicad/code/kicad/issues/5356
 2020-08-25 12:54:40 +01:00
Marek Roszko 3674064b9e Fix double msgpanel refresh and use the new moved event 2020-08-18 13:11:48 +00:00
Jeff Young 7340c97ef9 Undo for schematic-wide operations. 
Editing value/footprint fields of multi-unit components.
Find/Change.
Annotation.
Back annotation.

Fixes https://gitlab.com/kicad/code/kicad/issues/2122

Fixes https://gitlab.com/kicad/code/kicad/issues/4869

Fixes https://gitlab.com/kicad/code/kicad/issues/3933

Fixes https://gitlab.com/kicad/code/kicad/issues/4871

Fixes https://gitlab.com/kicad/code/kicad/issues/3899
 2020-07-13 12:32:17 +01:00
Jeff Young 73e1496b25 Change attached-label algorithm. 
Rather than try and keep moving with other items, calculate nearest
point on current line to original label at each step.

Fixes https://gitlab.com/kicad/code/kicad/issues/4347
 2020-05-07 18:59:47 +01:00
Jeff Young 51e72ed9ba Finish the collect-attached-labels rewrite. 
Fixes https://gitlab.com/kicad/code/kicad/issues/4341
 2020-05-06 20:38:12 +01:00
Jeff Young 0f34fc2e5f Simplify the "pick up attached labels" logic. 
This should vastly reduce the number of side-effects we were seeing.

Fixes https://gitlab.com/kicad/code/kicad/issues/4311

Fixes https://gitlab.com/kicad/code/kicad/issues/git

Fixes https://gitlab.com/kicad/code/kicad/issues/4320
 2020-05-06 15:48:58 +01:00
Jeff Young 5bed201a23 Don't collect connected labels on a paste. 
Fixes https://gitlab.com/kicad/code/kicad/issues/4311
 2020-05-03 21:47:53 +01:00
Jeff Young a286cb5a8f Keep labels on dragged wires. 
Fixes https://gitlab.com/kicad/code/kicad/issues/2107
 2020-04-19 18:24:39 +01:00
Jeff Young 122b1ddaae Unwrap an unnecessary layer now that we have new config stuff. 2020-04-13 20:58:12 +01:00
jean-pierre charras e811101567 fix a few Coverity warnings. 2020-04-01 09:34:44 +02:00
Jeff Young 535033c5c9 Enable editing of sheet fields. 2020-03-07 18:52:30 +00:00