haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
19,427 Commits 9 Branches 105 Tags 1.3 GiB
Commit Graph

154 Commits

Author SHA1 Message Date
Jeff Young 827138f6b4 Remove left-over debug code. 2020-08-10 14:17:17 +01:00
Jeff Young f4ab14f32d Performance improvements for SchematicCleanup(). 
Fixes https://gitlab.com/kicad/code/kicad/issues/4563
 2020-08-10 12:41:52 +01:00
Jeff Young 7340c97ef9 Undo for schematic-wide operations. 
Editing value/footprint fields of multi-unit components.
Find/Change.
Annotation.
Back annotation.

Fixes https://gitlab.com/kicad/code/kicad/issues/2122

Fixes https://gitlab.com/kicad/code/kicad/issues/4869

Fixes https://gitlab.com/kicad/code/kicad/issues/3933

Fixes https://gitlab.com/kicad/code/kicad/issues/4871

Fixes https://gitlab.com/kicad/code/kicad/issues/3899
 2020-07-13 12:32:17 +01:00
Jeff Young 1535c83b88 Lay some groundwork for adding distances to DRC errors. 
modified:   eeschema/lib_rectangle.cpp
 2020-04-24 14:46:22 +01:00
Jeff Young 20c00cbb21 Finish off "busses" -> "buses". 
Fixes https://gitlab.com/kicad/code/kicad/issues/4144
 2020-04-02 18:27:05 +01:00
Seth Hillbrand ef00fa6008 Cleanup busses 
At some point the buses were no longer being addressed in
SchematicCleanup().  This re-adds bus segments to the checklist for
segments to merge/clean
 2020-01-22 05:53:40 -08:00
Seth Hillbrand 6e5e453d0d Replace EESchema DLIST 
This moves EESchema DLIST structures to rtree.  These changes are more
fundamental than the pcbnew changes from 9163ac543 888c01d11 d1877d7c1
and 961b22d60 as eeschema operations were more dependent on passing
drawing list references around with SCH_ITEM* objects.
 2020-01-10 06:37:08 -08:00
Ian McInerney 079423c3cc eeschema: Remove unused include of eeschema_id.h 2020-01-03 16:04:54 +00:00
Seth Hillbrand cda291adae eeschema: Clean bits of DLIST 
Removes the extra DLIST manipulation from SCH_LINE_WIRE_BUS_TOOL and
moves the static storage into class storage
 2019-12-13 11:22:18 -08:00
Jeff Young 9d288968e7 Be more explicit about extent of schematic cleanups. 
The new connectivity algorithm had a tendency to cleanup
globally, but that could insert undo records from other sheets
into the current screen's undo stack.  Needless to say, this
was a recipie for segfaults.

Fixes: lp:1846247
* https://bugs.launchpad.net/kicad/+bug/1846247
 2019-11-10 23:25:54 +00:00
Jeff Young 33606431cc Fix an insidious bug where DoDelete() and DeleteJunction() were fighting over who owned the STRUCT_DELETED flag. 
Fixes: lp:1844620
* https://bugs.launchpad.net/kicad/+bug/1844620
 2019-09-19 19:11:19 +01:00
Jeff Young 7ad98b8a7d Fix bug in JunctionNeeded and selection around adding/removing junctions. 
When checking for 3 or more connections, at least one of them must be
a pin.  Otherwise we need to fall down to the next check which also
ensures that at least one of them is not parallel.

Fixes: lp:1841458
* https://bugs.launchpad.net/kicad/+bug/1841458
 2019-09-12 20:10:47 +01:00
Jeff Young b4c8657904 Fix non-visible-part or conversion items from getting selected. 
Also renames lib_draw_item to lib_item to match the class.

Fixes: lp:1840170
* https://bugs.launchpad.net/kicad/+bug/1840170
 2019-08-15 10:00:23 +01:00
Seth Hillbrand 91446c1515 eeschema: Fix list invalidation 
When removing a junction, we need to keep the next pointer for deleted
item, marking them with a flag until committed.

Fixes: lp:1837398
* https://bugs.launchpad.net/kicad/+bug/1837398

(cherry picked from commit 4363e6a213)
 2019-08-05 09:04:47 -07:00
Jeff Young d03041b565 Cleanup. 2019-07-02 21:36:42 +01:00
Seth Hillbrand 0b629b4bd4 eeschema: Limit normalization on load 
When loading a new file, we do not want to add junctions where they did
not exist before.  This could generate invalid netlists by breaking a
wire at a pin connection point.

We do break/add connections when the user modifies the schematic but
this happens while the user is actively working with the component and
sees the action.

Fixes: lp:1830411
* https://bugs.launchpad.net/kicad/+bug/1830411
 2019-05-28 13:29:20 -07:00
Jeff Young 25209516a6 Adjust net highlighting after edits. 
Fixes: lp:1800291
* https://bugs.launchpad.net/kicad/+bug/1800291
 2019-05-12 18:20:41 +01:00
Jeff Young 7995b5cc3c Restore selection on abort and undo/redo. 
Also includes a related bug fix to not create an undo record for
the initial schematic cleanup.

Fixes: lp:1825975
* https://bugs.launchpad.net/kicad/+bug/1825975
 2019-05-11 15:38:49 +01:00
Jeff Young c1539ae014 Naming changes to reflect sharing between SchEdit and LibEdit. 2019-05-10 19:56:20 +01:00
Jeff Young b97d65e791 Fix crash bug when deleting sheet pin and disappearing bug when moving them. 
Fixes: lp:1827890
* https://bugs.launchpad.net/kicad/+bug/1827890
 2019-05-06 16:31:02 +01:00
Jeff Young 6e695aac25 Move bus unfold and symbol unit selection to modern toolkit. 2019-05-05 17:14:30 +01:00
Jeff Young f4b92e6acf Refactor as SCH_DRAWING_TOOL was getting too big. 2019-05-05 17:14:30 +01:00
Jeff Young 902be18a04 More modern toolset context menu work. 
Text/label type changes and bus entry shape changes.  And some
context menu bug fixing.
 2019-05-05 17:12:59 +01:00
Jeff Young eacc3e67a5 Implement repeatDrawItem in modern toolkit and fix bugs. 
Fixes moving of SCH_FIELDS.
Fixes undo operations around SCH_FIELDS and SCH_PINS.
 2019-05-05 17:12:59 +01:00
Jeff Young a461eae8b9 Fix 100s of usages of GetFlags() which conflated != 0 with being edited. 
While this was true long ago, many flags have been added since which
have nothing to do with editing (HIGHLIGHTED, BEGIN_ONPAD, etc.)
 2019-04-22 09:58:06 +01:00
Jeff Young c88fd514a0 Implement drawing tools in modern toolset. 
Fixes: lp:1825192
* https://bugs.launchpad.net/kicad/+bug/1825192
 2019-04-17 21:49:50 +01:00
Seth Hillbrand 3e7969ab8d eeschema: Place bus unfold on the stack 
When activating a bus unfold, the results should be placed with the new
line generation to allow proper undo ordering.
 2019-04-13 07:28:22 -07:00
Seth Hillbrand 3bdd69ad6b eeschema: Fix undo stacking for break wire 
The break wire command is actually two commands: modify the existing
wire and add a new wire.  This means that the command must append to the
previous commit to avoid breaking the undo stack

Fixes: lp:1824251
* https://bugs.launchpad.net/kicad/+bug/1824251
 2019-04-13 07:11:24 -07:00
Seth Hillbrand 822cd9c6ef eeschema: Remove UR_WIRE_IMAGE 
The wire image undo/redo option required special handling and was only
used in a single location.  Replacing with single change handling
reduces the code complexity
 2019-04-13 07:11:24 -07:00
Jon Evans 232b1c799f Add a workaround for bus unfolding without real-time connectivity 
Fixes: lp:1822728
* https://bugs.launchpad.net/kicad/+bug/1822728
 2019-04-11 00:17:22 -04:00
Jon Evans 9589427960 Refactor how at-load schematic normalization is called 
Don't prepend "/" for nets at the top level

Revert "Don't prepend "/" for nets at the top level"

This reverts commit fa9533222f7d33eee5f3fa2320bd9f3167e28076.
 2019-03-31 19:57:00 -04:00
Jon Evans 4bc7e6fdfa Add missing junctions during schematic cleanup 2019-03-31 19:56:54 -04:00
Jon Evans 3c714f1d8c Fix undo handling of SchematicCleanUp 2019-03-31 19:55:57 -04:00
Jon Evans 83c7e7fc65 New connectivity algorithm and bus upgrades 
Bus upgrades: core new connectivity code

Bus upgrades: eeschema integration and modifications

Bus upgrades: eeschema dialogs

Bus upgrades: netlist export

Bus upgrades: file format changes
 2019-03-31 19:53:41 -04:00
Wayne Stambaugh 2447933b54 Eeschema: do not merge graphical lines with different attributes. 
Fixes lp:1821728

https://bugs.launchpad.net/kicad/+bug/1821728
 2019-03-28 13:46:05 -04:00
Jeff Young ae6989f3a1 Don't trim entire wires. 
Fixes: lp:1804297
* https://bugs.launchpad.net/kicad/+bug/1804297
 2018-11-20 21:44:35 +00:00
Jeff Young 4030eec939 Implement proper dangling end handling for block moves. 
(Most of this is actually fixing the IsDanglingStateChanged() to
correctly indicate that it *updates* the dangling state, not just
tests it.)
 2018-10-30 11:33:49 +00:00
Seth Hillbrand a3bbd32953 Fix minor compile warnings 2018-10-25 17:14:04 -07:00
Jeff Young 1f1bdc87bd Update GAL with wire dimensions before changing them. 2018-10-24 23:18:53 +01:00
Jeff Young 1114b5cfa9 Refresh item when its dangling state changes. 
Fixes: lp:1797996
* https://bugs.launchpad.net/kicad/+bug/1797996
 2018-10-16 17:07:59 +01:00
Jeff Young 97c83766db Refresh issues around sheet pins. 2018-10-09 11:08:56 +01:00
Jeff Young ca3751fbbb Add GAL refresh for some more commands and remove unused DC params. 2018-10-09 11:08:56 +01:00
Jeff Young cb8e6c0df5 Handle GAL view refresh for breaking wires. 2018-10-09 11:08:55 +01:00
Tomasz Wlostowski 90c7c60471 eeschema-gal: initial GALified version. Lots of stuff still to do! 2018-10-09 11:08:52 +01:00
Seth Hillbrand d2906f7975 eeschema: fix mistaken wire removal bug 
The wire between two points should not be trimmed if it starts or ends
on one of the component's connection points.
 2018-10-08 08:42:06 -07:00
Seth Hillbrand 618374db88 eeschema: Re-add auto-wire removal 
Somewhere during v5 rc cycle, the trimming of wires laid over simple
components was removed.  The wires were still removed as soon as the
user moved the component again.  This corrects the first behavior to
intended action for simple components.

Fixes: lp:1794019
* https://bugs.launchpad.net/kicad/+bug/1794019

(cherry picked from commit 9831a14ef3)
 2018-09-24 08:31:50 -07:00
Ronnie Gaensli 00d912f0b8 eeschema: fix dangling pin marker after adding NoConnect 
Fixes: lp:1787858
* https://bugs.launchpad.net/kicad/+bug/1787858
 2018-08-19 19:48:22 -07:00
Jeff Young 108dc20fba Keep first segment of wire attached to sheet pin horizontal. 
If allowed to go vertical it's very hard to see on top of the
sheet boundary and liable to short out other pins.

Fixes: lp:1685508
* https://bugs.launchpad.net/kicad/+bug/1685508
 2018-05-11 21:50:43 +01:00
Seth Hillbrand fddd5abef1 Merges a line after manually removing its junction. 
Fixes: lp:1746998
* https://bugs.launchpad.net/kicad/+bug/1746998
 2018-02-03 10:50:10 +01:00
jean-pierre charras 8022f1cc01 fix code after renamin files 2018-01-30 11:49:51 +01:00