584eb9f531
Remove extra nag/grid assertion
...
When editing the properties, if you accidentally make an extra line, you
should be able to remove the data and have it ignored.
2023-09-13 12:31:46 -07:00
3cd6935acb
Work around wxGTK printing offset in eeschema.
...
Affects landscape Letter, Legal, A4 paper.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/1907
(cherry picked from commit 5da4dfd4a7
2023-09-11 14:37:39 +03:00
30c2028852
Revert "Set reporter in DIALOG_SIM_MODEL::TransferDataToWindow."
...
This reverts commit 5b0d752e0c
2023-09-06 08:03:00 +03:00
95e6be0e81
Prevent crash trying to load missing spice lib
...
(cherry picked from commit 4fe7c7a902
2023-09-06 01:13:54 +00:00
c8e49599ce
Use STD_BITMAP_BUTTON for change symbols dialog.
...
(cherry picked from commit f3f57f77d9
2023-09-02 11:18:34 +01:00
351cb7e104
Re-run autoplacement after symbol replacement (when appropriate).
...
Also prevents an internal wxWidgets assert by clearing grid
selection before deleting rows.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15541
(cherry picked from commit 377ffb00b0
2023-09-02 11:18:34 +01:00
9bcb6f0adf
Don't count pins of both De Morgan variants when matching to footprint pads.
...
(And remove un unused variable from grid settings dialog.)
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15550
(cherry picked from commit cb003d8ab4
2023-08-31 12:37:44 +01:00
f9b59b4fdf
PANEL_SETUP_SEVERITIES: fix a missing init (m_severitiesPage) creating a crash.
...
PANEL_SETUP_SEVERITIES::ImportSettingsFrom(): ensure the option to set
actually exists before setting it.
2023-08-29 10:56:40 +02:00
aae7d94ffd
Remove duplicate references from change symbol dialog.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15480
(cherry picked from commit 1db9febcfe
2023-08-25 14:28:13 -04:00
5b0d752e0c
Set reporter in DIALOG_SIM_MODEL::TransferDataToWindow.
...
It could've been set to point to local variable "reporter" in loadLibrary.
Fixes KICAD-15C
(cherry picked from commit 26f398a4b1
2023-08-25 21:09:28 +03:00
7d389f8024
Don't try to be smart about enabling the Clear Annotation button.
...
(At a minimum it would need to also handle when the scope changes, but
it's not clear we're adding anything by enabling/disabling it to start
with.)
(cherry picked from commit 2278f5dbca
2023-08-19 20:09:47 +01:00
af1561b848
Don't double-offset effective text shapes.
...
Also fixes several bugs with intersheet ref fields. (It's possible for
other fields to have an ID of 0.)
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15165
(cherry picked from commit eedf319ba4
2023-08-19 20:09:47 +01:00
dba36c07fe
Only re-build the members grid when we have to.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15320
(cherry picked from commit d3329a0781
2023-08-15 17:26:14 +01:00
88dfe6eb9c
Stricter API for LIB_TABLE
...
Prevent nickname map or row parent getting out of sync
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15315
(cherry picked from commit 4c4bbdc8f3
2023-08-15 01:39:09 +00:00
8625a59d4c
Fix a display issue in wxStyledTextCtrl widgets in dialogs (Windows specific).
...
It happens when a text is using some esoteric unicode chars.
Fixes #15314
https://gitlab.com/kicad/code/kicad/-/issues/15314
2023-08-03 18:44:57 +02:00
228fe71eb4
Do not force focus on dataview in RC dialogs
...
On GTK, this causes the first item to be selected, firing the
selection handler and causing unwanted side effects.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/11925
(cherry picked from commit 7804c2177c
2023-08-03 13:06:37 +00:00
e5df16ba2b
Pass proper parent to symbol viewer frame when changing symbols
...
Fixes sentry KICAD-1Z9
Fixes sentry KICAD-22J
(Cherry-picked from 1f5719ef3a
2023-08-02 23:29:04 +01:00
2fa05ed245
Sort the bus alias set by name
...
If we place pointers in a set, they are sorted by the pointer value in
memory, not the data, so we need a custom comparator
Fixes https://gitlab.com/kicad/code/kicad/-/issues/11890
(cherry picked from commit f7f67c6d53
2023-07-21 09:04:46 -07:00
cc2637b310
Symbol editor, DIALOG_FIELD_PROPERTIES: fix missing initialization of font.
...
In Symbol editor, trying to change the font of a field did nothing.
From master branch
2023-07-18 19:41:56 +02:00
e1c6f4f58f
Repair new switch-based Global Update Text & Graphics.
...
We were forgetting to handle wire and bus labels.
2023-07-16 20:24:20 +01:00
0562776b7a
Fix logic errors in DIALOG_GLOBAL_EDIT_TEXT_AND_GRAPHICS::visitItem().
...
(We can't exit out if it doesn't match a particular type as we haven't
checked the other types yet. Use a switch to prevent this.)
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15206
(cherry picked from commit a16033f624
2023-07-16 20:04:43 +01:00
7078381175
Eeschema printing: fix bg fill when paper orientation or size differs.
...
(cherry picked from commit 86458ae582
2023-07-09 05:46:11 +05:00
e7ae6cd190
Recompute intersheet refs while printing.
...
Also fixes a bug where the schematic offset wasn't being added to
intersheet refs when printing.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/14978
(cherry picked from commit e3eb0abc5f
2023-06-17 18:12:44 +01:00
a5ded3341a
Adapt panels to PAGED_DIALOG sizing algorithm.
...
Also some cosmetic fixes (GTK).
(cherry picked from commit d3be62f644
2023-06-17 15:19:26 +03:00
c61931996a
PAGED_DIALOG: allow setting initial size in ctor.
...
(cherry picked from commit f5da58e17d
2023-06-17 15:19:26 +03:00
bfcdec47c1
Move bitmap setup to ctor in eeschema annotation options.
...
(cherry picked from commit 26c25c5475
2023-06-17 15:19:25 +03:00
bc0a53a226
Increased mutex safety.
...
Don't even query the size() without having at least a shared_lock.
*May* prevent KICAD-4S, but seems unlikely.
(cherry picked from commit f3d3ade1dc
2023-06-10 10:57:14 +01:00
c3a6bf3d40
UI: Add Numpad Enter as "Return" equivalent in missing places
...
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/14244
2023-06-05 08:58:50 -04:00
441c2b50b9
Fix potential stale pointer bug in schematic highlight connection code.
...
SCH_CONNECTION objects are temporary and can become stale any time the
connectivity is updated. Keeping them around to reference later is a
bad idea. Even if the object pointer is still valid in an SCH_ITEM in
the undo/redo buffers, comparing the pointer against another pointer as
a test to see if they are the same connection is not valid. Saving the
connection name is safe and ensures the connection is the same even if
the pointers differ.
(cherry picked from commit 831a6d55fc
2023-05-29 13:55:07 -04:00
aa78abc649
Manual reimplementation of 84c72b087c
...
(cherry picked from commit 7cc55d2d3a
2023-05-28 19:38:27 +02:00
8b114c81c5
Fix issue with colours in the new lazy-loaded preference panels.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/14784
Fixes https://gitlab.com/kicad/code/kicad/-/issues/14782
(cherry picked from commit d4c9d9d60ac33b3fd314
2023-05-28 19:38:27 +02:00
19b4e98ee7
Lazy loading of Schematic Setup panels.
...
(cherry picked from commit ddc6ecf7be6cbc10db81
2023-05-28 19:38:27 +02:00
77c76bbc8a
Insta-prefs.
...
(cherry picked from commit 9ae82552024c28070449
2023-05-28 19:38:27 +02:00
7e39411910
Revert "Insta-prefs."
...
This reverts commit 4c28070449
2023-05-24 08:54:16 -07:00
2f3659e7ac
Revert "Lazy loading of Schematic Setup panels."
...
This reverts commit 6cbc10db81
2023-05-24 08:54:16 -07:00
e967020ebe
Revert "Fix issue with colours in the new lazy-loaded preference panels."
...
This reverts commit c33b3fd314
2023-05-24 08:54:16 -07:00
e2c0c6362f
Revert "Manual reimplementation of 84c72b087c548829908d7fbbecfd2fa5968cc98b"
...
This reverts commit 7cc55d2d3a
2023-05-24 08:54:16 -07:00
7cc55d2d3a
Manual reimplementation of 84c72b087c
2023-05-23 09:40:32 +01:00
c33b3fd314
Fix issue with colours in the new lazy-loaded preference panels.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/14784
Fixes https://gitlab.com/kicad/code/kicad/-/issues/14782
(cherry picked from commit d4c9d9d60a
2023-05-23 09:40:32 +01:00
6cbc10db81
Lazy loading of Schematic Setup panels.
...
(cherry picked from commit ddc6ecf7be
2023-05-23 09:40:32 +01:00
4c28070449
Insta-prefs.
...
(cherry picked from commit 9ae8255202
2023-05-23 09:40:32 +01:00
d805f5ceff
De Morgan conversions are equivalences, not additional items to simulate.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/14230
(cherry picked from commit fdcc97e604
2023-05-09 18:12:02 +01:00
e28b50e8d6
Fix a bunch more issues with sheetpaths and allowExtraText.
...
A sheetpath is required to correctly resolve text variables.
Depending on currentSheet is rife with bugs.
There are many places where we do *not* want to be prepending
field names to the field values, such as netlisting,
building PDF hypertext menus, etc.
Also, Find/Replace needs to work on unresolved text, as
that's what we're going to display (and if replace nuked
your variable references you wouldn't be happy).
(cherry picked from commit b41d446f58
2023-05-05 18:02:59 +01:00
f4fa5bb0fc
Don't store resolved values in symbol fields table editor dataStore.
...
We're going to use the dataStore to update the symbol, so
if we store resolved values it will nuke any text variables
even if the field wasn't edited.
Not sure if the BOM generator has a separate resolve-variables
step or not. But it will need one as the code removed here
only worked for Values and Footprint fields anyway.
2023-05-04 00:08:18 +01:00
cd9196ddb9
Use fileds from flattened lib symbol when updating.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/14577
(cherry picked from commit d816fb071f
2023-04-26 13:04:05 +01:00
050f47daf1
Bug Fixes for new incremental connectivity
...
- Ensure that critical paths (ERC/netlister) are fully-rechecked
- Handle symbol/pin distinction in change markers
- Fully connect hierarchical pins in one pass descending
(cherry picked from commit 6e8a5acc66
2023-04-25 11:32:59 -07:00
683abd2029
Add ability to update subgraphs based on changeset
...
Previously, almost all connectivity updates were full updates, meaning
that the entire connectivity graph would be rebuilt each time a change
was made to the schematic. This update modifies the update to only
correct the subgraphs that are directly affected by the change.
It uses the existing connection graph to find all affected subgraphs as
well as connections to the changes based on the visible schematic.
These elements are removed from the existing connectivity graph and
marked dirty. They then have a new connectivity graph built only around
their changes. The resulting graph is merged into the original.
Currently, this ability is behind an advanced config flag
`IncrementalConnectivity` while testing.
Fixes https://gitlab.com/kicad/code/kicad/issues/10846
Fixes https://gitlab.com/kicad/code/kicad/issues/1794
(cherry picked from commit a154571438
2023-04-25 11:32:04 -07:00
4f9e754a51
Ignore empty field-name-templates.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/14552
2023-04-18 13:46:08 +01:00
5574f35473
Apply symbol attributes from base symbol, not derived symbol.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/13740
(cherry picked from commit d4b4abd001
2023-04-15 22:31:49 +01:00
a51475a094
Performance improvement for GetShownColumns.
...
(This needs to be fast as it's called from OnUpdateUI events.)
(cherry picked from commit 8e29a054f3
2023-04-13 13:47:21 +01:00
Seth Hillbrand
Alex Shvartzkop
Marek Roszko
Jeff Young
jean-pierre charras
Wayne Stambaugh
Jon Evans
Ian McInerney
Mike Williams