Seth Hillbrand
f5793c5984
Adding default clang-tidy parameters
2019-12-05 19:48:50 -08:00
Seth Hillbrand
6983c56cf8
Use const references where possible
...
This avoids copy cost on local vars where we only read.
2019-12-05 14:40:22 -08:00
Seth Hillbrand
c6f5df134c
Minor speed cleanup
...
This adjusts iterators to use const reference when only used for
copy. It also ensures pre-allocation of vectors when size is known
ahead of time.
2019-12-05 14:20:59 -08:00
Seth Hillbrand
b5f021ff9f
Cleanup: Replace push_back with emplace_back
...
In cases where we create a new item and immediately push into a
container, the emplace idiom is faster and more efficient.
2019-12-05 13:41:21 -08:00
Seth Hillbrand
6f8b399c5f
Replace unused resize() call
...
Calling resize(size()) will only zero out elements that exist above the
vector size(). The memory is not freed in this case. shrink_to_fit()
will accomplish this action (at the discretion of the library)
2019-12-05 13:21:48 -08:00
Seth Hillbrand
4d2e953f42
Cleanup: Replace C-only deprecated headers
...
This replaces headers deprecated by C++14 with their equivalent
replacement
2019-12-05 11:03:15 -08:00
Seth Hillbrand
a2edf9c442
Unified update to C++14 std::make_unique
...
This update replaces the existing uses of unique pointer creation with
the C++14 std::make_unique call that provides proper memory release in
event of an exception.
2019-12-05 10:43:55 -08:00
John Beard
4dc82ff76f
Technical TODO: make_unique is no longer polyfilled
...
Since we use C++14, std::make_unique required no "polyfill".
The KiCad polyfill was removed in
5151cd0bfe
,
so remove the TODO item.
2019-12-05 18:25:15 +01:00
John Beard
1b124832fe
QA: Remove deprecated boost headers
...
The test_case_template.hpp header is deprecated in Boost, and the
latest Boost version is now throwing warnings during the build.
In Boost 1.59 (at least), this header is included transitively by the main
Boost test header, so this header is not needed by any supported Boost
version.
2019-12-05 18:19:40 +01:00
Eeli Kaikkonen
f1ef036400
Removed old and outdated TODO.txt.
2019-12-05 10:00:13 +00:00
Seth Hillbrand
65ef8c1894
StrokeFont: Reserve rather than resize
...
Minor speedup by not double-initializing the stroke font vector.
2019-12-04 16:36:06 -08:00
Ian McInerney
4ebb591a5c
Allow the formatting test to fail
...
By allowing to to fail, we won't block the rest
of the CI tests, and also won't block the merge.
2019-12-04 20:10:23 +00:00
jean-pierre charras
4a75cc586c
Zone filler: do not create stubs in thermal reliefs when not possible.
...
pad size is sometimes smaller than the zone minimal width.
So, to avoid strange and incorrect results, do not create the stubs in
thermal relief when the pad size is smaller than the zone minimal width.
2019-12-04 13:23:09 +01:00
Ian McInerney
f0c386f5dd
Update GitLab CI script
...
Changes SHA detection to find the start of the MR and makes check_coding return non-zero when formatting changes needed
2019-12-03 18:51:59 +00:00
Jeff Young
581dc81358
Performance optimizations for the stroke font.
2019-12-03 17:45:26 +00:00
Ian McInerney
edf23dc5a9
Fix GitLab CI format hook
...
The variable CI_COMMIT_BEFORE_SHA is not available in
normal merge requests
2019-12-03 15:28:30 +00:00
Ian McInerney
7433d252bb
Merge branch 'eelik-master-patch-06344' into 'master'
...
Changed .wings to .step (the former isn't supported anymore, STEP is the official format)
See merge request kicad/code/kicad!2
2019-12-03 12:07:07 +00:00
Eeli Kaikkonen
4739f33ca2
Changed .wings to .step (the former isn't supported anymore, STEP is the official format)
2019-12-03 12:07:07 +00:00
Jeff Young
089ce90de3
Fix some issues with the previous commit.
2019-12-02 23:35:19 +00:00
Jeff Young
9b36489270
Make sure that libraries are always sorted consistently.
...
Fixes #1847481 | https://gitlab.com/kicad/code/kicad/issues/1847481
2019-12-02 21:52:50 +00:00
Jeff Young
d4816d843d
Check /all/ libraries when toggling the Save All toolbar button.
2019-12-02 20:48:22 +00:00
Wayne Stambaugh
ea62b19b58
Merge branch 'update-compiling-md' into 'master'
...
Update compiling.md for GitLab
See merge request kicad/code/kicad!1
2019-12-02 20:20:05 +00:00
Jon Evans
95f703aac0
Update compiling.md for GitLab
2019-12-02 20:20:05 +00:00
Jeff Young
a9da0c6ecf
Update local coords when editing EDGE_MODULEs.
...
Fixes: lp:1853726
* https://bugs.launchpad.net/kicad/+bug/1853726
2019-12-02 20:01:44 +00:00
Jeff Young
3af3bf894c
Make sure the IS_MOVED flag gets set when breaking out of a bus.
...
This (among other things) causes an update-preview event to be sent
when modifying it (such as rotating).
Fixes: lp:1854456
* https://bugs.launchpad.net/kicad/+bug/1854456
2019-12-02 20:01:44 +00:00
jean-pierre charras
5cd7f3fdee
DIALOG_DRC_CONTROL: fix a crash on wxWidgets 3.1.3, Windows,
...
Happens when right clicking on an item in displayed lists.
The crash was due to a bug in wxWidgets, and the fix is only a workaround
Also remove duplicate code.
2019-12-02 11:27:40 +01:00
Maciej Suminski
2a3d4ffe88
Update 'git fixes' alias and the documentation to point to Gitlab
2019-12-01 11:01:56 +01:00
Ian McInerney
07c6cfdc38
Add Ian to AUTHORS.txt
2019-11-30 19:52:32 +00:00
jean-pierre charras
4bf7ca49b8
Commit test
2019-11-30 20:21:17 +01:00
Jon Evans
0857a1f5dc
Update contributors link to GitLab
2019-11-30 09:59:09 -05:00
Seth Hillbrand
d20d310fcc
Fix compile error on Linux
...
The wxArrayString doesn't have a standard assignment operator to
std::vector<wxString> so we iterate over the members.
Fixes: lp:1854562
* https://bugs.launchpad.net/kicad/+bug/1854562
2019-11-30 05:24:35 -08:00
Seth Hillbrand
2ce7d9a708
Adding merge CI
...
Adds GitLab merge CI for code formatting.
2019-11-29 21:55:36 -08:00
Jon Evans
d5140d87cd
Fix indentation in previous commit
2019-11-29 21:22:56 -05:00
Jon Evans
8b87dc7e0f
A slightly better ERC check for hierarchical labels
...
Fixes: lp:1839822
* https://bugs.launchpad.net/kicad/+bug/1839822
2019-11-29 21:11:44 -05:00
Jon Evans
972d765aea
Use direct call to update highlighting on new sheet load
2019-11-29 21:11:44 -05:00
Jon Evans
719a70b510
Update FindwxWidgets.cmake to work under MSW/vcpkg
...
Taken from: https://github.com/CaeruleusAqua/vcpkg-wx-find/blob/master/FindwxWidgets.cmake
2019-11-29 21:11:44 -05:00
Jon Evans
78add8f4bd
Mark ERC compare operators as const
...
Not including these is a compile error on MSW/VC
2019-11-29 21:11:44 -05:00
Jon Evans
f23e151b90
Use wxArrayString instead of vector<wxString> in BUS_ALIAS
...
Fixes linker errors on Windows/VC
See: https://trac.wxwidgets.org/ticket/10884
2019-11-29 21:11:44 -05:00
Jeff Young
342c8941b5
More cleanup of dialog_find-base.fbp
2019-11-30 01:00:16 +00:00
Jeff Young
1e4437c6df
Some cleanup for the Pcbnew search changes.
2019-11-29 21:38:18 +00:00
Fabien Corona
7297822423
pcbnew: search options
...
-Users can now search DRC markers with string filtering
-GUI changes for consistency with Eeschema
Fixes: lp:1845460
* https://bugs.launchpad.net/kicad/+bug/1845460
2019-11-29 17:58:05 +00:00
Fabien Corona
5d3e6e3d44
pcbnew: search options
...
-Add a "wrap" option->Search results implemented as a nested list.
-Allow to go back with a "Find previous" button
-Remove the marker search option
-Fix a DLIST issue
-Add a result counter ("eg: hit(s): 1/3")
-Search history limited to 10
-Fix the search history order
-User can include or exclude references/values/texts from results
Fixes: lp:1845460
* https://bugs.launchpad.net/kicad/+bug/1845460
2019-11-29 17:55:01 +00:00
Jeff Young
102b530162
Fix library tree updating bug present at least on OSX.
2019-11-29 17:55:01 +00:00
Seth Hillbrand
ffcf3b01fc
Fixup issue with adding junctions
...
Segfault when we pass a component to the routine as it expects to see a
selection.
2019-11-27 11:13:01 -08:00
Ian McInerney
9f9b48739c
pcbnew: Adjust dimension display after updating units
...
Fixes: lp:1854167
* https://bugs.launchpad.net/kicad/+bug/1854167
2019-11-27 16:39:13 +00:00
Jonatan Liljedahl
e517069a51
Eeschema: Add options for selection appearance
...
ADDED: Three new options that affects selection appearance:
- Draw selected text items as box
- Draw selected child items
- Fill selected shapes
2019-11-26 19:57:11 -08:00
Franck Jullien
a5f8340654
eechema: add junction if needed when component is placed
...
Fixes: lp:1849376
* https://bugs.launchpad.net/kicad/+bug/1849376
2019-11-26 19:23:02 -08:00
Simon Richter
ac09c9c9d4
Enable full CTest framework
...
This allows asking CTest for running the test suite under valgrind
2019-11-26 17:40:34 -05:00
jean-pierre charras
c186e7d391
Cosmetic and usability enhancements.
...
- Better menu texts
- do not show pad edit options in board editor,
when they are used only in the footprint editor.
2019-11-26 19:53:00 +01:00
Seth Hillbrand
a643bdff4b
Remove ergonomic statement
2019-11-26 09:44:47 -08:00