f2a902c0b1
Remove extraneous drag actions.
2020-08-18 19:05:30 +01:00
1711b489b6
Dark-mode proof the undefined colour swatch.
2020-08-18 19:05:30 +01:00
1cce03acb1
Commenting and formatting.
2020-08-18 19:05:30 +01:00
e2bdd34d82
Fix overzealous delete from previous commit.
2020-08-18 13:34:48 -04:00
ede39780e2
Remove all debugging output that cannot be disabled.
...
The use of printf, wxLogDebug, and std::err/std::out causes excessive
debugging output which makes finding specific debugging messages more
difficult than it needs to be.
There is still some debugging output in test code that really needs to
be moved into a unit test.
Add debugging output section to the coding policy regarding debugging
output.
2020-08-18 10:17:36 -04:00
4cc820f550
PNS: skip hulls for layers where the solid isn't
...
If we don't have an object on the required layer and there isn't a
through-hole (m_alternateShape), then we shouldn't return a hull
Fixes https://gitlab.com/kicad/code/kicad/issues/5233
2020-08-18 06:53:03 -07:00
294de666a4
Don't update msgpanel while dragging zone points
2020-08-18 13:11:47 +00:00
d2086eecdd
Don't update panel while drawing a dimension
2020-08-18 13:11:47 +00:00
73b2a10cab
Don't try updating msgpanel while segments.
2020-08-18 13:11:47 +00:00
a417da4ce0
Split selecteditemmodified to a selecteditemmoved to reduce updatemsgpanel spam
2020-08-18 13:11:47 +00:00
3696064f6f
Don't post update events twice and on motion for movement of items
...
Fix #4880
Fix #4741 (hopefully)
2020-08-18 13:11:47 +00:00
a0956fbf97
text tool: msgpanel on motion is the same as msgpanel on not moved text....
2020-08-18 13:11:47 +00:00
96f4e8f6f8
Remember the last active tab on the appearance panel
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/5216
2020-08-17 22:06:31 -04:00
ab7c96f672
Pass focus back to canvas from appearance panel
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/5225
2020-08-17 21:57:49 -04:00
3c66f932bf
Synchronize flip board checkbox
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/5224
2020-08-17 21:48:11 -04:00
88d76eaf62
Enforce Apple's destructive button distance guideline.
...
Also fixes a few errant icon buttons that were still setting a fixed
size.
2020-08-17 23:55:31 +01:00
e6a0732e64
Minor cosmetic issues.
2020-08-17 23:55:31 +01:00
66ff16dd3d
Better board-edge error reporting.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/4950
2020-08-17 23:55:31 +01:00
01eb8ad032
Better handling of excluded layers for Color Preferences.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/5184
2020-08-17 23:55:31 +01:00
8234e70e77
Remove unused footprint text front & back colours.
2020-08-17 23:55:31 +01:00
e825a99b9a
Consolidate some UI conditions from context menu enabling
...
These conditions are for enabling/disabling a control,
so place them inside the new UI conditions framework instead
of the separate update routine.
2020-08-17 23:21:25 +01:00
aceed2b0a4
Cleaner look for colour swatches and the undefined colour.
2020-08-17 18:31:20 +01:00
5c3a1d059e
Fix memory mgmt issue with SOLID shapes
...
We don't delete items from the CTOR but we do need to check if they
exist in the incoming SOLID before cloning
Fixes https://gitlab.com/kicad/code/kicad/issues/5214
2020-08-17 06:16:11 -07:00
cff76e55d5
Only update the layer icon bitmap when it has actually changed
...
This was causing unnecessary calls to refresh the toolbar, causing
flickering in the layer widget.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/5212
2020-08-17 12:37:25 +01:00
5b365053db
Fix a few I18n issues.
...
Especially, only ASCII7 chars can be used in messages.
Do not mark debug messages as I18n strings
2020-08-17 09:18:49 +02:00
b06e605255
Remove duplicate code in Eagle PCB plugin
2020-08-17 03:02:44 +00:00
595ea70b0f
Don't rebuild on page change in MSW
...
This bug appears to not happen on MSW, so we can avoid the refresh
Fixes https://gitlab.com/kicad/code/kicad/-/issues/5210
2020-08-16 18:42:50 -04:00
fd53df6f10
Collapse space out of the presets area.
...
Hopefully this will save us from conditional compilation as the
OSX spacing here is wildly different from GTK.
2020-08-16 22:22:47 +01:00
1134d99bb7
Repair some more merge conflicts.
2020-08-16 22:22:47 +01:00
0debaa5866
Update selection ratsnest should do slow updates sometimes
...
When rotating/mirroring/etc, the selection ratsnest should be
recalculated to keep the lines correctly connected for the fast tree
move.
Fixes https://gitlab.com/kicad/code/kicad/issues/5194
2020-08-16 13:31:50 -07:00
126565cbed
Fix visibility control for Default netclass
2020-08-16 15:43:14 -04:00
afc94fdec3
PNS: Be better about handling multiple layers
...
Rather than adding pads/vias multiple times for each layer, we introduce
the "alternate shape" idiom to PNS that allows us to optionally place
the collision constraint on the hole instead of the pad for those
vias/pads that have inner layers removed.
Fixes https://gitlab.com/kicad/code/kicad/issues/5158
Fixes https://gitlab.com/kicad/code/kicad/issues/5198
Fixes https://gitlab.com/kicad/code/kicad/issues/5195
2020-08-16 12:39:15 -07:00
4491f24d5e
Ripout the old SyncToolbars infrastructure reminants
...
The tool framework no longer needs to request updates of the UI
state for the controls, wxWidgets will do it for us.
2020-08-16 19:10:26 +00:00
75cdf9df4e
Don't say the board must be empty to be modified
...
It is possible to empty a full board and have modifications that
should be saved.
Fixes https://gitlab.com/kicad/code/kicad/issues/3739
2020-08-16 19:10:26 +00:00
e8b11c911e
Migrate Pcbnew/footprint viewer/footprint editor to the new UI update system
2020-08-16 19:10:26 +00:00
d19ff3e595
Unify the UI IDs for actions between the menus and toolbars
...
By unifying the IDs so that an action only has one UI ID,
it will receive only one update event that will work for
all controls using the action.
2020-08-16 19:10:24 +00:00
15edac4738
Implement a more flexible layout for the objects tab of appearances.
2020-08-16 19:51:26 +01:00
54682d39ff
Remember width of right AUI panel in PcbNew
2020-08-16 14:33:40 -04:00
92174d414c
Ensure pads and zones come up visible by default
...
These visibility layers didn't exist until now
2020-08-16 10:17:20 -04:00
6bfb32245b
Show the Default netclass in the appearance panel
2020-08-16 09:57:21 -04:00
7da5419a2c
Reduce flicker on layout change in MSW
2020-08-16 09:38:12 -04:00
1f5a3c57a0
Fix net color radio buttons
2020-08-16 09:32:03 -04:00
453976be5e
Add cleanup to the new appearance widget
...
It really should be cleaning up the heap-allocated objects
it owns.
2020-08-16 12:37:51 +01:00
25f2a13157
Fix pcbnew/fpedit editing options panel
...
The panel was incorrectly saving the preferences for the footprint
editor.
2020-08-16 12:37:50 +01:00
ade7f529b8
Switch shared_ptr creation to using make_shared
2020-08-16 12:37:50 +01:00
198d9a4243
Fix merge conflicts.
2020-08-16 12:26:15 +01:00
92322667d6
Fix asserts on later wxWidgets versions.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/5197
2020-08-16 11:49:36 +01:00
e5f2015a9c
More spacing adjustments for appearance manager.
2020-08-16 01:55:09 +01:00
5938528a16
Move to conditional compilation for appearance palette spacing.
2020-08-16 00:43:19 +01:00
103443f496
Back out some spacing changes for MacOS
...
These were too aggressive on other platforms
2020-08-15 19:20:49 -04:00
Jeff Young
Wayne Stambaugh
Seth Hillbrand
Marek Roszko
Jon Evans
Ian McInerney
jean-pierre charras
Michael Kavanagh