kicad

Commit Graph

Author	SHA1	Message	Date
John Beard	a045642b7e	Sexpr: Do not leak memory on parse exception Use std::unique_ptr to guard against leaking the new'd pointers in SEXPR lists if there is an exception during parse. This was noticable during the Sexpr/ParseExceptions unit test. Fixes: lp:1830209 * https://bugs.launchpad.net/kicad/+bug/1830209	2019-05-23 13:52:39 +01:00
John Beard	f7d35cf94b	Sexpr: needs to be a STATIC lib Fedora COPR builds with -DBUILD_SHARED_LIBS:BOOL=ON, which means this breaks until the sexpr lib target is explicitly STATIC	2019-04-24 17:31:22 +01:00
John Beard	03214b5dea	Sexpr/QA: Split out the sexpr classes into a reusable lib and test The SEXPR class is a useful general-purpose S-Expression library class and can (maybe) be used else where. It also should get test coverage, as even if noone else uses it, it's critical for the kicad2step exporter. Also add some test coverage for some kicad2step routines. For now, they're not useful outside kicad2step, but they are at least a useful reference for S-Expression parsing.	2019-04-17 10:52:56 +01:00

Author

SHA1

Message

Date

John Beard

a045642b7e

Sexpr: Do not leak memory on parse exception

Use std::unique_ptr to guard against leaking the new'd pointers
in SEXPR lists if there is an exception during parse.

This was noticable during the Sexpr/ParseExceptions unit test.

Fixes: lp:1830209
* https://bugs.launchpad.net/kicad/+bug/1830209

2019-05-23 13:52:39 +01:00

John Beard

f7d35cf94b

Sexpr: needs to be a STATIC lib

Fedora COPR builds with -DBUILD_SHARED_LIBS:BOOL=ON, which
means this breaks until the sexpr lib target is explicitly
STATIC

2019-04-24 17:31:22 +01:00

John Beard

03214b5dea

Sexpr/QA: Split out the sexpr classes into a reusable lib and test

The SEXPR class is a useful general-purpose S-Expression library
class and can (maybe) be used else where. It also should get
test coverage, as even if noone else uses it, it's critical for the
kicad2step exporter.

Also add some test coverage for some kicad2step routines. For now,
they're not useful outside kicad2step, but they are at least a useful
reference for S-Expression parsing.

2019-04-17 10:52:56 +01:00

3 Commits