cc058a7927
Exit pad edit mode before closing footprint editor.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16766
2024-01-26 13:49:17 +00:00
f4e123f57e
!m_isBoardEditor != m_isFootprintEditor.
...
(There's also python, cli, etc.)
2024-01-26 12:47:01 +00:00
e99f758447
Revert b8a2b3b2bf.
2024-01-26 12:33:21 +00:00
991703ceee
Add missing default init
2024-01-26 07:23:28 -05:00
12357cfba6
symbol checker: do not forget to display error messages about pins not on grid.
...
Fixes #16759
https://gitlab.com/kicad/code/kicad/-/issues/16759
2024-01-26 10:19:58 +01:00
74e02d7701
Eeschema, open CvPcb: ensure the netlist sent to CvPcb is up to date.
...
Fixes #16762
https://gitlab.com/kicad/code/kicad/-/issues/16762
2024-01-26 09:24:38 +01:00
7f5433f0f2
Realize why we sch parity wasnt included in cli drc
...
Need to add schematic loading...to the pcbnew jobs handler
2024-01-25 22:19:52 -05:00
465ccaef90
Add missing schematic parity drc test to cli
2024-01-25 22:14:49 -05:00
a282762686
Fix pcb drc in cli due to awkward !m_isBoardEditor logic with more awkward logic
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16744
2024-01-25 22:09:29 -05:00
ec82a1b4e2
Fix duplicate pin check string
...
MessageTextFromValue returns text not floating point
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16758
2024-01-25 18:02:05 -08:00
c2989132ac
DeselectRow as we delete rows to avoid asserts
2024-01-25 20:37:00 -05:00
5d44e090dc
Fix shadowed var
2024-01-25 19:55:02 -05:00
bba0a8d038
Protect schematic undo list actions
...
The undo/redo lists can have non-SCH_ITEM elements such as worksheet
items. When re-doing connectivity, we only need the schematic items, so
we pass on these
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16752
2024-01-25 16:47:14 -08:00
b8a2b3b2bf
Take a stab at fixing #16752 .
2024-01-25 23:46:35 +00:00
4d6bbc8caa
Fix symbol annotation when pasting nested hierarchical sheets.
2024-01-25 16:39:21 -05:00
9e9dfb38d1
IPC2581: Correct flipped pad handling
...
Board footprints have pads already flipped, so we don't need to adjust
layers when outputting
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16659
2024-01-25 13:06:59 -08:00
6a69396070
Allow column auto-sizing in RC trees.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16727
2024-01-25 20:51:54 +03:00
2e760483b0
HIERARCHY_PANE: Update tree labels when editing a sheet name or number
...
Fixes #16650
https://gitlab.com/kicad/code/kicad/-/issues/16650
2024-01-25 18:22:41 +01:00
a2b204572d
Don't assert when a sim returns no results.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16749
2024-01-25 15:40:12 +00:00
70bca8bc4e
Provide popups for inductor references.
...
Also fixes a long-standing bug deleting the last field of
a symbol in the Symbol Editor.
2024-01-25 15:30:25 +00:00
340d1b7fad
Guard against nullptr access.
2024-01-25 15:30:25 +00:00
b3f94ad46a
Cleanup before exit.
...
Possibly KICAD-5TE.
2024-01-25 15:30:25 +00:00
d3bc59e0e7
SelectBlock() will assert for invalid selection modes.
...
KICAD-63D.
2024-01-25 15:30:25 +00:00
a377fa4201
Add some missing deep comparisions for BOARD_STACKUP
2024-01-25 09:08:27 -05:00
fec57459f3
Use correct arg types in altium arc import error message
...
Fixes KICAD-6Q1
2024-01-25 07:50:13 -05:00
bfbf000f60
Add some safety around event-driven menubar recreation
...
Maybe addresses sentry KICAD-PC
2024-01-24 23:30:34 -05:00
3ef16221fe
Make sure default board thickness exists
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16733
2024-01-24 23:09:56 -05:00
c816280c6d
Move the current selection before deleting the row to avoid asserts
...
Fixes sentry KICAD-63D
2024-01-24 22:57:36 -05:00
5321c1c481
Create the import directory if it doesn't exist
...
Fixes sentry KICAD-6BC
2024-01-24 20:35:03 -05:00
b8bbbcf410
Fix assert in SYMBOL_VIEWER_FRAME::onSelectNextSymbol due to bad current selection check
...
Fixes sentry KICAD-6KE
2024-01-24 20:15:23 -05:00
8f57a9bcf0
Fix spacemouse version check by pawning it off on wxWidgets
...
Version is a value not a key name. Also the registry returns things in wchars soooo lets just pawn off the encoding mess on wxWidgets
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16730
2024-01-24 19:04:50 -05:00
5d7eac7677
Allow for empty LIB_PART in certain symbol functions
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16731
2024-01-24 12:18:10 -05:00
13f8fd77ac
wx 3.3 compatibility.
2024-01-24 19:58:12 +03:00
b8b4ea1a45
Comments.
2024-01-24 16:24:19 +00:00
d04b21c6d6
Ensure parameter typeinfo matches the actual object's typeinfo
...
AppleClang seems to generate different typeinfo for forward declarations
of classes than the actual class object, so the any_cast for the pointer
parameter fails due to the types not matching (even when they look the
same when printed in the error).
Instead, we must always ensure we use the actual object when defining
the parameter type when placing the object into the event.
2024-01-24 16:14:32 +00:00
a5ee614ae8
Comments.
2024-01-24 14:51:41 +00:00
65c75072ef
Convert between refs and KIIDs in Footprint Properties.
...
Also fixes DIALOG_TEXT_PROPERTIES, which did it correctly
for multi-line texts, but not for single-line texts.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16721
2024-01-24 13:35:37 +00:00
89850824d5
Naming & comments.
2024-01-24 13:35:37 +00:00
64221b95c9
Don't skip highlighting selected NPTH/via holes
2024-01-24 08:23:26 -05:00
b6ddef7162
pcbnew: Added missing DRC checks for value and library-link between symbol and footprint
2024-01-24 12:35:51 +00:00
7cf861a239
Use ARC_HIGH_DEF (not ARC_LOW_DEF) for courtyard generation.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16695
2024-01-24 12:00:33 +00:00
9d88a9f60a
Fix typo causing OnItemsChanged() to get called too often.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16657
2024-01-24 11:36:56 +00:00
6407576cb9
Convert between refs and KIIDs in Symbol Properties.
2024-01-24 11:02:56 +00:00
d50e0811fb
Fix QA build
2024-01-23 22:50:53 -05:00
a85478df97
Test the directory opened explicitly to silence assert
...
Fixes KICAD-6FY
2024-01-23 22:37:22 -05:00
c143be6279
Pads need to be included in collection for length checks
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16724
2024-01-23 22:08:08 -05:00
ed00cb3304
Support arcs in Break Track.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16712
2024-01-24 05:47:50 +03:00
a46d409ec6
Make sure grouping commits follow board editor path
2024-01-23 21:22:23 -05:00
256364aaa1
Parent property should not be accessible from the UI
2024-01-23 20:41:34 -05:00
426aa76788
Add Andre Iwers to developers
2024-01-23 20:30:37 -05:00
Jeff Young
Marek Roszko
jean-pierre charras
Seth Hillbrand
Wayne Stambaugh
Alex Shvartzkop
Jon Evans
Ian McInerney
Jan Wichmann