07481cd4ca
CADSTAR PCB: Invert logic for guessing which layer is top / bottom
...
Ensures correct automatic layer mapping is applied to the design in
https://gitlab.com/kicad/code/kicad/-/issues/12349
(cherry picked from commit 9abf3438b8
2022-09-04 01:03:55 +02:00
8a9ee0f9e1
CADSTAR PCB: Load 2-point polygons as line segments
...
Fixes asserts when loading design from https://gitlab.com/kicad/code/kicad/-/issues/12349
(cherry picked from commit c961624d43
2022-09-04 01:03:55 +02:00
9a823ca61b
CADSTAR PCB: Parse Teardrops
...
Todo: We need to figure out how we will load teardrops. For now
just drop them on import.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/12349
(cherry picked from commit 21b3753e9b
2022-09-04 01:03:51 +02:00
e25d937fd8
Null-ptr safety for diff-pair-coupling test.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/12329
(cherry picked from commit 854acd4c77
2022-09-02 01:18:18 +01:00
ea3f6c8406
Make sure dirty flag gets set, and leave save enabled regardless.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11824
(cherry picked from commit 09773e3e2e
2022-09-02 01:11:20 +01:00
bf272e379f
Run hole-to-hole checks on Edge_Cuts layer.
...
Also makes the flashing logic inside PAD::GetEffectiveShape() easier
to understand.
Fixes https://gitlab.com/kicad/code/kicad/issues/12296
(cherry picked from commit e0f6a6e475
2022-09-02 01:11:20 +01:00
0acea2e386
Make sure via-gap-same-as-trace-gap gets turned off for board settings.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/12236
(cherry picked from commit 7baa56528a
2022-09-02 00:55:53 +01:00
83305dd407
Re-route m_last_head after routing fails
...
This should ensure the shove state gets reverted
Fixes https://gitlab.com/kicad/code/kicad/-/issues/9023
2022-09-01 22:06:06 +00:00
1d5db513a1
Ensure arcs are handled in topology
...
Use the connection-independent `Anchor()` function to get connection
points for either arcs or segments in topology. This allows the
ratsnest to be correctly drawn between nets with arcs
Fixes https://gitlab.com/kicad/code/kicad/issues/12205
2022-09-01 22:06:06 +00:00
9d0d45450b
Account for groups in undo of Position Relative To.
...
Also fixes a bug were pads weren't correctly being found for anchoring
the selection before the Position Relative To.
Fixes https://gitlab.com/kicad/code/kicad/issues/11793
(cherry picked from commit 1e68c353f1
2022-09-01 16:25:41 +01:00
c3496d61eb
Set locale in python save routine
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11006
2022-08-23 09:41:55 -07:00
1e09f0e8b0
Fix Eagle plugin footprint QA test issue.
...
Apparently mapping Eagle footprint layers to the KiCad Dwg_User
that were previously mapped to UNDEFINED_LAYER breaks the QA test
and causes the footprint editor to crash when opening Eagle
footprints. This means that the potential data loss issue when
loading Eagle footprints is still in play.
(cherry picked from commit c72457482c
2022-08-22 11:40:15 -04:00
c2c4609272
Fix Eagle plugin board layer mapping issue.
...
The Eagle plugin layers have to be mapped differently depending on
whether a board is being imported or a footprint library is being
cached. Footprint libraries can bypass the manual layer remapping
step that happens when importing a board.
Please note that when loading footprints in the footprint editor
and viewer, all layers that do not directly map to KiCad layers are
put on the Dwg_User layer so that there is data loss. Users will
have to manually remap objects to the correct layer as required.
This is less than ideal but until the footprint library table parser
supports prompting users to remap unknown layers, it will have to do.
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/11839
(cherry picked from commit 0bc1188897
2022-08-22 11:40:15 -04:00
9e9b38ef6a
Revert "cadstar: Report warning that imported text may be different"
...
This reverts commit f637a820b6
2022-08-20 20:09:40 -07:00
5e409f0f6c
Remove string change and associated new feature
...
String changes are not allowed in v6 branch
2022-08-20 20:06:26 -07:00
962df45b65
Fix some issues in PCB_SELECTION_TOOL::selectAllItemsOnSheet():
...
especially a typo that prevent working on root sheet.
Clearly, commit 6b2bb4d8
2022-08-20 13:04:06 +02:00
ca4da4706a
Fix reserve call with the wrong source for size
2022-08-16 23:53:42 -04:00
1005f75cdb
CADSTAR PCB: Allow remapping all non-electrical layers
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/12196
(cherry picked from commit 6b349fdb0a
2022-08-14 21:26:37 +00:00
f637a820b6
cadstar: Report warning that imported text may be different
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/12195
(cherry picked from commit 69d696660b
2022-08-14 21:25:46 +00:00
36a0c2a9cc
Fix issue with caches not being initialized when printing msg bar.
...
(cherry picked from commit 43df863df2
2022-08-04 13:04:21 +01:00
4ac48ad829
Cherry-pick of 2bf33321d1.
2022-08-04 09:29:45 +01:00
afc491c5a5
58f553a9ca requires that cache be layer-sensitive.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11814
(cherry picked from commit 5e80e2a421
2022-08-04 00:48:18 +01:00
7b5e3feb19
By-hand cherry-pick of 004abcd370.
2022-08-04 00:05:48 +01:00
a12ae5050a
Cleanup unused code
...
(cherry picked from commit 76b9e25143
2022-08-02 08:51:04 -07:00
82e8e38054
PNS: Handle via-in-pad distances when tuning
...
Tuning with a via in pad, the via isn't a part of the full line. But we
still need to account for the line length distance of the
starting/ending vias. To do this, we simply measure the height from
the ending track to the ending pad and starting track to starting pad
2022-08-01 20:23:07 -07:00
57de5a6b65
Net Inspector: Handle via layers
...
Rather than measuring the total via height, measure from the entry to
exit track height to get a more accurate distance
2022-08-01 20:22:13 -07:00
6c617d84ca
Prevent drag index from exceeding full line count
...
Simplification removes segments, so we might lose our valid index.
Ideally, we would simplify during the assembly or pass the input index
to the simplify routine to maintain the proper value.
Fixes https://gitlab.com/kicad/code/kicad/issues/12137
2022-08-01 08:57:45 -07:00
06e612661c
Kicad2step: fix STEP export from Pcbnew, broken by changes in commit 8456d6c
...
also: DIALOG_EXPORT_STEP: remember tolerance option during a session.
From Master branch.
Fixes #12119
https://gitlab.com/kicad/code/kicad/issues/12119
2022-07-29 19:46:34 +02:00
3f448a7eaa
Clear dimension pointer after committing.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11864
(cherry picked from commit b80fd5329d
2022-07-28 10:46:02 +01:00
5214290000
Get rid of error-prone reverse logic.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/12049
(cherry picked from commit 012d861aab
2022-07-28 10:45:56 +01:00
fcd7e827e6
Hook up ID_GRID_SETTINGS for footprint viewers.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/12030
(cherry picked from commit 6a9c6e8599
2022-07-28 10:44:03 +01:00
466f1283c1
DXF parameters are for DXF (only).
...
Fixes https://gitlab.com/kicad/code/kicad/issues/12021
(cherry picked from commit 763c77eab8
2022-07-28 10:43:56 +01:00
7bd073b5cb
Make sure there are no translation changes for 6.0.x.
2022-07-28 01:08:42 +01:00
af40ddd0e1
Make sure strings are either 6.0.7 values or 5.1 values.
2022-07-28 00:25:45 +01:00
e59d8b0a2d
Fix up merge errors.
2022-07-28 00:12:25 +01:00
7113f1f879
Fix through via drawing width
...
Related to fix for https://gitlab.com/kicad/code/kicad/-/issues/11851
2022-07-27 12:09:35 -07:00
a5b676fa0e
Avoid crashes when, for some reason, a dll cannot be loaded.
...
In this case a null pointer was returned by the internal code.
This pointer is now tested against nullptr to avoid the application crashing.
Fixes #12080
https://gitlab.com/kicad/code/kicad/issues/12080
2022-07-26 16:04:27 +02:00
38b75db12c
Fix merge breakage.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/12088
2022-07-26 14:42:36 +01:00
ac28ed9888
Cherry-pick fix for pad clearances from master.
2022-07-25 21:50:23 +01:00
d9fef3da72
Don't allow 0 line-width for unfilled shapes.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/12010
(cherry picked from commit d0547cbde7
2022-07-25 21:46:27 +01:00
61bb793324
Save fp browser list widths and apply known hack to work around wxWidgets bug.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11744
Fixes https://gitlab.com/kicad/code/kicad/issues/11745
(cherry picked from commit 0a623bff9f
2022-07-25 21:21:23 +01:00
e06e65cdde
Add newly-drawn objects to any entered group.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11912
(cherry picked from commit 654740b90d
2022-07-25 21:02:26 +01:00
0f882d91e5
Add proper collision test to via placer.
...
Also moves DISALLOW constraint processing outside the loop as it
performs it's own loop over any objects referenced by the rules.
Fixes https://gitlab.com/kicad/code/kicad/issues/11832
(cherry picked from commit 73836b50fc
2022-07-25 20:16:01 +01:00
2fdddb970f
Bug fixes for printing vias.
...
Blind/buried and microvias didn't get their layers trimmed properly,
nor did through vias with dropped pads.
Fixes https://gitlab.com/kicad/code/kicad/issues/11851
(cherry picked from commit 231ac567b8
2022-07-25 20:05:40 +01:00
0321d96b1e
Fill in missing bits of LAYER variable for printing/plotting.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11788
(cherry picked from commit f22cf1cc3a
2022-07-25 19:49:09 +01:00
06baaa33fa
Rely on DRC rules when items might overlap.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/1790
(cherry picked from commit f48ed79039
2022-07-25 19:31:05 +01:00
cd5b4ec8f2
Add edge-exclusions to router (for castellated pads).
...
Fixes https://gitlab.com/kicad/code/kicad/issues/1790
(cherry picked from commit 833dc70bff
2022-07-25 19:30:49 +01:00
58451335cb
Apply DRC fixes to ERC.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11844
(cherry picked from commit 83a2f43661
2022-07-25 19:23:57 +01:00
e7dd9f9337
Don't reset Footprint Tests Run if the board didn't change.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11844
(cherry picked from commit 048f277b1e
2022-07-25 18:41:48 +01:00
7bf66be2ac
Don't clear marker counts when closing DRC dialog.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11844
(cherry picked from commit 801a98a302
2022-07-25 18:41:21 +01:00
Roberto Fernandez Bautista
Jeff Young
Seth Hillbrand
Wayne Stambaugh
jean-pierre charras
Marek Roszko