94f8aafec5
Fix missing variable initialization.
2020-01-13 00:18:49 +00:00
9e8a66a0a3
Don't try to clear memory if the bitmap has an invalid size.
2020-01-13 00:18:49 +00:00
d24bd5c832
Fix a couple of Coverity issues.
2020-01-12 21:07:41 +00:00
8d0f31f6f4
Clean a bunch of legacy code out of the Filter Selection dialog.
2020-01-12 20:53:56 +00:00
127c66285b
Rename old DIALOG_BLOCK_OPTIONS to DIALOG_FILTER_SELECTION....
...
... which is what it has done for some time now.
2020-01-12 20:30:58 +00:00
3a1585718f
Remove unnecessary casts (they're just casting to a superclass).
2020-01-12 20:26:07 +00:00
836c1ea56e
Fix a bunch of un-caught boost::bad_pointer exceptions.
...
This also removes vector cover types which do nothing except obfuscate
the underlying implementation.
Mainly changes SCH_SHEET_PINS and CONFIG_PARAM_ARRAY (which will soon
be replaced by Jon's new stuff).
2020-01-12 19:55:00 +00:00
cc573eed31
Patch crash bug when closing symbol properties dialog.
2020-01-12 19:55:00 +00:00
960b553a70
Cleanup type casting in EE toolbase
...
* Ensure the lib edit undo checks for pointer validity
* Assert that the frames are the correct type (satisfies coverity)
* Convert C casts to C++ casts
2020-01-12 19:47:13 +00:00
cd0d92956b
Use static cast in sch_view since type has been checked
2020-01-12 19:46:17 +00:00
b445ce6632
Clean up pointer casting
...
* Make note of when dynamic cast is actually needed
* Convert some to static cast when we know the type for sure
2020-01-12 19:45:37 +00:00
4ffbefb9dc
Use the layer from the module item instead
...
They are both from the same argument, but this one make coverity happy.
2020-01-12 19:39:39 +00:00
52bfdb9703
PNS: Assume the current line is a base before optimizing
...
We use the cost of the current line before trying to improve the pad
breakout cost when optimizing the smart pads
Fixes #3759 | https://gitlab.com/kicad/code/kicad/issues/3759
2020-01-12 11:08:46 -08:00
3346f812a9
Cleanup error handling in VRML export (from coverity scan)
2020-01-12 17:18:08 +00:00
00e58cd974
Fix unintialized values (from coverity scan)
2020-01-12 13:00:42 +00:00
ae91312416
Fix default pin orientation (from Coverity scan)
2020-01-12 11:55:03 +00:00
76c26d6ae1
Remove unneeded unique_ptr
...
The unique_ptr was useful when the original function took multiple paths
which could de-scope the pointer. Current use allowed potential
use-after-free. This is now re-written to pass pointer directly.
2020-01-11 17:29:12 -08:00
84d5d6c168
Eeschema: Return null in case of canceling placement
2020-01-11 17:02:55 -08:00
b343391723
Code cleanup for readibility.
2020-01-11 21:30:48 +00:00
116e3d6816
Fix missing member variable initialization.
2020-01-11 21:29:25 +00:00
3d8150032f
Fix some uninitialized variables found by Coverity.
2020-01-11 21:29:25 +00:00
2e509480a4
Fix guaranteed divide-by-zero error when called with correction of 0.
2020-01-11 21:29:25 +00:00
715448611d
Fix potential divide-by-zero (from Coverity scan).
2020-01-11 21:29:25 +00:00
1591d13839
Use static_cast since we've already checked the type.
...
This is faster and also keeps Coverity happy.
2020-01-11 21:29:25 +00:00
17710c15d3
Fix leak of empty PICKED_ITEMS_LIST.
2020-01-11 21:29:25 +00:00
677fcee0d2
Remove exception which is not caught in most code paths.
2020-01-11 21:29:25 +00:00
9182b3a850
Remove dead code and simplify remaining logic.
2020-01-11 21:29:25 +00:00
43abd53b19
Clarify limits of the if statement
2020-01-11 21:28:25 +00:00
6e8f06e042
Fixup some issues in libkimath
...
* Perform floating-point computations when needed
* Specify to use the default equality operator
2020-01-11 21:27:38 +00:00
f896043067
Fix comments for switch statement fall throughs
...
This cleans up all GCC warnings (-Wimplicit-fallthrough=2) about
implicitly falling through switch cases.
2020-01-11 19:16:32 +00:00
4ebb87d1c1
Fix Eeschema BW printing
...
Checks forced state when printing to convert images to grayscale.
2020-01-11 09:55:30 -08:00
195c3d074b
Fix bitmap clipping
...
When printing (using DC context) the bitmap will clear the full screen
unless the clipping region is set to the image itself.
Addresses KSC ticket 126
Fixes #1877 | https://gitlab.com/kicad/code/kicad/issues/1877
2020-01-11 09:47:19 -08:00
c3df984c0b
Project manager: fix files in nested dir not being added to hierarchy
...
Fixes #1945 | https://gitlab.com/kicad/code/kicad/issues/1945
2020-01-11 16:03:26 +00:00
94a9e81a0f
Fixes invalid initialization for Rect in rtree iterator.
...
The rtree has the rect array sizes templated by NUMDIM, initializing with 3 default values violates the templating.
2020-01-11 15:49:51 +00:00
ce5c63b368
Fix bitmap unit test
...
This was testing for bitmap dots per IU. But IU changed, so we needed
to adjust how the bitmaps were scaled. This brings the QA up to date.
2020-01-11 07:30:17 -08:00
7c28c3838a
Comment-only changes
...
Makes class comments conform to coding standards
2020-01-10 16:43:01 -08:00
2a780dba0e
Initialize view variable
...
Sets known initialization value to the last keyboard command
2020-01-10 16:43:01 -08:00
94f682c6bd
Fix bug in linux compile
...
wx 3.0 does not have an emplace_back method for wxVector
2020-01-10 16:41:55 -08:00
d1a0102e84
eeschema: Fix print order between worksheet and screen
...
The worksheet should be drawn behind the screen.
2020-01-10 16:33:53 -08:00
c2904ce7e9
Fixing drawing order when plotting/printing
...
This is a partial re-work of a previous commit to the v5 branch
(8f7278e34ffixes #368
2020-01-10 16:33:53 -08:00
a35db35029
eeschema: Fix bitmap scaling when printing
...
Bitmaps scale internally to 100nm instead of 1mil. There is a better
way to do this but I think we'll be adjusting it again when Cairo
printing in finished.
2020-01-10 16:33:53 -08:00
8fed9df1d0
Fix uninitialized variable (from Coverity scan).
2020-01-11 00:18:27 +00:00
254ba1f998
Fix null pointer access (from Coverity scan).
2020-01-11 00:15:47 +00:00
88eab8134e
Fix a couple of uninitialized variables (from Coverity scan).
2020-01-11 00:11:31 +00:00
0fd68dad62
Fix freed pointer access issue (from Coverity scan).
2020-01-11 00:09:08 +00:00
7bb9551801
Handle boost exceptions. (From Coverity scan.)
2020-01-11 00:04:01 +00:00
33da81cd27
Repair Coverity scan defects.
2020-01-10 23:17:54 +00:00
b54a42ba53
Clean up dialog (including uninit var from Coverity scan).
2020-01-10 22:32:50 +00:00
8576a4a067
Fix unchecked array access (from Coverity scan).
2020-01-10 22:32:50 +00:00
8abfc13053
Fix possible null dereference (from Coverity scan).
2020-01-10 22:32:50 +00:00
Jeff Young
Ian McInerney
Seth Hillbrand
Mikołaj Wielgus
Mark Roszko