haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
16,379 Commits 9 Branches 105 Tags 1.3 GiB
Commit Graph

4704 Commits

Author SHA1 Message Date
Jeff Young 19aba615c2 Remove selection condition from conditional menu separators. 
We don't allow duplicate separators anyway so all they really do
is complicate the code.
 2019-06-15 20:43:51 +01:00
Jeff Young 5610261dce Immediate-action hotkeys (and context menu actions) for eeschema. 2019-06-15 20:43:51 +01:00
Jeff Young 83ee51370c Cancel interactive editing when switching sheets. 
Fixes: lp:1819278
* https://bugs.launchpad.net/kicad/+bug/1819278
 2019-06-14 16:54:46 +01:00
Maciej Suminski 7d69a917b9 Fixed a crash in EE_SELECTION_TOOL::SelectPoint() 
The for loop is continued after an item removal, so the removed item
is not accessed anymore.
 2019-06-14 13:00:39 +02:00
Seth Hillbrand fb3d1bdb59 Clear some compile warnings 2019-06-13 15:16:54 -07:00
Jeff Young 8cc1e2b5e7 Fix breakage in wire moving/dragging/etc. 
Fixes: lp:1832750
* https://bugs.launchpad.net/kicad/+bug/1832750
 2019-06-13 19:58:37 +01:00
Jeff Young 8f84c3ec4f Grid rid of GetCanvas/GetGalCanvas distinction now that there's only gal. 2019-06-13 19:58:37 +01:00
Steven A. Falco 1edeba7fb4 Show the current grid setting. 2019-06-13 14:34:39 -04:00
Jeff Young ce1f35a1be Cleanup some left-over vestiages of the legacy canvas architecture. 2019-06-13 15:51:32 +01:00
Jeff Young 4043a15482 When pasting a sheet link to existing copy if it already appears in the hierarchy. 
Fixes: lp:1830633
* https://bugs.launchpad.net/kicad/+bug/1830633
 2019-06-13 15:51:32 +01:00
Wayne Stambaugh 028973d182 LibEdit: fix library tree refresh issue when library is removed. 
A bug in LIB_MANAGER::LibraryExists() prevented a library removed from
the symbol library table from being removed from the tree view.  Add the
proper check to SYMBOL_TREE_SYNCHRONIZING_ADAPTER::Sync().

This exposed another issue with synchronization between the library
table editor and the tree view which could lead to orphaned library
modifications and/or a segfault when the currently selected library was
removed from the symbol library table.  Give the user a chance to save
or revert any changes before allowing changes to the symbol library
table.

Fixes lp:1821691

https://bugs.launchpad.net/kicad/+bug/1821691
 2019-06-13 07:45:03 -04:00
Seth Hillbrand e52afd93a3 Remove Legacy options for overlay/context 
These options were used to support the legacy canvas when drawing on
MacOS and GTK3.  With the move to 100% GAL, they are extraneous.  This
moves all DC over to "COPY" as we only use this for printing support in
Eeschema at the moment, so there is a single draw command (no erasing)
for the canvas.
 2019-06-12 06:01:03 -07:00
Seppe Stas 455ee4c08c Set KiCad version in MacOS apps 
Uses CMake's configure_file function [1] to automaticaly set the
CFBundleShortVersionString [2] value in every app's Info.plist file.

Also updates the CFBundleLongVersionString and CFBundleVersion with the
extended KiCad Version

[1]: https://cmake.org/cmake/help/latest/command/configure_file.html
[2]: https://developer.apple.com/documentation/bundleresources/information_property_list/cfbundleshortversionstring
 2019-06-12 04:40:03 -07:00
Jeff Young c0e1f7a17a Add dragging of wire ends, corners and junctions. 
Fixes: lp:1830007
* https://bugs.launchpad.net/kicad/+bug/1830007
 2019-06-11 21:20:19 +01:00
Jeff Young b1b7408cf2 Accidentally checked in some debugging stuff. 2019-06-11 18:53:36 +01:00
Jeff Young 7726b039b2 Re-jigger standard submenus so they both link AND work. 2019-06-11 18:03:16 +01:00
Jeff Young 05652d4787 Rework the preparation for eeschema's move-tool. 
There are a whole bunch of cases which all have to work:
 regular move
 move followed by drag
 drag followed by move
 move followed by duplicate
 duplicate
 paste
and all both with and without Warp Mouse on Move checked.
 2019-06-11 18:03:16 +01:00
Jeff Young e4d16abcbd Fix overly-generic flag test when synchronizing pins. 
Fixes: lp:1832170
* https://bugs.launchpad.net/kicad/+bug/1832170
 2019-06-11 09:29:30 +01:00
Jeff Young 09a3c5b280 Update pasted items' parent pointers. 
Fixes crashes when trying to manipulate the item after the paste,
and weird redraw behaviour with pins.

Fixes: lp:1832178
* https://bugs.launchpad.net/kicad/+bug/1832178
 2019-06-11 09:22:56 +01:00
Jeff Young 6623ab91a8 Fix issue with picker tool activation. 2019-06-11 00:25:38 +01:00
Jeff Young e9017ce0b1 Update status bar when selected items are modified. 
Fixes: lp:1831801
* https://bugs.launchpad.net/kicad/+bug/1831801
 2019-06-10 23:46:01 +01:00
Jeff Young b3e30e50c8 Cleanup. 2019-06-10 23:46:01 +01:00
Jeff Young b0e8443383 Sync-ing of menu has been done in CONDITIONAL_MENU for some time now. 2019-06-10 23:46:01 +01:00
Jeff Young a568e70b99 Follow naming conventions. 2019-06-10 23:46:01 +01:00
Jeff Young 5e49517781 Move hotkeys to ACTION architecture. 2019-06-10 23:46:00 +01:00
Jeff Young 6025256e07 Push KIWAY_HOLDER down a level so we can move a bunch of stuff that doesn't belong there out. 2019-06-10 23:46:00 +01:00
Jeff Young 765606012f Convert separate-compilation of selection.cpp to polymorphism. 2019-06-10 23:46:00 +01:00
Jeff Young e606587ff6 Move remaining Symbol Tree ctx menu cmds to ACTIONS. 
Also moves the various Player instantiators down into COMMON_TOOLS
for better sharing.
 2019-06-10 23:46:00 +01:00
John Beard 7ebda0247f Common: Remove legacy_gal library, fold into common 
Return the EDA_DRAW_FRAME class back to common, whence it came (before it was
duplicated into legacy_wx and legacy_gal). Now there is only one
implementation (the GAL one), it doesn't need to be in a separate library.

This simplifies the dependencies for common lib users.
 2019-06-10 18:56:57 +01:00
jean-pierre charras beb4348016 Eeschema: fix incorrect saving in prj config on the default netlist format. 
It was not always saved, and this was not the default, but the last used format.
 2019-06-10 18:44:46 +02:00
Seth Hillbrand bc096dc4ee Eagle: Fix stacked NC pin import 
Since Eagle does not connect stacked NC pins but KiCad will if the pins
are coincident, we choose to only import the first of the stacked NC
pins.  While this creates symbols that are slightly different in pin
count from the Eagle version, it keeps the schematic and netlist
functionally correct relative to the Eagle version.

Fixes: lp:1821319
* https://bugs.launchpad.net/kicad/+bug/1821319

(cherry picked from commit 370109b868)
 2019-06-09 17:03:44 -07:00
jean-pierre charras bc27b0ed5f Sim spice: fix unescaped netnames in spice netlist and simulator dialogs. 
Net names in eeschema that include '/' are escaped ('/' replaced by "{slash}")
Escaped netnames are only for internal use, and must be unescaped in spice netlist and dialogs.
 2019-06-09 17:48:01 +02:00
jean-pierre charras df5c5c23ca Eeschema: fix incorrect handling of '/' in graphic texts. 
It was escaped (replaced by "{slash}") in dialog.
This is right for labels, not for texts.
A consequence was the directives in spice simul can be broken.
Now the graphic text is not escaped.
 2019-06-08 17:32:49 +02:00
Seth Hillbrand 598b140112 eagle: Strip newlines from description 
Eeschema old format is line-terminated so the newlines in descriptions
will break the schematic file if saved.

Fixes: lp:1829707
* https://bugs.launchpad.net/kicad/+bug/1829707

(cherry picked from commit fb85612f81)
 2019-06-07 22:08:58 -07:00
Jon Evans 607650be22 Connectivity: don't consider neighbor propagation when types don't match 
Fixes: lp:1831608
* https://bugs.launchpad.net/kicad/+bug/1831608
 2019-06-05 22:26:44 -04:00
Jon Evans 1142eb259b Eagle: properly translate group buses now that we support them 2019-06-05 22:09:09 -04:00
Jon Evans 42887544c9 Connectivity: ensure globally-labeled buses are always propagated 
Fixes: lp:1822964
* https://bugs.launchpad.net/kicad/+bug/1822964
 2019-06-05 21:33:20 -04:00
Jon Evans 8d8c743f97 Connectivity: remove unused method 2019-06-05 21:27:56 -04:00
Jeff Young b9927a0655 Don't put standard menu items into symbol tree context menu. 2019-06-05 23:33:15 +01:00
Jeff Young 469fc3b572 Finish moving symbol editor tree context menu to ACTIONs. 2019-06-05 23:29:59 +01:00
Jeff Young 6fab7cc025 Remove a bunch of ugly mutex hacks now that we don't use wxString's UTF8 mode anymore. 2019-06-05 21:23:41 +01:00
Seth Hillbrand c6af38477d CMake: Handle custom_target indirection 
Building custom targets that depend on custom commands such as our
keyword lexer requires two layers of indirection to pick up changes
properly and not overwrite the same file in parallel builds.

Fixes: lp:1831643
* https://bugs.launchpad.net/kicad/+bug/1831643
 2019-06-05 13:05:43 -07:00
Jeff Young 2d40425e4d Move footprint & symbol tree context menus to tool infrastructure. 
Fixes: lp:1831692
* https://bugs.launchpad.net/kicad/+bug/1831692
 2019-06-05 20:16:48 +01:00
Jeff Young 1ea5b04e22 More ACTIONS work. Nearly done now. 2019-06-04 22:31:42 +01:00
Jeff Young dfcffddbe4 Fix destruction order in Symbol Properties grid table. 
wxGrid is VERY cranky about this.  I've only found one recipie that works,
and it must be applied strictly.

Fixes: lp:1831317
* https://bugs.launchpad.net/kicad/+bug/1831317
 2019-06-04 15:02:42 +01:00
Jeff Young 1fe848f37c Minor performance enhancements. 2019-06-04 13:56:54 +01:00
Jeff Young 1ea001d497 Go back to event-loop zooming for new frames. 
The immediate mode appears to have made things worse not better.
 2019-06-04 13:56:54 +01:00
Jeff Young 7c337ec45d Make sure the current desc is shown for parts being edited. 
Fixes: lp:1820298
* https://bugs.launchpad.net/kicad/+bug/1820298
 2019-06-04 13:56:54 +01:00
Jon Evans 1721cc1700 Ensure pasted sheets get parents set properly for screen discovery 
Fixes: lp:1831460
* https://bugs.launchpad.net/kicad/+bug/1831460
 2019-06-03 20:30:35 -04:00
Jeff Young 1bf04d1722 More ACTIONs work. 2019-06-04 00:51:16 +01:00
Jeff Young 568c8c336b Move DRC control to a tool; move assorted commands to ACTIONS. 2019-06-03 21:08:30 +01:00
Jeff Young 9f1e2e34b7 Move some dupicated tools to common tools. 2019-06-03 21:08:30 +01:00
Jeff Young e517199794 Move ConfigurePaths and LibTable management to common ACTIONs. 2019-06-03 21:08:30 +01:00
Jeff Young da4fe27447 More ACTIONS work. 2019-06-02 21:10:56 +01:00
Jeff Young 33773bad4d Yet more command conversions to ACTIONs. 2019-06-02 21:10:56 +01:00
Jon Evans 256d7b0714 ERC: Use local paths for bus<>bus entry testing 
Fixes: lp:1831365
* https://bugs.launchpad.net/kicad/+bug/1831365
 2019-06-02 11:34:15 -04:00
Jeff Young dfc2fe3929 Don't try to post-process an empty clipboard paste. 
Fixes: lp:1831364
* https://bugs.launchpad.net/kicad/+bug/1831364
 2019-06-02 16:21:44 +01:00
Jeff Young 45a9544726 Instantate a default menu from no selection when menu is first built. 
This might resolve some of the GTK menu anomalies.
 2019-06-02 12:58:08 +01:00
Jeff Young 6c93cccb70 Implement enable/disable of LibEdit save icon. 
Fixes: lp:1831314
* https://bugs.launchpad.net/kicad/+bug/1831314
 2019-06-01 23:24:17 +01:00
Jeff Young 7f1ed30ff5 Move DeMorgan handling to ACTIONs. 2019-06-01 23:03:24 +01:00
Jeff Young 39b91c90dd Moved more operations to ACTIONs. 2019-06-01 23:03:24 +01:00
Jeff Young 3777c5270b Move some more Eeschema operations to ACTIONs. 2019-06-01 16:29:12 +01:00
Jeff Young 74e10791ff Fix some Mac-specific issues with the Preferences... menu item. 2019-06-01 16:29:12 +01:00
Jon Evans 27a2b840ec Eeschema: Fix multiple net label ERC after sorting changes 
Fixes: lp:1831003
* https://bugs.launchpad.net/kicad/+bug/1831003
 2019-05-31 21:55:54 -04:00
Jeff Young f1076c0f48 Fix missing reference keeping history from getting saved. 
Fixes: lp:1830185
* https://bugs.launchpad.net/kicad/+bug/1830185
 2019-05-31 23:38:15 +01:00
Jeff Young c7fa5c567f Load sheet content after a paste. 
Fixes: lp:1830633
* https://bugs.launchpad.net/kicad/+bug/1830633
 2019-05-31 23:38:15 +01:00
Jeff Young 1dd1ddf83b Try an "add wires" strategy instead of trying to figure out what to pick up and what to anchor. 
Fixes: lp:1831199
* https://bugs.launchpad.net/kicad/+bug/1831199
 2019-05-31 21:56:35 +01:00
Jeff Young d7774b94fc Fix regression with switching between drag and move operation. 2019-05-31 21:56:35 +01:00
Jeff Young ead1914b1d Don't autopan until mouse moves. 2019-05-31 21:55:30 +01:00
Jeff Young c2662b0e11 Retire EDA_DRAW_PANEL and legacy_wx/EDA_DRAW_FRAME. 2019-05-31 21:55:30 +01:00
Jeff Young d6e9bdf07b Convert remaining legacy drawing code to print code. 2019-05-31 21:54:22 +01:00
Jeff Young 03bab2f4a9 Remove some more legacy drawing stuff. 2019-05-31 21:54:22 +01:00
Jeff Young 0a01277808 Fix issues with schematic find/change. 
Fixes: lp:1831006
* https://bugs.launchpad.net/kicad/+bug/1831006
 2019-05-31 21:54:22 +01:00
Jeff Young d2daab808c Remove some legacy cursor handling stuff. 2019-05-31 21:54:22 +01:00
Jeff Young edc8438ef0 Start the process of removing the legacy draw panel. 2019-05-31 21:54:21 +01:00
jean-pierre charras 4842c73530 Fix minor compil warnings. 2019-05-31 21:38:30 +02:00
jean-pierre charras 611878351a BOM and Netlist dialogs: replace "plugin" by "generator" and/or "script". 
The "plugins" in these dialogs are not plugins.
They are external scripts (or applications) run from Eeschema.
 2019-05-31 11:06:23 +02:00
Jeff Young 1e9da7f57b Remove CurItem() architecture and legacy routers and drawing code. 2019-05-29 00:26:30 +01:00
Jeff Young 9d29e94cb5 Remove some more legacy code. 2019-05-29 00:26:29 +01:00
Jeff Young 0260b32125 Push resetLocalCoords down into COMMON_TOOLS. 
Fixes: lp:1830693
* https://bugs.launchpad.net/kicad/+bug/1830693
 2019-05-29 00:26:29 +01:00
Jeff Young a27e4246e0 Move some more menu commands to ACTIONs. 2019-05-29 00:26:29 +01:00
Jeff Young c0909611d3 Remove a bunch more legacy editing code. 2019-05-29 00:26:29 +01:00
Wayne Stambaugh 133ff9b552 Eeschema: fix broken symbol library links after sheet edit. 
Refresh the currently edit sheet screen symbol links when the sheet file
name is changed.

https://bugs.launchpad.net/kicad/+bug/1830315

Fixes lp:1830315
 2019-05-28 17:31:54 -04:00
Seth Hillbrand 0b629b4bd4 eeschema: Limit normalization on load 
When loading a new file, we do not want to add junctions where they did
not exist before.  This could generate invalid netlists by breaking a
wire at a pin connection point.

We do break/add connections when the user modifies the schematic but
this happens while the user is actively working with the component and
sees the action.

Fixes: lp:1830411
* https://bugs.launchpad.net/kicad/+bug/1830411
 2019-05-28 13:29:20 -07:00
Jon Evans 5287ab6e4f Eeschema: improve simulator behavior for two-source DC analysis 
Fixes: lp:1830478
* https://bugs.launchpad.net/kicad/+bug/1830478

(cherry picked from commit 356ccd0314)
 2019-05-27 18:23:56 -04:00
Jeff Young 718ad77891 Fix a bug introduced when UseGalCanvas() no longer switches. 
We still need to setup the viewport the first time.
Also removes some more legacy editing code.
 2019-05-27 18:47:20 +01:00
Jeff Young 9d9745b555 Remove more legacy editing code. 2019-05-27 18:47:20 +01:00
Jeff Young db90e97d0b fixup! Implement undo for Page Settings in PlEditor, Eeschema and PCBNew. 2019-05-27 14:12:20 +01:00
Jeff Young d24a2afaca Fix duplicate to work like paste to keep pins from getting duplicated. 
Also fixes the post-duplicate move to start at the cursor pos.
Also fixes the fact that duplicate wasn't getting its hotkey.

Fixes: lp:1830596
* https://bugs.launchpad.net/kicad/+bug/1830596
 2019-05-27 11:58:56 +01:00
Jeff Young 800cc1a11c Fix intial drag point for paste in LibEdit. 2019-05-27 11:58:56 +01:00
Jeff Young e9e28b9aac Retire legacy block architecture. 2019-05-27 11:58:56 +01:00
Jeff Young 927d2a645c Move LibEdit Save operations to ACTIONS. 2019-05-27 11:58:55 +01:00
Jeff Young 2502bce987 Move quit back to wxIDs. wxWidgets like to muck around with the location on OSX. 2019-05-27 11:58:55 +01:00
Jeff Young 6936effaa7 Implement undo for Page Settings in PlEditor, Eeschema and PCBNew. 
Fixes: lp:1820059
* https://bugs.launchpad.net/kicad/+bug/1820059
 2019-05-27 11:58:55 +01:00
Jeff Young bdd44ce88c Use consistent PageLayout data structure names. 2019-05-27 11:55:58 +01:00
Seth Hillbrand 0e5cc54ec9 Eagle: Fix crash when importing Eagle V6 
This fixes multiple issues when importing Eagle V6 files.

Crashes occured when arcs of 0-length were found and when parts were
referenced in the schematic that were not found in the library.  This
could happen if the library and schematic were different cases.

Fixes: lp:1830564
* https://bugs.launchpad.net/kicad/+bug/1830564
 2019-05-26 20:31:55 -07:00
Jon Evans d2a2dea9c4 Eeschema: fix worksheet and background color for printing 
Fixes: lp:1820611
* https://bugs.launchpad.net/kicad/+bug/1820611

(cherry picked from commit 720b26d11e)
 2019-05-26 14:26:26 -04:00
Jon Evans b40289c1bd Eeschema: use worksheet color when plotting 
Fixes: lp:1825568
* https://bugs.launchpad.net/kicad/+bug/1825568

(cherry picked from commit e35be13b23)
 2019-05-26 13:03:23 -04:00
jean-pierre charras 568d4e2b19 Avoid including id.h in a lot of files that do not use it. 2019-05-26 08:14:25 +02:00
jean-pierre charras b8e2054b23 Activate context menu in LIB_VIEW_FRAME canvas. 2019-05-25 10:13:27 +02:00
Jeff Young a3dfce5adb Implement common file menu actions and move Eeschema over. 2019-05-25 01:14:21 +01:00
Jeff Young 94c8e84d3b Make sure PCB document is opened when doing an update. 
Fixes: lp:1830256
* https://bugs.launchpad.net/kicad/+bug/1830256
 2019-05-24 21:23:26 +01:00
jean-pierre charras 057366e97e Viewlib frame: make toolbar menu "List Hotkeys" working 2019-05-24 21:01:49 +02:00
Jeff Young 85f984ccd9 Add point-editor activation for immediate-mode drawing. 2019-05-24 19:49:09 +01:00
Jeff Young 323bb0f8e1 Moving PageLayout editor to GAL canvas and modern toolset. 2019-05-24 19:49:09 +01:00
Michael Kavanagh 43a5bb72ca Fix swapped mirror icons in eeschema context menu 
Fixes: lp:1828631
* https://bugs.launchpad.net/kicad/+bug/1828631
 2019-05-24 13:12:58 -04:00
jean-pierre charras 40382f4d52 Viewlib: menubar/view menu: make grid select working 
Set also a better icon for this menu item
 2019-05-24 15:49:51 +02:00
jean-pierre charras 944ecc8913 Remove unused vars. 2019-05-24 15:21:40 +02:00
jean-pierre charras 4ae5a006d0 Viewlib: fix minor issues. 2019-05-24 12:54:11 +02:00
jean-pierre charras e3815381ab Viewlib: register missing EE_SELECTION_TOOL. 
This tool is needed to manage the View menu.
 2019-05-24 11:28:39 +02:00
Jon Evans 4c33320cbc Stop erroneously accepting bus alias labels without curly braces 2019-05-23 23:06:51 -04:00
Jon Evans 4e6c9ac7b1 Remove defunct junction code that left some isolated 
Fixes: lp:1828716
* https://bugs.launchpad.net/kicad/+bug/1828716
 2019-05-23 22:58:46 -04:00
Jon Evans 8c89847627 Properly handle tildes at the end of bus vector names 
Fixes: lp:1825532
* https://bugs.launchpad.net/kicad/+bug/1825532
 2019-05-23 22:47:01 -04:00
Jon Evans ab3ada5200 Clear moving flag for second-click-placed items 
Fixes: lp:1830227
* https://bugs.launchpad.net/kicad/+bug/1830227
 2019-05-23 21:51:14 -04:00
Jeff Young 924736c6f3 Make sure PCBNew is open when running F8. 
Fixes: lp:1830256
* https://bugs.launchpad.net/kicad/+bug/1830256
 2019-05-23 22:57:53 +01:00
Jeff Young 39bb4b639f Fix crash with opening find dialog twice. 
Fixes: lp:1830224
* https://bugs.launchpad.net/kicad/+bug/1830224
 2019-05-23 22:57:53 +01:00
Jeff Young ebd8c44eee Don't confuse SCH_ITEMs and LIB_ITEMs. 
Fixes: lp:1829826
* https://bugs.launchpad.net/kicad/+bug/1829826
 2019-05-23 22:57:53 +01:00
jean-pierre charras 872c8ca37b Remove a duplicate icon. 2019-05-23 16:21:06 +02:00
Wayne Stambaugh c52ff1ca23 Symbol Editor: fix datasheet field bug loading old symbol libraries. 
This only applies to the root symbol when the datasheet field is not
empty and the datasheet for root symbol alias in the document file is
empty.  Use the root symbol datasheet field value when adding a new
symbol that meets this criteria.

The root symbol datasheet field gets copied to the root symbol alias
datasheet member variable so if the symbol is modified and saved, the
datasheet information is saved in the .dcm file.

https://bugs.launchpad.net/kicad/+bug/1830078

Fixes lp:1830078
 2019-05-23 09:00:50 -04:00
Wayne Stambaugh 300f5cb082 Eeschema: fix datasheet field bug loading old symbol libraries. 
This only applies to the root symbol when the datasheet field is not
empty and the datasheet for root symbol alias in the document file is
empty.  Use the root symbol datasheet field value when adding a new
symbol that meets this criteria.

https://bugs.launchpad.net/kicad/+bug/1830083

Fixes lp:1830083
 2019-05-23 07:25:16 -04:00
John Beard 0617bffce0 Eeschema: build with object libraries 
This is done to allow access to the eeschema library
internals for purposes of test and script access, as the
DLL library has highly restrictive -fvisibility settings
that otherwise prevent the tests being able to access 99.9%
of the eeschema library functions (only a single function
is APIEXPORT'ed, therefore that's the only test we can do).

Using object libraries is a bit of a hack, and makes for
a slower link when done for multiple targets, but with the currently
supported CMake versions, it's about as good as we can get.

A better solution in the longer term may be to break eeschema_kiface(_objects)
into many smaller libraries, each of which has a much more defined scope,
rather than one big interlinked amorphous lump. This has the advantage that
each module is testable in isolation, and we get better organisation of
inter-dependencies in the codebase.

Then, the kiface DLL will gather these sub-libs and present what
is needed on the visible DLL API. Thus, we get both a testable
suite of library functions, and a restricted kiface DLL interface.
 2019-05-23 11:29:28 +01:00
John Beard e1f6230e8c Do not statically construct wxTimer 
If you construct wxTimer statically, it will be constructed
before WX init, which means you might get assertions about
missing m_impl's within the timer class.

The solution is to construct the wxTimer at run time. In this
case, static within the function will be constructed only after
the function is called (and actually the scope only needed to be
this function anyway).
 2019-05-23 11:28:11 +01:00
Jeff Young d3777eaddf Don't double-launch selection tool. 
Fixes: lp:1829741
* https://bugs.launchpad.net/kicad/+bug/1829741
 2019-05-23 01:56:06 +01:00
Jeff Young 1f2bdf895e Not all SCH_DRAW_PANELs have a selection tool. 
Fixes: lp:1829981
* https://bugs.launchpad.net/kicad/+bug/1829981
 2019-05-23 00:27:53 +01:00
Jeff Young 0047f88f82 Mark unfold bus menu as clean so it doesn't get generated a second time. 
Fixes: lp:1829878
* https://bugs.launchpad.net/kicad/+bug/1829878
 2019-05-23 00:27:53 +01:00
Jeff Young 1636405b66 Set a reference point for all selection sizes. 
Fixes: lp:1829833
* https://bugs.launchpad.net/kicad/+bug/1829833
 2019-05-23 00:27:53 +01:00
Tomasz Włostowski ecb81426a4 eemodern: fixed use-after-free in SCH_DRAWING_TOOLS::DrawSheet(). 2019-05-23 00:28:58 +02:00
Jeff Young 323ecada8d Generate refresh preview events when objects are moving. 
Fixes: lp:1829683
* https://bugs.launchpad.net/kicad/+bug/1829683
 2019-05-22 21:48:04 +01:00
Jeff Young fbffb9ae1e Don't put KICAD_T arrays on stack and expect them to be there when you need them. 
Fixes: lp:1829748
* https://bugs.launchpad.net/kicad/+bug/1829748
 2019-05-22 21:48:04 +01:00
Jeff Young 67f7571f04 Don't call VIEW::Redraw() from within the tool. 
Fixes: lp:1828824
* https://bugs.launchpad.net/kicad/+bug/1828824
 2019-05-22 21:48:04 +01:00
Jeff Young 67cc2aac2e Rework Eeschema find/replace for modern toolset. 
Fixes: lp:1827274
* https://bugs.launchpad.net/kicad/+bug/1827274

Fixes: lp:1827240
* https://bugs.launchpad.net/kicad/+bug/1827240
 2019-05-22 21:48:04 +01:00
Tomasz Włostowski 2b38b23a5e eemodern: fixed use-after-free crash in LIB_EDIT_TOOL::DoDelete() 2019-05-22 21:35:03 +02:00
jean-pierre charras f18807ea0f Eeschema: Ensure axis are always drawn in libedit and viewlib 
Fixes: lp:1822408
https://bugs.launchpad.net/kicad/+bug/1822408
 2019-05-22 10:04:34 +02:00
jean-pierre charras 459a972116 Remove unused vars. 2019-05-22 08:27:48 +02:00
Seth Hillbrand e1373d70ae libedit: Ensure proper dereference in shared tools 
Fixes: lp:1829826
* https://bugs.launchpad.net/kicad/+bug/1829826
 2019-05-21 19:43:15 -07:00
Seth Hillbrand b53b29399d eeschema: Ensure conn is updated after import 
After importing Eagle files, we need to make sure that the connectivity
network is updated before the system requests a new netlist.  Otherwise,
we end up with different results from the first to second updates.
 2019-05-21 19:31:59 -07:00
Seth Hillbrand 68451a2a9c eeschema: Don't free pointers held by undo stack 2019-05-21 16:19:48 -07:00
Seth Hillbrand a62a89eac3 EAGLE: Prevent numeric-only component references 
KiCad does not allow references to be numeric only.  This prefixes such
references with "UNK" to note that the reference designator type is
unknown.
 2019-05-21 13:49:18 -07:00
Wayne Stambaugh 691f05273e Eeschema: replace invalid characters when converting from text to label. 
Fixes lp:1829664

https://bugs.launchpad.net/kicad/+bug/1829664
(cherry picked from commit 0403437ad0)
 2019-05-21 07:36:21 -04:00
jean-pierre charras 62a5302bc4 Fix issues created by commit cbb0d74bd5. 
This commit redirected too many menuitem IDs to the tool manager.
Only some context menu items have to be redirected, not all inside ACTION_EVENT events.

This hack is not perfect. It needs a better handling of ACTION_EVENT handling.
 2019-05-21 12:48:37 +02:00
Jon Evans c5f8a6b26e Add a nicer bus / net name validator 2019-05-20 22:52:39 -04:00
Jon Evans 1401d8a8ea Revert "Allow commas in group bus signal lists" 
This reverts commit cc290715a2.

(pushed accidentally; then decided behavior should be different)
 2019-05-20 19:28:32 -04:00
Tomasz Włostowski bc52f0a03b eemodern: clean printf debug gibberish, implement inline drag, move & cursor warp/reference point options 2019-05-20 21:04:46 +02:00
Tomasz Włostowski af30eca3cb eemodern: hover selection should autoclear after invoking properties dialog 2019-05-20 21:04:46 +02:00
Tomasz Włostowski aff3243f3b eeschema: fix use-after-free crash in GetScreen()/GetCurrentSheet() 2019-05-20 21:04:46 +02:00
Tomasz Włostowski 034669bf30 eemodern: implement drag-related settings in the Preferences window 2019-05-20 21:04:46 +02:00
Tomasz Włostowski 5ea46e8b78 eemodern: initial attempt at inline drag/move actions 2019-05-20 21:04:46 +02:00
Jon Evans 9d56102210 Prevent unannotated components from driving connectivity 
Fixes: lp:1829301
* https://bugs.launchpad.net/kicad/+bug/1829301
 2019-05-19 11:40:24 -04:00
Jon Evans cc290715a2 Allow commas in group bus signal lists 2019-05-19 11:09:25 -04:00
Jeff Young 813de6a1f3 Implement brightening for Eeschema Find/Replace. 2019-05-18 14:28:22 +01:00