Commit Graph

1003 Commits

Author SHA1 Message Date
Wayne Stambaugh fcc497509a Don't treat project Save As path as a path and file name.
The single string ctor of wxFileName treats the string as a path and file
name.  If there is a dot in the last path name, it assumes that the last
path is actually a file name and extension.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/10116
2021-12-26 17:02:54 -05:00
Jeff Young c3552a940a Make sure standard OK/Cancel buttons respond to current language.
Fixes https://gitlab.com/kicad/code/kicad/issues/9635
2021-12-24 18:13:11 +00:00
Jeff Young 84a9732497 PCM strings. 2021-12-24 18:13:06 +00:00
Jeff Young d28714167c All the preferences, all the time.
Fixes https://gitlab.com/kicad/code/kicad/issues/7877

Fixes https://gitlab.com/kicad/code/kicad/issues/5153
2021-12-24 13:08:44 +00:00
jean-pierre charras 40752afafd DIALOG_TEMPLATE_SELECTOR: Force display refresh after selecting a path
For some reason the panel showing the templates did not show the new selection
Fixes #10106
https://gitlab.com/kicad/code/kicad/issues/10106
2021-12-24 11:40:20 +01:00
Seth Hillbrand a4db439cf8 Move quitting flag to manager quit
The flag is to protect against the frame going out of scope with the
references intact.  This shouldn't be in CloseProject because we close
the project without removing the frame.  Instead, placing it in OnExit
gets set correctly when closing the whole project manager

Fixes https://gitlab.com/kicad/code/kicad/issues/10018
2021-12-17 13:10:27 +00:00
jean-pierre charras 0f728e4d67 Fix some issues in PCM code.
Try to fix 9955, due to a problem with WX_PROGRESS_REPORTER (issue with its parent)
Fixes #9955
https://gitlab.com/kicad/code/kicad/issues/9955
2021-12-12 18:25:31 +01:00
jean-pierre charras 3a04a1ee64 Fix incorrect use of NULL (aka nullptr on wxWidgets) instead of 0 2021-12-12 09:09:50 +01:00
Jeff Young 329f00acdc Fix logic error in Save As recursion guard.
Fixes https://gitlab.com/kicad/code/kicad/issues/9916
2021-12-09 17:04:40 +00:00
jean-pierre charras 0ba11e9856 Kicad manager: minor cosmetic enhancement: show a busy cursor when launching an editor 2021-12-06 20:03:31 +01:00
Ian McInerney ab797d191f Disregard the project manager window size on migration
An old size for the window could cut off the PCM button if it were
migrated, so to ensure the button is visible, just always use a fresh
window size on migration.

Fixes https://gitlab.com/kicad/code/kicad/issues/9649
2021-12-03 01:43:53 +00:00
Seth Hillbrand 84cfa052a1 Unify KiCad Manager title bar versions 2021-11-29 16:19:37 -08:00
Jon Evans fca3367873 PCM: Disable actions while task manager is open
Fixes https://gitlab.com/kicad/code/kicad/-/issues/9788
2021-11-27 08:46:19 -05:00
jean-pierre charras d03a13b8d8 Kicad and PCM: fix some (minor) issues:
- do not use KICAD_MANAGER_CONTROL::Execute() to run PCM: it is not an external app.
- add a workaround to avoid keeping incorrect focus on buttons in PANEL_KICAD_LAUNCHER.
Fixes #9780
https://gitlab.com/kicad/code/kicad/issues/9780
2021-11-26 10:52:52 +01:00
qu1ck 78aa76d0e6 PCM: reuse download prrogress dialog 2021-11-25 21:23:23 +00:00
Jon Evans 250de83bf2 Prevent divide-by-zero in DIALOG_PCM_PROGRESS 2021-11-25 16:23:16 -05:00
Jeff Young ba6ae4fa9b Kicad has many plugins. This one is for the pcb. 2021-11-25 12:56:46 +00:00
Wayne Stambaugh 802cfc1a7d Don't allow project files to be renamed or deleted in project tree pane.
This prevents any potential breakage of a project due to the file changes.
It is overly zealous because the project manager doesn't actually have any
knowledge of which files belong to the project.

Fixes: https://gitlab.com/kicad/code/kicad/-/issues/9654
2021-11-19 11:39:24 -05:00
Jeff Young c01649fc6e Make it easier to open legacy files. 2021-11-19 13:36:14 +00:00
jean-pierre charras cc339e56a2 Kicad manager: fix a minor cosmetic issue when clicking on a launcher button.
- On GTK the next button was gaining the focus.
- On MSW the button disappears a bit of time.
Fixes #9676
https://gitlab.com/kicad/code/kicad/issues/9676
2021-11-18 13:44:23 +01:00
jean-pierre charras cf334b1ebb PCM: fix a minor cosmetic issue when resizing the dialog.
Fixes #9647
https://gitlab.com/kicad/code/kicad/issues/9647
2021-11-18 10:57:52 +01:00
Seth Hillbrand a699cccaaf Fix two string issues
Comp -> Compatible
Update string reference to changed string
2021-11-16 10:38:56 -08:00
Seth Hillbrand f950d96324 Prevent dereferencing frame on exit
Processing a menu event for quitting results in the frame being
destroyed.  This crashes the program when it tries to access the newly
freed frame to check for autosave data.  We bind the closing flag into
the base program which will be the last item freed on exit to ensure we
can correctly check for data loss

Fixes https://gitlab.com/kicad/code/kicad/issues/8638
2021-11-15 10:07:28 -08:00
qu1ck 6264dd40ea PCM: don't ignore schema validation errors 2021-11-15 13:46:05 +00:00
qu1ck 2340f82091 Fix empty space in pcm packages view 2021-11-15 10:44:17 +00:00
Jeff Young 47cb7f53fd Stope event propagation when closing project.
Fixes https://gitlab.com/kicad/code/kicad/issues/8638
2021-11-15 00:13:09 +00:00
qu1ck 338d13c1b5 PCM models -> 3dmodels 2021-11-14 15:08:28 -08:00
Jeff Young 5da876af26 Another attempt to fix the inactive scrollbar on GTK.
Fixes https://gitlab.com/kicad/code/kicad/issues/9559
2021-11-14 20:47:25 +00:00
Jeff Young 9bb5310fa5 Implement distructive-button-spacing as per Mac UI guidelines. 2021-11-14 20:33:32 +00:00
Jeff Young 66d9e7073f More discrete borders for Kicad mgr, PCM and appearances panels.
Fixes https://gitlab.com/kicad/code/kicad/issues/9616
2021-11-14 15:01:44 +00:00
Jeff Young 36fd62ccdc Another round of beautification changes for PCM.
Fixes https://gitlab.com/kicad/code/kicad/issues/9616
2021-11-14 13:11:19 +00:00
qu1ck bef43f975d Increase pcm package id allowed length to 100 2021-11-13 13:34:15 -08:00
Jeff Young e3ddc412d2 Better selection colour for PCM packages. 2021-11-13 19:45:10 +00:00
Mikolaj Wielgus 0b59246279 PCM: Select the preferred version first in version grid 2021-11-13 18:02:16 +00:00
Mikolaj Wielgus 0e4e9206ff PCM: Make version grid only selectable by rows, not individual cells
And select the first row from the top by default.
2021-11-13 18:02:16 +00:00
Mikolaj Wielgus 00aa4f3393 PCM: Disable Download, Install buttons when they're non-functional
Fixes https://gitlab.com/kicad/code/kicad/issues/9584
2021-11-13 18:02:16 +00:00
jean-pierre charras b3d44515c9 PCM: call finishDialogSettings(); to run sizer final calculations in dialogs 2021-11-13 15:21:43 +01:00
Jeff Young 2f99621bd3 Fix some layout issues; change packaage highlight scheme. 2021-11-13 11:21:29 +00:00
Mikolaj Wielgus 921105330a Remove printing files from Project Manager 2021-11-12 20:18:32 +00:00
Mikolaj Wielgus aa0a00dee7 PCM: Auto select on download/install if there is only one version 2021-11-12 19:05:27 +00:00
Jeff Young 2515948a7b Jiggle things around to have fewer fixed sizes.
Also adds some code to re-calc the package panel heights to
hopefully get around larger fonts getting clipped.
2021-11-12 15:31:41 +00:00
Jeff Young 43b840d9d2 Clean up download progress vs package progress vs overall progress. 2021-11-12 11:18:11 +00:00
Jeff Young a22dd614b0 Fix type that can lead to deadlock. 2021-11-12 10:49:14 +00:00
Jeff Young 0b48876ce5 Decouple left and right pane minimums for splitter window. 2021-11-12 02:12:44 +00:00
Jeff Young faabcc079a Sniff URLs in descriptions and be more defensive re MSW scrolling. 2021-11-12 00:39:47 +00:00
Jeff Young f9bbaed7a1 Enable URLs in PCM metadata.
Going to HTML_WINDOW also sidesteps the bullet size issue between
platforms.
2021-11-11 23:42:28 +00:00
Jeff Young 8777135d9f Try to make window backgrounds the same on Windows.
Also reduces the use of auto.
2021-11-11 14:02:40 +00:00
Jeff Young c3c2af9cd0 Improve bullets on Mac & GTK; improve scrollbar behaviour on MSW. 2021-11-11 11:33:28 +00:00
Jeff Young 78bedbed93 Update progress during InstallFromFile. 2021-11-11 10:17:53 +00:00
Jeff Young cc938e7a67 Fix a few issues in the PCM dialog tune-up. 2021-11-11 01:03:07 +00:00
qu1ck 54e9f1cf24 Fix pcm fallback loading
Need to add a fake version otherwise the package gets filtered out of
the packages view.
2021-11-10 23:48:54 +00:00
Jeff Young b408cda0b8 Uninitialized variables. 2021-11-10 23:42:33 +00:00
qu1ck d9bd7ed2c1 Fix incorrect include 2021-11-10 15:06:11 -08:00
Jeff Young 59e5c836fc Tighter thread safety for PCM progress dialog. 2021-11-10 22:12:22 +00:00
Jeff Young 7b4d5b2312 Fix wxWidgets annoying assert. 2021-11-10 18:29:43 +00:00
Jeff Young f036243142 Fix a few minor issues in PCM dialogs. 2021-11-10 16:19:13 +00:00
Jeff Young 5c0befa880 Use sdbSizer so buttons are in right platform order. 2021-11-10 13:32:10 +00:00
Jeff Young 7211c5a350 Kicad look & feel and reduce conceptual nesting depth of PCM. 2021-11-10 12:42:54 +00:00
qu1ck 97a4034d95 Coverity report and compile warning fixes 2021-11-10 03:24:14 +00:00
Jon Evans 89f5842a17 PCM: Fix loading bitmaps from installed packages 2021-11-09 21:44:57 -05:00
Jon Evans 8e2d599751 Allow PCM to load schema from build dir 2021-11-09 21:44:40 -05:00
Mikolaj Wielgus ae37ae7072 PCM: Prevent crash on clicking "Install" when there is no versions
Fixes https://gitlab.com/kicad/code/kicad/issues/9585
2021-11-10 02:19:17 +00:00
Jeff Young 27661edff6 Apply a bit of Kicad look & feel.
Also fixes a spelling error in a string.
2021-11-10 01:11:27 +00:00
Jon Evans beb1ad0098 Use actual package ID when searching m_installed
Fixes https://gitlab.com/kicad/code/kicad/-/issues/9583
2021-11-09 20:07:22 -05:00
Jeff Young e860f9f9a9 Use correct dir when writing project file before Save As. 2021-11-09 20:57:58 +00:00
Jeff Young bc30ee85c0 Make sure JSON contents are in memory before saving.
Fixes https://gitlab.com/kicad/code/kicad/issues/9582
2021-11-09 20:17:56 +00:00
Jeff Young d4e3e67b8d Update kicad_prl file when doing a SaveAs.
Fixes https://gitlab.com/kicad/code/kicad/issues/9455
2021-11-09 17:25:18 +00:00
Seth Hillbrand 2d66b6fd3e Cound't -> Couldn't 2021-11-08 15:56:51 -08:00
Seth Hillbrand 905c72cec6 Repositores -> Repositories 2021-11-08 15:56:51 -08:00
jean-pierre charras 452b9bacba DIALOG_MANAGE_REPOSITORIES: fix crash on exit:
A event handler was pushed but not pop-ed.
Fixes #9551
https://gitlab.com/kicad/code/kicad/issues/9551
2021-11-08 17:14:48 +01:00
Jon Evans ed3642c5c7 PCM: reverse-transform package ID when loading fallback 2021-11-07 21:31:51 -05:00
Jon Evans e48811189c Fix PCM and plugin loading for namespaced plugins 2021-11-08 01:59:28 +00:00
qu1ck d84cea58a4 Update pcm schema
1. Allow dots in package id for namespacing requirements
2. Add regex anchoring to force matching whole string
3. sha hex digest can only have [a-f0-9] chars
2021-11-07 12:41:57 +00:00
Jon Evans f847a76ac3 Update schema ID to use redirect URL 2021-11-06 11:11:20 -04:00
Seth Hillbrand cf6b18ec7e Remove escaped double-quotes
For some reason, escaped double quotes in wxString::Format cause issues
on Mac.  We can replace them with single quotes in most places without
loss of clarity
2021-11-03 17:03:14 -07:00
Jeff Young c8a8efa67b Save as for current version project files.
Fixes https://gitlab.com/kicad/code/kicad/issues/9455
2021-10-30 23:01:53 +01:00
Jeff Young 8a8775bed8 Remove another use of non-argv wxExecute
(Fixes supplied by mwielgus.)
2021-10-15 12:45:43 +01:00
Jeff Young 1b6c4638ca Escape quotes to prevent break-out.
Fixes https://gitlab.com/kicad/code/kicad/issues/9236
2021-10-13 17:17:57 +01:00
Mikolaj Wielgus 5f53019290 Substitute all wxHtmlWindow with HTML_WINDOW
Remove other places where <body> tag is used to override the default
black-on-white theme.
2021-10-12 07:07:15 +00:00
jean-pierre charras e508e08ecf Kicad manager: Fix some issues in DIALOG_TEMPLATE_SELECTOR. The fix is not perfect, but it works. Fixes #9329 https://gitlab.com/kicad/code/kicad/issues/9329 2021-10-08 13:15:11 +02:00
Seth Hillbrand 9a8d1246cc We don't keep a CHANGELOG.TXT
Direct interested readers to AUTHORS.TXT instead.
2021-10-05 19:46:53 -07:00
Jeff Young b6d723e44e The parameterized interface doesn't like its parameters quoted. 2021-09-30 19:10:23 +01:00
Jeff Young c05e4376f9 Update backups folder name when doing project save as.
Fixes https://gitlab.com/kicad/code/kicad/issues/9254
2021-09-27 13:24:45 +01:00
Jeff Young 7bafbf9ca7 Fix one more fixed size value in the template selector. 2021-09-27 00:23:40 +01:00
Jeff Young 665eeb65e9 Make layout of project template browser more flexible.
In particular, don't use a fixed height for the templates chooser,
and Wrap() must be called again whenever the text is changed.

Also moves the buttons to icon buttons.

Fixes https://gitlab.com/kicad/code/kicad/issues/9241
2021-09-26 18:40:18 +01:00
Jeff Young 5bf042fcc1 Use individual parameter version of wxExecute.
Fixes https://gitlab.com/kicad/code/kicad/issues/9236
2021-09-26 15:03:06 +01:00
Jeff Young c6bcb85562 Excise system() calls.
Fixes https://gitlab.com/kicad/code/kicad/issues/9236
2021-09-25 20:09:06 +01:00
Jeff Young 23c76cccf3 Give a timeslice to show Save Changes? dialog before things get ugly.
This also moves closing the existing project earlier to improve the
workflow -- so there's a chance that the main fix might not be needed
anymore, but it's still safer to not have a control-flow that crashes
rather than to just not use that control-flow.

Fixes https://gitlab.com/kicad/code/kicad/issues/9200
2021-09-21 11:14:42 +01:00
Seth Hillbrand c088de5f75 Fix compile issues on non-mac 2021-09-19 08:41:10 -07:00
Jeff Young 6e7ce09572 Use more descriptive terminology for preferred text editor.
Also improves execution to allow the preferred editor to include
parameters, such as "/usr/bin/open -e".

Fixes https://gitlab.com/kicad/code/kicad/issues/9131
2021-09-19 15:17:26 +01:00
Jeff Young b84d1456d5 KIFACE_I -> KIFACE_BASE. 2021-09-14 23:45:14 +01:00
Jeff Young 7a993c0211 Add support mode for dark mode to SCINTILLA_TRICKS.
Also removes the return value from the BITMAP_STORE's themeChanged
method as it will provide the wrong answer for the second frame it's
called on.

Also hooked up ACTION_TOOLBAR, the app launcher, and the project tree
to the wx event for system color changes so they change on the fly.

Fixes https://gitlab.com/kicad/code/kicad/issues/6026
2021-09-14 00:18:50 +01:00
Jeff Young a5247471f7 Expunge a bunch more fixed font specs from wxFormBuilder files.
Also removes the -1 sizing of the status bar on GTK and MSW.

Fixes https://gitlab.com/kicad/code/kicad/issues/8608
2021-09-12 13:53:12 +01:00
Jeff Young 9c78e4cf54 Mac needs different font size handling than MSW & GTK.
Mac already uses diverse font sizes (for instance, smaller fonts for
radio button groups), and the anti-aliasing is a lot better.  The
other platforms need a more limited range of sizes.

Fixes https://gitlab.com/kicad/code/kicad/issues/8608
2021-09-11 23:40:31 +01:00
Jeff Young 769ca2d255 Add a quantized scaling mode for bitmaps.
125% scaled bitmaps look bad in the Launcher so we pin to 100%,
200%, 300%, etc.
2021-09-11 23:40:31 +01:00
Jeff Young fbee62fc15 Tie font size scaling to when automatic icon scaling fails.
It appears that SetSymbolicSize() and ConvertDialogToPixes() fail
under the same circumstances.
2021-09-11 15:29:51 +01:00
Jeff Young ad59254be8 Another round of font sizing tweaks.
It appears that both strategies in the last commit worked, leaving us
with squared scaling.  The dialog pixel architecture seems safer than
our icon scaling stuff, so this version attempts to use only it.

Also works around a bug where wxELLIPSIZE_MIDDLE doesn't work on Mac.

Fixes https://gitlab.com/kicad/code/kicad/issues/8608

Fixes https://gitlab.com/kicad/code/kicad/issues/8375
2021-09-10 21:46:13 +01:00
Jeff Young 7a822b55aa Another round of changes to attempt to fix the GTK font size issue.
Fixes https://gitlab.com/kicad/code/kicad/issues/8608
2021-09-10 15:59:50 +01:00
Jeff Young 7a035e2675 More font scaling changes.
These may or may not fix scaling issues on GTK with HiDPI monitors.
2021-09-09 11:17:21 +01:00
Wayne Stambaugh ad1ee958b0 Code cleaning. 2021-09-07 15:18:42 -04:00