Seth Hillbrand
4d8269c5fd
Correct usage signature for PNS_NODE::Add()
...
When moving a unique_ptr, you are actually passing the object, not a
reference to the object. So we either std::move with the bare
unique_ptr parameter or we pass a reference. But we should never pass
an rvalue reference for this or we'll make a copy without holding the
tracking (because it was moved)
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16839
(cherry picked from commit b2a25cb59e
)
(cherry picked from commit 38df918993
)
2024-03-01 14:46:40 -08:00
Seth Hillbrand
99ac73630a
Do not re-number aperture pads
...
Aperture pads do not have numbers, so reserving space for them will
cause the actual numbered pads to become out of order
(cherry picked from commit d3334ed9f0
)
2024-03-01 13:05:06 -08:00
Jeff Young
cd5827a694
Check env vars when testing for unresolved variables.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17174
(cherry picked from commit 27031dd2c5
)
2024-02-29 18:18:39 +00:00
Jeff Young
a32e7a44e3
Unflip when going to viewport which isn't flipped.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/13773
(cherry picked from commit c23550dc0b
)
2024-02-29 18:18:39 +00:00
jean-pierre charras
5eb265080f
try to cherry pick commit 7fd9226bec
from master:
...
Fix issue in CalcArcCenter( VECTOR2D& aStart, VECTOR2D& aMid, VECTOR2D& aEnd )
It happens when the segment (aStart, aMid) is horizontal
Probably also when the segment (aEnd, aMid) is horizontal
Slopes with value 0.0 are set to double:: epsilon(), but it was a too small values
generating broken calculations.
Now set to 1e-10 (it seems working).
Fixes #16089
https://gitlab.com/kicad/code/kicad/-/issues/16089
2024-02-19 15:52:37 +01:00
Jon Evans
780df7262b
Re-enable non-KiCad board import when non-standalone
...
Partial revert of 37ac2ee0a
2024-02-15 12:16:16 -05:00
jean-pierre charras
8871b0385d
Gerber drill file: do not flash oblong holes: they must be routed.
...
Fixes #16962
https://gitlab.com/kicad/code/kicad/-/issues/16962
2024-02-14 09:30:11 +01:00
Mark Roszko
479b3e6c72
Add some missing newlines to cli output
2024-02-12 02:16:48 +00:00
Marek Roszko
27c573ca42
Fix crash if we exit lib table setup
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16917
(cherry picked from commit 6a37f99e94
)
2024-02-12 02:06:33 +00:00
Jon Evans
37ac2ee0a3
Guard actions that change project against running in non-standalone mode
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16942
(cherry picked from commit ec2cd99405
)
2024-02-11 09:44:46 -05:00
Jeff Young
f671f4db51
Re-use ERC's delete-exclusions-query dialog for DRC.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16914
(cherry picked from commit 91e15634fc
)
2024-02-09 16:20:38 +00:00
Alex
fc0911f55e
DXF import: INSERT angles are in degrees.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16656
(cherry picked from commit 767ab72cdb
)
2024-02-01 21:09:09 +03:00
Alex
b74fef1b10
Altium PCB: support polygon id 65534 for keepout tracks on board outline.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16849
(cherry picked from commit 285067dad1
)
2024-02-01 20:59:20 +03:00
Mark Roszko
585693f0b3
Explicitly add 48, 128, 256 to icon bundles for each app
2024-01-30 20:58:05 +00:00
jean-pierre charras
35094a786d
PANEL_PCBNEW_COLOR_SETTINGS: ensure color setting for all DRC markers are in list
...
From master branch.
Fixes #16674
https://gitlab.com/kicad/code/kicad/-/issues/16674
2024-01-23 13:39:34 +01:00
Jeff Young
a25888b4ba
Partial cherry-pick of d6b39c672e
2024-01-21 23:10:18 +00:00
Jeff Young
7f3508b8b3
Don't query first item of empty vector.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16687
(cherry picked from commit 6fca467e2a
)
2024-01-21 23:10:18 +00:00
Jeff Young
c855702918
Selective cherry-pick from 13935399a5
2024-01-20 22:38:01 +00:00
Jeff Young
51023a1ae4
Make sure imported graphics layer is visible.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16642
(partially cherry picked from commit 57315dd625
)
2024-01-18 14:10:55 +00:00
Jeff Young
35364bd8ad
Support point editing of inverted rectangles.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16595
(cherry picked from commit 455fae45d8
)
2024-01-17 15:31:17 +00:00
Jeff Young
0f715223e9
Restore preferential selection treatment for silk items.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16607
(cherry picked from commit df48ebfbe7
)
2024-01-17 14:11:39 +00:00
Jeff Young
0b1065ff55
Knockout different-net dimensions in zone-filler.
...
(By-hand cherry-pick of 435e60d0e54826f799ed1580c616e82e0199c460.)
2024-01-10 17:01:13 +00:00
jean-pierre charras
ace6439758
LIB_TEXTBOX: fix incorrect line style in plot function for LINE_STYLE::DEFAULT.
...
LINE_STYLE::DEFAULT is fixed as SOLID in all plot functions, but not for this item.
From master branch
Fixes #16543
https://gitlab.com/kicad/code/kicad/-/issues/16543
2024-01-07 16:19:33 +01:00
Roberto Fernandez Bautista
32cc486d89
Handle bitmap (reference image) selection correctly
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16522
2024-01-05 00:20:32 +01:00
Jeff Young
d33fbd8e47
Do NOT return false from a visitor unless you want to stop visiting!
...
This fixes a bug where DRC would bail out early if any of
the colliding objects was a free pad.
2024-01-04 13:24:38 +00:00
Roberto Fernandez Bautista
39236ae68f
CADSTAR PCB: Fix build. BuildLibName() doesn't exist in 7.0
2024-01-04 01:01:26 +01:00
Roberto Fernandez Bautista
5ee89b41ac
CADSTAR PCB: Handle multi-layer figures & fix multi-layer mapping
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16515
2024-01-04 00:55:55 +01:00
Roberto Fernandez Bautista
ec0ff4ffc2
CADSTAR PCB: Handle multi-layer library coppers correctly
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16486
2024-01-04 00:55:54 +01:00
Wayne Stambaugh
1b6b2d7896
Fix crash when importing Eagle board file with no "classes" element.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16504
2024-01-03 10:16:28 -05:00
Jeff Young
036241c819
More explicit pad-missing message when net involved.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16489
(cherry picked from commit 15a2d65a0c
)
2024-01-01 10:54:38 +00:00
Jeff Young
85f4ab3944
Attempt to fix borked build....
2023-12-29 16:41:59 +00:00
Jeff Young
25db3032ee
Add missing DRC auto-complete token.
...
(cherry picked from commit 2ba9e07f0f
)
2023-12-29 14:08:07 +00:00
Jeff Young
d638f4cad0
Record nested footprints for collision checking.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16410
(cherry picked from commit 6a5adc7646
)
2023-12-29 14:07:27 +00:00
Jeff Young
32fe612045
Handle units switch in board stackup.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16361
(cherry picked from commit c051e66830
)
2023-12-29 14:07:07 +00:00
Jeff Young
874f7fbdff
Prevent copy-elision issues by using smart-pointer.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16335
(cherry picked from commit e801e793dc
)
2023-12-11 17:27:16 +00:00
jean-pierre charras
0d330051ed
Pcbnew: draw shadow PCB_SHAPEs for locked items using continuous lines.
...
Using other shapes gives really strange and ugly results.
From master branch
Fixes #16327
https://gitlab.com/kicad/code/kicad/-/issues/16327
2023-12-10 15:51:14 +01:00
Jeff Young
f17c4cceac
Back-port bugfix from master.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16315
2023-12-09 14:54:24 +00:00
jean-pierre charras
e3d45fb37b
Fix compil issue (change PCB_REFERENCE_IMAGE_T to old name PCB_BITMAP_T)
2023-12-07 17:50:45 +01:00
Jeff Young
e3369608fd
Add missing case to Selectable().
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16283
(cherry picked from commit aa046345eb
)
2023-12-07 14:04:43 +00:00
Alex Shvartzkop
1c6390f829
Don't crash when OCC fails to read a model and didn't open the doc.
...
(cherry picked from commit 9345b73af5
)
2023-12-06 03:18:26 +03:00
Seth Hillbrand
df64a6c583
Handle FP polygons in DRC check
...
Iterator points are relative to the footprint
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16266
2023-12-05 16:07:57 -08:00
jean-pierre charras
e05b3955a5
Gerber export: fix incorrect shape of round rect pads on paste layers in some cases.
...
They can be plotted as rect shape depending on margin value.
From master branch.
Fixes #16257
https://gitlab.com/kicad/code/kicad/-/issues/16257
2023-12-04 13:06:25 +01:00
Jeff Young
af99c9da34
Don't use epsilon when calculating pushout force in dp placer.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16210
(cherry picked from commit ff9d834e31
)
2023-12-03 17:24:45 +00:00
Jeff Young
dbf5455656
Update message panel after switching layers.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16247
(cherry picked from commit a1b514bcba
)
2023-12-03 17:10:30 +00:00
Ian McInerney
60d23b14e7
Plot footprint edgecuts in PDF drill map file
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15247
(Cherry-picked from e5f688e865
)
2023-12-03 11:55:11 +00:00
Seth Hillbrand
12fdeac31c
Re-implementation of 8b3ac316
...
Update GenCAD export to handle arbitrary outline
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15961
2023-12-02 17:15:39 -08:00
Jeff Young
69a1a4611b
Fill empty zones when auto-fill is on.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16234
(cherry picked from commit 1618beba2c
)
2023-12-02 20:17:41 +00:00
Jeff Young
5f8a0b0728
Import a few more rules from Altium board files.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15585
(cherry picked from commit 6a2aeeeae2
)
2023-12-02 16:20:34 +00:00
Seth Hillbrand
7cb98f6856
Check for actual dirty flag
...
Looking at the address will always return true
2023-12-01 09:31:48 -08:00
Seth Hillbrand
fc86de34f8
Add default parameter to GetEffectivePolygon()
...
Allows legacy plugins to use this function
(cherry picked from commit 6b3ac54a41
)
2023-12-01 09:28:13 -08:00