4e5febdb19
Fixes the import pin issue, that the they are shown in two different way https://gitlab.com/kicad/code/kicad/-/issues/11391
2022-05-22 04:42:22 +00:00
8e94c307d2
Provide default case for mirroring single objects.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11649
2022-05-21 22:50:55 +01:00
d381fd8b29
Typo.
...
LIB_SYMBOL's value field is the name; SCH_SYMBOL's value field is not.
Fixes https://gitlab.com/kicad/code/kicad/issues/11556
2022-05-20 18:01:01 +01:00
23fb4c7433
Uniformly use a single facility for location-less prime events.
...
Also implements a uniform mechanism for avoiding auto-scroll after
a prime event or dialog which results in a mouse position at the
edge of the canvas.
Fixes https://gitlab.com/kicad/code/kicad/issues/11057
2022-05-16 23:43:00 +01:00
f2fc78f380
Don't copy modifiers to prime events.
...
The modifiers go with the hotkey, not with the action.
Fixes https://gitlab.com/kicad/code/kicad/issues/11618
2022-05-16 13:51:40 +01:00
359c99991b
Eeschema: do not leave a temporary flag set after use in draw symbol function.
...
Fixes #11617
https://gitlab.com/kicad/code/kicad/issues/11617
2022-05-15 18:35:07 +02:00
9049c907a1
Fix wxWidgets assert in symbol preview widgets
2022-05-15 15:26:53 +01:00
79a0ce9137
Unset forced cursor before leaving two-click place.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11607
2022-05-14 22:38:54 +01:00
38e5faf21b
Overhaul bitmap text for performance.
...
Also adjusts metrics to better match stroke font.
Also removes text-halo highlighting as it's too expensive to re-render
when the zoom changes.
Fixes https://gitlab.com/kicad/code/kicad/issues/11460
2022-05-14 20:09:54 +01:00
5802ede3fd
Change default value of MatchByReference to false.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11382
2022-05-14 12:41:25 +00:00
88c7322a0d
EDA_TEXT Get/SetTextSize should use VECTOR2I
2022-05-14 08:16:15 -04:00
45b167dff5
Some fixes related to translated/not translated mandatory field names. DIALOG_SYMBOL_FIELDS_TABLE: add new fields to symbols only if the field is not empty.
2022-05-13 11:45:38 +02:00
20d1d0705e
Fix a few issues related to field names and their translation. - Do not use translated field names outside strings displayed in dialogs. - fix code that does not work well with default locale. - fix some (not all) I18n issues in DIALOG_UPDATE_SYMBOL_FIELDS.
2022-05-13 11:45:37 +02:00
bbc250720f
Resolve title variable when plotting
...
Be sure to use variable name if it exists when plotting the file
Fixes https://gitlab.com/kicad/code/kicad/issues/11608
(cherry picked from commit d971cbefcb
2022-05-12 15:31:15 -07:00
b68514afb1
Fix a wxWidgets alert.
2022-05-12 20:58:48 +02:00
5c4f49351d
Remove extra compilation of common.cpp
...
It's already built in the common target, no eeschema specific code
2022-05-10 21:31:31 -04:00
f85251ef75
Fix eda_doc not looking for schematic locally
...
It looks like this was overlooked by Jeff in 2020 not realizing eda_doc isn't built under eeschema but common in cc9ac37a0e
2022-05-10 21:28:48 -04:00
ad066ef09a
Fix cross-probing in complex hierarchies, remove unused code.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11493
2022-05-09 23:22:03 +03:00
4bd349d922
Update some demos
2022-05-09 19:06:14 +02:00
b7a77a9498
Schematic: Add CSV export to Symbol Fields Table
2022-05-09 12:02:12 -04:00
8f937b17a2
Remove wxWidgets 3.0.x hack.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11540
2022-05-07 23:24:55 +01:00
f9f0f6fe24
Implement cross-references for labels.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11564
2022-05-07 21:10:04 +01:00
5cd3c07862
Catch throws in DeleteSymbol
...
DeleteSymbol may call SaveSymbol if the name is changed. In this case,
SaveSymbol may throw back and needs to be caught
Fixes https://gitlab.com/kicad/code/kicad/issues/11566
(cherry picked from commit e05c8f8852
2022-05-06 16:13:59 -07:00
7e20c0ed9c
eeschema: removed unused code
...
Fixes #11533
2022-05-06 17:17:55 +00:00
a644aad1cf
Hand-code tab navigation from value field of Label Properties dialog.
...
wxWidgets doesn't appear to handle it correctly, doing nothing on OSX
and potentially crashing on GTK.
Fixes https://gitlab.com/kicad/code/kicad/issues/11572
2022-05-06 18:14:25 +01:00
5f7ac58f95
Catch errors when saving individual symbols
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11566
(cherry picked from commit f4d4f23876
2022-05-06 09:55:28 -07:00
a19490b097
Eeschema: fix broken project symbol rescue.
...
The legacy symbol library plugin code was changed to escape symbol names
which broke the LIB_ID string comparison when checking to see if symbols
needed to be rescued. Escaping the LIB_ID names before comparison resolves
the issue.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/11563
2022-05-06 08:50:09 -04:00
32077673e8
Symbol editor crash: Fix use of a null pointer.
...
LIB_TEXT::Clone() did not copy a member set to nullptr.
Fixes #11569
https://gitlab.com/kicad/code/kicad/issues/11569
2022-05-06 12:51:26 +02:00
1751c8e1cf
Save selection *before* clearing it. Saving after doesn't do much good.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11242
2022-05-06 00:06:00 +01:00
9c5aa5c3c1
Font and color for FIELDS_GRID_TABLE.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11459
2022-05-06 00:06:00 +01:00
e80c5a4e4e
Add text colour to Edit Text & Graphics Properties.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11459
2022-05-06 00:06:00 +01:00
bd7447cff3
Fix variable name
...
This is the top left position, not the top right.
2022-05-05 10:27:19 +00:00
f14dc9e305
Don't plot private symbol text.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11548
2022-05-03 19:41:20 +01:00
babfb29c54
Formatting cleanup.
2022-05-03 13:39:14 +01:00
67f352717e
Fix dodgy type-cast and init line-widths to "inherit".
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11535
2022-05-03 13:39:14 +01:00
3f470359a2
Eeschema, backannotate: fix minor issues in displayed messages.
...
Fixes #11530
https://gitlab.com/kicad/code/kicad/issues/11530
2022-05-03 09:20:46 +02:00
a56955443f
Fix botched commit
...
(cherry picked from commit ba276fe470
2022-05-02 16:29:07 -07:00
2079d15b3f
Catch IO_ERRORs that we throw
...
FILEOUTPUT_FORMATTER likes to throw when it gets an issue. We need to
catch this to avoid the app falling apart
Fixes https://gitlab.com/kicad/code/kicad/issues/11516
(cherry picked from commit 4d47857738
2022-05-02 15:15:52 -07:00
f6f316bd8c
Promote field selection to field-owner for Autoplace.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11529
2022-05-02 20:11:21 +01:00
d2610736ff
Fix bugs with printing bordered shapes.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11536
2022-05-02 19:45:55 +01:00
585ea85f95
LIB_SHAPE default line style is SOLID, not DASHED.
...
(Copy/paste error from SCH_SHAPE.)
Fixes https://gitlab.com/kicad/code/kicad/issues/11527
2022-05-02 17:22:13 +01:00
036d283433
Don't muck with linestyle default when setting it.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11520
2022-05-02 17:22:13 +01:00
804ab5609e
Add dash-dot-dot to Edit Text & Graphics Properties.
...
Also fixes a bug where textboxes and shapes weren't correctly updated.
Fixes https://gitlab.com/kicad/code/kicad/issues/11522
2022-05-02 17:22:13 +01:00
50223c9337
Eeschema print: Do not print private graphics in symbols.
...
Fixes #11532
https://gitlab.com/kicad/code/kicad/issues/11532
2022-05-02 16:29:08 +02:00
ece15b6472
Fix a compil warning (shadowed var).
2022-05-02 15:25:55 +02:00
dfa6b9ed15
Reset plotter dash-style after use.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11527
2022-05-02 13:21:46 +01:00
40c75c74fa
EEschema/Cvpcb: make assign footprints from CvPcb undoable.
...
Fixes #11508
https://gitlab.com/kicad/code/kicad/issues/11508
2022-05-02 12:49:14 +02:00
772bdc4bbf
Turn off auto-dialog for text objects when immediateActions == false.
2022-05-02 11:25:40 +01:00
de0bb26c4c
Init global label's intersheet ref's visibility from schematic settings.
2022-05-02 09:42:38 +01:00
7ebdb4853c
Do not open label edit dialog when adding label to an already named wire
2022-05-02 08:42:15 +00:00
6d44ca2145
Ellipsize long heirarchical paths.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11499
2022-04-30 14:09:30 +01:00
9fbf8e6f5d
Respect default layer color for textbox borders.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11497
2022-04-29 14:10:48 +01:00
dc1e063b00
Iron out some issues with linestyle handling in SCH printing and plotting.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11498
2022-04-29 13:52:30 +01:00
3589eb33f0
Handle text color when printing and plotting.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11491
2022-04-29 10:51:00 +01:00
2cccd5b090
Fix minor layout issue in dialog.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11490
2022-04-27 17:14:33 +01:00
8a97a46e6b
Release file before re-loading it for Revert.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11481
2022-04-26 22:28:35 +01:00
e0f2a5f07c
Update findnext to handle new instance data architecture.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11424
2022-04-26 20:21:15 +01:00
47e002a33d
Add font to status bar for text objects.
2022-04-26 18:52:53 +01:00
e6f11c5c39
Reset outline font if bold or italic changed.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11462
2022-04-26 12:52:29 +01:00
85680886f8
Adjust outline font SCH_TEXT positioning so it better matches SCH_FIELD text.
2022-04-26 12:52:29 +01:00
25474b347c
Fix frustration with mirroring autoplaced fields
...
When the user asks to mirror a symbol is is frequently to get the
reference/value on the other side of the symbol for placement purposes.
Autoplacing the fields here keeps the text where they were initially
which can be frustating to work around.
This commit treats the mirror command as a user request to change where
the fields are
2022-04-25 12:50:45 -07:00
1a70465927
Use instance data to store values
...
Previous use of instance was as an "override" of the default value.
This has changed to be used as the primary storage location for all
values. This means that we cannot clear the instance data when setting
a new value for all instances, instead we have to change the instance
data and the default value is superfluous
Fixes https://gitlab.com/kicad/code/kicad/issues/11439
2022-04-25 12:47:48 -07:00
f5d612eaed
Switch <insert> replacement on OSX to <f1>.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11413
2022-04-25 10:01:33 +01:00
90bfe2d94b
Remove Save Copy As from fp editor, and rename to Save a Copy elsewhere.
...
It's still used by Eeschema and PCBNew when not in stand-alone mode.
Fixes https://gitlab.com/kicad/code/kicad/issues/9185
2022-04-24 19:46:57 +01:00
6738708a7f
Disable background color when printing in black & white.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11180
2022-04-24 19:46:57 +01:00
52eb210aa8
Initialize virtual page no. to something more reasonable.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11295
2022-04-24 19:46:57 +01:00
3bc34590c7
Eeschema: fix missing call to UpdateMessagePanel() due to commit e09147db.
...
EE_INSPECTION_TOOL::UpdateMessagePanel was called by EVENTS::SelectedEvent
But This event after commit calls E_INSPECTION_TOOL::CrossProbe(),
and no longer UpdateMessagePanel.
So CrossProbe() now calls UpdateMessagePanel.
Fixes #11447
https://gitlab.com/kicad/code/kicad/issues/11447
2022-04-24 18:40:10 +02:00
c6f83b6dec
ADDED Duplicate Footprint, Rename Symbol and Rename Footprint.
2022-04-22 22:06:51 +01:00
b42365190e
Schematic/PCB: deleting fields sets them to invisible
2022-04-21 16:20:23 +00:00
eb1a238a53
Remove extra event handler.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11418
2022-04-20 16:19:42 +01:00
fc2eb2d7c9
Fix missing line keeping tabs from switching.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11417
2022-04-20 14:51:08 +01:00
aac6f576c2
Fix broken comparison in pin_numbers
...
Pin names like "+V" were incorrectly parsed as doubles leading to broken
comparisons. These caused heap overflows when sorting pin tables
This corrects the comparison so that numeric sorts are only performed
when there is an actual number in the symbol segment. Also adds unit
tests for common error cases
2022-04-19 14:46:05 -07:00
4ab2c93070
Update Selection Filter title bar with language changes.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11421
2022-04-19 21:12:13 +01:00
ffc28f23e5
Repair GetFullRef() and use it when running Symbol Fields Table filtering.
...
(Previously GetFullRef() failed to add the number between the prefix letter
and the unit designator.)
Fixes https://gitlab.com/kicad/code/kicad/issues/11419
2022-04-19 19:55:30 +01:00
08f15fe587
ADDED New Library functionality to Footprint/Symbol Save As.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/2343
2022-04-19 19:55:30 +01:00
84f620a96e
Minor dialog beautification.
2022-04-19 19:55:30 +01:00
c3bed8f6ee
Resolve textvars before opening file browser.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6436
2022-04-18 22:45:02 +01:00
cc18c31cb5
Fix some layout issues in the Project Template Selector.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/5222
2022-04-18 22:45:02 +01:00
653baf270c
Schematic: drag created / changed segments need junction checks
...
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/10844
2022-04-18 17:24:02 +00:00
801c5deb87
Fix minimum size calculation for new hierarchical sheets
...
These constants are given in mil, but are used in a context of internal
units.
2022-04-18 15:01:59 +00:00
1e505d4c22
Remove a few call sites of SCH_SHEET::SetSize
...
This function is dangerous and should be used only by parsers, and not even
those, really.
For new objects, the size can be passed to the constructor.
2022-04-18 16:23:03 +02:00
55a8fb39c4
ADDED filtering for Symbol Fields Table dialog.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11224
2022-04-17 20:02:58 +01:00
71c2cb3180
ADDED revert for pcbnew and eeschema.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6802
2022-04-17 20:02:58 +01:00
38c54ffa8f
Eeschema, Symbol Library Browser: fix crash when left clicking on the canvas.
2022-04-17 09:54:19 +02:00
e09147db30
Cross-probing for ERC dialog.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11411
2022-04-17 00:33:56 +01:00
7f4f5f2882
Save and re-load query string in Choose Symbol dialog.
...
While this has been requested on its own, it's primarily done here
because wxWidgets decided to send a SEARCH_CANCEL from a wxSearchCtrl
when hitting <ENTER> if the search control holes the empty string.
This causes us to not do a symbol instert in the Chooser dialog.
Fixes https://gitlab.com/kicad/code/kicad/issues/10169
Fixes https://gitlab.com/kicad/code/kicad/issues/7699
2022-04-17 00:33:56 +01:00
250a246761
Clear flags after we're done with them
...
The CANDIDATE flag is a temporary element that should not be maintained
outside of the routine in which is it temporarily set
Fixes https://gitlab.com/kicad/code/kicad/issues/11361
2022-04-16 15:45:17 -07:00
65f7d9f97a
EEschema: move symbol checker code in symbol_checker.cpp.
...
- Add some tests for Power symbols.
- Fix incorrect print format in some messages.
2022-04-16 18:56:06 +02:00
ce9bd780d1
Fix crash due to cleared view data
...
When changing fields, we need to update the view before allowing canvas
updates
(cherry picked from commit 851f893e8e
2022-04-15 15:14:29 -07:00
4ee6cfe5b6
Disable all use of the default instance reference prefix for annotation.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11385
2022-04-14 17:55:35 +01:00
6ef6e37edb
Disable using default instance data when writing to clipboard.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11379
2022-04-14 17:09:27 +01:00
160240166c
Cleanup.
2022-04-14 17:09:27 +01:00
034b57d9c0
When reannotating keep existing prefix in most cases.
...
(Execption is reannotating entire schematic, in which case we reset
all of them.)
Fixes https://gitlab.com/kicad/code/kicad/issues/11379
2022-04-13 23:38:45 +01:00
184b67098f
Meet user expectations on life-cycle of symbol fields.
...
In other words, support empty fields.
Also adds deleting fields to Symbol Fields Table.
Fixes https://gitlab.com/kicad/code/kicad/issues/8999
2022-04-12 22:11:31 +01:00
85f6ff48e7
CADSTAR Sch: Clear symbol of all elements before overwriting with new one
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/11378
2022-04-12 21:34:23 +01:00
306dfef7e5
Fix typo.
2022-04-12 19:18:15 +01:00
576f3dc2fd
Keep pins aligned to grid when possible.
...
This uses the first pin as the anchor point in a mulitple-item
selection.
Fixes https://gitlab.com/kicad/code/kicad/issues/11151
2022-04-12 18:14:21 +01:00
f88e0481c8
Change the behavior of ACTION_MENU::Add to require clones if required outside the function
...
This reverts commit 2a5769607f
2022-04-11 19:03:01 -04:00
16acba34d3
Don't save schematic symbol back to lib manager.
...
Also, since it doesn't get saved, changing symbols will lose any edits.
Make sure to ask the user first.
Fixes https://gitlab.com/kicad/code/kicad/issues/10767
2022-04-11 22:43:39 +01:00
2a5769607f
Revert "Change the behavior of ACTION_MENU::Add to require clones if required outside the function"
...
This reverts commit 403992a6f4
2022-04-11 11:39:03 -07:00
Chetan Shinde
Jeff Young
jean-pierre charras
Roberto Fernandez Bautista
Jonathan Haas
Marek Roszko
Seth Hillbrand
dsa-t
Mike Williams
Miklós Márton
Wayne Stambaugh
Simon Richter