haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
37,267 Commits 9 Branches 105 Tags 1.3 GiB
Commit Graph

624 Commits

Author SHA1 Message Date
Jeff Young e28b50e8d6 Fix a bunch more issues with sheetpaths and allowExtraText. 
A sheetpath is required to correctly resolve text variables.
Depending on currentSheet is rife with bugs.

There are many places where we do *not* want to be prepending
field names to the field values, such as netlisting,
building PDF hypertext menus, etc.

Also, Find/Replace needs to work on unresolved text, as
that's what we're going to display (and if replace nuked
your variable references you wouldn't be happy).

(cherry picked from commit b41d446f58)
 2023-05-05 18:02:59 +01:00
jean-pierre charras e42c66bd0e Pcbnew: fix crash when loading a file having vias on connected layers only. 
It was due to an access out of bounds in a std::array
Fixes #14668
https://gitlab.com/kicad/code/kicad/issues/14668
 2023-05-03 17:18:28 +02:00
jean-pierre charras b74af71312 * Eeschema: save worksheet filename in project file. 
The call to saveProjectSettings() was missing.
From master branch, commit b96f3d085c
Fixes #14219
https://gitlab.com/kicad/code/kicad/issues/14219
Fix also a minor compil warning
 2023-04-20 09:22:33 +02:00
Marek Roszko 5527c12a8d Fix crash due to extra right parens in pcad files 
Fixes sentry KICAD-TA


(cherry picked from commit 37eaa29679)
 2023-04-12 01:53:29 +00:00
Mark Roszko fb1cc72013 Don't crash on empty pcad polygons 
Fixes sentry KICAD-103
 2023-04-12 01:41:06 +00:00
Jeff Young 199e31ea3f Eagle template footprints don't actually belong to board. 
Set their parent to nullptr before deleting (as the board may have
already been deleted).

Likely fix for Sentry KICAD-79.

(cherry picked from commit 13e79af8a0)
 2023-04-04 14:21:19 +01:00
Roberto Fernandez Bautista 1e8055f504 CADSTAR PCB Importer: Ignore construction layers on outer surfaces 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/14443

7.0 version of d5bc223ff2 (no strings)
 2023-03-31 00:17:06 +02:00
Roberto Fernandez Bautista 3d9047bec4 Revert "CADSTAR PCB importer: Fix incorrect position of overridden pads" 
This reverts commit 5cab66fb18
 2023-03-29 21:53:14 +00:00
Roberto Fernandez Bautista 08d65beb26 CADSTAR PCB importer: Fix loading of rounded rectangle pads 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/14445


(cherry picked from commit aaeb8ca739)
 2023-03-29 20:56:14 +00:00
Roberto Fernandez Bautista 5cab66fb18 CADSTAR PCB importer: Fix incorrect position of overridden pads 
(cherry picked from commit 89441d807d)
 2023-03-29 20:55:50 +00:00
Marek Roszko abb6404ab2 Move up a layer validity check to prevent crash 
Fixes sentry crash KICAD-RF


(cherry picked from commit 604a7d69db)
 2023-03-25 21:13:38 +00:00
Marek Roszko 0688491e1b Fix typo 
(cherry picked from commit eb90448247)
 2023-03-24 23:55:24 +00:00
Marek Roszko 434161687e Fix cli crash due to dialogs buried in the pcb parser... 
Fixes sentry KICAD-Q2


(cherry picked from commit 8a8589b9db)
 2023-03-24 23:53:15 +00:00
Jeff Young 74da0043b4 Move automatic dimension processing inside PCB_DIMENSION_BASE. 
Also move dimension precision to an enum so it can get a proper dropdown
in the properties inspector.

(cherry picked from commit 461def2719)
 2023-03-12 21:04:09 +00:00
Jeff Young c0ddca12df Add Property Inspector support for dimension objects. 
Includes changing the class hierarchy so that dimension objects inherit
from PCB_TEXT rather than containing a PCB_TEXT member variable.

(cherry picked from commit 23accffc6d)
 2023-03-12 21:03:58 +00:00
Wayne Stambaugh 2c7f44f78d Coverity fixes and code cleaning. 
(cherry picked from commit 789bf6455a)
 2023-03-04 13:14:59 -05:00
Johannes Pfister 33f835a437 When importing legacy PCB dimension: Use automatic dimension when Unit couldn't be determined 
(cherry picked from commit a87550a2c6)
 2023-02-28 14:21:12 +00:00
Roberto Fernandez Bautista a1a3f810f0 Add missing line from commit b03366c9e8 
(cherry picked from commit bb8a3a7fdc)
 2023-02-27 23:13:44 +00:00
Roberto Fernandez Bautista c96f0f2396 Fix CADSTAR importer memory leaks 
We were leaking the xml tree when throwing exceptions


(cherry picked from commit b03366c9e8)
 2023-02-27 22:58:41 +00:00
Marek Roszko 6b38927123 Fix crash parsing cadstar 
Fixes sentry KICAD-B2
 2023-02-19 08:11:33 -05:00
Jon Evans d20f49b58b Fix handling of PPI when loading embedded images 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/13884


(cherry picked from commit 473979d686)
 2023-02-15 00:42:30 +00:00
Jon Evans e066454c61 Zones: use metric defaults and limits instead of mixed units 
Update testcases to reflect new defaults
 2023-02-11 07:39:29 -05:00
Alex b71fa91bc4 Don't write outside of overrides array on pad zone_layer_connections. 
Use std::array to catch future errors in Debug.

Fixes https://gitlab.com/kicad/code/kicad/issues/13803
 2023-02-08 01:32:52 +03:00
Jeff Young f2f54fe926 Improve zone-layer-connections terminology and comments. 
This makes it clearer that the overrides are not inverses of each
other -- one overrides the flashing state and the other overrides
the connection state (to other zones, not to everything).

Also fixes a bug where we were failing to check the force-no-connect
for pads.
 2023-02-05 17:39:42 +00:00
Jon Evans 200bf696af Fix importing of legacy netclasses 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/13746
 2023-02-02 08:29:43 -05:00
Roberto Fernandez Bautista 44cfb1ea43 CADSTAR PCB: Don't create zero sized text items 
Partially addresses https://gitlab.com/kicad/code/kicad/-/issues/13693
 2023-01-30 19:56:22 +00:00
Roberto Fernandez Bautista 963e82ee7f CADSTAR PCB: Correctly handle anticlockwise arcs 
Also add some qa tests for EDA_SHAPE::SetAngleAndEnd

Fixes https://gitlab.com/kicad/code/kicad/-/issues/13626
 2023-01-30 19:56:22 +00:00
Chris Morgan ce06171561 Convert additional sprintf to snprintf 2023-01-30 16:22:03 +00:00
vinsfortunato 5bdaf20af6 eagle: determine and use the minimum copper layer stackup count 
Fixes: https://gitlab.com/kicad/code/kicad/issues/13484
 2023-01-29 21:13:41 +00:00
Marek Roszko d4a5e2caad Fix crash when .kicad_pcb is renamed to .kicad_mod and load library attempted 
Pick a random error message used elsewhere
 2023-01-28 10:42:46 -05:00
Seth Hillbrand 7e5a2450b8 Move multiple wxMessageBox to DisplayErrorMessage 
Also provide protection for headless running in multiple callsites

Fixes https://gitlab.com/kicad/code/kicad/issues/13575
 2023-01-18 16:54:01 -08:00
Dag Lem cff0560088 Eagle schematic import: Handling of escaped text 2023-01-18 12:33:36 +00:00
Seth Hillbrand 60ba245474 Remove Eagle islands by default unless told otherwise 
Fixes https://gitlab.com/kicad/code/kicad/issues/13503
 2023-01-17 12:49:44 -08:00
Jeff Young ca1fb732c8 Share Eagle var substitution between board and schematic importers. 
Fixes https://gitlab.com/kicad/code/kicad/issues/13541
 2023-01-15 22:27:19 +00:00
Jeff Young 0c8f95aa02 Make sure tesselate_lambda has lock before modifying zone. 
Also implements locking for upating pad & tracks' zoneConnectionCaches.

Fixes https://gitlab.com/kicad/code/kicad/issues/13531
 2023-01-15 15:52:24 +00:00
Jeff Young f358749b28 Import copper pour cutouts from Eagle packages (footprints). 
Fixes https://gitlab.com/kicad/code/kicad/issues/13503
 2023-01-13 16:35:45 +00:00
Jeff Young 631fd54f9f Don't suppress writing of empty values. They have meaning. 
Fixes https://gitlab.com/kicad/code/kicad/issues/13507
 2023-01-12 15:24:59 +00:00
Jon Evans ac3ed02283 Rework bitmap cache and enable it 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/12405
 2023-01-04 00:26:45 +00:00
lukas-heiligenbrunner 29e51cc198 fix quoting of layernames 2022-12-29 09:01:11 +00:00
Marek Roszko 61119fbf64 Poke a const to make gcc happy 2022-12-06 22:00:23 -05:00
Marek Roszko c0b5fe58c3 Implement output targeting of symlib/fplib upgrade per request 2022-12-06 21:20:27 -05:00
jean-pierre charras d7368588db stackup manager: fix incorrect handling of colors for multi-layer dielectrics 
The dialog allows a color selection for each dielectric layer.
However for a "dielectric" defined by more than one layer, the color was handled
only for the first layer, and not for the other sub-layers.
 2022-12-01 16:19:13 +01:00
Marek Roszko 25d5defc10 Add cli for "fp" upgrade 2022-11-28 20:48:14 -05:00
Jeff Young 1aad2fb37b Change via keep-start-end to be start/end, not top/bottom. 
The implementation used to always check F_Cu and B_Cu, rather than
where the via started and ended (which will be different for blind/
buried vias and microvias).
 2022-11-23 21:37:50 +00:00
Seth Hillbrand 50ecb5b498 Remove errant printf 2022-11-21 15:19:45 -08:00
Jeff Young 9b2606018e Fix shadowed variable. 2022-11-19 11:53:33 +00:00
Jeff Young bab2b6c4b6 Don't assume a 1:1 map between Altium and Kicad nets. 
We've found at least one Altium board which has duplicate netcodes
for the same net.

Fixes https://gitlab.com/kicad/code/kicad/issues/12909
 2022-11-19 11:53:33 +00:00
Marek Roszko 3dd2ae762d Refactor step export to use our normal board processing routines 2022-11-12 21:27:10 -05:00
Jeff Young 1d7c5dce70 Don't attempt to write zone-connection-layers to footprint library. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12857
 2022-11-08 12:13:15 +00:00
Jon Evans dd94b2d3a7 Rename PROPERTIES to STRING_UTF8_MAP for clarity 
This class has nothing to do with the properties system
 2022-11-06 11:51:52 -05:00