3ab9db6ff1
Update cast in PNS since we are guaranteed to have text
...
We are guaranteed that the BOARD_ITEM will be a TEXTE_MODULE
since we have tested its type already, so just use a static_cast
to remove the overhead.
2020-01-13 19:42:49 +00:00
81ee5edcaf
Test dynamic_cast for safety from future changes
2020-01-13 15:22:26 +00:00
34bc0a4e96
pcbnew_control: Replace C casts with C++ casting
2020-01-13 14:19:44 +00:00
e2853862e5
Cleanup redundant type casting
2020-01-13 14:00:45 +00:00
8fc434be19
Formatting change for dynamic cast tests
2020-01-13 01:48:57 +00:00
36f6b4a9b4
Clean up redundant dynamic casts
2020-01-13 01:39:08 +00:00
94f8aafec5
Fix missing variable initialization.
2020-01-13 00:18:49 +00:00
d24bd5c832
Fix a couple of Coverity issues.
2020-01-12 21:07:41 +00:00
8d0f31f6f4
Clean a bunch of legacy code out of the Filter Selection dialog.
2020-01-12 20:53:56 +00:00
127c66285b
Rename old DIALOG_BLOCK_OPTIONS to DIALOG_FILTER_SELECTION....
...
... which is what it has done for some time now.
2020-01-12 20:30:58 +00:00
836c1ea56e
Fix a bunch of un-caught boost::bad_pointer exceptions.
...
This also removes vector cover types which do nothing except obfuscate
the underlying implementation.
Mainly changes SCH_SHEET_PINS and CONFIG_PARAM_ARRAY (which will soon
be replaced by Jon's new stuff).
2020-01-12 19:55:00 +00:00
b445ce6632
Clean up pointer casting
...
* Make note of when dynamic cast is actually needed
* Convert some to static cast when we know the type for sure
2020-01-12 19:45:37 +00:00
4ffbefb9dc
Use the layer from the module item instead
...
They are both from the same argument, but this one make coverity happy.
2020-01-12 19:39:39 +00:00
52bfdb9703
PNS: Assume the current line is a base before optimizing
...
We use the cost of the current line before trying to improve the pad
breakout cost when optimizing the smart pads
Fixes #3759 | https://gitlab.com/kicad/code/kicad/issues/3759
2020-01-12 11:08:46 -08:00
3346f812a9
Cleanup error handling in VRML export (from coverity scan)
2020-01-12 17:18:08 +00:00
00e58cd974
Fix unintialized values (from coverity scan)
2020-01-12 13:00:42 +00:00
76c26d6ae1
Remove unneeded unique_ptr
...
The unique_ptr was useful when the original function took multiple paths
which could de-scope the pointer. Current use allowed potential
use-after-free. This is now re-written to pass pointer directly.
2020-01-11 17:29:12 -08:00
3d8150032f
Fix some uninitialized variables found by Coverity.
2020-01-11 21:29:25 +00:00
2e509480a4
Fix guaranteed divide-by-zero error when called with correction of 0.
2020-01-11 21:29:25 +00:00
715448611d
Fix potential divide-by-zero (from Coverity scan).
2020-01-11 21:29:25 +00:00
17710c15d3
Fix leak of empty PICKED_ITEMS_LIST.
2020-01-11 21:29:25 +00:00
9182b3a850
Remove dead code and simplify remaining logic.
2020-01-11 21:29:25 +00:00
43abd53b19
Clarify limits of the if statement
2020-01-11 21:28:25 +00:00
f896043067
Fix comments for switch statement fall throughs
...
This cleans up all GCC warnings (-Wimplicit-fallthrough=2) about
implicitly falling through switch cases.
2020-01-11 19:16:32 +00:00
7c28c3838a
Comment-only changes
...
Makes class comments conform to coding standards
2020-01-10 16:43:01 -08:00
254ba1f998
Fix null pointer access (from Coverity scan).
2020-01-11 00:15:47 +00:00
88eab8134e
Fix a couple of uninitialized variables (from Coverity scan).
2020-01-11 00:11:31 +00:00
7bb9551801
Handle boost exceptions. (From Coverity scan.)
2020-01-11 00:04:01 +00:00
5e5edd03f6
Implement super- and subscript printing and plotting for eeschema.
2020-01-10 22:32:49 +00:00
e03281a9ae
Allow exclusive-or selections on OSX.
2020-01-10 22:32:49 +00:00
7c61b83df6
Code cleanup
2020-01-10 20:10:29 +00:00
5e6c6e7e22
Fix memory leak in the footprint preview panel
...
The cached modules were never deleted, so they would
leak whenever the panel was closed.
2020-01-10 20:10:29 +00:00
77c60d9655
Remove the last vestiges of dlist
...
It served us (mostly) well for more than a decade. It helped KiCad grow
before the std:: came into decent shape or speed. It was a good little
list.
RIP DLIST 2008-2020
2020-01-10 06:37:08 -08:00
a8d9fcb4e0
Fix event handler type casting
...
The old methods were very clunky and not recommended (and didn't
properly cast the function types). This changes to useing the
recommended way of declaring events and casting the event handlers.
2020-01-09 18:08:49 +00:00
16026e75cf
pcbnew: Don't compare across containers
...
std:: defines cross-container comparison as invalid and is not
guaranteed to work. This breaks the comparison out into separate
steps, each for the separate containers.
2020-01-07 16:03:32 -08:00
9dff31c2ac
Remove unused DIALOG_FILE_DIR_PICKER
...
This class was replaced with native dialogs for choosing
the files and directories
2020-01-07 23:40:00 +00:00
13b6028e1b
Refactor all math into a new kimath library
...
* Split up the thirdparty code into the thirdparty folder (#3637 )
* Create a new kimath static library containing all the math functions
This is part of cleaning the build system for #1906 .
2020-01-07 17:12:59 +00:00
270aaec443
Rewrite FBP files generated with unreleased wxFB
...
These use a few features that are too new, causing errors when trying to
edit with a released version of wxFormBuilder.
2020-01-07 13:32:33 +00:00
b114dabbed
Convert line endings in three FBP files
2020-01-07 13:32:33 +00:00
86f9ed1dd9
Allows pad property only by the kicad_advanced feature.
...
pad property is allowed if "UsePadProperty=1" is found in kicad_advanced.
2020-01-06 18:11:01 +01:00
f2518a5120
ADDED: pad fabrication property, as required in latest Gerber file specification.
...
Property is a pad info used mainly for fabrication or test.
Currently, supported properties are:
BGA property (variant of SMD pad)
Fiducial (global to the board or local to the footprint)
Test Point
Heat sink
Castellated.
And are used in Gerber files (copper layers and drill files)
Increment BOARD_FILE_VERSION to 20200104
2020-01-06 16:37:35 +01:00
28222d3bd0
Use existing pcb filename for Save As where possible
2020-01-06 14:26:03 +00:00
a5c7d452ce
Convert line endings back to Unix
...
- pcbnew/class_board.h
2020-01-05 00:48:18 +01:00
820690d024
pcbnew : fix selection color for the 'hole' part of NPTHs
...
The inner circles of NPTHs now change color when selected
Fixes #1860
2020-01-04 20:59:49 +00:00
772835e3e3
Add fifo_map and use it for Gerber job file generation
2020-01-04 11:05:09 -05:00
21d577e638
Implement Gerber job file writing using nlohmann/json
2020-01-04 10:46:50 -05:00
4c1e64628e
pcbnew: Modify IDs in panel_fp_lib_table
...
Move the IDs from the main enum to be local and use
the end of the main enum as the starting point.
2020-01-03 16:10:53 +00:00
5d46e721e5
pcbnew: Cleanup includes of pcbnew_id.h
...
* Remove unused IDs from the enum
* Remove the include statements from files that no longer need it
2020-01-03 15:39:05 +00:00
49db816c82
Pcbnew: improve add existing footprint library browser and button
...
CHANGED: Modify Add Existing Footprint Library button to us OS file/directory browsers
2020-01-03 15:09:26 +00:00
ed0a28769a
code cleaning: remove useless includes.
2019-12-31 14:58:39 +01:00
496f3d49e4
pcbnew: When using '+' and '-' hotkeys, skip non-visible layers
...
CHANGED: pcbnew: When using '+' and '-' hotkeys, skip non-visible layers
Fixes https://gitlab.com/kicad/code/kicad/issues/3443
2019-12-29 23:37:25 +00:00
7241247fbc
Pcbnew: add missing storage of dimension units and dimension precision in pcb files.
...
https://gitlab.com/kicad/code/kicad/issues/3712
2019-12-28 13:27:31 +01:00
ffe3fdf832
Set m_netNamesOnVias. We currently follow m_netNamesOnPads.
...
We could also follow m_netNamesOnTracks, or add another set of
options in the GUI. But for now I suspect this is sufficient.
2019-12-28 11:58:33 +00:00
cd1f3acf49
Fix compil warnings
2019-12-28 08:43:29 +01:00
19ceb11ae7
Change more enums over to scoped enums
2019-12-28 00:55:11 +00:00
25a302758e
Fix macos plist version string generation
...
Generate these resource files similar to how it is done one Linux.
Fixes mac-builder issue https://gitlab.com/kicad/packaging/kicad-mac-builder/issues/275
2019-12-26 12:42:25 +00:00
80fb3bde56
Don't try to write fp-info-cache to a read-only directory
...
Fixes #1890
2019-12-25 18:38:31 -05:00
a12b803af5
Add missing option to show footprint texts in fill or sketch (line) mode.
...
This option is settable in stable version, but not in master.
So, this option set from the stable version could be modified in master version.
2019-12-23 18:11:45 +01:00
bf5dba847c
pcbnew: Fix cmake to work with no wxPython on macOS
2019-12-22 02:04:15 +00:00
7fb56cf9a3
Fix compile error due to enum changes
...
Merge request !23 changed to strongly typed enums,
so we now need to explicitly cast the output in the
Python getters.
2019-12-20 14:47:41 +00:00
11ff16be4e
Switch to scoped enums
2019-12-20 14:11:39 +00:00
116ac9aa75
Move dxflib, tinyspline and nanosvg into a thirdparty library directory
...
Part of fixing https://gitlab.com/kicad/code/kicad/issues/3637
2019-12-19 17:41:02 +00:00
b9d8849b28
Unify unsaved changes detection logic in all frames
...
Create an IsContentModified() function in each frame
that provides if the content has been modified, and
use that instead of always copying the checks.
2019-12-19 15:34:01 +00:00
686b768a3d
Add shutdown blocking on Windows for pcbnew, eeschema and pleditor
...
ADDED: Block shutdown/logoff on Windows when contents have been modified
2019-12-19 14:11:11 +00:00
a9f9540fa4
Pcbnew: minor cosmetic enhancement:in status panel, for polygon graphic shape:
...
shows the coordinates of the first polygon point (instead of 0,0 coordinates)
2019-12-19 08:30:20 +01:00
cc185e4b8a
Pcbnew: fix crash when deleting pads in the board editor
...
Fixes # |3684 https://gitlab.com/kicad/code/kicad/issues/3684
2019-12-17 13:56:17 +01:00
fa200f3d39
Pcbnew: enhancement: graphic polygon: display the points count, instead of length.
...
Previously, the meaningless length (always 0) was displayed.
2019-12-17 08:40:44 +01:00
6bc8005d60
Pcbnew: fix strange behavior when editing board setup, if a zone is currently selected.
...
The zone was silently deleted.
Fixes #3673 | https://gitlab.com/kicad/code/kicad/issues/3673
2019-12-16 12:44:53 +01:00
d40019210f
Allow undo during a drag.
2019-12-15 21:33:58 +00:00
1f07505b27
Fix long-standing issue with arrow keys moving in both axes.
2019-12-15 14:29:47 +00:00
d14950c3f8
Pcbnew: Add missing options to show graphics in fill or sketch mode.
...
These options where settable in stable version, but not in master.
So, the options set from the stable version cannot be modified in master version.
2019-12-15 13:56:26 +01:00
dc241df602
pcbnew: Cleanup stale code
2019-12-13 11:22:18 -08:00
02977aacfc
Pcbnew: fix incorrect rotation angle unit when building thermal spokes
...
The new Rotate function uses radians, not deci-degrees.
Fixes #3668 | https://gitlab.com/kicad/code/kicad/issues/3668
2019-12-13 17:41:20 +01:00
ae785194ce
Silence/fix double to float conversion warnings
2019-12-12 21:51:21 +00:00
0e1a274f0c
pcbnew: Clean unused lambda includes
2019-12-12 11:52:50 -08:00
eb3d32f967
SHAPE_LINE_CHAIN: Unify constructors
...
Keeps the multi element SHAPE_LINE_CHAIN constructors in a single
routine using std::vector and implicit construction.
2019-12-12 13:54:48 +00:00
c4d853c1e8
SHAPE_LINE_CHAIN: Remove element access
...
This is the first step to allowing non-segments in the line chain.
External routines cannot be allowed to change the line chain without
going through the internal routines. To accomplish this, we remove the
Vertex() and Point() access routines and only leave the const versions.
Transformations are given for both points as well as the chain itself.
2019-12-12 13:54:48 +00:00
21dd8db7a9
P&S router: length tuning tool: fix a crash after trying to tune a track.
...
It happens on Windows, and wxWidgets 3.1.3.
It is created by PNS_TUNE_STATUS_POPUP instance used in tool.
I am pretty sure this crash is created by the stack switching
when managing events, due to some changes in wxWidgets code.
the fix creates the instance on the heap, instead of on the stack.
This is not the first time I see this kind of issue.
2019-12-12 09:39:51 +01:00
351e249105
Fix full-screen-crosshairs toolbar button.
...
Fixes #1937 | https://gitlab.com/kicad/code/kicad/issues/1937
2019-12-11 21:04:52 +00:00
e57fe9d173
Gerber object attribute: avoid trying to guess if a SMD pad is a BGA pad.
...
Previously, if a SMD pad was round, itb was seen as BGA pad.
But this is not always true. so use always SMD PAD attribute,
until an explicit BGA pad attribute is added in Pcbnew
2019-12-11 08:52:31 +01:00
9b7d4e2742
Recleaning DLIST from pcbnew
...
This was re-introduced by 5d3e6e3d44Fixes #2623 | https://gitlab.com/kicad/code/kicad/issues/2623
2019-12-10 09:52:07 -08:00
c7ce93e10e
Pcbnew: fix crash on exit, if a place zone tool is activated.
2019-12-08 18:01:02 +01:00
b6b805548d
PNS: Allow snap to temp hidden
...
The IFACE for kicad refers to the board hidden state, not the
temporarily hidden state used by the router. We allow snapping to items
that have been removed by the temporary router state to provide snapping
to original track location.
Fixes #1827 | https://gitlab.com/kicad/code/kicad/issues/1827
(cherry picked from commit 1e64524afb
2019-12-07 09:51:02 -08:00
9f896312ee
Add missing include
2019-12-06 06:47:03 -08:00
4aa9552f1f
Adding missing include
2019-12-06 06:26:59 -08:00
36fba5bd7f
PCBnew: placing a blind/buried via sometimes incorrectly place a through via.
...
Fixes #1819
https://gitlab.com/kicad/code/kicad/issues/1819
2019-12-06 13:11:33 +01:00
ac92afcf13
Clean up compile warnings
...
Ratsnest did not need a reserve and then iterative emplace. Instead, we
use resize(). Stroke font gets private vars initialized and kiway
variables that are only used in debug builds are properly scoped for
releases as well
2019-12-05 20:05:21 -08:00
6983c56cf8
Use const references where possible
...
This avoids copy cost on local vars where we only read.
2019-12-05 14:40:22 -08:00
c6f5df134c
Minor speed cleanup
...
This adjusts iterators to use const reference when only used for
copy. It also ensures pre-allocation of vectors when size is known
ahead of time.
2019-12-05 14:20:59 -08:00
b5f021ff9f
Cleanup: Replace push_back with emplace_back
...
In cases where we create a new item and immediately push into a
container, the emplace idiom is faster and more efficient.
2019-12-05 13:41:21 -08:00
4d2e953f42
Cleanup: Replace C-only deprecated headers
...
This replaces headers deprecated by C++14 with their equivalent
replacement
2019-12-05 11:03:15 -08:00
a2edf9c442
Unified update to C++14 std::make_unique
...
This update replaces the existing uses of unique pointer creation with
the C++14 std::make_unique call that provides proper memory release in
event of an exception.
2019-12-05 10:43:55 -08:00
4a75cc586c
Zone filler: do not create stubs in thermal reliefs when not possible.
...
pad size is sometimes smaller than the zone minimal width.
So, to avoid strange and incorrect results, do not create the stubs in
thermal relief when the pad size is smaller than the zone minimal width.
2019-12-04 13:23:09 +01:00
089ce90de3
Fix some issues with the previous commit.
2019-12-02 23:35:19 +00:00
9b36489270
Make sure that libraries are always sorted consistently.
...
Fixes #1847481 | https://gitlab.com/kicad/code/kicad/issues/1847481
2019-12-02 21:52:50 +00:00
a9da0c6ecf
Update local coords when editing EDGE_MODULEs.
...
Fixes: lp:1853726
* https://bugs.launchpad.net/kicad/+bug/1853726
2019-12-02 20:01:44 +00:00
5cd7f3fdee
DIALOG_DRC_CONTROL: fix a crash on wxWidgets 3.1.3, Windows,
...
Happens when right clicking on an item in displayed lists.
The crash was due to a bug in wxWidgets, and the fix is only a workaround
Also remove duplicate code.
2019-12-02 11:27:40 +01:00
342c8941b5
More cleanup of dialog_find-base.fbp
2019-11-30 01:00:16 +00:00
1e4437c6df
Some cleanup for the Pcbnew search changes.
2019-11-29 21:38:18 +00:00
7297822423
pcbnew: search options
...
-Users can now search DRC markers with string filtering
-GUI changes for consistency with Eeschema
Fixes: lp:1845460
* https://bugs.launchpad.net/kicad/+bug/1845460
2019-11-29 17:58:05 +00:00
Ian McInerney
Jeff Young
Seth Hillbrand
Simon Richter
jean-pierre charras
Jon Evans
Fabien Corona
Mark Roszko