haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
15,400 Commits 9 Branches 105 Tags 1.3 GiB
Commit Graph

1175 Commits

Author SHA1 Message Date
Jeff Young a375edf9ac Perform cancel action by hand. 
Fixes: lp:1814138
* https://bugs.launchpad.net/kicad/+bug/1814138
 2019-01-31 19:07:07 +00:00
Jeff Young ba7b970817 Add pre-select architecture to grid helper icon-text-buttons. 
Fixes: lp:1813973
* https://bugs.launchpad.net/kicad/+bug/1813973
 2019-01-31 01:09:03 +00:00
John Beard 88f9f6f072 Break out ref-des-centric functions to own header 
This breaks the following functions out to a general-purposed refdes utils
header:

* MODULE::GetReferencePrefix()
* kicad_string.h RefDesStringCompare()

This acheives:

* Slimming of MODULE interface
* Placement of refdes code in common rather than pcbnew
** Testing of this code in qa_common
* Tighter and smaller includes for code that only needed refdes functions

Note: there are failing tests commited (as expected failures). These
are the cause of lp:1813669 and will be fixed as a follow-up commit.
 2019-01-30 15:41:36 -08:00
Jeff Young 19c9ae7ecb Use updated value when checking for empty. 
Fixes: lp:1813640
* https://bugs.launchpad.net/kicad/+bug/1813640
 2019-01-30 16:29:21 +00:00
Seth Hillbrand 872f0eb44c eeschema: Set grid editor to use qty as the drop-down 
Symbol fields uses a custom expander control.  This should be tied to a
column that cannot be hidden in order to ensure the ability to view sub
elements remains intact, like the standard control.

Fixes: lp:1780847
* https://bugs.launchpad.net/kicad/+bug/1780847
 2019-01-29 17:10:58 -08:00
jean-pierre charras b8cfabd22e Fix some issues in I10n strings 
Fix typo and missing I10n identifier for 2 strings
 2019-01-26 09:25:12 +01:00
jean-pierre charras 4cd41e3941 Eeschema: avoid using a incorrect background color the first time a SCH_DRAW_PANEL is displayed 
When starting Eeschema, or a frame/dialog using a SCH_DRAW_PANEL, the bg color was initialized too late,
thus creating a flicker or an annoying draw artifact (in SYMBOL_PREVIEW_WIDGET for instance) if a Paint event
is fired before the right bg color is initialized.
Initializing the bg color earlier fix this issue.

Fixes: lp:1797203
https://bugs.launchpad.net/kicad/+bug/1797203
 2019-01-25 20:32:46 +01:00
Wayne Stambaugh 2dcba4723d Lay groundwork for loading the initial global footprint library table. 
Factor out common dialog code from global symbol library table dialog for
loading initial library table.

Update global symbol library table code to user factored out common dialog
code.
 2019-01-20 13:09:49 -05:00
Baranovskiy Konstantin 8400ee41c0 Grid tricks: cell selection fixes. 
CHANGED: First click sets a cursor to the specified cell, second click
activates editor (current realization, where first click activates cell
editor, is very buggy especially with cells selection).

Set cursor on cell of reference on mouse left click in Fields editor of
Eeschema.
 2019-01-19 14:54:37 -05:00
Baranovskiy Konstantin 4ea08d477d Clear comp highlighting before highlight new one. 
On clicking a reference cell in the field editor of Eeschema a
corresponding component is highlighted in Eeschema. But previously
highlighted components are staying highlighted.

With current patch all highlightings are cleared before highlighting
selected component.
 2019-01-19 14:54:29 -05:00
Seth Hillbrand c3a295df1a Fix segfaults from not checking index 
Return value of wxArrayString.Index() always needs to be check for
existence.
 2019-01-17 10:23:25 -08:00
jean-pierre charras e7fa02a9f0 DIALOG_BOM: fix a few issues. Mainly an annoying issue when a plugin file was not found 
Previously, all the dialog setup was lost.
 2019-01-14 13:14:13 +01:00
Seth Hillbrand a0a4e5e18d libedit: Small edit component cleanup 
Initialize local variables and ensure that the SPICE edit button is not
shown in compiles that do not support it.
 2019-01-12 06:58:40 -08:00
Seth Hillbrand 634d02bd04 libedit: Check proper field grid type 
Fixes segfault where pointers are not zeroed

Fixes: lp:1811519
* https://bugs.launchpad.net/kicad/+bug/1811519
 2019-01-12 06:51:09 -08:00
Jeff Young 81a0ab4d7e Don't return wxID_OK from a cancel. 
Also fixes the Save icon not getting enabled/disabled.

Fixes: lp:1810116
* https://bugs.launchpad.net/kicad/+bug/1810116
 2019-01-10 17:41:33 +00:00
Jeff Young 15af0cc43d Don't inherit previously-selected alias properties when deleting. 
Fixes: lp:1810768
* https://bugs.launchpad.net/kicad/+bug/1810768
 2019-01-10 17:41:33 +00:00
Seth Hillbrand 170ff66cbb libedit: Allow SPICE parameter editing 
This fixes a regression to allow SPICE parameters to be added to the
symbol in libedit.

Fixes: lp:1793062
* https://bugs.launchpad.net/kicad/+bug/1793062
 2019-01-09 21:43:23 -08:00
Wayne Stambaugh 906161dcf8 Fix configuration dialog layout issues on GTK. 2019-01-09 17:35:12 -05:00
John Beard 658cc8fd96 Wildcards: unify handling of all files wildcards 
Use the AddFileExtListToFilter() to also generate the
wildcard for "all files". This is because:

* Users can use AddFileExtListToFilter for the all files WC
  with the same interface as for any other extensions.
* Users do not need to worry about wxGetTranslation, as the
  _() is applied in the same way as the other *Wildcard() helpers,
  and it is a function just like the others, so it is consistent
* There is a testable interface to document the expected result.
  The test is added.
 2019-01-09 08:57:42 -05:00
jean-pierre charras 1ca3b2c768 Eeschema: DIALOG_FIELDS_EDITOR_GLOBAL: fix missing clearing old highlight when highlighting a new symbol or exiting the dialog 2019-01-09 14:38:44 +01:00
Seth Hillbrand 31ab4e6c9a eeschema: Simplify netlist dialog 
The default filename textbox confusingly could not be edited and the
checkbox for "Use default filename" would also use a default location.
As the netlist export is no longer required in the workflow, we can
simplify the layout to always show the user the file save dialog
allowing them to choose the location and name of the exported netlist
file.
 2019-01-08 09:26:36 -08:00
Seth Hillbrand 3b54a44540 wildcard strings update 
Replace a few other cases where we used Windows-only or *nix specific
wildcard strings
 2019-01-05 20:26:45 -08:00
Seth Hillbrand 02a1bf1de6 eeschema: Use system-dependent default wildcard 
wxWidgets provides a system-dependent string for "*" or "*.*" depending
on the system.  Unfortunately, wxFormBuilder does not use this and
instead defaults to the Windows-only "*.*".  This is an ugly work
around.

Fixes: lp:1810221
* https://bugs.launchpad.net/kicad/+bug/1810221
 2019-01-05 20:18:59 -08:00
Seth Hillbrand 37967eb685 eeschema: init pin table local var 
Explicitly set modified to false when instantiating
 2019-01-02 19:41:18 -08:00
Jeff Young ad0d9f8df0 Save user-defined nicknames. 
While name and path fields would make more sense, this commit
encodes the nickname as an "opts" field so that older versions will
still read the preferences file.
 2018-12-28 20:34:06 +00:00
Jeff Young 2c53ab3d8c Fix debug assert. 2018-12-11 17:56:41 +00:00
jean-pierre charras a40cff18d3 PANEL_EESCHEMA_SETTINGS_BASE: very minor cosmetic enhancement. 2018-12-07 11:30:52 +01:00
jean-pierre charras f1c1c5db3f Fix a minor compil warning 2018-12-07 11:22:03 +01:00
Jeff Young ff6a3482ec Remove on-kill-focus-validation. 
Fixes: lp:1805361
* https://bugs.launchpad.net/kicad/+bug/1805361
 2018-11-29 19:00:21 +00:00
Maciej Suminski 6d8ca311f8 Fix a crash after clicking 'delete' button with empty Template Field Names grid 2018-11-29 14:09:07 +01:00
Jeff Young 6bf0e17036 Fix typo which was keeping rename from working. 
(Renaming the dialog window instead of the libentry doesn't really
do the trick.)
 2018-11-25 01:51:45 +00:00
Jeff Young 239482ec98 Add tooltips to Symbol Properties dialogs. 
Fixes: lp:1804931
* https://bugs.launchpad.net/kicad/+bug/1804931
 2018-11-24 15:06:21 +00:00
Jeff Young 2e1920abad Add tooltips to library manager dialogs. 
Fixes: lp:1804930
* https://bugs.launchpad.net/kicad/+bug/1804930
 2018-11-24 15:06:21 +00:00
Jeff Young b2db49f4ac Add browse buttons to Library Manager dialogs. 
Fixes: lp:1804924
* https://bugs.launchpad.net/kicad/+bug/1804924
 2018-11-24 15:06:21 +00:00
jean-pierre charras db7deff21b DIALOG_SPICE_MODEL_BASE: fix minor wxWidgets alerts. 2018-11-23 10:21:57 +01:00
Jeff Young ed6c68a1e3 Clean up handling of component fields. 
In particular the datasheet field and how its handled with aliases,
but also cleaning up duplicated functionality around aliases and
libids.
 2018-11-22 21:31:45 +00:00
jean-pierre charras 8522baf4a7 bom_plugins.cpp: fix incorrect command line for python scripts on Windows. 
* On Windows, a python command line must be python <script_path>/script.py
and not python <script_path>\script.py
* Fix also a incorrect warning message when a script is not found.
 2018-11-19 17:50:38 +01:00
Maciej Suminski 2ee2d9014a Populate BOM plugins list if the list is empty 
Fixes: lp:1464893
* https://bugs.launchpad.net/kicad/+bug/1464893
 2018-11-19 16:17:53 +01:00
Maciej Suminski 15772e4b0b BOM plugins refactor 
Extended BOM_PLUGIN to a class and moved the plugin construction related code there.
 2018-11-19 15:59:08 +01:00
jean-pierre charras b35b1bb644 Fix a few minor I18n issues. 
Especially remove trailing and leading spaces in sentences, always annoying in translations, and never useful in sources.
 2018-11-16 18:12:01 +01:00
Maciej Suminski e3bcd31bff Added a dialog to confirm discarding unsaved changes in Pin Table dialog. 2018-11-16 16:10:53 +01:00
Jeff Young 4050991d28 Move ERC marker focusing to GAL architecture. 
Fixes: lp:1802537
* https://bugs.launchpad.net/kicad/+bug/1802537
 2018-11-16 10:38:44 +00:00
jean-pierre charras 1f3d5cee0e Fix a few minor I18n issues. 2018-11-15 09:34:29 +01:00
Maciej Suminski 298a033b9d Fixed a crash on moving down the last field in the Symbol Properties dialog 2018-11-13 14:14:08 +01:00
Maciej Suminski 44424dcbb3 Fixed a crash in Symbol Properties dialog 
Fixes: lp:1802641
* https://bugs.launchpad.net/kicad/+bug/1802641
 2018-11-13 14:02:16 +01:00
jean-pierre charras 436f80a0bb eeschema/dialogs/dialog_lib_edit_pin_base.cpp: fix a minor wxWidgets alert 2018-11-13 13:03:38 +01:00
jean-pierre charras f7cf40f2f4 Fix a few Coverity warnings. 
Sometimes a dynamic_cast was used without testing the returned value.
Some are replaced by static_cast, when the dynamic_cast was useless.
 2018-11-11 08:28:58 +01:00
Maciej Suminski 02f81d7419 Handle 'show page limits' in eeschema 2018-11-08 09:57:16 +01:00
Jeff Young c4cd81a906 Remove side-effect of LIB_FIELD::SetText(). 
Fixes: lp:1800545
* https://bugs.launchpad.net/kicad/+bug/1800545
 2018-10-31 12:57:23 +00:00
jean-pierre charras c49917c5a8 Dialog edit component in lib: Fix a few minor wxWidgets alerts. 2018-10-28 18:42:16 +01:00
Wayne Stambaugh ce34a713b4 Eeschema, make BOM tool add file dialog remember last used path. 
Fixes lp:1797679

https://bugs.launchpad.net/kicad/+bug/1797679
 2018-10-25 10:33:19 -04:00
Michael Kavanagh 3248c270ee Update Eeschema BOM dialog html help text 
Now links to relevant section in stable eeschema docs.

Fixes: lp:1798248
https://bugs.launchpad.net/kicad/+bug/1798248
 2018-10-22 13:19:15 -04:00
jean-pierre charras 1116acd74b Libedit: Fix broken handling of "common to all bodu style" property of lib draw items. 
Fix a minor wxWidgets assert.
 2018-10-20 12:38:36 +02:00
Jeff Young baa4019448 Draw pin previews with the correct schematic background color. 
Fixes: lp:1798447
* https://bugs.launchpad.net/kicad/+bug/1798447
 2018-10-18 13:27:41 +01:00
Jeff Young 8a54b1b3b7 Add view refresh calls for edit operations. 
Note that the bug referenced in the "fixes" section is only one
of many addressed by this commit.

Fixes: lp:1798449
* https://bugs.launchpad.net/kicad/+bug/1798449
 2018-10-18 12:12:48 +01:00
Jeff Young e9a80a5d7f Some minor dialog layout fixups. 2018-10-17 11:23:02 +01:00
Jeff Young 1114b5cfa9 Refresh item when its dangling state changes. 
Fixes: lp:1797996
* https://bugs.launchpad.net/kicad/+bug/1797996
 2018-10-16 17:07:59 +01:00
Jeff Young 0bd0558833 Auto-select reference numbers in PcbNew like we do in Eeschema. 2018-10-14 00:06:41 +01:00
Tomasz Włostowski e988cd9c25 Fixed crash in footprint chooser in eeschema triggering in standalone/no-pcbnew mode 
Fixes: lp:1797644
* https://bugs.launchpad.net/kicad/+bug/1797644
 2018-10-12 23:43:08 +02:00
Jeff Young 779ef044b7 Fix wxGrid column dragging bugs. 
Close an open editor when dragging (as wxWidgets won't move it).

Make sure native column headers aren't in use where we need dragging:
their interaction with wxWidgets' dragging is buggy.

Fixes: lp:1796398
* https://bugs.launchpad.net/kicad/+bug/1796398

Fixes: lp:1796396
* https://bugs.launchpad.net/kicad/+bug/1796396
 2018-10-09 21:33:43 +01:00
Jeff Young 55c1ca1191 Handle pin sorting properly for values. 
The pin number sorter doesn't handle units at all, and seems to
stumble on negative numbers.

Fixes: lp:1796869
* https://bugs.launchpad.net/kicad/+bug/1796869
 2018-10-09 14:56:29 +01:00
jean-pierre charras 88cdce8d62 Make SYMBOL_PREVIEW_WIDGET working, and using the canvas type of the caller. Fix an issue with F3 zoom key in libedit. 2018-10-09 11:08:56 +01:00
Jeff Young 96724af2c4 Ensure junctions and no-connects are visible even on fat wires. 
Also adds a preference for junction size.

Fixes: lp:1545422
* https://bugs.launchpad.net/kicad/+bug/1545422
 2018-10-09 11:08:56 +01:00
Jeff Young 37cfa3fed9 Cleanup unused and redundant stuff. 2018-10-09 11:08:56 +01:00
Jeff Young 5fd20ee786 Implementation of ERC markers. 2018-10-09 11:08:55 +01:00
Jeff Young 47189034aa Grid settings for LibEdit. 2018-10-09 11:08:55 +01:00
Jeff Young afeebc8944 Grid settings for Eeschema GAL. 
Split antialiasing options out from display options.  Move
antialiasing to common.  Duplicate the rest of display options
for Eeschema.

Implement OnSelectGrid and hookup GAL canvas refresh to
SetPresetGrid.

Add Grid Settings... to View menu and move Show Grid from
preferences to View Menu to match Pcbnew.
 2018-10-09 11:08:55 +01:00
Jeff Young 1c52824913 Rewrite unit/convert handling so it also works for LibEdit. 2018-10-09 11:08:55 +01:00
Jeff Young 6eafb9a2fd Convert Rescue Symbols dialog previews to GAL. 2018-10-09 11:08:55 +01:00
Jeff Young 538a5d49ee Fix up GAL version of Symbol Viewer. 
Also includes some preliminary work for supporting hidden pins,
pin electrical names, and other preferences.
 2018-10-09 11:08:55 +01:00
Jeff Young 7cbfa08ddd Move symbol chooser dialog preview to GAL. 2018-10-09 11:08:55 +01:00
Tomasz Wlostowski 90c7c60471 eeschema-gal: initial GALified version. Lots of stuff still to do! 2018-10-09 11:08:52 +01:00
Jeff Young 90df7a8b22 Sort references before removing duplicates. 
std::unique only works within consecutive blocks, so the list must
be sorted first.  (We need it sorted in the end anyway, so no
big deal.)
 2018-10-08 00:14:07 +01:00
Jeff Young 8015334683 Don't resize hidden columns. 
wxGrid columns are hidden by setting their width to 0.  Resizing
them will "unhide" them.

Fixes: lp:1796150
* https://bugs.launchpad.net/kicad/+bug/1796150
 2018-10-05 14:17:58 +01:00
Jeff Young 3c2aafd7b7 Move Edit Symbol References to standard text/button control. 2018-09-29 22:07:31 +01:00
jean-pierre charras 094f340359 Eeschema: Opening "Edit Symbol Fields" dialog crashes Eeschema 
Fixes: lp:1795088
https://bugs.launchpad.net/kicad/+bug/1795088
 2018-09-29 10:08:29 +02:00
Jeff Young 6fdfd0932e Use newer wxWidgets calls (old ones aren't available on MSW). 2018-09-27 18:53:46 +01:00
Jeff Young 5703060d87 Turn off escaping names for now. 
Fixes: lp:1794816
* https://bugs.launchpad.net/kicad/+bug/1794816
 2018-09-27 17:21:49 +01:00
Jeff Young e456ecd0a1 Calculate column widths based on all data, not just shown data. 
Also caps the calculated width at 1/3 of the default dialog width.

Fixes: lp:1794625
* https://bugs.launchpad.net/kicad/+bug/1794625
 2018-09-27 16:57:25 +01:00
Jeff Young 521183a587 Work in progress to allow arbitrary chars in references, etc. 2018-09-27 11:56:51 +01:00
Simon Richter 1253020a8b Add missing header 2018-09-24 10:47:15 -04:00
jean-pierre charras b70d0f43b6 Fix minor compil warnings. 2018-09-24 13:12:47 +02:00
Maciej Suminski e6f2c49eae Spice model editor: support for JFET models 2018-09-22 19:05:01 +02:00
Maciej Suminski f2f6dffd16 Refactored logic in Spice model editor dialog 
- Removed redundant enums
- Stored Spice model description in an array
- Made code generic by using the model description array
 2018-09-22 19:04:54 +02:00
Jeff Young 5974899fa5 Clean up file locations and names. 2018-09-22 16:23:13 +01:00
Jeff Young 618182dcd6 Use pin number sorting algorithm in pin table. 
Fixes: lp:1793180
* https://bugs.launchpad.net/kicad/+bug/1793180
 2018-09-19 22:23:18 +01:00
Jeff Young e5e1a315f1 Keep name & value in sync for library items. 
Also fixes library reference highlighting from board footprints.

Fixes: lp:1792243
* https://bugs.launchpad.net/kicad/+bug/1792243

Fixes: lp:1792256
* https://bugs.launchpad.net/kicad/+bug/1792256
 2018-09-13 16:41:23 +01:00
Jeff Young 806b1fc63d Fix bugs to enable read-only grid cells to be copied. 
Fixes: lp:1791129
* https://bugs.launchpad.net/kicad/+bug/1791129
 2018-09-12 14:01:36 +01:00
jean-pierre charras bfb0fac015 Minor fixes related to I18n 2018-09-05 13:59:20 +02:00
Jeff Young 95a08d0dbc Follow file naming conventions. 2018-09-01 14:05:16 +01:00
Jeff Young 270f81f03d Make fill colour terminology more consistent. 
Fixes: lp:1789855
* https://bugs.launchpad.net/kicad/+bug/1789855
 2018-09-01 14:05:16 +01:00
Jeff Young c90a3efea2 Change KIDIALOG hashing algorithm to __FILE__ + __LINE__. 
Using Title + Message wasn't working for all the dialogs which
did substitutions in the message (which was a lot of them).

Fixes: lp:1789348
* https://bugs.launchpad.net/kicad/+bug/1789348
 2018-08-29 23:38:23 +01:00
Jeff Young 946f4a217d Fix grid sizing for symbol aliases. 2018-08-29 20:08:01 +01:00
Jeff Young 00b2c21820 Missed a HIG destructive button separation. 2018-08-29 20:08:00 +01:00
Jeff Young a9c8a7b69c Remove unused warp mouse parameter. 2018-08-29 19:59:02 +01:00
Jeff Young 45bc1b1aff Add single-click editing to grid cells. (Experimental.) 2018-08-29 19:59:02 +01:00
Jeff Young b90a261d5c More safety fixes for uncommitted grid changes. 2018-08-29 19:59:01 +01:00
Wayne Stambaugh 089f27f485 Remove more dialog control borders. 2018-08-27 15:11:27 -04:00
jean-pierre charras c756fc318e Fix a few wxWidgets minor alerts in DIALOG_EDIT_COMPONENTS_LIBID_BASE. 2018-08-22 17:14:30 +02:00
Jeff Young 779398891d Follow HIG guidelines for destructive button separation. 2018-08-21 10:34:41 +01:00