haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
40,452 Commits 9 Branches 105 Tags 1.3 GiB
Commit Graph

62 Commits

Author SHA1 Message Date
Jeff Young 04246a969c Show tuning status while tuning. 2023-12-03 14:23:57 +00:00
Jeff Young 33b602eb44 Use popup look & feel for on-canvas tuning status. 
We previously used the ruler look & feel because it leveraged
pre-existing code.

But it's too hard to read over a busy background.  Maybe the ruler
should move to popup look & feel as well?
 2023-12-03 13:21:01 +00:00
Jeff Young b13590f4c0 Use preview items instead of highlightNets & status popup 
The router preview item can be specific to the part that is being
tuned, rather than the whole net.  It's also less visually noisy as
it doesn't dim/undim the rest of the board.

Using kigfx preview items for the status keeps us from having a bunch
of focus issues with the status popup window.
 2023-12-02 16:15:43 +00:00
Alex Shvartzkop 2d9eee93e2 Fixes for length tuning patterns. 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16198
 2023-12-01 08:44:10 +03:00
Graham Keeth 4f36f669dc Use Title Case for property names 2023-11-29 01:23:35 +00:00
Alex Shvartzkop f84bab00b4 Fix build; renaming. 2023-11-28 22:18:37 +03:00
Alex Shvartzkop 7eb98a9863 Fixes for tuning patterns and router. 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16160
 2023-11-28 20:55:39 +03:00
Seth Hillbrand 619c9bb0e4 Don't include hidden layers when selecting tuning 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16188
 2023-11-28 09:41:09 -08:00
Jeff Young efaa131bc4 Position dummy tuning pattern before trying to get length out of it. 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16165
 2023-11-26 18:18:49 +00:00
Jeff Young 2a198e22e2 Draw tuning pattern border when placing. 2023-11-23 23:25:49 +00:00
Jeff Young b6501ce632 Report current length on roll-over. 2023-11-23 23:25:49 +00:00
Alex Shvartzkop 05e954ad5d Fixes for length tuning patterns. 2023-11-12 12:17:08 +03:00
Alex Shvartzkop 78c7dc85f0 Fix moving tuning patterns, disable rotation. 2023-11-12 02:24:35 +03:00
Jeff Young cc721c4907 Improve encapsulation of group internals. 
(It's still leaking into BOARD_COMMIT and some other places, but at
least it no longer leaks into all the edit tools.)

Also fixes some bugs when moving/copying/pasting multiple selections
containing length-tuning patterns.
 2023-11-09 14:05:35 +00:00
Jeff Young b5d904b45d Ignore VVIAs when assembling length-tuning line. 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15995
 2023-10-30 19:55:51 +00:00
Jeff Young 7c08aa09d5 Don't generate virtual vias when editing a tuning pattern. 2023-10-22 20:35:15 +01:00
Jeff Young 5da35d7750 Don't modify dp-tuning when doing skew tuning. 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15901
 2023-10-22 20:35:14 +01:00
Jeff Young fc22e602e2 Coverity fixes. 2023-10-20 16:38:21 +01:00
Jeff Young 00fb542146 nullptr safety 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15906
 2023-10-20 16:28:05 +01:00
Jeff Young 68a5753c80 Repair Rotate on PCB_GENERATOR items. 2023-10-19 23:34:52 +01:00
Jeff Young 24ddc728e8 Add PCB_ACTIONS::regenerateAllTuning.... 
... and move GENERATOR_TOOL to RegenerateAllOfType().
 2023-10-19 11:20:09 +01:00
Jeff Young 67f0f6e3b9 Rename class to match current terminology. 2023-10-19 01:31:13 +01:00
Jeff Young e5225abb62 Tuning mode is invariant. 
Don't show target skew for length tuning, and don't show
target length for skew tuning.
 2023-10-17 13:30:58 +01:00
Jeff Young 89011e888c More modern look & feel for tuning status popup. 
(Also includes min and max info, and move string processing out
of router.)
 2023-10-17 13:30:58 +01:00
Jeff Young 9ed802e951 Support min/max rules in diff pair placer and skew placer. 2023-10-17 13:30:58 +01:00
Jeff Young 9c4bb464ac Improve tuning status popup colours. 2023-10-17 13:30:58 +01:00
Jeff Young a2e35aabae Trim meander group items to just the tuning pattern. 2023-10-16 13:44:05 +01:00
Jeff Young 64cc8dd6aa Adjust dashed-box and edit-point locations to be outside meanders. 2023-10-16 13:44:05 +01:00
Jeff Young d51e058e24 Move diff-pair netname resolution to BOARD. 
Also adds reporting of dp gap constaints and max uncoupled to track
selections, and max uncoupled during routing.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/13748
 2023-10-15 22:46:23 +01:00
Jeff Young 2c02c26af4 Centralize min/opt/max printing. 2023-10-15 22:46:23 +01:00
Jeff Young ccc20348bf Don't start with MEANDER_SIDE_DEFAULT. 
It means we get a different default for left-to-right-drawn than we
do when going the other way.

Also fixes bug in PNS::DP_MEANDER_PLACER so that it honours side
specified in settings.
 2023-10-15 17:59:11 +01:00
Jeff Young 2450250ae7 Use "tuning pattern" in the GUI. 2023-10-15 17:59:11 +01:00
Jeff Young 6baac175c5 Status bar messages for meanders. 2023-10-15 17:59:11 +01:00
jean-pierre charras 7efd414519 Fix minor Coverity and compil warnings 2023-10-15 15:55:31 +02:00
Jeff Young 8028ea893f Reduce public API of PCB_GENERATOR_MEANDERS. 
It doesn't make a huge difference because the class is declared in
the .cpp file, but it still makes it easier to understand what is
conceptually public and what is not.
 2023-10-14 15:04:18 +01:00
Jeff Young 5f5113c80a Pick up current rule values when editing meanders. 2023-10-14 15:04:18 +01:00
Thomas Pointhuber 7cb198e021 fix SEGV in pcb_generator_meanders 2023-10-12 21:47:34 +02:00
Jeff Young af020f4f9a Fixes for diff-pair meander rectangle & edit points. 2023-10-12 17:54:34 +01:00
Jeff Young 78ee6f2e42 Fix a couple of undo bugs. 
The first caused items coming back from undo to be hidden.

The second caused them to be ungrouped from the parent meander.
 2023-10-12 17:54:34 +01:00
Jeff Young cdc9c2e409 Fix undo bug where items come back hidden. 2023-10-12 17:54:34 +01:00
Jeff Young 16d904d47e Add support for diff-pair meanders. 2023-10-12 17:54:34 +01:00
Jeff Young d4b8b550f3 Go back to using VIEW::Hide() instead of ForcedTransparency(). 
(The issue was that the selection VIEW_GROUP drawing ignores the
HIDDEN flag so we need to make sure the PCB_GENERATOR_MEANDERS isn't
in the selection VIEW_GROUP while we're editing it.)
 2023-10-12 17:54:34 +01:00
Jeff Young 1b676985f6 Retire length tuning tool in favour of first-class meanders. 2023-10-12 17:54:34 +01:00
Jeff Young 1ca477aeee Unroll from PICKER_TOOL so we can handle amplitude/spacing events. 
Also fixes a bug where we didn't clear the router on an <ESC>.
 2023-10-12 17:54:34 +01:00
Jeff Young d6c2ad7503 Unroll from PICKER_TOOL so we can handle amplitude/spacing events. 
Also fixes a bug where we didn't clear the router on an <ESC>.
 2023-10-12 17:54:34 +01:00
Jeff Young 1aeccc5895 Unroll from PICKER_TOOL so we can handle amplitude/spacing events. 2023-10-12 17:54:34 +01:00
Jeff Young a57c9967f3 Draw meander borders while placing. 2023-10-12 17:54:34 +01:00
Jeff Young 4da3e0ff93 Make meander dashed-line borders constant size. 2023-10-12 17:54:34 +01:00
Jeff Young d04641c868 ADDED: support for editing target length in Meander Properties dialog. 
Also supports overriding the custom rules.
 2023-10-12 17:54:34 +01:00
Jeff Young 0683313ecb Fix ghosted image while moving meander. 
Also cleans up some undo description strings.  (They go in the menu
so they should be title-caps.)
 2023-10-10 15:24:58 +01:00