Jeff Young
f71998b34e
Remove repetitive calls to other cancel operations.
2018-11-19 16:03:30 +00:00
Jeff Young
5b9458f4c2
Don't delegate context menu to Selection Tool.
...
Our superclass can handle it more correctly (including the Cancel
item at the top).
2018-11-19 16:03:30 +00:00
jean-pierre charras
240051fb26
Worksheet display in GAL mode: fix missing filename and (in Eeschema) sheet full name.
2018-11-19 10:21:28 +01:00
Seth Hillbrand
eb689a5221
Ratsnest: Improve show heuristics
...
When the local ratsnest tool is used, it should toggle the state based
on the global ratsnest visibility. After changing state, the layer
cache is marked as well.
Possibly related to lp:1800301
(cherry picked from commit 22fbf30f22
)
2018-11-18 20:03:46 -08:00
jean-pierre charras
c539d6e0be
fix incorrect initialization of VIEW::m_boundary.
...
This parameter defines the working area (full page) size.
The fix is not perfect, because it does not take in account the page size.
However it is similar to the "old" initialization, before Eeschema GAL.
In Eeschema, a reasonable boundary size is used.
2018-11-18 20:04:17 +01:00
jean-pierre charras
65a967dca1
Fix minor I10n issues.
2018-11-18 14:40:36 +01:00
jean-pierre charras
2fdf13ab79
Fix minor compil warnings.
2018-11-18 10:12:34 +01:00
jean-pierre charras
0ef7aeb274
Fix incorrect behavior when collection footprint items in collectors.cpp.
...
It was a bug in commit 208622699
.
Fixes: lp:1803803
https://bugs.launchpad.net/kicad/+bug/1803803
2018-11-18 10:08:12 +01:00
Jeff Young
208622699f
Scale zone hit area by zoom.
...
Fixes: lp:1803362
* https://bugs.launchpad.net/kicad/+bug/1803362
2018-11-17 00:35:07 +00:00
Jeff Young
0de9cb345c
Add shortcuts to setting dialogs for track widths, via sizes and grid sizes.
...
Fixes: lp:1803671
* https://bugs.launchpad.net/kicad/+bug/1803671
2018-11-17 00:35:06 +00:00
Jeff Young
3c6adbdf03
Indent layer properties for better comprehension.
2018-11-17 00:35:06 +00:00
Seth Hillbrand
940353afde
GRID_HELPER: Keep edited items out of snap
...
Distinguish between the snap-from and snap-to items. Previously, we
used the SELECTED or DRAGGED flags but the flagging arcitecture was
inherently fragile. This specifies items directly that should not be
used as snap targets.
Fixes: lp:1802795
* https://bugs.launchpad.net/kicad/+bug/1802795
2018-11-16 10:05:31 -08:00
jean-pierre charras
b35b1bb644
Fix a few minor I18n issues.
...
Especially remove trailing and leading spaces in sentences, always annoying in translations, and never useful in sources.
2018-11-16 18:12:01 +01:00
Jeff Young
4050991d28
Move ERC marker focusing to GAL architecture.
...
Fixes: lp:1802537
* https://bugs.launchpad.net/kicad/+bug/1802537
2018-11-16 10:38:44 +00:00
jean-pierre charras
8c8ccf83e6
Fix a few I18n minor issues.
2018-11-16 09:43:40 +01:00
jean-pierre charras
1f3d5cee0e
Fix a few minor I18n issues.
2018-11-15 09:34:29 +01:00
Jeff Young
bcc8c64256
Consider edge cuts items to have zero width when filling zones.
...
Fixes: lp:1797787
* https://bugs.launchpad.net/kicad/+bug/1797787
2018-11-14 23:45:32 +00:00
Jeff Young
02a559678a
Improve terminology of track selection commands.
...
There was confusion that "copper" and "net" meant zones, and there
was confusion about what "trivial" meant.
Fixes: lp:1772251
* https://bugs.launchpad.net/kicad/+bug/1772251
2018-11-13 21:29:35 +00:00
Maciej Suminski
361b768aaf
Fix frozen cursor on interactive DXF placement
2018-11-13 14:58:54 +01:00
Jeff Young
86273e86b9
Added user and grid origins to Position Relative dialog.
...
Also fixed a refresh bug when doing Position Relative.
Fixes: lp:1792699
* https://bugs.launchpad.net/kicad/+bug/1792699
2018-11-12 23:09:45 +00:00
Jeff Young
6d76097291
When running selectable() recursively, we're really only checking visibility.
...
Fixes: lp:1802949
* https://bugs.launchpad.net/kicad/+bug/1802949
2018-11-12 21:59:43 +00:00
Jeff Young
fdff010199
Fix copy/paste errors in delayedFocusRow stuff.
...
Fixes: lp:1802907
* https://bugs.launchpad.net/kicad/+bug/1802907
2018-11-12 17:08:45 +00:00
Seth Hillbrand
c15c64e991
GRID_HELPER: Don't snap to sub elements being moved
...
Fixes: lp:1802795
* https://bugs.launchpad.net/kicad/+bug/1802795
2018-11-12 06:53:33 -08:00
Jeff Young
62e2fe8bbd
Recurse for more detailed selectability tests.
...
Fixes: lp:1801709
* https://bugs.launchpad.net/kicad/+bug/1801709
2018-11-11 20:26:19 +00:00
Jeff Young
befc504734
Warp cursor back to creation point after new-text dailog.
...
Also fixes same issue for new zones.
Fixes: lp:1802532
* https://bugs.launchpad.net/kicad/+bug/1802532
2018-11-11 20:26:19 +00:00
Jeff Young
6789103961
Save internal values rather than textbox content.
...
Fixes: lp:1802442
* https://bugs.launchpad.net/kicad/+bug/1802442
2018-11-11 20:26:19 +00:00
Jeff Young
295013e4a9
Clarify fp reference filter and add fp id filter.
...
Fixes: lp:
* https://bugs.launchpad.net/kicad/+bug/
2018-11-11 20:26:19 +00:00
Seth Hillbrand
c24f70ba1e
GRID_HELPER: Filter targets based on dragging
...
Filtering based on selection ignores the use case where we are measuring
to a selected item. This utilizes the dragged flag to prevent snapping
based on the current state of the item drag.
Fixes: lp:1801089
* https://bugs.launchpad.net/kicad/+bug/1801089
2018-11-11 11:30:36 -08:00
Seth Hillbrand
cf20b39ddc
GRID HELPER: Consider all snappable items
...
When snapping, we should allow any point identified as a snappable
point. The additional consideration for corners might be used for
alignment in the future.
Fixes: lp:1802741
* https://bugs.launchpad.net/kicad/+bug/1802741
2018-11-11 11:30:36 -08:00
jean-pierre charras
fcafe5362f
NC drill (Excellon) exporter: remove useless M71 / M72 lines.
...
They are probably incorrect in V2 format, and the format is already specified.
2018-11-11 19:57:16 +01:00
jean-pierre charras
0d3637c2ee
Fix a few minor I18n issues.
...
Avoid translation of debug messages.
2018-11-11 10:46:26 +01:00
jean-pierre charras
f7cf40f2f4
Fix a few Coverity warnings.
...
Sometimes a dynamic_cast was used without testing the returned value.
Some are replaced by static_cast, when the dynamic_cast was useless.
2018-11-11 08:28:58 +01:00
jean-pierre charras
acfa13c038
Fix typo
2018-11-09 15:46:09 +01:00
Seth Hillbrand
70e660dfe8
GRID_HELPER: Update target geometry when moving
...
Setting a previously visible item visible is a nop. If the target was
visible, make sure to update the geometry
Fixes: lp:1802405
* https://bugs.launchpad.net/kicad/+bug/1802405
2018-11-09 06:12:31 -08:00
Wayne Stambaugh
f1f4473d8b
Footprint editor: add save view to PNG file.
...
Factor out save current canvas view to image file code from symbol editor
code so it can be used anywhere.
Add ability to save to any image format supported by wxBitmapType. See
https://docs.wxwidgets.org/3.0/gdicmn_8h.html#a90a1eb6d85b5044a99b706fd979f27f5 .
Currently only PNG output is implemented.
Please note that there is a minor bug that appears to be due to the
scroll bars which causes unfilled areas on the right and bottom edges
of the image. This always existed in the save symbol editor view
image but it was not as noticeable because by default the background
color is white. It is very noticeable in the footprint editor with
a black background.
The usual smattering of coding policy and comment fixes.
Fixes lp:1802127
https://bugs.launchpad.net/kicad/+bug/1802127
2018-11-09 08:32:36 -05:00
Jeff Young
5c726744b6
Move Zone Properties dialog to Connect() strategy.
...
If checkboxes don't have individual IDs FormBuilder won't assign
them and the event table ends up connecting each checkbox to all
of the checkbox handlers in the dialog.
Fixes: lp:1801746
* https://bugs.launchpad.net/kicad/+bug/1801746
2018-11-08 21:27:15 +00:00
Seth Hillbrand
4b931aeb57
pcbnew: Force cursor position when snapping
...
This places the crosshairs (confusingly named here) at the snap
position, either one of the snap points or the grid, depending on the
status of the hotkeys SHIFT/ALT.
Fixes: lp:1801373
* https://bugs.launchpad.net/kicad/+bug/1801373
Fixes: lp:1801369
* https://bugs.launchpad.net/kicad/+bug/1801369
2018-11-07 14:36:46 -08:00
Seth Hillbrand
f2ccad39b6
pcbnew: Fix grid snapping for picker
...
Fixes: lp:1801373
* https://bugs.launchpad.net/kicad/+bug/1801373
2018-11-07 09:03:26 -08:00
Jeff Young
5c26b1dabd
Don't use C-style cast when we don't actually know what it is.
2018-11-07 14:24:16 +00:00
Jeff Young
3439551543
Implement a work-around for net-ties.
...
Fixes: lp:1799318
* https://bugs.launchpad.net/kicad/+bug/1799318
2018-11-07 14:24:16 +00:00
Seth Hillbrand
1f25fcd3d6
pcbnew: Shift zone filler to std::async
2018-11-06 09:28:12 -08:00
Seth Hillbrand
a24bd9baa1
pcbnew: Adjust default update rate to 100ms
...
10ms was too fast to update the progress reporter and actually slowed
the process down for many machines.
2018-11-06 09:28:12 -08:00
jean-pierre charras
238abad004
Gerber job file: fix incorrect GUID.
...
Fixes: lp:1801696
https://bugs.launchpad.net/kicad/+bug/1801696
2018-11-06 08:16:07 +01:00
Maciej Suminski
4ad37bc9ea
Limit 'items on disabled layers' DRC check to copper layers
...
Fixes: lp:1788248
* https://bugs.launchpad.net/kicad/+bug/1788248
2018-11-05 14:00:49 +01:00
Jeff Young
6e9475694c
Fix bug with zone selection when zones are shown filled.
2018-11-04 19:17:53 +00:00
Seth Hillbrand
df562b7ec0
pcbnew: Prevent degenerate values in Eagle import
...
Importing Eagle files allowed for invalid zone values for clearance and
minimum width that triggered asserts in the 3d-viewer.
Fixes: lp:1801188
* https://bugs.launchpad.net/kicad/+bug/1801188
2018-11-04 11:01:08 -08:00
jean-pierre charras
93d3e4ccf8
dialog_footprint_wizard_list_base.cpp: fix a minor wxWidgets alert.
2018-11-04 15:50:29 +01:00
Jeff Young
589e1f6a96
MSW and GTK need a separate dialog for opening/saving directories.
...
Fixes: lp:1801528
* https://bugs.launchpad.net/kicad/+bug/1801528
2018-11-04 12:35:01 +00:00
Jeff Young
68b07d1aff
Add show/hide search tree to modedit, and fix it in libedit.
...
Fixes: lp:1801531
* https://bugs.launchpad.net/kicad/+bug/1801531
2018-11-04 12:35:01 +00:00
Jeff Young
3bfd32cdc5
Inherit grid settings from PCBNew.
...
Fixes: lp:1801428
* https://bugs.launchpad.net/kicad/+bug/1801428
2018-11-04 12:35:01 +00:00