33b602eb44
Use popup look & feel for on-canvas tuning status.
...
We previously used the ruler look & feel because it leveraged
pre-existing code.
But it's too hard to read over a busy background. Maybe the ruler
should move to popup look & feel as well?
2023-12-03 13:21:01 +00:00
b13590f4c0
Use preview items instead of highlightNets & status popup
...
The router preview item can be specific to the part that is being
tuned, rather than the whole net. It's also less visually noisy as
it doesn't dim/undim the rest of the board.
Using kigfx preview items for the status keeps us from having a bunch
of focus issues with the status popup window.
2023-12-02 16:15:43 +00:00
2d9eee93e2
Fixes for length tuning patterns.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16198
2023-12-01 08:44:10 +03:00
4f36f669dc
Use Title Case for property names
2023-11-29 01:23:35 +00:00
f84bab00b4
Fix build; renaming.
2023-11-28 22:18:37 +03:00
7eb98a9863
Fixes for tuning patterns and router.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16160
2023-11-28 20:55:39 +03:00
619c9bb0e4
Don't include hidden layers when selecting tuning
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16188
2023-11-28 09:41:09 -08:00
efaa131bc4
Position dummy tuning pattern before trying to get length out of it.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16165
2023-11-26 18:18:49 +00:00
2a198e22e2
Draw tuning pattern border when placing.
2023-11-23 23:25:49 +00:00
b6501ce632
Report current length on roll-over.
2023-11-23 23:25:49 +00:00
05e954ad5d
Fixes for length tuning patterns.
2023-11-12 12:17:08 +03:00
78c7dc85f0
Fix moving tuning patterns, disable rotation.
2023-11-12 02:24:35 +03:00
cc721c4907
Improve encapsulation of group internals.
...
(It's still leaking into BOARD_COMMIT and some other places, but at
least it no longer leaks into all the edit tools.)
Also fixes some bugs when moving/copying/pasting multiple selections
containing length-tuning patterns.
2023-11-09 14:05:35 +00:00
b5d904b45d
Ignore VVIAs when assembling length-tuning line.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15995
2023-10-30 19:55:51 +00:00
7c08aa09d5
Don't generate virtual vias when editing a tuning pattern.
2023-10-22 20:35:15 +01:00
5da35d7750
Don't modify dp-tuning when doing skew tuning.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15901
2023-10-22 20:35:14 +01:00
fc22e602e2
Coverity fixes.
2023-10-20 16:38:21 +01:00
00fb542146
nullptr safety
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15906
2023-10-20 16:28:05 +01:00
68a5753c80
Repair Rotate on PCB_GENERATOR items.
2023-10-19 23:34:52 +01:00
24ddc728e8
Add PCB_ACTIONS::regenerateAllTuning....
...
... and move GENERATOR_TOOL to RegenerateAllOfType().
2023-10-19 11:20:09 +01:00
67f0f6e3b9
Rename class to match current terminology.
2023-10-19 01:31:13 +01:00
e5225abb62
Tuning mode is invariant.
...
Don't show target skew for length tuning, and don't show
target length for skew tuning.
2023-10-17 13:30:58 +01:00
89011e888c
More modern look & feel for tuning status popup.
...
(Also includes min and max info, and move string processing out
of router.)
2023-10-17 13:30:58 +01:00
9ed802e951
Support min/max rules in diff pair placer and skew placer.
2023-10-17 13:30:58 +01:00
9c4bb464ac
Improve tuning status popup colours.
2023-10-17 13:30:58 +01:00
a2e35aabae
Trim meander group items to just the tuning pattern.
2023-10-16 13:44:05 +01:00
64cc8dd6aa
Adjust dashed-box and edit-point locations to be outside meanders.
2023-10-16 13:44:05 +01:00
d51e058e24
Move diff-pair netname resolution to BOARD.
...
Also adds reporting of dp gap constaints and max uncoupled to track
selections, and max uncoupled during routing.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/13748
2023-10-15 22:46:23 +01:00
2c02c26af4
Centralize min/opt/max printing.
2023-10-15 22:46:23 +01:00
ccc20348bf
Don't start with MEANDER_SIDE_DEFAULT.
...
It means we get a different default for left-to-right-drawn than we
do when going the other way.
Also fixes bug in PNS::DP_MEANDER_PLACER so that it honours side
specified in settings.
2023-10-15 17:59:11 +01:00
2450250ae7
Use "tuning pattern" in the GUI.
2023-10-15 17:59:11 +01:00
6baac175c5
Status bar messages for meanders.
2023-10-15 17:59:11 +01:00
7efd414519
Fix minor Coverity and compil warnings
2023-10-15 15:55:31 +02:00
8028ea893f
Reduce public API of PCB_GENERATOR_MEANDERS.
...
It doesn't make a huge difference because the class is declared in
the .cpp file, but it still makes it easier to understand what is
conceptually public and what is not.
2023-10-14 15:04:18 +01:00
5f5113c80a
Pick up current rule values when editing meanders.
2023-10-14 15:04:18 +01:00
7cb198e021
fix SEGV in pcb_generator_meanders
2023-10-12 21:47:34 +02:00
af020f4f9a
Fixes for diff-pair meander rectangle & edit points.
2023-10-12 17:54:34 +01:00
78ee6f2e42
Fix a couple of undo bugs.
...
The first caused items coming back from undo to be hidden.
The second caused them to be ungrouped from the parent meander.
2023-10-12 17:54:34 +01:00
cdc9c2e409
Fix undo bug where items come back hidden.
2023-10-12 17:54:34 +01:00
16d904d47e
Add support for diff-pair meanders.
2023-10-12 17:54:34 +01:00
d4b8b550f3
Go back to using VIEW::Hide() instead of ForcedTransparency().
...
(The issue was that the selection VIEW_GROUP drawing ignores the
HIDDEN flag so we need to make sure the PCB_GENERATOR_MEANDERS isn't
in the selection VIEW_GROUP while we're editing it.)
2023-10-12 17:54:34 +01:00
1b676985f6
Retire length tuning tool in favour of first-class meanders.
2023-10-12 17:54:34 +01:00
1ca477aeee
Unroll from PICKER_TOOL so we can handle amplitude/spacing events.
...
Also fixes a bug where we didn't clear the router on an <ESC>.
2023-10-12 17:54:34 +01:00
d6c2ad7503
Unroll from PICKER_TOOL so we can handle amplitude/spacing events.
...
Also fixes a bug where we didn't clear the router on an <ESC>.
2023-10-12 17:54:34 +01:00
1aeccc5895
Unroll from PICKER_TOOL so we can handle amplitude/spacing events.
2023-10-12 17:54:34 +01:00
a57c9967f3
Draw meander borders while placing.
2023-10-12 17:54:34 +01:00
4da3e0ff93
Make meander dashed-line borders constant size.
2023-10-12 17:54:34 +01:00
d04641c868
ADDED: support for editing target length in Meander Properties dialog.
...
Also supports overriding the custom rules.
2023-10-12 17:54:34 +01:00
0683313ecb
Fix ghosted image while moving meander.
...
Also cleans up some undo description strings. (They go in the menu
so they should be title-caps.)
2023-10-10 15:24:58 +01:00
d916e650f1
Tuning status popup for point editor.
2023-10-10 11:55:57 +01:00
bb74445dda
Code clarity.
2023-10-10 11:14:47 +01:00
4226839586
Switch to diff-pair mode if startItem is a diff-pair member.
2023-10-10 11:08:53 +01:00
099e5dd9e7
More undo bugs.
2023-10-09 22:32:32 +01:00
994f9f8823
Cleanup & compiler warnings.
2023-10-09 22:32:32 +01:00
642938455e
Add status popup for meander placer.
2023-10-09 22:32:32 +01:00
1afa6ddbd5
Rename getLineBetweenPoints() to getLine().
...
While it uses the first point to find the line, it in fact returns
the entire connection, not just the part between the two points.
2023-10-09 22:32:32 +01:00
44e0821e13
Fix some issues with undo.
...
Also fixes the baseline being visible while placing the meander.
2023-10-09 22:32:32 +01:00
d10b0b053e
Move meander placer picker tool from item highlighting to net highlighting.
2023-10-09 22:32:32 +01:00
b662ff4956
Improve graphical feedback while placing a meander.
2023-10-09 15:22:41 +01:00
c9d6e79d2d
Fix minor compil warnings.
2023-10-08 15:04:45 +02:00
a4832dd3c8
ADDED: Interactive meander objects for length tuning.
2023-10-08 02:41:17 +00:00
Jeff Young
Alex Shvartzkop
Graham Keeth
Seth Hillbrand
jean-pierre charras
Thomas Pointhuber