haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
kicad/pcbnew/tools
History
Jeff Young 77334628c4 Change default tool behaviour to skip unhandled events. 
The problem is that wxEVT_CHAR_HOOK doesn’t do the key translation
properly.  wxEVT_CHAR does, but we only get to that if we skip the
event at the end of the tool’s event processing loop, which most tools
don’t do.  (Selection tools, point editors, pickers, and a couple of
others do skip, which is probably why this didn’t get reported earlier.)

I played around with a couple of ways to fix wxEVT_CHAR_HOOK.  Most of
them don’t work, and the few egregious hacks I tried weren't cross-
platform.

So I’m changing it so that most tools now skip at the end of their
event loops.  I left out a couple that I felt were high risk (length
tuning, for instance).  But there’s still enough risk that I’m 100%
sure it will break something, I just haven’t a clue what.

Fixes: lp:1836903
* https://bugs.launchpad.net/kicad/+bug/1836903
 		2019-07-26 12:21:24 -06:00
..
drawing_tool.cpp Change default tool behaviour to skip unhandled events. 2019-07-26 12:21:24 -06:00
drawing_tool.h A more robust fix for 36f1d023f0. 2019-07-15 14:15:24 +01:00
drc.cpp Implement preserved-corners to prevent divots when filling adjacent zones. 2019-07-14 18:18:48 +01:00
drc.h Performance enhancements to zone filling & track DRC. 2019-06-25 11:34:28 +01:00
drc_clearance_test_functions.cpp Performance enhancements to zone filling & track DRC. 2019-06-25 11:34:28 +01:00
edit_tool.cpp Change default tool behaviour to skip unhandled events. 2019-07-26 12:21:24 -06:00
edit_tool.h Fix event-loop issue with some pickers. 2019-07-17 21:35:28 +01:00
footprint_editor_tools.cpp Don't try and run drawing tools in ModEdit with no module selected. 2019-07-19 15:29:10 -06:00
footprint_editor_tools.h Reconcile tool and menu for Enumerate Pads. 2019-06-10 23:46:01 +01:00
global_edit_tool.cpp Implement I18N for ACTIONs. 2019-06-17 10:45:23 +01:00
global_edit_tool.h Move global commands to ACTIONs. 2019-06-03 21:08:30 +01:00
grid_helper.cpp Push Eeschema & PLEditor PICKER_TOOLs down into common. 2019-07-16 00:44:01 +01:00
grid_helper.h Push Eeschema & PLEditor PICKER_TOOLs down into common. 2019-07-16 00:44:01 +01:00
microwave_tool.cpp Change default tool behaviour to skip unhandled events. 2019-07-26 12:21:24 -06:00
microwave_tool.h Insert EE_TOOL_BASE under SchEdit and LibEdit tools, and fix errant rename scope which clobbered PCBNew's PICKER_TOOL. 2019-05-12 13:47:08 +01:00
pad_tool.cpp Change default tool behaviour to skip unhandled events. 2019-07-26 12:21:24 -06:00
pad_tool.h Reconcile tool and menu for Enumerate Pads. 2019-06-10 23:46:01 +01:00
pcb_actions.cpp Fix missing AF_ACTIVATE flags on some tools. 2019-07-26 12:21:24 -06:00
pcb_actions.h added board statistics dialog, which shows info for production and assembly 2019-07-20 14:39:08 -06:00
pcb_bright_box.cpp Refactor BRIGHT_BOX to common so it can be used by other programs 2017-03-11 21:38:01 +01:00
pcb_bright_box.h Refactor BRIGHT_BOX to common so it can be used by other programs 2017-03-11 21:38:01 +01:00
pcb_editor_control.cpp Change default tool behaviour to skip unhandled events. 2019-07-26 12:21:24 -06:00
pcb_editor_control.h Fix re-entrancy problem in cross-probing. 2019-07-17 21:35:28 +01:00
pcb_inspection_tool.cpp added board statistics dialog, which shows info for production and assembly 2019-07-20 14:39:08 -06:00
pcb_inspection_tool.h added board statistics dialog, which shows info for production and assembly 2019-07-20 14:39:08 -06:00
pcb_selection_conditions.cpp pcbnew: Rename PCB_ZONE_T and remove from connectivity 2018-09-29 15:09:15 -07:00
pcb_selection_conditions.h Refactor SELECTION, SELECTION_CONDITIONS, and context menus to common 2017-02-28 14:47:20 +01:00
pcb_tool_base.cpp Change default tool behaviour to skip unhandled events. 2019-07-26 12:21:24 -06:00
pcb_tool_base.h A more robust fix for 36f1d023f0. 2019-07-15 14:15:24 +01:00
pcbnew_control.cpp Fix crash bugs in picker tools. 2019-07-21 19:06:06 -06:00
pcbnew_control.h Real-time highlighting for Pcbnew and ModEdit delete tools. 2019-06-25 21:10:21 +01:00
pcbnew_picker_tool.cpp Fix bug with PCBNEW_PICKER_TOOL not doing a push/pop. 2019-07-16 20:25:25 +01:00
pcbnew_picker_tool.h kicad_plugin.cpp: fix incorrect detection of existing footprints in PCB_IO::FootprintExists(), when fp names contain a point. 2019-07-19 18:16:07 +02:00
pcbnew_selection.cpp Convert separate-compilation of selection.cpp to polymorphism. 2019-06-10 23:46:00 +01:00
pcbnew_selection.h Convert separate-compilation of selection.cpp to polymorphism. 2019-06-10 23:46:00 +01:00
placement_tool.cpp Implement I18N for ACTIONs. 2019-06-17 10:45:23 +01:00
placement_tool.h Move hotkeys to ACTION architecture. 2019-06-10 23:46:00 +01:00
point_editor.cpp Push Eeschema & PLEditor PICKER_TOOLs down into common. 2019-07-16 00:44:01 +01:00
point_editor.h Allow edits to self-intersecting polygons. 2019-07-14 18:18:48 +01:00
position_relative_tool.cpp Make sure the postion relative tool gets activated when used. 2019-07-19 20:14:40 -06:00
position_relative_tool.h Move hotkeys to ACTION architecture. 2019-06-10 23:46:00 +01:00
selection_tool.cpp Implement preference for immediate actions. 2019-07-25 20:41:22 -06:00
selection_tool.h Homogenize selection tools around our HIG. 2019-07-09 21:59:46 +01:00
tool_event_utils.cpp More modern toolset context menu work. 2019-05-05 17:12:59 +01:00
tool_event_utils.h More modern toolset context menu work. 2019-05-05 17:12:59 +01:00
zone_create_helper.cpp Allow edits to self-intersecting polygons. 2019-07-14 18:18:48 +01:00
zone_create_helper.h Immediate actions for PlEditor, PcbNew, etc. 2019-06-25 11:34:28 +01:00
zone_filler_tool.cpp A better hack for the post-ProgressReporter-loss-of-focus issue. 2019-07-14 18:18:48 +01:00
zone_filler_tool.h A better hack for the post-ProgressReporter-loss-of-focus issue. 2019-07-14 18:18:48 +01:00