haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
kicad/include
History
dwilches 963b4d5ed6 Fix Preferred Editor dialog (lp: 1558353) 
The functions involved in the problem were PGM_BASE::GetEditorName and
EDA_BASE_FRAME::OnSelectPreferredEditor:

1) OnSelectPreferredEditor showed a dialog to allow the user selecting the
editor, but before that called GetEditorName to get the name of the current
editor (to show as a default in the choose file dialog).

2) The problem was when there was no editor, GetEditorName showed its own
dialog.

3) So the user was seeing first the dialog from (2) and then the dialog from
(1).

4) As GetEditorName is used in many other places the solution I did was to add
to it an optional parameter that tells it what to do if no editor is set. To
avoid modifying other code that relies on the current behaviour, this parameter
has a default value that causes to show the dialog. But now when
OnSelectPreferredEditor calls it, it passes the parameter that causes it to
return an empty string if no editor was set.

5) Also, I found a second bug while doing it which allowed in the first dialog
to select an unexistent file (the dialog was missing the wxFD_FILE_MUST_EXIST
flag).

6) Lastly, to avoid having duplicated code (the one that showed the same dialog
and that configured the wildcard was in two methods) I created a single
function that now both functions call: PGM_BASE::AskUserForPreferredEditor.
This way we also will have consistency in the behaviour of both dialogs and
there is a single place where it needs to be modified.
 		2016-03-18 08:11:19 -04:00
..
core Modular KiCad Blueprint Milestone B), major portions: 2014-08-13 15:28:54 -05:00
gal Fix incorrect (too small) bounding box EDA_TEXT, noticeable when chars like j or { are used in zone fill functions. 2016-03-11 16:30:32 -05:00
geometry More accurate pushout force calculation for circle-segment collisions. (fixes lp:1551579) 2016-03-01 08:44:02 -05:00
math Fixed a few warnings. 2015-07-15 14:08:50 +02:00
tool TOOL_SETTINGS acquires wxConfigBase each time it is used. 2015-08-07 18:17:51 +02:00
ttl Removed a redundant field in RN_NODE class. 2015-06-05 17:49:01 +02:00
view Fixed cursor freeze in pcbnew (GAL). 2015-07-24 10:58:47 +02:00
HersheyCyrillic.h.unused Use layer_widget in Gerbview 2010-02-03 14:05:17 +00:00
base_struct.h Minot fixes: Minor coding style issues fix (tab -> spaces). Add missing GetClass to all classes derived from EDA_ITEM. Make debug method Show() only compiled in debug mode. 2015-03-06 09:58:32 +01:00
base_units.h Add "move exact" and "duplicate" tools to pcbnew 2015-02-12 03:22:24 +00:00
bezier_curves.h More missing source license fixes. 2014-10-22 11:51:34 -04:00
bin_mod.h improve help file finding after kiway breakage. 2014-04-14 13:49:52 -05:00
bitmaps.h KiCad: add html file support to tree view. 2015-06-24 15:30:35 -04:00
block_commande.h Fix Bug #1426675 (Undo and cancel commands don't have effect for Duplicate operation in legacy mode) 2015-03-22 10:42:41 +01:00
build_version.h More missing source license fixes. 2014-10-22 11:51:34 -04:00
class_base_screen.h Fix saving undo/redo limits in Eeschema. 2015-08-05 20:10:52 -04:00
class_bitmap_base.h Very minor fixes: add missing const return type to some GetBoundingBox() declarations. Change few functions names to better names in some places (like GetName() to GetPinName() ) 2015-01-18 18:28:14 +01:00
class_board_design_settings.h Remove a few coverity warnings. Fix some comments which were incorrect, due to the changes in code. Remove not compiled code (kept as comments), now outdated or useless 2015-03-13 17:48:42 +01:00
class_board_item.h Moved GetLayerSet() to BOARD_ITEM. 2015-06-04 14:54:07 +02:00
class_collector.h Try to fix Bug #1431391 (Unable to edit pins in Schematic library editor). It happens on XFCE, but also on Unity. This fix works on Unity. (it is due to the fact the dialog is not raised, for an unknown reason, and this bug depend on the way Eeschema and Libedit are run). 2015-03-14 12:50:39 +01:00
class_colors_design_settings.h Add missing source file licenses and code policy fixes. 2014-10-19 16:20:16 -04:00
class_draw_panel_gal.h Fixed the problem of GAL frames excessively taking over focus in Windows. 2015-08-25 11:21:00 +02:00
class_drawpanel.h Fix middle mouse panning bug and cross-hair drawing bug. (fixes lp:1462067). 2015-07-22 19:33:50 -04:00
class_drc_item.h Fix uninitialized member in DRC_ITEM constructor. 2014-08-16 14:12:11 -04:00
class_eda_rect.h Fixing SELECTION_TOOL heuristics, take #2. 2015-07-30 13:49:35 +02:00
class_layer_box_selector.h More missing source license fixes. 2014-10-22 11:51:34 -04:00
class_macros_record.h More missing source license fixes. 2014-10-22 11:51:34 -04:00
class_marker_base.h Move the non shared file class_sch_screen.h to eeschema folder. Code cleaning. Remove some wxCHECK_VERSION tests now useless. 2015-07-29 20:06:45 +02:00
class_page_info.h Move the non shared file class_sch_screen.h to eeschema folder. Code cleaning. Remove some wxCHECK_VERSION tests now useless. 2015-07-29 20:06:45 +02:00
class_pcb_screen.h More missing source license fixes. 2014-10-22 11:51:34 -04:00
class_title_block.h Minor and very minors fixes: move -DKICAD_USE_WEBKIT definition to the main CMakeLists.txt. Remove duplicate semi-colon at end of some lines. 2015-01-17 09:01:16 +01:00
class_undoredo_container.h Added const modifiers where applicable (PICKED_ITEMS_LIST). 2013-12-18 13:27:18 +01:00
class_worksheet_dataitem.h More missing source license fixes. 2014-10-22 11:51:34 -04:00
colors.h A bit of cleaning code. 2015-07-08 19:46:24 +02:00
colors_selection.h More missing source license fixes. 2014-10-22 11:51:34 -04:00
common.h Minor fixes. 2015-06-30 18:31:48 +02:00
config_params.h Cvpcb: very minor fixes. 2015-01-11 19:35:02 +01:00
confirm.h Minor message box improvements 2013-10-18 09:32:22 -04:00
convert_basic_shapes_to_polygon.h Removed all dependencies on boost::polygon except for bitmap2component. Replaced almost all instances of CPOLYGONS_LIST with SHAPE_POLY_SET. 2015-07-27 21:45:57 +02:00
convert_from_iu.h Minor fixes: remove a few useless includes and move a few others to the right file. Remove a few coverity warnings about not initialized members. 2015-05-15 14:49:11 +02:00
convert_to_biu.h Minor fixes: remove a few useless includes and move a few others to the right file. Remove a few coverity warnings about not initialized members. 2015-05-15 14:49:11 +02:00
dialog_env_var_config.h Many minor fixes (like bug #1477213). Better help in dialog environment variables editor (the tooltip was never shown on Windows) 2015-07-24 12:23:34 +02:00
dialog_get_component.h More missing source license fixes. 2014-10-22 11:51:34 -04:00
dialog_helpers.h Try to fix an issue on Ubuntu/Unity for some dialogs which are not displayed. For most, adding GetSizer()->Fit( this ) in dialog constructor fix the issue, but at least one dialog still is not displayed. 2014-11-19 15:22:47 +01:00
dialog_hotkeys_editor.h Remove duplicate id for 2 buttons in dialog hotkeys editor and use better button label (Cancel instead of Close, because changes are actually cancelled by closing the editor). 2015-10-16 10:53:57 +02:00
dialog_shim.h Remove a few conditional compilation for wxWidgets version < 3.0 2015-11-09 13:14:28 +01:00
dlist.h Refinement to commit #4993. 2014-07-14 16:43:21 +02:00
draw_frame.h Push UI preferences to child edit and view windows. (fixes lp:1468388) 2015-08-25 10:16:15 -04:00
drawtxt.h More missing source license fixes. 2014-10-22 11:51:34 -04:00
dsnlexer.h More Coverity scan error fixes. 2015-02-22 16:25:29 -05:00
eda_dde.h More missing source license fixes. 2014-10-22 11:51:34 -04:00
eda_doc.h More missing source license fixes. 2014-10-22 11:51:34 -04:00
eda_text.h Pcbnew: simplify draw code in default canvas and plot functions by removing the plot LINE option, which is not existing in all plotters, not existing in opengl/cairo canvas, and not usefull in default canvas. 2015-02-02 09:06:39 +01:00
fctsys.h Move the non shared file class_sch_screen.h to eeschema folder. Code cleaning. Remove some wxCHECK_VERSION tests now useless. 2015-07-29 20:06:45 +02:00
filter_reader.h Add Pcbnew GEDA PCB module plugin support. 2012-12-28 15:52:12 -05:00
footprint_info.h CvPcb: count unique pin numbers when filtering by pin count. (fixes:1300719) 2015-11-11 13:35:26 -05:00
fp_lib_table.h More Coverity scan error fix goodness. 2015-02-28 15:50:35 -05:00
fpid.h Pcbnew: Fpid parser: Fix crash when reading a .kicad_pcb file containing a valid fpid with a revision value. 2015-08-23 14:35:49 +02:00
frame_type.h More missing source license fixes. 2014-10-22 11:51:34 -04:00
gestfich.h Default and most recently used path fixes. (fixes: 1494210) 2015-09-25 15:38:09 -04:00
gr_basic.h All: use solid lines instead of dashed lines to draw X and Y axis in legacy canvas (like in Gal canvas). The main reason: on OSX axis using dashed lines are very very slow to draw (looks like a wxWidget issue when the wxDC scale factor is very small) 2015-10-25 17:58:04 +01:00
grid_tricks.h *) Factor out Cut, Copy, and Paste for wxGrid into class common/GRID_TRICKS. 2013-10-23 13:56:03 -05:00
hashtables.h Temporary back to boost::polygon in 3d-viewer. Fix an assert warning in hashtables.h, when a wxString contains non basic ASCII chars (Bug #1470078). 2015-07-04 21:53:37 +02:00
hotkeys_basic.h Hot keys settings are synchronized between GAL & legacy 2015-05-05 20:39:42 +02:00
html_messagebox.h More missing source license fixes. 2014-10-22 11:51:34 -04:00
id.h Add path (environment variable) configuration dialog. 2015-03-29 17:22:53 -04:00
import_export.h * KIWAY Milestone A): Make major modules into DLL/DSOs. 2014-03-19 19:42:08 -05:00
ki_mutex.h More missing source license fixes. 2014-10-22 11:51:34 -04:00
kicad_device_context.h 1) Add "rules" to base of tree for copying into BZR_HOME/rules. 2013-05-25 23:36:44 -05:00
kicad_string.h Pcbnew: Fpid parser: Fix crash when reading a .kicad_pcb file containing a valid fpid with a revision value. 2015-08-23 14:35:49 +02:00
kiface_i.h Modular-Kicad milestone B), major portions: 2014-05-03 12:40:19 -05:00
kiway.h Comments typos fixed. 2015-04-06 21:50:12 +02:00
kiway_express.h remove KIWAY_EXPRESS::kiway_express() typo, add comments. 2014-04-22 10:26:59 -05:00
kiway_mgr.h *) Add KIFACE_I::StartFlags() and IsSingle() so a KIFACE implementation can know 2014-04-17 21:05:40 -05:00
kiway_player.h Remove a few conditional compilation for wxWidgets version < 3.0 2015-11-09 13:14:28 +01:00
layers_id_colors_and_visibility.h Pcbnew: fix bug when flipping a block that dosesn't flip inner layers nor their connected microvias. (fixes lp:1527446) 2016-02-08 19:16:07 -05:00
length.h.usuned Namespace KiGfx->KIGFX. 2013-10-14 16:13:35 +02:00
macros.h Remove a few conditional compilation for wxWidgets version < 3.0 2015-11-09 13:14:28 +01:00
mail_type.h Use KiwayExpress messaging for CvPcb footprint assignment instead of *.cmp file. 2015-06-07 14:18:45 -04:00
menus_helpers.h Remove duplicate icon apply.svg (use ckecked_ok.svg instead which is the same icon). 2014-02-07 20:32:08 +01:00
msgpanel.h More Coverity scan error fix goodness. 2015-02-28 15:50:35 -05:00
newstroke_font.h Fix incorrect (too small) bounding box EDA_TEXT, noticeable when chars like j or { are used in zone fill functions. 2016-03-11 16:30:32 -05:00
online_help.h Help files: can now be html or pdf files: Kicad search first for a .html help file, and if not found in a path, search for the corresponding .pdf file. 2014-09-02 18:44:53 +02:00
origin_viewitem.h Add axis origin to the Footprint Editor to align with the Legacy canvas 2015-09-05 20:47:35 +01:00
pad_shapes.h Rework on Enum PAD_SHAPE_T, PAD_DRILL_SHAPE_T and PAD_ATTR_T (see rev 6008) : the new and better names are now used in Kicad code and existing python scripts. 2015-08-23 21:40:33 +02:00
painter.h Net highlighting mode is toggled when used on the same net (GAL). 2015-09-03 17:56:30 +02:00
pcbcommon.h Default path fixes and remove old to find 3D model path code. 2015-02-27 08:34:02 -05:00
pcbstruct.h Pcbnew: simplify draw code in default canvas and plot functions by removing the plot LINE option, which is not existing in all plotters, not existing in opengl/cairo canvas, and not usefull in default canvas. 2015-02-02 09:06:39 +01:00
pgm_base.h Fix Preferred Editor dialog (lp: 1558353) 2016-03-18 08:11:19 -04:00
plot_common.h Plot PS and PDF: fix bug Bug #1457215 (rect/trap pads plotted with an incorrect pen size, and therefore an incorrect size and shape. Only noticeable with a large default pen size) 2015-05-21 11:04:47 +02:00
profile.h Remove superflous includes. 2015-07-31 09:50:47 -04:00
project.h Add schematic component library change rescue feature (fixes lp:1435338). 2015-04-25 18:26:51 -04:00
ptree.h switch back to original sexpr usage of PTREE, add new DSNLEXER constructor, enforce accessors in kicad.exe 2014-07-07 14:49:14 -05:00
reporter.h Added lazy rendering mode for HTML reporter widget (allows a faster report creation, when the report has many lines) 2015-07-24 17:47:48 +02:00
richio.h Use KiwayExpress messaging for CvPcb footprint assignment instead of *.cmp file. 2015-06-07 14:18:45 -04:00
search_stack.h Fix windows help path bug. (fixes lp:1313412) 2015-09-20 14:23:17 -04:00
trigo.h Eeschema: netlist generation: fix bad choice for the "best net name" when selecting a net name between labels connected to the same net. 2013-09-27 14:30:35 +02:00
utf8.h Python scripting: make UTF8 class accessible by python scripts. Add python method GetChars() to UTF8 class to get its char buffer. 2014-10-18 10:18:14 +02:00
validators.h Envrionment variable dialog improvments. 2015-08-16 20:30:29 -04:00
wildcards_and_files_ext.h KiCad: add html file support to tree view. 2015-06-24 15:30:35 -04:00
worksheet.h Code cleaning: move class PAGE_INFO from common.h to class_page_info.h; 2014-12-23 14:01:59 +01:00
worksheet_shape_builder.h Page layout selection: fix Bug #1405972, and add minor enhancement in page layout selection dialog (the new layout is shown after selection). 2014-12-31 13:31:19 +01:00
worksheet_viewitem.h Minot fixes: Minor coding style issues fix (tab -> spaces). Add missing GetClass to all classes derived from EDA_ITEM. Make debug method Show() only compiled in debug mode. 2015-03-06 09:58:32 +01:00
wxBasePcbFrame.h Small cleanup: remove a few unnecessary casts, and minor cleaning code. 2015-09-03 09:44:30 +02:00
wxPcbStruct.h Pcbnew: fix Flip hotkey for blocks in legacy (fixes lp:1534120) 2016-02-09 18:31:39 -05:00
wx_status_popup.h Code formatting. 2015-02-18 17:53:46 +01:00
wx_unit_binder.h Method to check WX_UNIT_BINDER value validity. 2015-07-09 13:35:50 +02:00
wxstruct.h Default and most recently used path fixes. (fixes: 1494210) 2015-09-25 15:38:09 -04:00
wxunittext.h Fix many doxygen warnings (due to missing info, old comments, typo ...) when building the doxygen doc. 2014-11-02 17:25:04 +01:00
xnode.h Remove a few conditional compilation for wxWidgets version < 3.0 2015-11-09 13:14:28 +01:00