kicad/eeschema/dialogs
John Beard 473c41ddbf Eeschema: internal tidying of field editor ApplyData
Make a few things const (specficially the reference into
m_fieldStore - we should commit to not modifying that in this
function.

Also avoid a couple of needless string copies.

Also explicitly dereference the into a (non-const) reference at the outset.
For the whole if this function, comp is the same object and may not
be null (as it is used unchecked).

(cherry picked from commit edd94ce2d6)
2019-03-27 10:29:36 +00:00
..
dialog_annotate.cpp eeschema-gal: initial GALified version. Lots of stuff still to do! 2018-10-09 11:08:52 +01:00
dialog_annotate_base.cpp Fix MSW spacing issues. 2018-08-21 10:34:41 +01:00
dialog_annotate_base.fbp Fix MSW spacing issues. 2018-08-21 10:34:41 +01:00
dialog_annotate_base.h Fix MSW spacing issues. 2018-08-21 10:34:41 +01:00
dialog_bom.cpp DIALOG_BOM: fix a few issues. Mainly an annoying issue when a plugin file was not found 2019-01-14 13:14:13 +01:00
dialog_bom_base.cpp DIALOG_BOM: fix a few issues. Mainly an annoying issue when a plugin file was not found 2019-01-14 13:14:13 +01:00
dialog_bom_base.fbp DIALOG_BOM: fix a few issues. Mainly an annoying issue when a plugin file was not found 2019-01-14 13:14:13 +01:00
dialog_bom_base.h DIALOG_BOM: fix a few issues. Mainly an annoying issue when a plugin file was not found 2019-01-14 13:14:13 +01:00
dialog_bom_cfg.keywords Eeschema: add dialog and utilities to create BOMs from generic netlist 2013-06-14 16:59:52 +02:00
dialog_bom_help.html Update Eeschema BOM dialog html help text 2018-10-22 13:19:15 -04:00
dialog_choose_component.cpp Eeschema: avoid using a incorrect background color the first time a SCH_DRAW_PANEL is displayed 2019-01-25 20:32:46 +01:00
dialog_choose_component.h Move symbol chooser dialog preview to GAL. 2018-10-09 11:08:55 +01:00
dialog_edit_component_in_lib.cpp libedit: Don't move the field below the last item 2019-03-18 10:27:09 -07:00
dialog_edit_component_in_lib.h libedit: Control resize requests 2019-03-02 05:49:18 -08:00
dialog_edit_component_in_lib_base.cpp Symbol editor: improve tooltip in symbol properties dialog. 2019-03-20 15:58:11 -04:00
dialog_edit_component_in_lib_base.fbp Symbol editor: improve tooltip in symbol properties dialog. 2019-03-20 15:58:11 -04:00
dialog_edit_component_in_lib_base.h Symbol editor: improve tooltip in symbol properties dialog. 2019-03-20 15:58:11 -04:00
dialog_edit_component_in_schematic.cpp Handle excessive resize requests 2019-02-27 11:32:30 -08:00
dialog_edit_component_in_schematic.h Handle excessive resize requests 2019-02-27 11:32:30 -08:00
dialog_edit_component_in_schematic_base.cpp Perform cancel action by hand. 2019-01-31 19:07:07 +00:00
dialog_edit_component_in_schematic_base.fbp Perform cancel action by hand. 2019-01-31 19:07:07 +00:00
dialog_edit_component_in_schematic_base.h Perform cancel action by hand. 2019-01-31 19:07:07 +00:00
dialog_edit_components_libid.cpp Remove previous cell selection fixes in favour of slow-click hack. 2019-03-04 11:09:33 +00:00
dialog_edit_components_libid_base.cpp Tooltip and error message improvements. 2019-02-17 10:20:29 +00:00
dialog_edit_components_libid_base.fbp Tooltip and error message improvements. 2019-02-17 10:20:29 +00:00
dialog_edit_components_libid_base.h Move Edit Symbol References to standard text/button control. 2018-09-29 22:07:31 +01:00
dialog_edit_label.cpp eeschema: Clean up last RefreshRect 2019-02-19 10:52:38 -08:00
dialog_edit_label_base.cpp Fix a few wxWidgets asserts or alerts. 2018-07-25 20:26:55 +02:00
dialog_edit_label_base.fbp Fix a few wxWidgets asserts or alerts. 2018-07-25 20:26:55 +02:00
dialog_edit_label_base.h Fix a few wxWidgets asserts or alerts. 2018-07-25 20:26:55 +02:00
dialog_edit_line_style.cpp Remove on-kill-focus-validation. 2018-11-29 19:00:21 +00:00
dialog_edit_line_style.h More g_UserUnit erradication. 2018-07-17 15:12:31 +01:00
dialog_edit_line_style_base.cpp Standardize colons in line style dialog 2018-04-23 11:53:18 -07:00
dialog_edit_line_style_base.fbp Standardize colons in line style dialog 2018-04-23 11:53:18 -07:00
dialog_edit_line_style_base.h Standardize colons in line style dialog 2018-04-23 11:53:18 -07:00
dialog_edit_one_field.cpp Remove on-kill-focus-validation. 2018-11-29 19:00:21 +00:00
dialog_edit_one_field.h Remove side-effect of LIB_FIELD::SetText(). 2018-10-31 12:57:23 +00:00
dialog_erc.cpp Move ERC marker focusing to GAL architecture. 2018-11-16 10:38:44 +00:00
dialog_erc.h Move ERC marker focusing to GAL architecture. 2018-11-16 10:38:44 +00:00
dialog_erc_base.cpp eeschema: Show ERC buttons in all pages 2019-02-09 19:17:53 -08:00
dialog_erc_base.fbp eeschema: Show ERC buttons in all pages 2019-02-09 19:17:53 -08:00
dialog_erc_base.h eeschema: Show ERC buttons in all pages 2019-02-09 19:17:53 -08:00
dialog_fields_editor_global.cpp Eeschema: internal tidying of field editor ApplyData 2019-03-27 10:29:36 +00:00
dialog_fields_editor_global.h Add an Add Field button to global Field Editor. 2018-07-17 15:11:22 +01:00
dialog_fields_editor_global_base.cpp eeschema: Set grid editor to use qty as the drop-down 2019-01-29 17:10:58 -08:00
dialog_fields_editor_global_base.fbp Eeschema: DIALOG_FIELDS_EDITOR_GLOBAL: fix missing clearing old highlight when highlighting a new symbol or exiting the dialog 2019-01-09 14:38:44 +01:00
dialog_fields_editor_global_base.h More safety fixes for uncommitted grid changes. 2018-08-29 19:59:01 +01:00
dialog_global_sym_lib_table_config.cpp Fix some issues in I10n strings 2019-01-26 09:25:12 +01:00
dialog_global_sym_lib_table_config.h Lay groundwork for loading the initial global footprint library table. 2019-01-20 13:09:49 -05:00
dialog_lib_edit_draw_item.cpp Remove on-kill-focus-validation. 2018-11-29 19:00:21 +00:00
dialog_lib_edit_draw_item.h More g_UserUnit erradication. 2018-07-17 15:12:31 +01:00
dialog_lib_edit_draw_item_base.cpp Libedit: Fix broken handling of "common to all bodu style" property of lib draw items. 2018-10-20 12:38:36 +02:00
dialog_lib_edit_draw_item_base.fbp Libedit: Fix broken handling of "common to all bodu style" property of lib draw items. 2018-10-20 12:38:36 +02:00
dialog_lib_edit_draw_item_base.h Libedit: Fix broken handling of "common to all bodu style" property of lib draw items. 2018-10-20 12:38:36 +02:00
dialog_lib_edit_pin.cpp libedit: Set initial pin properties when editing 2019-02-15 16:00:39 -08:00
dialog_lib_edit_pin.h UNIT_BINDERize Pin Properties dialog. 2018-07-17 15:11:24 +01:00
dialog_lib_edit_pin_base.cpp eeschema/dialogs/dialog_lib_edit_pin_base.cpp: fix a minor wxWidgets alert 2018-11-13 13:03:38 +01:00
dialog_lib_edit_pin_base.fbp eeschema/dialogs/dialog_lib_edit_pin_base.cpp: fix a minor wxWidgets alert 2018-11-13 13:03:38 +01:00
dialog_lib_edit_pin_base.h eeschema/dialogs/dialog_lib_edit_pin_base.cpp: fix a minor wxWidgets alert 2018-11-13 13:03:38 +01:00
dialog_lib_edit_pin_table.cpp Handle excessive resize requests 2019-02-27 11:32:30 -08:00
dialog_lib_edit_pin_table.h Handle excessive resize requests 2019-02-27 11:32:30 -08:00
dialog_lib_edit_pin_table_base.cpp Added a dialog to confirm discarding unsaved changes in Pin Table dialog. 2018-11-16 16:10:53 +01:00
dialog_lib_edit_pin_table_base.fbp Added a dialog to confirm discarding unsaved changes in Pin Table dialog. 2018-11-16 16:10:53 +01:00
dialog_lib_edit_pin_table_base.h Added a dialog to confirm discarding unsaved changes in Pin Table dialog. 2018-11-16 16:10:53 +01:00
dialog_lib_edit_text.cpp Remove on-kill-focus-validation. 2018-11-29 19:00:21 +00:00
dialog_lib_edit_text.h Add position to Eeschema's edit text dialogs. 2018-07-17 15:13:41 +01:00
dialog_lib_edit_text_base.cpp Fix a minor wxWidgets debug alert. 2018-08-03 21:28:44 +02:00
dialog_lib_edit_text_base.fbp Fix a minor wxWidgets debug alert. 2018-08-03 21:28:44 +02:00
dialog_lib_edit_text_base.h Fix a minor wxWidgets debug alert. 2018-08-03 21:28:44 +02:00
dialog_lib_new_component.cpp MACOS Setfocus and CancelButtonIssue moved into dialog_shim. 2017-01-29 23:51:35 +01:00
dialog_lib_new_component.h Add more "override" markers. 2016-09-25 13:59:41 -04:00
dialog_lib_new_component_base.cpp DIALOG_LIB_NEW_COMPONENT_BASE: fix minor issues. 2019-03-04 08:27:00 +01:00
dialog_lib_new_component_base.fbp DIALOG_LIB_NEW_COMPONENT_BASE: fix minor issues. 2019-03-04 08:27:00 +01:00
dialog_lib_new_component_base.h DIALOG_LIB_NEW_COMPONENT_BASE: fix minor issues. 2019-03-04 08:27:00 +01:00
dialog_netlist.cpp Wildcards: unify handling of all files wildcards 2019-01-09 08:57:42 -05:00
dialog_netlist_base.cpp eeschema: Simplify netlist dialog 2019-01-08 09:26:36 -08:00
dialog_netlist_base.fbp eeschema: Simplify netlist dialog 2019-01-08 09:26:36 -08:00
dialog_netlist_base.h eeschema: Simplify netlist dialog 2019-01-08 09:26:36 -08:00
dialog_plot_schematic.cpp Fix flicking issues on non-double-buffered platforms. 2018-07-19 21:46:41 +01:00
dialog_plot_schematic.h Fix flicking issues on non-double-buffered platforms. 2018-07-19 21:46:41 +01:00
dialog_plot_schematic_base.cpp Fix MSW spacing issues. 2018-08-21 10:34:41 +01:00
dialog_plot_schematic_base.fbp Fix MSW spacing issues. 2018-08-21 10:34:41 +01:00
dialog_plot_schematic_base.h UNIT_BINDERize print and plot dialogs. 2018-07-17 15:12:29 +01:00
dialog_print_using_printer.cpp Cleanup unused and redundant stuff. 2018-10-09 11:08:56 +01:00
dialog_print_using_printer_base.cpp Some minor dialog layout fixups. 2018-10-17 11:23:02 +01:00
dialog_print_using_printer_base.fbp Some minor dialog layout fixups. 2018-10-17 11:23:02 +01:00
dialog_print_using_printer_base.h Some minor dialog layout fixups. 2018-10-17 11:23:02 +01:00
dialog_rescue_each.cpp Decouple SCH_EDIT_FRAME from symbol rescue and remap dialogs. 2019-02-05 12:43:46 -05:00
dialog_rescue_each_base.cpp Make SYMBOL_PREVIEW_WIDGET working, and using the canvas type of the caller. Fix an issue with F3 zoom key in libedit. 2018-10-09 11:08:56 +01:00
dialog_rescue_each_base.fbp Make SYMBOL_PREVIEW_WIDGET working, and using the canvas type of the caller. Fix an issue with F3 zoom key in libedit. 2018-10-09 11:08:56 +01:00
dialog_rescue_each_base.h Make SYMBOL_PREVIEW_WIDGET working, and using the canvas type of the caller. Fix an issue with F3 zoom key in libedit. 2018-10-09 11:08:56 +01:00
dialog_sch_edit_sheet_pin.cpp Eeschema: fix highlight hierarchical pin name in properties dialog. 2019-02-07 13:03:38 -05:00
dialog_sch_edit_sheet_pin.h Remove some references to g_UserUnit 2018-07-17 15:09:56 +01:00
dialog_sch_edit_sheet_pin_base.cpp Remove some references to g_UserUnit 2018-07-17 15:09:56 +01:00
dialog_sch_edit_sheet_pin_base.fbp Remove some references to g_UserUnit 2018-07-17 15:09:56 +01:00
dialog_sch_edit_sheet_pin_base.h Remove some references to g_UserUnit 2018-07-17 15:09:56 +01:00
dialog_sch_sheet_props.cpp Adjust tab ordering in some dialogs 2019-02-23 14:49:38 +00:00
dialog_sch_sheet_props.h Remove some references to g_UserUnit 2018-07-17 15:09:56 +01:00
dialog_sch_sheet_props_base.cpp Remove some references to g_UserUnit 2018-07-17 15:09:56 +01:00
dialog_sch_sheet_props_base.fbp Remove some references to g_UserUnit 2018-07-17 15:09:56 +01:00
dialog_sch_sheet_props_base.h Remove some references to g_UserUnit 2018-07-17 15:09:56 +01:00
dialog_schematic_find.cpp Move search status messages to Find/Replace dialog. 2018-07-17 15:13:37 +01:00
dialog_schematic_find.h Move search status messages to Find/Replace dialog. 2018-07-17 15:13:37 +01:00
dialog_schematic_find_base.cpp Move search status messages to Find/Replace dialog. 2018-07-17 15:13:37 +01:00
dialog_schematic_find_base.fbp Move search status messages to Find/Replace dialog. 2018-07-17 15:13:37 +01:00
dialog_schematic_find_base.h Move search status messages to Find/Replace dialog. 2018-07-17 15:13:37 +01:00
dialog_set_grid.cpp Grid settings for Eeschema GAL. 2018-10-09 11:08:55 +01:00
dialog_set_grid_base.cpp Grid settings for Eeschema GAL. 2018-10-09 11:08:55 +01:00
dialog_set_grid_base.fbp Grid settings for Eeschema GAL. 2018-10-09 11:08:55 +01:00
dialog_set_grid_base.h Grid settings for Eeschema GAL. 2018-10-09 11:08:55 +01:00
dialog_signal_list.cpp Removed an obsolete comment 2018-04-28 01:19:42 +02:00
dialog_signal_list.h Changed the simulator code license to GPLv3+ 2016-08-11 14:41:43 +02:00
dialog_signal_list_base.cpp Common, 3D viewer, CvPcb, and Eeschema dialog tweaks. 2017-12-26 09:38:45 -05:00
dialog_signal_list_base.fbp Common, 3D viewer, CvPcb, and Eeschema dialog tweaks. 2017-12-26 09:38:45 -05:00
dialog_signal_list_base.h Common, 3D viewer, CvPcb, and Eeschema dialog tweaks. 2017-12-26 09:38:45 -05:00
dialog_sim_settings.cpp Removed redundant 'v' in noise simulation command 2018-08-01 17:28:55 +02:00
dialog_sim_settings.h Simulator dialogs: Fix incorrect handling of Validate(), which was called for all widgets by the default wxID_OK button handler. It is now called only for the active page of these dialogs (as wanted in code), therefore only for used widgets. 2016-09-17 14:38:34 +02:00
dialog_sim_settings_base.cpp Fix a few wxWidgets minor asserts 2018-07-29 17:27:11 +02:00
dialog_sim_settings_base.fbp Fix a few wxWidgets minor asserts 2018-07-29 17:27:11 +02:00
dialog_sim_settings_base.h Fix a few wxWidgets minor asserts 2018-07-29 17:27:11 +02:00
dialog_spice_model.cpp Fix a few coverity errors 2019-02-15 20:15:04 -08:00
dialog_spice_model.h libedit: Allow SPICE parameter editing 2019-01-09 21:43:23 -08:00
dialog_spice_model_base.cpp DIALOG_SPICE_MODEL_BASE: fix minor wxWidgets alerts. 2018-11-23 10:21:57 +01:00
dialog_spice_model_base.fbp DIALOG_SPICE_MODEL_BASE: fix minor wxWidgets alerts. 2018-11-23 10:21:57 +01:00
dialog_spice_model_base.h DIALOG_SPICE_MODEL_BASE: fix minor wxWidgets alerts. 2018-11-23 10:21:57 +01:00
dialog_symbol_remap.cpp Decouple SCH_EDIT_FRAME from symbol rescue and remap dialogs. 2019-02-05 12:43:46 -05:00
dialog_symbol_remap.h Eeschema: allow remapping if a project symbol library table exists. 2018-01-12 10:13:41 -05:00
dialog_symbol_remap_base.cpp Minor symbol remapping fixes. 2017-12-22 08:03:49 -05:00
dialog_symbol_remap_base.fbp Minor symbol remapping fixes. 2017-12-22 08:03:49 -05:00
dialog_symbol_remap_base.h Minor symbol remapping fixes. 2017-12-22 08:03:49 -05:00
dialog_update_fields.cpp Use updated value when checking for empty. 2019-01-30 16:29:21 +00:00
dialog_update_fields.h Added a dialog to select fields to be updated 2017-10-02 15:57:23 +02:00
dialog_update_fields_base.cpp Add updating of visiblity, position, etc. to fields. 2018-07-17 15:10:50 +01:00
dialog_update_fields_base.fbp Add updating of visiblity, position, etc. to fields. 2018-07-17 15:10:50 +01:00
dialog_update_fields_base.h Add updating of visiblity, position, etc. to fields. 2018-07-17 15:10:50 +01:00
panel_eeschema_display_options.cpp eeschema: Refresh canvas when the options change 2019-02-19 17:04:51 -08:00
panel_eeschema_display_options.h Grid settings for Eeschema GAL. 2018-10-09 11:08:55 +01:00
panel_eeschema_display_options_base.cpp Ensure junctions and no-connects are visible even on fat wires. 2018-10-09 11:08:56 +01:00
panel_eeschema_display_options_base.fbp PANEL_EESCHEMA_SETTINGS_BASE: very minor cosmetic enhancement. 2018-12-07 11:30:52 +01:00
panel_eeschema_display_options_base.h Ensure junctions and no-connects are visible even on fat wires. 2018-10-09 11:08:56 +01:00
panel_eeschema_settings.cpp Grid settings for Eeschema GAL. 2018-10-09 11:08:55 +01:00
panel_eeschema_settings.h Unified preferences dialog framework. 2018-07-17 15:11:17 +01:00
panel_eeschema_settings_base.cpp Fix configuration dialog layout issues on GTK. 2019-01-09 17:35:12 -05:00
panel_eeschema_settings_base.fbp Fix configuration dialog layout issues on GTK. 2019-01-09 17:35:12 -05:00
panel_eeschema_settings_base.h Fix configuration dialog layout issues on GTK. 2019-01-09 17:35:12 -05:00
panel_eeschema_template_fieldnames.cpp Fix a minor compil warning 2018-12-07 11:22:03 +01:00
panel_eeschema_template_fieldnames.h Move all the grid workarounds into our own WX_GRID class. 2018-07-17 15:11:38 +01:00
panel_eeschema_template_fieldnames_base.cpp Remove more dialog control borders. 2018-08-27 15:11:27 -04:00
panel_eeschema_template_fieldnames_base.fbp Remove more dialog control borders. 2018-08-27 15:11:27 -04:00
panel_eeschema_template_fieldnames_base.h Remove more dialog control borders. 2018-08-27 15:11:27 -04:00
panel_libedit_display_options.cpp Grid settings for LibEdit. 2018-10-09 11:08:55 +01:00
panel_libedit_display_options.h Grid settings for LibEdit. 2018-10-09 11:08:55 +01:00
panel_libedit_settings.cpp Grid settings for LibEdit. 2018-10-09 11:08:55 +01:00
panel_libedit_settings.h Unified preferences dialog framework. 2018-07-17 15:11:17 +01:00
panel_libedit_settings_base.cpp Grid settings for LibEdit. 2018-10-09 11:08:55 +01:00
panel_libedit_settings_base.fbp Grid settings for LibEdit. 2018-10-09 11:08:55 +01:00
panel_libedit_settings_base.h Grid settings for LibEdit. 2018-10-09 11:08:55 +01:00
panel_sym_lib_table.cpp Remove previous cell selection fixes in favour of slow-click hack. 2019-03-04 11:09:33 +00:00
panel_sym_lib_table.h More safety fixes for uncommitted grid changes. 2018-08-29 19:59:01 +01:00
panel_sym_lib_table_base.cpp Add tooltips to library manager dialogs. 2018-11-24 15:06:21 +00:00
panel_sym_lib_table_base.fbp Add tooltips to library manager dialogs. 2018-11-24 15:06:21 +00:00
panel_sym_lib_table_base.h More safety fixes for uncommitted grid changes. 2018-08-29 19:59:01 +01:00