feat: Implement configuration to display pyenv version name (#140)

This behavior can be enabled via setting `use_pyenv` to true.
The "pyenv" prefix before the version name can be configured using `pyenv_prefix`.
This commit is contained in:
MaT1g3R 2019-08-12 21:12:55 -04:00 committed by Matan Kushner
parent 274042832d
commit 160a79fa06
4 changed files with 95 additions and 28 deletions

View File

@ -10,27 +10,16 @@ steps:
versionSpec: "1.10" versionSpec: "1.10"
displayName: "Install a fixed version of Go" displayName: "Install a fixed version of Go"
# Because the Pipelines agent updates are out of sync, we can't install 3.6.9 # We are using pyenv to install Python for integration tests
# with PythonTool on macOS
# Install Python # Install Python
- task: UsePythonVersion@0
inputs:
versionSpec: "3.6.9"
displayName: "Install a fixed version of Python"
condition: not(eq(variables['Agent.OS'], 'Darwin'))
# Install Python (macOS)
- script: | - script: |
echo "##vso[task.setvariable variable=PYTHON_VERSION;]3.6.9" echo "##vso[task.setvariable variable=PYTHON_VERSION;]3.6.9"
echo "##vso[task.setvariable variable=PYENV_ROOT;]$HOME/.pyenv" echo "##vso[task.setvariable variable=PYENV_ROOT;]$HOME/.pyenv"
condition: eq(variables['Agent.OS'], 'Darwin')
- script: | - script: |
curl https://pyenv.run | bash curl https://pyenv.run | bash
echo "##vso[task.setvariable variable=PATH;]$PYENV_ROOT/bin:$PYENV_ROOT/shims:$PATH" echo "##vso[task.setvariable variable=PATH;]$PYENV_ROOT/bin:$PYENV_ROOT/shims:$PATH"
condition: eq(variables['Agent.OS'], 'Darwin')
- script: | - script: |
eval "$(pyenv init -)" eval "$(pyenv init -)"
pyenv install $PYTHON_VERSION pyenv install $PYTHON_VERSION
pyenv global $PYTHON_VERSION pyenv global $PYTHON_VERSION
condition: eq(variables['Agent.OS'], 'Darwin')
displayName: "Install a fixed version of Python" displayName: "Install a fixed version of Python"

View File

@ -350,8 +350,13 @@ symbol = "🎁 "
## Python ## Python
The `python` module shows the currently installed version of Python. The `python` module shows the currently installed version of Python.
It will also show the current Python virtual environment if one is
If `pyenv_version_name` is set to `true`, it will display the pyenv version name.
Otherwise, it will display the version number from `python --version`
and show the current Python virtual environment if one is
activated. activated.
The module will be shown if any of the following conditions are met: The module will be shown if any of the following conditions are met:
- The current directory contains a `.python-version` file - The current directory contains a `.python-version` file
@ -365,6 +370,9 @@ The module will be shown if any of the following conditions are met:
| ---------- | ------- | -------------------------------------------------------- | | ---------- | ------- | -------------------------------------------------------- |
| `symbol` | `"🐍 "` | The symbol used before displaying the version of Python. | | `symbol` | `"🐍 "` | The symbol used before displaying the version of Python. |
| `disabled` | `false` | Disables the `python` module. | | `disabled` | `false` | Disables the `python` module. |
| `pyenv_version_name` | `false` | Use pyenv to get Python version |
| `pyenv_prefix` | `"pyenv "` | Prefix before pyenv version display (default display is `pyenv MY_VERSION`) |
### Example ### Example
@ -373,6 +381,8 @@ The module will be shown if any of the following conditions are met:
[python] [python]
symbol = "👾 " symbol = "👾 "
pyenv_version_name = true
pyenv_prefix = "foo "
``` ```
## Rust ## Rust

View File

@ -4,6 +4,8 @@ use std::process::Command;
use ansi_term::Color; use ansi_term::Color;
use crate::config::Config;
use super::{Context, Module}; use super::{Context, Module};
/// Creates a module with the current Python version /// Creates a module with the current Python version
@ -24,26 +26,52 @@ pub fn module<'a>(context: &'a Context) -> Option<Module<'a>> {
return None; return None;
} }
match get_python_version() { let mut module = context.new_module("python")?;
Some(python_version) => { let pyenv_version_name = module
.config_value_bool("pyenv_version_name")
.unwrap_or(false);
const PYTHON_CHAR: &str = "🐍 "; const PYTHON_CHAR: &str = "🐍 ";
let module_color = Color::Yellow.bold(); let module_color = Color::Yellow.bold();
let mut module = context.new_module("python")?;
module.set_style(module_color); module.set_style(module_color);
let formatted_version = format_python_version(&python_version);
module.new_segment("symbol", PYTHON_CHAR); module.new_segment("symbol", PYTHON_CHAR);
select_python_version(pyenv_version_name)
.map(|python_version| python_module(module, pyenv_version_name, python_version))
}
fn python_module(mut module: Module, pyenv_version_name: bool, python_version: String) -> Module {
const PYENV_PREFIX: &str = "pyenv ";
if pyenv_version_name {
module.new_segment("pyenv_prefix", PYENV_PREFIX);
module.new_segment("version", &python_version.trim());
} else {
let formatted_version = format_python_version(&python_version);
module.new_segment("version", &formatted_version); module.new_segment("version", &formatted_version);
get_python_virtual_env() get_python_virtual_env()
.map(|virtual_env| module.new_segment("virtualenv", &format!("({})", virtual_env))); .map(|virtual_env| module.new_segment("virtualenv", &format!("({})", virtual_env)));
};
Some(module) module
} }
None => None,
fn select_python_version(pyenv_version_name: bool) -> Option<String> {
if pyenv_version_name {
get_pyenv_version()
} else {
get_python_version()
} }
} }
fn get_pyenv_version() -> Option<String> {
Command::new("pyenv")
.arg("version-name")
.output()
.ok()
.and_then(|output| String::from_utf8(output.stdout).ok())
}
fn get_python_version() -> Option<String> { fn get_python_version() -> Option<String> {
match Command::new("python").arg("--version").output() { match Command::new("python").arg("--version").output() {
Ok(output) => { Ok(output) => {
@ -95,4 +123,5 @@ mod tests {
env::set_var("VIRTUAL_ENV", "/foo/bar/my_venv"); env::set_var("VIRTUAL_ENV", "/foo/bar/my_venv");
assert_eq!(get_python_virtual_env().unwrap(), "my_venv") assert_eq!(get_python_virtual_env().unwrap(), "my_venv")
} }
} }

View File

@ -1,10 +1,10 @@
use std::env;
use std::fs::File; use std::fs::File;
use std::io; use std::io;
use ansi_term::Color; use ansi_term::Color;
use crate::common; use crate::common;
use crate::common::TestCommand;
#[test] #[test]
#[ignore] #[ignore]
@ -93,3 +93,42 @@ fn with_virtual_env() -> io::Result<()> {
assert_eq!(expected, actual); assert_eq!(expected, actual);
Ok(()) Ok(())
} }
#[test]
#[ignore]
fn with_pyenv() -> io::Result<()> {
let dir = common::new_tempdir()?;
File::create(dir.path().join("main.py"))?;
let output = common::render_module("python")
.use_config(toml::toml! {
[python]
pyenv_version_name = true
})
.env("VIRTUAL_ENV", "/foo/bar/my_venv")
.arg("--path")
.arg(dir.path())
.output()?;
let actual = String::from_utf8(output.stdout).unwrap();
let expected = format!("via {} ", Color::Yellow.bold().paint("🐍 pyenv system"));
assert_eq!(expected, actual);
Ok(())
}
#[test]
#[ignore]
fn with_pyenv_no_output() -> io::Result<()> {
let dir = common::new_tempdir()?;
File::create(dir.path().join("main.py"))?;
let output = common::render_module("python")
.use_config(toml::toml! {
[python]
pyenv_version_name = true
})
.env("PATH", "")
.arg("--path")
.arg(dir.path())
.output()?;
let actual = String::from_utf8(output.stdout).unwrap();
assert_eq!("", actual);
Ok(())
}