Commit Graph

10 Commits

Author SHA1 Message Date
sokai d46c76920e
style(install): Simple code style fix in install.sh (#1690)
* Update install.sh

fixed only coding style (ShellCheck gave me a hint ;-))

* Make PR Bot happy
2020-10-03 10:58:06 +02:00
Thomas O'Donnell 2e14d1af5a
fix(install): switch to install the musl binaries by default (#1590)
We have had a few issues where users haave run the install script and
have ended up with a non-functioning version of starship because their
system doesn't have a required lib that we link against. To avoid these
problems it seems the easiest solution is to default to using the
statically compiled musl binaries. If a user knows that they are doing
they can use the non-statically compiled binaries by supplying the `-p`
argument to the installer. Note this is what other rust based tools such
as ripgrep do.
2020-08-16 11:30:10 -04:00
Or Bin 297cbd8654
fix: fixed a typo: permission → permissions (#1459) 2020-07-08 17:26:51 -04:00
Kevin Song 6ecabdfee4
fix: errant space breaks tar in installer (#1314) 2020-06-11 13:12:14 -05:00
Dario Vladović 30ff5913be
style: address shellcheck issues in install.sh (#1305)
Fixes some shellcheck issues in the install script. Also normalizes
formatting with `shfmt` program.
2020-06-10 13:40:05 -05:00
Kevin Song 3ebd2c0ad5
fix: Update install.sh for Windows (#1300)
Adds several cross-platform utility functions to the install.sh script and 
rewrites core functionality so that it might work on Windows. Among these are:
 - Correct platform extensions to match the output of `detect_platform`
 - Check to make sure installation directory actually exists
 - If sudo is not available, print a message asking the user to manually 
   escalate
 - Unpack zip files (used for Windows builds) without using pipes, since zip 
   files cannot be read through pipes

After these changes, install.sh works on a testing copy of Git Bash on Windows,
though it still has known issues (e.g. if the `unzip` program is not installed,
it will crash).
2020-06-09 17:21:35 -05:00
Diego Jornada b1bc2a04a4
feat(installer): Ask for permission escalation during installation, if needed (#914) 2020-02-12 21:13:21 -05:00
AppleTheGolden 8084c2e61d fix: Fix shellcheck issues in install.sh (#714) 2019-12-20 10:54:40 -05:00
BuggStream 93701b26b3 feat: Add support for the ion shell (#704) 2019-12-11 15:31:30 -05:00
Matan Kushner 5b440c0bb0
docs: Simplify installation process and docs (#643) 2019-12-05 13:15:21 -05:00