haskal
/
vagrant
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Make virtualbox vm_exists? more resilient to VirtualBox transient failures. 

We know that the vm does not exist if we get VBOX_E_OBJECT_NOT_FOUND.
For any other error, this may well be VirtualBox getting confused and it is probably
worth retrying...
This commit is contained in:
nico.vanelslande 2016-05-31 11:33:58 +01:00
parent 49ce775b53
commit 163e1997a6
4 changed files with 12 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
plugins/providers/virtualbox/driver/version_4_1.rb
View File

@ -661,9 +661,9 @@ module VagrantPlugins
result = raw("showvminfo", uuid)
return true if result.exit_code == 0
# GH-2479: Sometimes this happens. In this case, retry. If
# we don't see this text, the VM really probably doesn't exist.
return false if !result.stderr.include?("CO_E_SERVER_EXEC_FAILURE")
# If vboxmanage returned VBOX_E_OBJECT_NOT_FOUND,
# then the vm truly does not exist. Any other error might be transient
return false if result.stderr.include?("VBOX_E_OBJECT_NOT_FOUND")
# Sleep a bit though to give VirtualBox time to fix itself
sleep 2

6
plugins/providers/virtualbox/driver/version_4_2.rb
View File

@ -594,9 +594,9 @@ module VagrantPlugins
result = raw("showvminfo", uuid)
return true if result.exit_code == 0
# GH-2479: Sometimes this happens. In this case, retry. If
# we don't see this text, the VM really probably doesn't exist.
return false if !result.stderr.include?("CO_E_SERVER_EXEC_FAILURE")
# If vboxmanage returned VBOX_E_OBJECT_NOT_FOUND,
# then the vm truly does not exist. Any other error might be transient
return false if result.stderr.include?("VBOX_E_OBJECT_NOT_FOUND")
# Sleep a bit though to give VirtualBox time to fix itself
sleep 2

6
plugins/providers/virtualbox/driver/version_4_3.rb
View File

@ -701,9 +701,9 @@ module VagrantPlugins
result = raw("showvminfo", uuid)
return true if result.exit_code == 0
# GH-2479: Sometimes this happens. In this case, retry. If
# we don't see this text, the VM really probably doesn't exist.
return false if !result.stderr.include?("CO_E_SERVER_EXEC_FAILURE")
# If vboxmanage returned VBOX_E_OBJECT_NOT_FOUND,
# then the vm truly does not exist. Any other error might be transient
return false if result.stderr.include?("VBOX_E_OBJECT_NOT_FOUND")
# Sleep a bit though to give VirtualBox time to fix itself
sleep 2

6
plugins/providers/virtualbox/driver/version_5_0.rb
View File

@ -702,9 +702,9 @@ module VagrantPlugins
result = raw("showvminfo", uuid)
return true if result.exit_code == 0
# GH-2479: Sometimes this happens. In this case, retry. If
# we don't see this text, the VM really probably doesn't exist.
return false if !result.stderr.include?("CO_E_SERVER_EXEC_FAILURE")
# If vboxmanage returned VBOX_E_OBJECT_NOT_FOUND,
# then the vm truly does not exist. Any other error might be transient
return false if result.stderr.include?("VBOX_E_OBJECT_NOT_FOUND")
# Sleep a bit though to give VirtualBox time to fix itself
sleep 2