Handle a lot of TODOs
This commit is contained in:
parent
b08c1a62ce
commit
92df8cf6ae
|
@ -204,7 +204,6 @@ module Vagrant
|
||||||
url: url,
|
url: url,
|
||||||
versions: metadata.versions.join(", ")
|
versions: metadata.versions.join(", ")
|
||||||
else
|
else
|
||||||
# TODO: show supported providers
|
|
||||||
raise Errors::BoxAddNoMatchingProvider,
|
raise Errors::BoxAddNoMatchingProvider,
|
||||||
name: metadata.name,
|
name: metadata.name,
|
||||||
requested: provider,
|
requested: provider,
|
||||||
|
|
|
@ -3,9 +3,6 @@ require 'log4r'
|
||||||
require 'vagrant/action/hook'
|
require 'vagrant/action/hook'
|
||||||
require 'vagrant/util/busy'
|
require 'vagrant/util/busy'
|
||||||
|
|
||||||
# TODO:
|
|
||||||
# * env.lock
|
|
||||||
|
|
||||||
module Vagrant
|
module Vagrant
|
||||||
module Action
|
module Action
|
||||||
class Runner
|
class Runner
|
||||||
|
|
|
@ -76,7 +76,6 @@ module Vagrant
|
||||||
|
|
||||||
unknown_sources = @sources.keys - order
|
unknown_sources = @sources.keys - order
|
||||||
if !unknown_sources.empty?
|
if !unknown_sources.empty?
|
||||||
# TODO: Raise exception here perhaps.
|
|
||||||
@logger.error("Unknown config sources: #{unknown_sources.inspect}")
|
@logger.error("Unknown config sources: #{unknown_sources.inspect}")
|
||||||
end
|
end
|
||||||
|
|
||||||
|
|
|
@ -56,7 +56,6 @@ module Vagrant
|
||||||
#
|
#
|
||||||
# @return [String]
|
# @return [String]
|
||||||
def render
|
def render
|
||||||
# TODO: Seems like a pretty dirty way to do this. Perhaps refactor this
|
|
||||||
old_template = template
|
old_template = template
|
||||||
result = nil
|
result = nil
|
||||||
File.open(full_template_path, 'r') do |f|
|
File.open(full_template_path, 'r') do |f|
|
||||||
|
|
|
@ -38,8 +38,6 @@ module VagrantPlugins
|
||||||
new.ssh.forward_agent = @forward_agent if @forward_agent != UNSET_VALUE
|
new.ssh.forward_agent = @forward_agent if @forward_agent != UNSET_VALUE
|
||||||
new.ssh.forward_x11 = @forward_x11 if @forward_x11 != UNSET_VALUE
|
new.ssh.forward_x11 = @forward_x11 if @forward_x11 != UNSET_VALUE
|
||||||
new.ssh.shell = @shell if @shell != UNSET_VALUE
|
new.ssh.shell = @shell if @shell != UNSET_VALUE
|
||||||
|
|
||||||
# TODO: Warn that max_tries and timeout are gone
|
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
|
|
|
@ -19,7 +19,9 @@ module VagrantPlugins
|
||||||
regexp = /Successfully built (.+)$/i
|
regexp = /Successfully built (.+)$/i
|
||||||
match = regexp.match(result)
|
match = regexp.match(result)
|
||||||
if !match
|
if !match
|
||||||
# TODO: error
|
# This will cause a stack trace in Vagrant, but it is a bug
|
||||||
|
# if this happens anyways.
|
||||||
|
raise "UNKNOWN OUTPUT: #{result}"
|
||||||
end
|
end
|
||||||
|
|
||||||
match[1]
|
match[1]
|
||||||
|
@ -86,7 +88,6 @@ module VagrantPlugins
|
||||||
execute('docker', 'start', cid)
|
execute('docker', 'start', cid)
|
||||||
# This resets the cached information we have around, allowing `vagrant reload`s
|
# This resets the cached information we have around, allowing `vagrant reload`s
|
||||||
# to work properly
|
# to work properly
|
||||||
# TODO: Add spec to verify this behavior
|
|
||||||
@data = nil
|
@data = nil
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
|
|
Loading…
Reference in New Issue