haskal
/
vagrant
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Fix up some subprocess comments

This commit is contained in:
Mitchell Hashimoto 2011-12-22 21:55:57 -08:00
parent c0fabbe2bd
commit cc9abc8b9b
1 changed files with 4 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
lib/vagrant/util/subprocess.rb
View File

@ -169,10 +169,10 @@ module Vagrant
# since we use some Ruby 1.9 specific exceptions. # since we use some Ruby 1.9 specific exceptions.
breakable = false breakable = false
if e.instance_of?(EOFError) if e.is_a?(EOFError)
# An `EOFError` means this IO object is done! # An `EOFError` means this IO object is done!
breakable = true breakable = true
elsif defined?(IO::WaitReadable) && e.instance_of?(IO::WaitReadable) elsif defined?(IO::WaitReadable) && e.is_a?(IO::WaitReadable)
# IO::WaitReadable is only available on Ruby 1.9+ # IO::WaitReadable is only available on Ruby 1.9+
# An IO::WaitReadable means there may be more IO but this # An IO::WaitReadable means there may be more IO but this
@ -180,10 +180,8 @@ module Vagrant
# we read as much as we can, so we break. # we read as much as we can, so we break.
breakable = true breakable = true
elsif e.is_a?(Errno::EAGAIN) elsif e.is_a?(Errno::EAGAIN)
# Otherwise, we catch all syscall errors. This is most certainly # Otherwise, we just look for the EAGAIN error which should be
# not correct since we should only be catching a few, but I do # all that IO::WaitReadable does in Ruby 1.9.
# not know the exact errors to listen for, and they may not
# be defined on certain platforms.
breakable = true breakable = true
end end