Fixes #11236: Windows port detection

This reverts commit 81553263ab.

This fixes a regression with Windows port detection which led to port
collisions not being fixed on `vagrant up`.

PR #8517 changed `IsPortOpen#is_port_open?` to rescue
Errno::EADDRNOTAVAIL, but when we merged it into master, there was code
in `HandleForwardedPortCollisions#port_check` that depended on that
error bubbling up.

This also changes the port number in the HandleForwardedPortCollisions
tests to be a less common port number -- some of these tests will fail
if there is a local process running on port 8080.

lib/vagrant/util/is_port_open.rb

@@ -30,8 +30,7 @@ module Vagrant
           return true
         end
       rescue Timeout::Error, Errno::ECONNREFUSED, Errno::EHOSTUNREACH, \
-             Errno::ENETUNREACH, Errno::EACCES, Errno::ENOTCONN, \
-             Errno::EADDRNOTAVAIL
+             Errno::ENETUNREACH, Errno::EACCES, Errno::ENOTCONN
         # Any of the above exceptions signal that the port is closed.
         return false
       end

test/unit/vagrant/action/builtin/handle_forwarded_port_collisions_test.rb

@@ -69,7 +69,7 @@ describe Vagrant::Action::Builtin::HandleForwardedPortCollisions do
     end
 
     context "with forwarded port defined" do
-      let(:port_options){ {guest: 80, host: 8080} }
+      let(:port_options){ {guest: 80, host: 52811} }
       before do
         expect(vm_config).to receive(:networks).and_return([[:forwarded_port, port_options]]).twice
       end
@@ -80,7 +80,7 @@ describe Vagrant::Action::Builtin::HandleForwardedPortCollisions do
       end
 
       context "with forwarded port already in use" do
-        let(:extra_in_use){ [8080] }
+        let(:extra_in_use){ [52811] }
 
         it "should raise a port collision error" do
           expect{ instance.call(env) }.to raise_error(Vagrant::Errors::ForwardPortCollision)
@@ -105,7 +105,7 @@ describe Vagrant::Action::Builtin::HandleForwardedPortCollisions do
 
       context "with custom port_check method" do
         let(:check_result){ [] }
-        let(:port_options){ {guest: 80, host: 8080, host_ip: "127.0.1.1"} }
+        let(:port_options){ {guest: 80, host: 52811, host_ip: "127.0.1.1"} }
 
         context "that accepts two parameters" do
           let(:collision_port_check) do
@@ -145,7 +145,7 @@ describe Vagrant::Action::Builtin::HandleForwardedPortCollisions do
 
   describe "#port_check" do
     let(:host_ip){ "127.0.0.1" }
-    let(:host_port){ 8080 }
+    let(:host_port){ 52811 }
 
     it "should check if the port is open" do
       expect(instance).to receive(:is_port_open?).with(host_ip, host_port).and_return true

test/unit/vagrant/util/is_port_open_test.rb

@@ -49,5 +49,15 @@ describe Vagrant::Util::IsPortOpen do
     # best, really.
     expect(klass.is_port_open?("127.0.0.1", closed_port)).not_to be
   end
+
+  it "should handle connection refused" do
+    expect(TCPSocket).to receive(:new).with("0.0.0.0", closed_port).and_raise Errno::ECONNREFUSED
+    expect(klass.is_port_open?("0.0.0.0", closed_port)).to be(false)
+  end
+
+  it "should raise an error if cannot assign requested address" do
+    expect(TCPSocket).to receive(:new).with("0.0.0.0", open_port).and_raise Errno::EADDRNOTAVAIL
+    expect { klass.is_port_open?("0.0.0.0", open_port) }.to raise_error Errno::EADDRNOTAVAIL
+  end
 end