haskal
/
vagrant
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Remove TODO

This commit is contained in:
Brian Cain 2018-04-04 15:02:21 -07:00
parent a20404599e
commit e0806f623c
No known key found for this signature in database
GPG Key ID: 43D51080D357A001
2 changed files with 0 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
lib/vagrant/plugin/v2/trigger.rb
View File

@ -109,7 +109,6 @@ module Vagrant
triggers.each do |trigger| triggers.each do |trigger|
@logger.debug("Running trigger #{trigger.id}...") @logger.debug("Running trigger #{trigger.id}...")
# TODO: I18n me
if !trigger.name.nil? if !trigger.name.nil?
@machine.ui.info(I18n.t("vagrant.trigger.fire_with_name", @machine.ui.info(I18n.t("vagrant.trigger.fire_with_name",
name: trigger.name)) name: trigger.name))

9
plugins/kernel_v2/config/vm_trigger.rb
View File

@ -144,8 +144,6 @@ module VagrantPlugins
cmd: @command)) cmd: @command))
end end
# TODO: Does it make sense to strip out the "shell provisioner" error key here?
# We could add more context around triggers?
if @run if @run
errorz = @run.validate(machine) errorz = @run.validate(machine)
errors.concat errorz["shell provisioner"] if !errorz.empty? errors.concat errorz["shell provisioner"] if !errorz.empty?
@ -179,13 +177,6 @@ module VagrantPlugins
end end
end end
if !@only_on.nil?
# this check isn't quite right...
#if @only_on.all? { |o| !o.is_a?(String) || !o.is_a?(Regexp) }
# errors << I18n.t("vagrant.config.triggers.only_on_bad_type")
#end
end
errors errors
end end