haskal
/
vagrant
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

issue-7983 - Helper now throws WinRMNotReady exception is host ip is reported as an empty string

This commit is contained in:
Bryce Shurts 2016-12-01 13:03:38 -06:00
parent f37b0c26e8
commit e4626d088d
2 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
plugins/communicators/winrm/helper.rb
View File

@ -33,7 +33,7 @@ module VagrantPlugins
return addr if addr return addr if addr
ssh_info = machine.ssh_info ssh_info = machine.ssh_info
raise Errors::WinRMNotReady if !ssh_info raise Errors::WinRMNotReady if !ssh_info || ssh_info[:host].empty?
return ssh_info[:host] return ssh_info[:host]
end end

6
test/unit/plugins/communicators/winrm/helper_test.rb
View File

@ -36,6 +36,12 @@ describe VagrantPlugins::CommunicatorWinRM::Helper do
expect { subject.winrm_address(machine) }. expect { subject.winrm_address(machine) }.
to raise_error(VagrantPlugins::CommunicatorWinRM::Errors::WinRMNotReady) to raise_error(VagrantPlugins::CommunicatorWinRM::Errors::WinRMNotReady)
end end
it "raise an exception if it detects an empty host ip" do
machine.stub(ssh_info: { host: "" })
expect { subject.winrm_address(machine) }.
to raise_error(VagrantPlugins::CommunicatorWinRM::Errors::WinRMNotReady)
end
end end
describe ".winrm_info" do describe ".winrm_info" do