haskal
/
vagrant
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

pushes/harmony: use to_s.strip.empty? to check if app is set

This commit is contained in:
Mitchell Hashimoto 2014-10-29 09:49:37 -07:00 committed by Seth Vargo
parent 1705460880
commit fefaa8da71
2 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
plugins/pushes/harmony/config.rb
View File

@ -72,7 +72,7 @@ module VagrantPlugins
def validate(machine) def validate(machine)
errors = _detected_errors errors = _detected_errors
if @app == nil || @app == "" if @app.to_s.strip.empty?
errors << I18n.t("push_harmony.errors.config.app_required") errors << I18n.t("push_harmony.errors.config.app_required")
end end

6
test/unit/plugins/pushes/harmony/config_test.rb
View File

@ -50,6 +50,12 @@ describe VagrantPlugins::HarmonyPush::Config do
assert_invalid assert_invalid
end end
it "is invalid if blank" do
subject.app = " "
subject.finalize!
assert_invalid
end
it "is valid if set" do it "is valid if set" do
subject.app = "foo/bar" subject.app = "foo/bar"
subject.finalize! subject.finalize!