Chris Roberts
5feb234665
Return original URL value when unmodified
...
Due to the behavior of URI.parse on Ruby < 2.5 returning the string
value of the parsed URI object may modify the original URL. Specifically
it will remove the `//` prefix characters from SMB paths. When no
host modifications are being made, always return the original value.
Fixes #9636
2018-04-25 16:21:21 -07:00
Brian Cain
67c3f866dd
( #7886 ) Add tests and simplify code for continuing on 416
2018-04-25 14:03:24 -07:00
Brian Cain
5643ba0c7d
Merge pull request #9713 from briancain/vagrant-triggers-config
...
Integrate vagrant-triggers plugin functionality into core Vagrant
2018-04-24 11:35:04 -07:00
Brian Cain
7f004656db
( #9718 ) Properly finalize structured_facts config option
...
This commit sets the structured_facts option to nil if its still
UNSET_VALUE at the finalize step. This was causing a bug when the facter
config was set but was not using structured facts.
2018-04-23 14:23:59 -07:00
Brian Cain
2000a11042
Add tests for powershell run functions
2018-04-20 10:51:38 -07:00
Brian Cain
e7d07cb110
Add rspec tests for trigger plugin
2018-04-20 10:51:38 -07:00
Brian Cain
6ea7819402
Update rspec tests for trigger plugin
2018-04-20 10:51:38 -07:00
Brian Cain
fbad4c749d
Add basic spec test for trigger class
2018-04-20 10:51:38 -07:00
Brian Cain
0953287262
Relax only_on rspec tests
...
only_on can be either a string or regex
2018-04-20 10:51:38 -07:00
Brian Cain
e7274f1b6c
Improve config rspec tests
2018-04-20 10:51:38 -07:00
Brian Cain
956ed004bb
Update trigger config merge function
2018-04-20 10:51:38 -07:00
Brian Cain
7dae1acd21
Add some "default" options to be validated
2018-04-20 10:51:38 -07:00
Brian Cain
fc526a164a
Add basic create_trigger rspec test
2018-04-20 10:51:38 -07:00
Brian Cain
e157362ace
Add run and run_remote expectations
2018-04-20 10:51:38 -07:00
Brian Cain
7b1b044e72
Check for default on_error behavior setting
2018-04-20 10:51:38 -07:00
Brian Cain
6cbb5d8e5d
Add unit tests for config, fix type change bug with map!
2018-04-20 10:51:38 -07:00
Brian Cain
3dec6869bb
Update trigger unit tests
2018-04-20 10:51:38 -07:00
Brian Cain
42419bbd49
Fix rspec tests
2018-04-20 10:51:38 -07:00
Brian Cain
6f00eb5679
Move trigger options into own plugin class
2018-04-20 10:51:38 -07:00
Brian Cain
bb2f3b35b9
Add basic unit test
2018-04-20 10:51:38 -07:00
Brian Cain
9660951c89
Merge pull request #9490 from jzinn/solo-rb-cookbook-path
...
Improve Windows drive letter removal hack
2018-04-18 08:31:23 -07:00
Julian Zinn
269645f63d
Improve Windows drive letter removal hack
2018-04-17 13:23:14 -07:00
Brian Cain
151095a3e9
Merge pull request #9420 from ryanwalder/salt-json
...
Add master_json_config & minion_json_config options to salt provisioner
2018-04-16 15:37:44 -07:00
Chris Roberts
5d7506afe3
Merge pull request #9676 from chrisroberts/e-win-file-perms
...
Update generated ssh private key file permissions on create
2018-04-10 14:56:28 -07:00
Chris Roberts
b2db1adb7c
Merge pull request #9674 from chrisroberts/f-wsl-version-check
...
Check Windows installed Vagrant version using --version
2018-04-10 14:47:06 -07:00
Chris Roberts
b605da0ef5
Merge pull request #9673 from chrisroberts/f-win-paths-filter
...
Fix windows command filters
2018-04-10 14:44:32 -07:00
Chris Roberts
9731720773
Update generated ssh private key file permissions on create
...
This updates the permissions on the automatically generated private
key file to only be readable by the user. Includes support for file
permission modification on Windows platform.
2018-04-10 14:15:14 -07:00
Brian Cain
f1de9821e1
Merge pull request #8099 from chrisroberts/windows/shared-folder-path
...
Fix virtualbox shared folders path
2018-04-10 09:16:06 -07:00
Chris Roberts
e4399a5724
Check Windows installed Vagrant version using --version
...
Using the --version flag keeps Vagrant from doing a full startup
and prevents the Vagrantfile from being parsed. This makes the
version check faster, and stops things like syntax errors within
a Vagrantfile from causing an unexpected error.
Fixes #9635
2018-04-10 08:05:23 -07:00
Chris Roberts
ddfd86f3d1
Split with shellwords and quote paths in command filter
...
This uses shellwords to split the command in the command filter
inside the winrm communicator. Using shellwords properly handles
things like quoted paths. Path arguments are also quoted to
prevent issues with paths that include spaces.
Fixes #9390
2018-04-09 17:00:30 -07:00
Brian Cain
1a03fe687b
Update rspec tests for puppet provisioner
2018-04-09 11:03:30 -07:00
Chris Roberts
f3c5e86f28
Merge pull request #9504 from zachflower/feature/vagrant-aliases
...
Vagrant aliases
2018-04-06 15:39:18 -07:00
Chris Roberts
8391abc63a
Properly respect environment variable on checkpoint setup
...
The checkpoint update missed the environment variable check for
disabling the checks so this adds in the check and properly
disables checks when requested.
2018-04-05 10:47:28 -07:00
Chris Roberts
ef4318eda2
Merge pull request #9653 from chrisroberts/f-powershell-detection
...
Make powershell version detection timeout configurable
2018-04-04 16:20:23 -07:00
Chris Roberts
8ac0fedbbb
Suppress errors from invalid path encoding and carry on with best effort
...
Fixes #9299
2018-04-04 16:09:46 -07:00
Chris Roberts
90fa705a6d
Make powershell version detection timeout configurable
...
Allows custom configuration of the powershell timeout and bumps
the default timeout from 10 seconds to 30 seconds.
Fixes #9629
2018-04-04 16:02:11 -07:00
Chris Roberts
30e7e81eab
Make resolv-replace loading optional not automatic
2018-04-02 11:59:02 -07:00
Brian Cain
0ce6e9891e
Merge pull request #9572 from jsoref/spelling
...
Spelling
2018-03-22 09:50:52 -07:00
ajpaul
e602160234
update change_host_name_test to comply with reintroduction of sleep_timeout parameter
2018-03-16 13:59:23 -04:00
ajpaul
4e8062625c
update unit test for change_host_name to fix failures introduced by changes to the module
2018-03-16 13:49:39 -04:00
Adam Paul
0dc3798908
update unit test to reflect changes in change_host_name.rb
2018-03-15 11:07:02 -04:00
Josh Soref
1a5ddea9f4
Spelling fixes
...
* account
* addresses
* administrator
* afterwards
* because
* bridgeable
* capabilities
* capability
* checksum
* configuration
* configuration for
* configure
* criteria
* delimited
* delivered
* derivatives
* description
* detect
* directory
* display
* downloading
* during
* electric
* enabling
* encountered
* equivalent
* executable
* executed
* hashicorp
* hypervisor
* hyphens
* implementation
* incorporate
* inheritance
* initialize
* instance
* instead
* interactions
* invocable
* machine
* maximum
* message
* mounting
* overridden
* overwrite
* paramiko
* preparing
* provides
* provisioning
* recursively
* requested
* resetting
* retryable
* running
* satisfied
* searching
* sometimes
* specified
* successfully
* synced folders
* unauthorized
* underlying
* userprofile
* vagrant
* vagrantfile
* variable
* various
* version
* virtual
* windows
2018-03-14 14:41:04 +00:00
Chris Roberts
586ee5bfba
Use common provider configuration. Include extra information output for logs.
2018-03-12 09:06:10 -07:00
Chris Roberts
51232f9a03
When matching hostonly adapter name, force common types
...
Force a string type for comparison to prevent false positives when
the name is unset (resulting in a nil value).
2018-03-09 14:15:31 -08:00
Chris Roberts
1abbe67ee9
Add test runner script
2018-03-08 12:11:22 -08:00
Brian Cain
94d9495209
Merge pull request #9543 from moore3071/unnecessary_redirects
...
Update URLs for the repo
2018-03-08 09:54:16 -08:00
Brandon Moore
5a12641f9c
Update URLs for the repo
2018-03-07 17:10:30 -05:00
Chris Roberts
8b7e501e50
Handle pathing in lxrun generated WSL instances better.
2018-02-28 10:08:01 -08:00
Chris Roberts
5f0d16a0e9
Include support for lxrun generated install
...
Adds compatibility support for legacy lxrun generated WSL installation
which is a single install at a known path location. This allows earlier
versions of Windows 10 to continue working as expected while still
supporting the recent updates allowing for multiple instances.
2018-02-28 10:08:01 -08:00
Chris Roberts
d0701fc95d
Merge pull request #9422 from pvalena/patch-1
...
Use 127.0.0.1 instead of localhost
2018-02-23 09:49:10 -08:00
Chris Roberts
04ec3c26d7
Merge pull request #8735 from jhosteny/fix/debian_net_tools_deprecation_dhcp
...
Fix #8730 . Use 'ip route' in lieu of 'route' in debian dhcp template
2018-02-23 09:41:37 -08:00
Chris Roberts
00400c95d8
Merge pull request #9499 from chrisroberts/f-vc-urls
...
Update behavior of the authentication middleware
2018-02-23 09:28:04 -08:00
Chris Roberts
b5b5f8870a
Merge pull request #9472 from chrisroberts/e-sensitive-length
...
Ignore empty strings registered as sensitive
2018-02-23 09:26:38 -08:00
Chris Roberts
d6f4c75f40
Merge pull request #9344 from chrisroberts/e-dl-redirect-notify
...
Notify when host changes on redirect
2018-02-23 09:24:40 -08:00
Chris Roberts
fc5ceafbcf
Only generate notice once
2018-02-22 14:49:44 -08:00
Brian Cain
d1c3deb234
( #9452 ) Use provider override for box_version if given
...
Prior to this commit if an override was given for a box version, it
would be ignored. This commit ensures that the box_version override is
used when specified in a Vagrantfile.
2018-02-22 10:43:52 -08:00
Chris Roberts
5c9c10558a
Update curl options in test
2018-02-21 17:05:13 -08:00
Chris Roberts
f2bf18e56b
Update behavior of the authentication middleware
...
Always remap old hosts to target host when encountered. When custom
vagrant server is defined, warn when tokens may be attached and allow
time for user to cancel.
Fixes #9442
2018-02-21 17:03:38 -08:00
Zachary Flower
f46ebf5240
throw an exception when whitespace is found within an alias keyword
2018-02-16 13:28:57 -07:00
Zachary Flower
f16751a46d
start working through tests
2018-02-16 13:00:39 -07:00
Chris Roberts
330ee2e1eb
Ignore empty strings registered as sensitive
...
Fixes #9462
2018-02-15 17:02:34 -08:00
Brian Cain
78f317f55a
Merge pull request #9261 from vStone/bugfix/gentoo-static-ip-with-ifplugd
...
Disable if/netplugd when setting up a static ip on a gentoo guest using openrc.
2018-02-15 13:13:46 -08:00
Brian Cain
8c15e1995b
Merge pull request #9459 from briancain/9428/master/update-systemd-check
...
Update systemd? check for guest inspection
2018-02-14 08:50:27 -08:00
Brian Cain
b77171c4fc
( #9428 ) Update systemd? check for guest inspection
...
Prior to this commit, the regex matcher used with grep to determine if a
system was using systemd? was failing on systems that did not exactly
match the old regex. This commit updates that communications test to use
a different method of determining if systemd is in use with the ps
command.
2018-02-08 15:50:59 -08:00
Brian Cain
e8708232a5
( #9258 ) Exit if Hyper-V is enabled and VirtualBox provider is used
...
This commit adds a function on windows for the VirtualBox provider to
check if Hyper-V is enabled. If so, exit and display a warning to the
user that going forward will result in a system crash.
2018-02-08 11:20:41 -08:00
Pavel Valena
a102bc064f
Use 127.0.0.1 instead of localhost
...
in test is_port_open_test.rb
2018-01-31 19:08:35 +01:00
Ryan Walder
db457e6318
Add master_json_config & minion_json_config options to salt provisioner
...
* Allow use of -j/-J bootstrap options for configuring master/minion
2018-01-31 12:28:36 +00:00
Chris Roberts
0f7f4b32b9
Merge pull request #9400 from chrisroberts/fall-back-to-system-ssh
...
Allow which to use original path. Prefer native ssh.
2018-01-26 07:21:33 -08:00
Chris Roberts
570d5abb95
Prefer ssh executable found on original path
2018-01-25 08:23:14 -08:00
Chris Roberts
6f6e936451
Add option to Which utility for using original path on lookup
2018-01-25 08:23:14 -08:00
Brian Cain
343e252574
Favor system ssh binary over embedded ssh binary
2018-01-25 08:23:14 -08:00
Chris Roberts
780673c6fe
Add warning message for VirtualBox shared folders option.
...
Display warning to user about the VirtualBox SharedFoldersEnableSymlinksCreate
option with link to VirtualBox documentation and instructions on how the
setting can be disabled.
2018-01-20 06:51:59 -08:00
Chris Roberts
f31badebb8
Merge pull request #9380 from chrisroberts/e-checkpoint
...
Update checkpoint integration
2018-01-19 15:06:28 -08:00
Brian Cain
2225379b84
Update spec box versions
2018-01-17 16:34:15 -08:00
Chris Roberts
0bf589861c
Merge pull request #9212 from mahaag/master
...
Use basename for setting hostname on Suse
2018-01-16 20:08:05 -08:00
Chris Roberts
b5383cffab
Merge pull request #9369 from chrisroberts/e-generic-sensitive
...
Add Vagrantfile configuration option to register sensitive values
2018-01-16 20:05:37 -08:00
Chris Roberts
a51c6c8479
Merge pull request #9367 from chrisroberts/e-sensitive-prov
...
Allow hiding environment variable values in shell provisioner
2018-01-16 20:03:00 -08:00
Chris Roberts
933694d986
Merge pull request #9365 from chrisroberts/e-smb-cred-check
...
Check SMB credentials
2018-01-16 20:00:57 -08:00
Chris Roberts
3bd515dff3
Merge pull request #9366 from chrisroberts/e-smb-opts
...
Support SMB mount option overrides
2018-01-16 19:58:19 -08:00
Chris Roberts
f4cc82dffc
Include current kernel version when install devel package
2018-01-16 16:42:49 -08:00
Chris Roberts
48275614cf
Add test coverage on helper method
2018-01-16 15:39:31 -08:00
Chris Roberts
1e909fe5f3
Add test coverage on checkpoint integration
2018-01-16 15:19:59 -08:00
Chris Roberts
f2f8bc2db5
Add Vagrantfile configuration option to register sensitive values
2018-01-15 07:23:47 -08:00
Chris Roberts
3664f1a627
Allow hiding environment variable values in shell provisioner
2018-01-12 17:33:47 -08:00
Chris Roberts
b1c38c282e
Support SMB mount option overrides
2018-01-12 17:23:00 -08:00
Chris Roberts
5444271268
Move SMB credentials validation into host capability
2018-01-12 16:55:35 -08:00
Chris Roberts
b0fc6a06a1
Merge pull request #9294 from chrisroberts/e-smb
...
SMB synced folders enhancements
2018-01-12 15:02:08 -08:00
Brian Cain
25a2b5f9ab
Merge pull request #9183 from briancain/update-spec-boxes
...
Update vagrant-spec to include Windows platforms and updated linux boxes
2018-01-12 14:51:19 -08:00
Chris Roberts
15393fb725
Merge pull request #9274 from chrisroberts/f-nfs-naming
...
Update NFS service name usage for linux hosts
2018-01-12 13:14:07 -08:00
Brian Cain
5bf75dcfb3
Merge pull request #9338 from chrisroberts/fix-ubuntu17-networking
...
Update Debian guest configure networks
2018-01-10 10:11:47 -08:00
Brian Cain
bf4ea4e76c
Fix sticky Travis CI test
...
this commit removes the webserver block within the box add unit test.
It's not actually needed since the test is just ensuring that if a user
adds a box name as a URL it prints a warning to the user.
2018-01-09 16:05:07 -08:00
Brian Cain
b16ca2e384
Introduce flag for SharedFoldersEnableSymlinksCreate
...
Prior to this commit, the virtualbox synced folder option
`SharedFoldersEnableSymlinksCreate` was always enabled. This commit
introduces a config option and an environment variable which allows
users to configure the option globally or per synced_folder in their
Vagrantfile.
2018-01-09 14:33:24 -08:00
Brian Cain
c9e5a22bff
( #9062 ) Deprecate :paranoid in favor of :verify_host_key
...
As of `net-ssh` version 4.2.0, the key :paranoid has been deprecated in
favor of using :verify_host_key. This commit updates Vagrants ssh config
to use the new key, and deprecates the use of :paranoid.
2018-01-05 10:02:45 -08:00
Chris Roberts
5191ec1281
Remove old test stubs
2018-01-04 15:06:19 -08:00
Chris Roberts
9596765034
Update debian network configuration tests
2018-01-03 16:32:21 -08:00
Chris Roberts
abf74e3757
Expand existing and requested paths prior to comparison
2018-01-03 10:05:05 -08:00
Chris Roberts
3e4c81f6b1
Clean up tests
2018-01-02 14:36:56 -08:00
Chris Roberts
98ec1af30e
Add smb_start capability for darwin
2018-01-02 11:21:50 -08:00
Chris Roberts
aabf4d689c
Fix up NFS test to ignore smb capability requests
2017-12-21 10:05:50 -08:00
Chris Roberts
3fd9f44921
Add test coverage for windows host smb capability
2017-12-21 09:55:19 -08:00