Chris Roberts
e24728cb5a
Merge pull request #10155 from chrisroberts/f-plugin-load-config
...
Reset internal environment after plugin load
2018-08-30 11:30:14 -07:00
Chris Roberts
c4084a6387
Extract smblist information based on position
...
Since we are no longer extracting information based on key value due
to localization issues, use start and end locations to extract data.
This prevents errors when extra information is included like Scope.
2018-08-30 10:58:56 -07:00
Chris Roberts
9b67655e45
Reset internal environment after plugin load
...
Force the vagrantfile and configuration loader to be rebuilt after
plugins have been loaded to properly allow newly introduced plugin
configurations to be properly supported within the Vagrantfile.
2018-08-30 10:44:09 -07:00
Chris Roberts
92109752a3
Fix local plugin prompt and add coverage
2018-08-30 10:35:16 -07:00
Chris Roberts
d48b95ffaf
Check :verify_host_key value for :never or if falsey
2018-08-24 14:11:30 -07:00
Brian Cain
6a57ae74a8
Merge pull request #10118 from briancain/TRIGGER-SPACE-PATH
...
Allow for spaces in `path` for trigger run option
2018-08-17 15:29:07 -07:00
Brian Cain
b1357a2f60
Merge pull request #10123 from briancain/add-force-flag-reload
...
Add `--force` flag to reload command
2018-08-17 15:18:36 -07:00
Brian Cain
5723c7181a
Add test for trigger run path with spaces
2018-08-17 15:17:49 -07:00
Brian Cain
57c48ee348
Merge pull request #10116 from briancain/fix-run-arg-trigger
...
Ensure trigger run args are an array prior to join
2018-08-17 15:10:52 -07:00
Brian Cain
c9a31f7800
Merge pull request #10115 from briancain/flatten-ps-cmds-triggers
...
Properly join commands from passed in array
2018-08-17 15:10:46 -07:00
Brian Cain
f9892e0b24
Merge pull request #10124 from briancain/fixup-subprocess-tests-darwin
...
Fix up subprocess test to not be darwin
2018-08-17 15:10:25 -07:00
Brian Cain
c2cff0dc07
Merge pull request #10100 from briancain/DOCKER-TOOLBOX
...
Convert windows paths for volume mounts on docker driver
2018-08-17 15:08:59 -07:00
Brian Cain
e5364e7798
Only write box metadata if guest has box object
...
Prior to this commit, providers like docker would fail to be brought up
because they do not store box objects like virtualbox or vmware
provider guests. This commit fixes that by making sure the box object
exists before writing the metadata file to disk.
2018-08-17 09:58:24 -07:00
Brian Cain
fec681c1af
Fix up subprocess test to not be darwin
2018-08-16 14:57:56 -07:00
Brian Cain
c65a0a9054
( #9677 ) Add `--force` flag to reload command
...
This commit introduces the `--force` flag to the reload command. This
change means that if the flag is included, the halt step of the reload
will forcefully shutdown the virtual machine rather than a graceful
halt.
2018-08-16 13:57:13 -07:00
Brian Cain
8bce4f3828
Update tests to include passed in arg values
2018-08-14 13:24:42 -07:00
Brian Cain
29aba535ce
( #10104 ) Ensure trigger run args are an array prior to join
...
Prior to this commit, if the args key was a string rather than an array
of strings, the `join` command would fail when appending the arguments
to the run command for a given script. This commit updates that by
ensuring the `args` option is an array prior to joining the arguments.
2018-08-14 10:29:51 -07:00
Brian Cain
e073153728
( #10099 ) Properly join commands from passed in array
...
Prior to this commit, the `Util::Powershell.execute_inline`
method didn't properly join the passed in command and instead attempted
to execute the array of strings. This commit updates that
behavior to join the command array prior to inserting it into the full
powershell command.
2018-08-14 09:30:11 -07:00
Brian Cain
5d2d784ae7
( #9085 ) - Add test for converting windows paths
...
This commit adds a test for checking that a windows path for mounting a
volume in a container is properly converted into something that's
usable.
2018-08-08 10:30:04 -07:00
Chris Roberts
2c4c14c57c
Merge pull request #10084 from chrisroberts/f-host-nfs-sudo
...
Fix sudo usage in exports write within linux host cap
2018-08-08 08:28:49 -07:00
Jeremy Maness
a73fb9c139
- Filter out empty strings when constructing the list of network interfaces
...
- Sort interfaces properly whose name does not contain a numeric suffix (e.g. lo)
- Filter out loopback interfaces
2018-08-04 21:16:51 -04:00
Chris Roberts
00b783a6a5
Lookup latest available installed box if required on update
...
When performing a box update and the box version has been updated
to be different than the installed version, perform a lookup for
the latest available installed box to allow the update command to
continue successfully
2018-08-02 16:12:10 -07:00
Chris Roberts
051c7a7823
Fix sudo usage in exports write within linux host cap
...
Only move new exports file to destination without sudo when the
file has write access and the directory has write access. Always
use sudo when changing file ownership.
2018-08-02 15:13:27 -07:00
Chris Roberts
6c1a9dc58e
Store box metadata of active guest
...
When a guest is created, the box metadata information is stored in the
machine data directory. This allows modifications to happen to the
Vagrantfile definition of the box in use (box name change, box version
change, etc) while still allowing the Machine instance of an active
guest successfully load the box currently backing it.
2018-08-02 11:01:36 -07:00
Chris Roberts
66566b8c3d
Merge pull request #10078 from chrisroberts/e-appimage-libs
...
Detect AppImage and update executable environment if required
2018-07-31 13:56:35 -07:00
Chris Roberts
09c8e2800c
Merge pull request #10077 from chrisroberts/e-ipv6-link-local
...
Skip link-local addresses when fixing IPv6 route
2018-07-31 13:52:50 -07:00
Chris Roberts
e3e68c9b51
Merge pull request #10076 from chrisroberts/e-winrm-warn
...
Add warning when vagrant-winrm is found
2018-07-31 13:51:23 -07:00
Chris Roberts
fa9bda9554
Merge pull request #10066 from chrisroberts/e-net-ssh-update
...
Update net-ssh constraint
2018-07-31 13:48:49 -07:00
Chris Roberts
6009492e73
Detect AppImage and update executable environment if required
...
If starting a process while running from within AppImage adjust
the LD_LIBRARY_PATH of the subprocess when the executable exists
outside of the AppImage. This prevents issues of invalid dynamic
library lookups when the AppImage contains common named libraries.
2018-07-31 10:39:26 -07:00
Chris Roberts
87ee57d94a
Add test coverage on link-local skip for ipv6 in vbox
2018-07-30 15:16:50 -07:00
Chris Roberts
cd7215ab13
Add warning when vagrant-winrm is found
2018-07-30 13:27:20 -07:00
Chris Roberts
0e0f660f62
Fix stray test checking verify_host_key
2018-07-27 16:51:58 -07:00
Chris Roberts
57e0bb5105
Update net-ssh constraint
...
Also includes mapping of verify_host_key value to new values
introduced in 5.0.0
2018-07-27 16:30:06 -07:00
Brian Cain
a3ef471cb0
( #9811 ) Add test for volume consistency and improve documentation
2018-07-27 15:16:39 -07:00
Chris Roberts
c0b871794c
Merge pull request #9926 from Telekom-PD/centos_75_nmcli_hang
...
Fix hang at nmcli call on CentOS 7.5 when ssh.pty is enabled
2018-07-27 12:11:30 -07:00
Chris Roberts
f9e994a15d
Match package install string and fix test name
2018-07-27 10:26:10 -07:00
Chris Roberts
584b288b8f
Merge pull request #9935 from whitel/fix-for-#9878
...
Fixes the change in packaging for nfs in f28 (#9878 )
2018-07-27 10:22:42 -07:00
Chris Roberts
a993cbce4e
Merge pull request #10037 from chrisroberts/e-vagrant-plugins-local
...
Define project specific plugins
2018-07-27 09:57:41 -07:00
Chris Roberts
ab4dbe85d6
Merge pull request #10041 from chrisroberts/f-downloader-mtch
...
Prevent matching on other Location headers
2018-07-27 09:50:17 -07:00
Chris Roberts
4d4e707b73
Merge pull request #9889 from treytabner/debian-systemd-networkd
...
Increase priority and support multiple networks for Debian with systemd-networkd
2018-07-19 14:13:46 -07:00
Chris Roberts
c660643abb
Prevent matching on other Location headers
...
Prevent matching on custom headers that include the Location name
when checking for host redirection.
2018-07-19 09:18:30 -07:00
Chris Roberts
27a441f0bd
Merge pull request #10001 from chrisroberts/e-wsl-valid-sync
...
Disable synced folders on non-DrvFs
2018-07-18 16:41:16 -07:00
Chris Roberts
10faa599e7
Merge pull request #9999 from chrisroberts/f-hyper-v-snaps
...
Enable checkpoints for snapshots if disabled
2018-07-18 16:38:32 -07:00
Chris Roberts
2ba5c74e1c
Merge pull request #9998 from chrisroberts/f-plat-wsl-pathname
...
Always force string type conversion of path
2018-07-18 16:37:07 -07:00
Chris Roberts
14edb8f423
Add local only and global only flags to plugin expunge command
2018-07-18 13:43:52 -07:00
Chris Roberts
564dff651e
Add coverage on vagrantfile_name stubbing behavior
2018-07-18 10:50:41 -07:00
Chris Roberts
3e22764ac8
Add test coverage on globalize and localize within plugin manager
2018-07-18 10:48:57 -07:00
Chris Roberts
8baf7ced38
Use path of state file, not state file itself
2018-07-17 15:35:25 -07:00
Chris Roberts
737ef0eded
Allow Vagrantfile to load when using --local
2018-07-17 15:00:38 -07:00
Chris Roberts
78bf131dc8
Do not use singleton for testing
2018-07-17 14:49:41 -07:00
Chris Roberts
3223737734
Use env_local consistently internally
2018-07-17 14:49:41 -07:00
Chris Roberts
a410b0af51
Start adding bundler coverage
2018-07-17 14:49:41 -07:00
Chris Roberts
84c0aafe71
Support non-interactive local plugin install
2018-07-17 14:49:41 -07:00
Chris Roberts
516e1d2621
Add test coverage on the vagrant bin file behavior
2018-07-17 08:00:12 -07:00
Chris Roberts
8aa74a03a0
Differentiate checkpoints and automatic checkpoints
...
Provide separate configuration settings for enabling/disabling
checkpoints and automatic checkpoints with Hyper-V provider.
2018-07-13 15:23:09 -07:00
Brian Cain
52c3dcc70e
( #9997 ) Catch and allow for non-standard exit codes
...
Prior to this commit, the run trigger option wouldn't catch for failures
outside of the #Subprocess.execute raising exceptions. This commit fixes
that by inspecting the exit code result of the subprocess and using the
new `exit_codes` option to determine how to move forward with the
trigger.
2018-07-09 15:56:26 -07:00
Chris Roberts
859d48d5f5
Restrict synced folder access to DrvFs file systems only within WSL
2018-07-06 16:58:12 -07:00
Chris Roberts
6aa5c1a008
Always force string type conversion of path
...
Fixes #9984
2018-07-06 14:29:32 -07:00
Chris Roberts
ac8ad59823
Provide custom error when attempting to push too many files with FTP
...
When the configured directory for FTP push has too many files, it will
generate an exception and fail due to a stack overflow. When this happens
just rescue out the exception and re-raise a custom error to provide
some context to the user on the actual problem.
2018-06-26 08:28:01 -07:00
Chris Roberts
ed2af17e45
Add delete vm action checks for data directory removal and creation
2018-06-18 10:18:05 -07:00
Chris Roberts
ea4e60247d
Check for module_path entry instead of custom environment variable
2018-06-18 09:53:22 -07:00
Chris Roberts
835c500892
Add WSL check on usable? test for provider
2018-06-18 09:50:56 -07:00
Chris Roberts
cdab45424e
Clean up powershell tests and add test for full path check
2018-06-18 09:39:17 -07:00
langdon
f0b9d025e4
Fixes the change in packaging for nfs in f28 ( #9878 ). However, removed part of the unit test which will be very difficult to fix (I expect). The unit test is still doing a good test that nfs and rpcbind work though. If you go far enough back, you need to bury the error out too.
2018-06-18 12:16:23 -04:00
Trey Tabner
c218267436
Merge branch 'master' into debian-systemd-networkd
2018-06-13 12:49:50 -05:00
Simon Baatz
fa34f4d2af
Fix hang at nmcli call on CentOS 7.5 when ssh.pty is enabled
...
`vagrant up` may hang at the "Configuring and enabling network
interfaces..." step when private networks and PTY allocation for SSH
are used.
The newer version of `nmcli` that is part of CentOS now will open a
pager (i.e. `less`) for certain commands if it finds a tty. This
causes the invocations of `nmcli` in `guest_inspection.rb` to hang.
`nmcli` disables the use of a pager in 'terse' (`-t`) output mode,
while still returning enough information for the uses in
`guest_inspection.rb`.
2018-06-13 11:10:18 +02:00
Chris Roberts
ef4d431d36
Remove console resizing on powershell commands
2018-06-12 16:47:47 -07:00
Chris Roberts
ee5656da37
Merge pull request #9923 from chrisroberts/f-win-perms
...
Update SSH key file permissions handling
2018-06-12 16:45:39 -07:00
Chris Roberts
7e0cc99ffd
Include flag check on ssh cap test
2018-06-12 16:30:51 -07:00
Chris Roberts
4bf8fe1463
Merge pull request #9917 from chrisroberts/f-smb-garbage
...
Fix SMB information generation when using net share
2018-06-12 16:24:54 -07:00
Chris Roberts
2628d93370
Rename method name when checking capability
2018-06-12 14:13:10 -07:00
Chris Roberts
bf7cd4fb0a
Add test coverage for powershell module option
2018-06-12 12:32:04 -07:00
Chris Roberts
42cbae1e90
Add test coverage on ssh capabilities
2018-06-12 11:57:14 -07:00
Chris Roberts
ef5eca16d2
Fix SMB information generation when using net share
...
Adds the final line of output to tests and properly simulates
failure. Fix with type casting to prevent calling methods on
nil and drop the final entry as it's not valid.
Fixes #9806
2018-06-11 12:58:35 -07:00
Chris Roberts
7df6ea5a30
Fix Chef apply provisioner to not set node_name
...
The base chef provisioner class will set the node name automatically
if not provided in the configuration. Since the chef apply provisioner
does not provide a node_name option, setting it will invalidate the
configuration. This checks for the node name before attempting to
use it.
Fixes #9901
2018-06-11 10:35:52 -07:00
Chris Roberts
52c174da75
Merge pull request #9833 from afischer-opentext-com/9174
...
#9174 Remove masterless? config attribute
2018-06-08 16:18:06 -07:00
Chris Roberts
5e68c896cf
Force types for testing
2018-05-30 15:42:04 -07:00
Chris Roberts
1be87662da
Add missing test coverage for powershell util methods
2018-05-30 15:05:27 -07:00
Trey Tabner
9197036499
The restart command was moved to after the loop
2018-05-30 11:00:58 -05:00
Chris Roberts
1becae50a5
Include test coverage on provider option deprecation
2018-05-29 10:25:48 -07:00
Chris Roberts
c238dc0a35
Include machine name when raising invalid box errors
2018-05-25 16:43:17 -07:00
Chris Roberts
eba552ea73
Add more test coverage on Hyper-V Provider actions
2018-05-25 16:23:45 -07:00
Chris Roberts
d24b432273
Add Hyper-V provider actions test coverage
2018-05-25 15:12:39 -07:00
Chris Roberts
6c731fb86c
Add test coverage on hyper-v provider driver
2018-05-25 10:11:44 -07:00
Chris Roberts
beacb5bada
Add test coverage for all hyper-v configuration options
2018-05-24 16:56:46 -07:00
Brian Cain
c6cd8f1e9a
Merge pull request #9829 from briancain/add-suspend-global
...
Introduce flag for suspending all machines
2018-05-11 16:41:24 -07:00
Brian Cain
5ca382727d
Raise error if argument is provided with `--all-global` flag
...
This commit raises an error if additional arguments are provided to the
suspend command when the `--all-global` flag is used.
2018-05-11 15:43:14 -07:00
Brian Cain
aa5687cd14
( #7221 ) Introduce flag for suspending all machines
...
This commit introduces a new flag to the suspend command,
`--all-global`, which will suepend all vms both locally and globally.
2018-05-11 10:15:48 -07:00
Alexander Fischer
0b87184ad4
#9174 Remove masterless? config attribute
...
Remove the @config.masterless? attribute as there is no benefit from it
2018-05-11 08:49:57 +02:00
Brian Cain
728a9135c8
( #9726 ) Update netplan config generation to detect NetworkManager
...
Prior to this commit, when setting up private networks on Ubuntu using
netplan, it assumed that the guest was using systemd, the suggested
default tool to manage networking, and did not take into account devices
that could be managed with NetworkManager. This commit fixes that by
looking at the devices managed on the guest to see if its managed by
NetworkManager, and if so, use that renderer for netplan instead of
networkd.
2018-05-10 13:02:05 -07:00
Chris Yungmann
7fb9d3eb4f
propagate unset guestpath
2018-05-08 22:51:30 -05:00
Chris Roberts
3bcdd2901b
Merge pull request #9800 from chrisroberts/e-vbox-builtin
...
Support VirtualBox shared folders using builtin kernel module
2018-05-07 13:24:50 -07:00
Chris Roberts
0a523bc12b
Merge pull request #9785 from chrisroberts/f-smb-list
...
Use net.exe to fetch SMB shares when Get-SmbShare is not available
2018-05-07 13:07:47 -07:00
Chris Roberts
c571249000
Support VirtualBox shared folders using builtin kernel module
...
Check error output if initial mount command fails to determine if
the builtin module should be used for mounting instead.
2018-05-07 13:02:19 -07:00
Brian Cain
a177bcf4b7
Ensure internal trigger fire does not get called if plugin installed
...
This commit wraps up the internal machine action level trigger calls if
the community vagrant-trigger plugin is installed.
2018-05-07 11:33:55 -07:00
Brian Cain
092e73d87f
( #9775 ) Move triggers object init in machine
...
Prior to this commit, the hyper-v provider called an action on a machine
that hadn't fully finished initializing. This commit fixes that by
moving up the initialization of the triggers object next to the rest of
the instance variables of the machine object.
2018-05-04 14:32:57 -07:00
Chris Roberts
7a4150dc3f
Use net.exe to fetch SMB shares when Get-SmbShare is not available
...
Fixes #9547
2018-05-04 14:07:33 -07:00
Chris Roberts
40ae8aa38d
Merge pull request #9769 from chrisroberts/e-key-perms
...
Log error and proceed when private key permissions fail
2018-05-03 12:34:50 -07:00
Chris Roberts
f0e232d739
Log error and proceed when private key permissions fail
...
Fixes #9765
2018-05-03 11:48:57 -07:00
Chris Roberts
8b398b66a3
Trim drive letter prefix from path
...
Fixes #9764
2018-05-03 09:28:19 -07:00
Brian Cain
70df6d4b2a
Merge pull request #9760 from briancain/continue-on-malformed-json
...
Continue on if vagrant fails to parse metadata box for update
2018-05-02 15:49:08 -07:00
Brian Cain
e1129d27f9
Merge pull request #9761 from briancain/FIX-DOCKER-EXEC
...
Use Util::SafeExec if docker-exec is run with `-t` option
2018-05-02 15:47:46 -07:00
Brian Cain
79e535a7ee
( #9622 ) Use SafeExec for docker-exec
...
This commit uses the internal helper SafeExec rather than using the
Kernel class directly. It also adds a test to ensure that if the `-t`
option is used, it will call SafeExec.
2018-05-02 14:23:50 -07:00
Brian Cain
beb08b51a4
( #7076 ) Continue on if vagrant fails to parse metadata box for update
...
Prior to this commit, vagrant would halt if it could not parse the
metadata file for a box to check for updates with. This commit changes
that to behave like when vagrant fails to download a metadata file and
continue on but warn the user it failed to check for box updates.
2018-05-02 13:58:21 -07:00
Brian Cain
6fc2d9d82d
Merge pull request #9754 from briancain/DOCKER-PROV-WINDOWS
...
Update docker provisioner for windows, fix command filter behavior for `rm`
2018-05-01 13:46:33 -07:00
Brian Cain
93356d4635
Update rm filters to test for path
...
This commit updates the rm filter for winrm to operate like how rm works
in bash. If a folder doesn't exist, the command returns 0 rather than 1.
2018-05-01 13:35:45 -07:00
Joe Pleso
c882d888a7
Add docker cap to windows to detect daemon and fix whitespace
2018-04-27 09:45:24 -07:00
Chris Roberts
97f5822dee
Ignore URLs which cannot be parsed in the authentication middleware
...
Fixes #9725
2018-04-26 15:08:06 -07:00
Chris Roberts
d2ec4d9312
Merge pull request #9734 from chrisroberts/f-win-smb-mount
...
Default SMB version to 2.0 for linux guest mounts on Windows hosts
2018-04-26 14:48:01 -07:00
Chris Roberts
6fb293736e
Merge pull request #9730 from chrisroberts/f-smb-urls
...
Return original URL value when unmodified
2018-04-26 14:44:13 -07:00
Brian Cain
fd3d78746c
( #9717 ) Improve messaging around not finding requested provider
...
This commit adds a bit more helpful messaging for the user when asking
for a provider that might not exist or does not follow the correct
casing. If it can find a match on a provider it knows about, it will
suggest it.
2018-04-26 09:43:58 -07:00
Chris Roberts
40a1d2faf3
Default SMB version to 2.0 for linux guest mounts
...
Fixes #8959
2018-04-26 08:45:05 -07:00
Chris Roberts
5feb234665
Return original URL value when unmodified
...
Due to the behavior of URI.parse on Ruby < 2.5 returning the string
value of the parsed URI object may modify the original URL. Specifically
it will remove the `//` prefix characters from SMB paths. When no
host modifications are being made, always return the original value.
Fixes #9636
2018-04-25 16:21:21 -07:00
Brian Cain
67c3f866dd
( #7886 ) Add tests and simplify code for continuing on 416
2018-04-25 14:03:24 -07:00
Brian Cain
5643ba0c7d
Merge pull request #9713 from briancain/vagrant-triggers-config
...
Integrate vagrant-triggers plugin functionality into core Vagrant
2018-04-24 11:35:04 -07:00
Brian Cain
7f004656db
( #9718 ) Properly finalize structured_facts config option
...
This commit sets the structured_facts option to nil if its still
UNSET_VALUE at the finalize step. This was causing a bug when the facter
config was set but was not using structured facts.
2018-04-23 14:23:59 -07:00
Brian Cain
2000a11042
Add tests for powershell run functions
2018-04-20 10:51:38 -07:00
Brian Cain
e7d07cb110
Add rspec tests for trigger plugin
2018-04-20 10:51:38 -07:00
Brian Cain
6ea7819402
Update rspec tests for trigger plugin
2018-04-20 10:51:38 -07:00
Brian Cain
fbad4c749d
Add basic spec test for trigger class
2018-04-20 10:51:38 -07:00
Brian Cain
0953287262
Relax only_on rspec tests
...
only_on can be either a string or regex
2018-04-20 10:51:38 -07:00
Brian Cain
e7274f1b6c
Improve config rspec tests
2018-04-20 10:51:38 -07:00
Brian Cain
956ed004bb
Update trigger config merge function
2018-04-20 10:51:38 -07:00
Brian Cain
7dae1acd21
Add some "default" options to be validated
2018-04-20 10:51:38 -07:00
Brian Cain
fc526a164a
Add basic create_trigger rspec test
2018-04-20 10:51:38 -07:00
Brian Cain
e157362ace
Add run and run_remote expectations
2018-04-20 10:51:38 -07:00
Brian Cain
7b1b044e72
Check for default on_error behavior setting
2018-04-20 10:51:38 -07:00
Brian Cain
6cbb5d8e5d
Add unit tests for config, fix type change bug with map!
2018-04-20 10:51:38 -07:00
Brian Cain
3dec6869bb
Update trigger unit tests
2018-04-20 10:51:38 -07:00
Brian Cain
42419bbd49
Fix rspec tests
2018-04-20 10:51:38 -07:00
Brian Cain
6f00eb5679
Move trigger options into own plugin class
2018-04-20 10:51:38 -07:00
Brian Cain
bb2f3b35b9
Add basic unit test
2018-04-20 10:51:38 -07:00
Brian Cain
9660951c89
Merge pull request #9490 from jzinn/solo-rb-cookbook-path
...
Improve Windows drive letter removal hack
2018-04-18 08:31:23 -07:00
Julian Zinn
269645f63d
Improve Windows drive letter removal hack
2018-04-17 13:23:14 -07:00
Brian Cain
151095a3e9
Merge pull request #9420 from ryanwalder/salt-json
...
Add master_json_config & minion_json_config options to salt provisioner
2018-04-16 15:37:44 -07:00
Chris Roberts
5d7506afe3
Merge pull request #9676 from chrisroberts/e-win-file-perms
...
Update generated ssh private key file permissions on create
2018-04-10 14:56:28 -07:00
Chris Roberts
b2db1adb7c
Merge pull request #9674 from chrisroberts/f-wsl-version-check
...
Check Windows installed Vagrant version using --version
2018-04-10 14:47:06 -07:00
Chris Roberts
b605da0ef5
Merge pull request #9673 from chrisroberts/f-win-paths-filter
...
Fix windows command filters
2018-04-10 14:44:32 -07:00
Chris Roberts
9731720773
Update generated ssh private key file permissions on create
...
This updates the permissions on the automatically generated private
key file to only be readable by the user. Includes support for file
permission modification on Windows platform.
2018-04-10 14:15:14 -07:00
Brian Cain
f1de9821e1
Merge pull request #8099 from chrisroberts/windows/shared-folder-path
...
Fix virtualbox shared folders path
2018-04-10 09:16:06 -07:00
Chris Roberts
e4399a5724
Check Windows installed Vagrant version using --version
...
Using the --version flag keeps Vagrant from doing a full startup
and prevents the Vagrantfile from being parsed. This makes the
version check faster, and stops things like syntax errors within
a Vagrantfile from causing an unexpected error.
Fixes #9635
2018-04-10 08:05:23 -07:00
Chris Roberts
ddfd86f3d1
Split with shellwords and quote paths in command filter
...
This uses shellwords to split the command in the command filter
inside the winrm communicator. Using shellwords properly handles
things like quoted paths. Path arguments are also quoted to
prevent issues with paths that include spaces.
Fixes #9390
2018-04-09 17:00:30 -07:00
Brian Cain
1a03fe687b
Update rspec tests for puppet provisioner
2018-04-09 11:03:30 -07:00
Chris Roberts
f3c5e86f28
Merge pull request #9504 from zachflower/feature/vagrant-aliases
...
Vagrant aliases
2018-04-06 15:39:18 -07:00
Chris Roberts
8391abc63a
Properly respect environment variable on checkpoint setup
...
The checkpoint update missed the environment variable check for
disabling the checks so this adds in the check and properly
disables checks when requested.
2018-04-05 10:47:28 -07:00
Chris Roberts
ef4318eda2
Merge pull request #9653 from chrisroberts/f-powershell-detection
...
Make powershell version detection timeout configurable
2018-04-04 16:20:23 -07:00
Chris Roberts
8ac0fedbbb
Suppress errors from invalid path encoding and carry on with best effort
...
Fixes #9299
2018-04-04 16:09:46 -07:00
Chris Roberts
90fa705a6d
Make powershell version detection timeout configurable
...
Allows custom configuration of the powershell timeout and bumps
the default timeout from 10 seconds to 30 seconds.
Fixes #9629
2018-04-04 16:02:11 -07:00
Chris Roberts
30e7e81eab
Make resolv-replace loading optional not automatic
2018-04-02 11:59:02 -07:00
Brian Cain
0ce6e9891e
Merge pull request #9572 from jsoref/spelling
...
Spelling
2018-03-22 09:50:52 -07:00
ajpaul
e602160234
update change_host_name_test to comply with reintroduction of sleep_timeout parameter
2018-03-16 13:59:23 -04:00
ajpaul
4e8062625c
update unit test for change_host_name to fix failures introduced by changes to the module
2018-03-16 13:49:39 -04:00
Adam Paul
0dc3798908
update unit test to reflect changes in change_host_name.rb
2018-03-15 11:07:02 -04:00
Josh Soref
1a5ddea9f4
Spelling fixes
...
* account
* addresses
* administrator
* afterwards
* because
* bridgeable
* capabilities
* capability
* checksum
* configuration
* configuration for
* configure
* criteria
* delimited
* delivered
* derivatives
* description
* detect
* directory
* display
* downloading
* during
* electric
* enabling
* encountered
* equivalent
* executable
* executed
* hashicorp
* hypervisor
* hyphens
* implementation
* incorporate
* inheritance
* initialize
* instance
* instead
* interactions
* invocable
* machine
* maximum
* message
* mounting
* overridden
* overwrite
* paramiko
* preparing
* provides
* provisioning
* recursively
* requested
* resetting
* retryable
* running
* satisfied
* searching
* sometimes
* specified
* successfully
* synced folders
* unauthorized
* underlying
* userprofile
* vagrant
* vagrantfile
* variable
* various
* version
* virtual
* windows
2018-03-14 14:41:04 +00:00
Chris Roberts
51232f9a03
When matching hostonly adapter name, force common types
...
Force a string type for comparison to prevent false positives when
the name is unset (resulting in a nil value).
2018-03-09 14:15:31 -08:00
Brian Cain
94d9495209
Merge pull request #9543 from moore3071/unnecessary_redirects
...
Update URLs for the repo
2018-03-08 09:54:16 -08:00
Brandon Moore
5a12641f9c
Update URLs for the repo
2018-03-07 17:10:30 -05:00
Chris Roberts
8b7e501e50
Handle pathing in lxrun generated WSL instances better.
2018-02-28 10:08:01 -08:00
Chris Roberts
5f0d16a0e9
Include support for lxrun generated install
...
Adds compatibility support for legacy lxrun generated WSL installation
which is a single install at a known path location. This allows earlier
versions of Windows 10 to continue working as expected while still
supporting the recent updates allowing for multiple instances.
2018-02-28 10:08:01 -08:00
Chris Roberts
d0701fc95d
Merge pull request #9422 from pvalena/patch-1
...
Use 127.0.0.1 instead of localhost
2018-02-23 09:49:10 -08:00
Chris Roberts
04ec3c26d7
Merge pull request #8735 from jhosteny/fix/debian_net_tools_deprecation_dhcp
...
Fix #8730 . Use 'ip route' in lieu of 'route' in debian dhcp template
2018-02-23 09:41:37 -08:00
Chris Roberts
00400c95d8
Merge pull request #9499 from chrisroberts/f-vc-urls
...
Update behavior of the authentication middleware
2018-02-23 09:28:04 -08:00
Chris Roberts
b5b5f8870a
Merge pull request #9472 from chrisroberts/e-sensitive-length
...
Ignore empty strings registered as sensitive
2018-02-23 09:26:38 -08:00
Chris Roberts
d6f4c75f40
Merge pull request #9344 from chrisroberts/e-dl-redirect-notify
...
Notify when host changes on redirect
2018-02-23 09:24:40 -08:00
Chris Roberts
fc5ceafbcf
Only generate notice once
2018-02-22 14:49:44 -08:00
Brian Cain
d1c3deb234
( #9452 ) Use provider override for box_version if given
...
Prior to this commit if an override was given for a box version, it
would be ignored. This commit ensures that the box_version override is
used when specified in a Vagrantfile.
2018-02-22 10:43:52 -08:00
Chris Roberts
5c9c10558a
Update curl options in test
2018-02-21 17:05:13 -08:00
Chris Roberts
f2bf18e56b
Update behavior of the authentication middleware
...
Always remap old hosts to target host when encountered. When custom
vagrant server is defined, warn when tokens may be attached and allow
time for user to cancel.
Fixes #9442
2018-02-21 17:03:38 -08:00
Zachary Flower
f46ebf5240
throw an exception when whitespace is found within an alias keyword
2018-02-16 13:28:57 -07:00
Zachary Flower
f16751a46d
start working through tests
2018-02-16 13:00:39 -07:00
Chris Roberts
330ee2e1eb
Ignore empty strings registered as sensitive
...
Fixes #9462
2018-02-15 17:02:34 -08:00
Brian Cain
78f317f55a
Merge pull request #9261 from vStone/bugfix/gentoo-static-ip-with-ifplugd
...
Disable if/netplugd when setting up a static ip on a gentoo guest using openrc.
2018-02-15 13:13:46 -08:00
Brian Cain
8c15e1995b
Merge pull request #9459 from briancain/9428/master/update-systemd-check
...
Update systemd? check for guest inspection
2018-02-14 08:50:27 -08:00
Brian Cain
b77171c4fc
( #9428 ) Update systemd? check for guest inspection
...
Prior to this commit, the regex matcher used with grep to determine if a
system was using systemd? was failing on systems that did not exactly
match the old regex. This commit updates that communications test to use
a different method of determining if systemd is in use with the ps
command.
2018-02-08 15:50:59 -08:00
Brian Cain
e8708232a5
( #9258 ) Exit if Hyper-V is enabled and VirtualBox provider is used
...
This commit adds a function on windows for the VirtualBox provider to
check if Hyper-V is enabled. If so, exit and display a warning to the
user that going forward will result in a system crash.
2018-02-08 11:20:41 -08:00
Pavel Valena
a102bc064f
Use 127.0.0.1 instead of localhost
...
in test is_port_open_test.rb
2018-01-31 19:08:35 +01:00
Ryan Walder
db457e6318
Add master_json_config & minion_json_config options to salt provisioner
...
* Allow use of -j/-J bootstrap options for configuring master/minion
2018-01-31 12:28:36 +00:00
Chris Roberts
0f7f4b32b9
Merge pull request #9400 from chrisroberts/fall-back-to-system-ssh
...
Allow which to use original path. Prefer native ssh.
2018-01-26 07:21:33 -08:00
Chris Roberts
570d5abb95
Prefer ssh executable found on original path
2018-01-25 08:23:14 -08:00
Chris Roberts
6f6e936451
Add option to Which utility for using original path on lookup
2018-01-25 08:23:14 -08:00
Brian Cain
343e252574
Favor system ssh binary over embedded ssh binary
2018-01-25 08:23:14 -08:00
Chris Roberts
780673c6fe
Add warning message for VirtualBox shared folders option.
...
Display warning to user about the VirtualBox SharedFoldersEnableSymlinksCreate
option with link to VirtualBox documentation and instructions on how the
setting can be disabled.
2018-01-20 06:51:59 -08:00
Chris Roberts
f31badebb8
Merge pull request #9380 from chrisroberts/e-checkpoint
...
Update checkpoint integration
2018-01-19 15:06:28 -08:00
Chris Roberts
0bf589861c
Merge pull request #9212 from mahaag/master
...
Use basename for setting hostname on Suse
2018-01-16 20:08:05 -08:00
Chris Roberts
b5383cffab
Merge pull request #9369 from chrisroberts/e-generic-sensitive
...
Add Vagrantfile configuration option to register sensitive values
2018-01-16 20:05:37 -08:00
Chris Roberts
a51c6c8479
Merge pull request #9367 from chrisroberts/e-sensitive-prov
...
Allow hiding environment variable values in shell provisioner
2018-01-16 20:03:00 -08:00
Chris Roberts
933694d986
Merge pull request #9365 from chrisroberts/e-smb-cred-check
...
Check SMB credentials
2018-01-16 20:00:57 -08:00
Chris Roberts
48275614cf
Add test coverage on helper method
2018-01-16 15:39:31 -08:00
Chris Roberts
1e909fe5f3
Add test coverage on checkpoint integration
2018-01-16 15:19:59 -08:00
Chris Roberts
f2f8bc2db5
Add Vagrantfile configuration option to register sensitive values
2018-01-15 07:23:47 -08:00
Chris Roberts
3664f1a627
Allow hiding environment variable values in shell provisioner
2018-01-12 17:33:47 -08:00
Chris Roberts
b1c38c282e
Support SMB mount option overrides
2018-01-12 17:23:00 -08:00
Chris Roberts
5444271268
Move SMB credentials validation into host capability
2018-01-12 16:55:35 -08:00
Chris Roberts
b0fc6a06a1
Merge pull request #9294 from chrisroberts/e-smb
...
SMB synced folders enhancements
2018-01-12 15:02:08 -08:00
Chris Roberts
15393fb725
Merge pull request #9274 from chrisroberts/f-nfs-naming
...
Update NFS service name usage for linux hosts
2018-01-12 13:14:07 -08:00
Brian Cain
5bf75dcfb3
Merge pull request #9338 from chrisroberts/fix-ubuntu17-networking
...
Update Debian guest configure networks
2018-01-10 10:11:47 -08:00
Brian Cain
bf4ea4e76c
Fix sticky Travis CI test
...
this commit removes the webserver block within the box add unit test.
It's not actually needed since the test is just ensuring that if a user
adds a box name as a URL it prints a warning to the user.
2018-01-09 16:05:07 -08:00
Brian Cain
b16ca2e384
Introduce flag for SharedFoldersEnableSymlinksCreate
...
Prior to this commit, the virtualbox synced folder option
`SharedFoldersEnableSymlinksCreate` was always enabled. This commit
introduces a config option and an environment variable which allows
users to configure the option globally or per synced_folder in their
Vagrantfile.
2018-01-09 14:33:24 -08:00
Brian Cain
c9e5a22bff
( #9062 ) Deprecate :paranoid in favor of :verify_host_key
...
As of `net-ssh` version 4.2.0, the key :paranoid has been deprecated in
favor of using :verify_host_key. This commit updates Vagrants ssh config
to use the new key, and deprecates the use of :paranoid.
2018-01-05 10:02:45 -08:00
Chris Roberts
5191ec1281
Remove old test stubs
2018-01-04 15:06:19 -08:00
Chris Roberts
9596765034
Update debian network configuration tests
2018-01-03 16:32:21 -08:00
Chris Roberts
abf74e3757
Expand existing and requested paths prior to comparison
2018-01-03 10:05:05 -08:00
Chris Roberts
3e4c81f6b1
Clean up tests
2018-01-02 14:36:56 -08:00
Chris Roberts
98ec1af30e
Add smb_start capability for darwin
2018-01-02 11:21:50 -08:00
Chris Roberts
aabf4d689c
Fix up NFS test to ignore smb capability requests
2017-12-21 10:05:50 -08:00
Chris Roberts
3fd9f44921
Add test coverage for windows host smb capability
2017-12-21 09:55:19 -08:00
Chris Roberts
63d1b5e33d
Add test coverage for windows host configured IP addresses capability
2017-12-21 09:55:19 -08:00
Chris Roberts
f330f81fbf
Add test coverage on darwin host SMB capability
2017-12-21 09:55:19 -08:00
Chris Roberts
e12e2d5374
Add test coverage for darwin host configured addresses capability
2017-12-21 09:55:19 -08:00
Chris Roberts
98ce718e63
Add test coverage on SMB synced folder
2017-12-21 09:55:19 -08:00
Chris Roberts
e85ef1655b
Always remove credentials file after mount attempts
2017-12-21 09:55:19 -08:00
Brian Cain
f046482cfb
[WIP] systemd networkd for debian guests
2017-12-20 16:42:51 -08:00
Brian Cain
b9581ed213
Merge pull request #9251 from briancain/9137/master/exit-0-destroy-not-created
...
Exit 0 if vagrant destroy finds no running vms
2017-12-20 16:42:36 -08:00
Brian Cain
0d7ad9f18f
Merge pull request #9275 from zachflower/validate_ip_addresses
...
Add a clean error message for invalid IP addresses
2017-12-15 11:22:03 -08:00
Chris Roberts
6223afcfa6
Merge pull request #9276 from chrisroberts/e-scrub
...
Scrub sensitive information prior to message output
2017-12-15 09:55:18 -08:00
Brian Cain
144c402f3b
Merge pull request #9252 from briancain/9055/master/pretty-print-nameerror-exceptions
...
Print more helpful error message for NameEror exceptions
2017-12-15 09:19:26 -08:00
Chris Roberts
6f663edad0
Scrub sensitive information prior to message output
...
This provides a simple wrapper around all output to
scrub any strings that have been registered as sensitive
before being output. Also included is a small change
to the initial debug output to only show vagrant specific
environment variables and not the full user environment.
2017-12-14 15:38:31 -08:00
Brian Cain
627babe15e
( #9055 ) Print more helpful error message for NameEror exceptions
...
This commit adds some additional handling for when Vagrant loads config
files. Instead of showing the basic ruby exception, it prints a more
helpful error message and tries to direct the user to the line number
and file where the exception is occuring.
2017-12-14 15:31:48 -08:00
Zachary Flower
0f4c06f7ba
add unit tests to validate
2017-12-14 15:25:24 -07:00
Brian Cain
d4d4ed6473
( #9137 ) Exit 0 if vagrant destroy finds no running vms
...
This commit reverts the behavior of `vagrant destroy` to exit 0 if no
running vms were found when the destroy command is run.
2017-12-14 12:48:22 -08:00
Gilles Cornu
43bcf2aaf7
Merge pull request #9173 from hashicorp/gildegoma/fix-ansible-ask-sudo-pass-deprecation
...
Ansible Provisioner: Fix broken 'ask_sudo_pass' option
2017-12-14 21:46:23 +01:00
Chris Roberts
120722ab08
Update NFS service name usage for linux hosts
...
Provides simple nfs service name detection via systemd or sys-v. Defaults
are provided if no match is found. Service name is defined via method
allowing derivative guests to only need to provide an updated name.
2017-12-14 08:35:07 -08:00
Jan Vansteenkiste
e5bebb0b9f
Disable (if/net)plugd on gentoo/openrc. Fixes #9260 .
...
When ifplugd is installed, the process is backgrounded and we get the
wrong return value.
2017-12-14 06:02:28 +01:00
Matthias Haag
9807abe498
Adjusted test to work with new implementation
2017-11-22 11:28:30 +01:00
Zachary Flower
abb1149190
Raise an exception when the template cannot be found, and update tests accordingly
2017-11-17 12:20:03 -07:00
Zachary Flower
968fbb2399
Update `init` command unit tests to reflect new --template option
2017-11-17 12:02:23 -07:00
Justin Campbell
f1863a8243
Merge pull request #9145 from hashicorp/login-middleware-auth-hosts
...
Add app.vagrantup.com to allowed auth hosts
2017-11-15 14:17:55 -05:00
Brian Cain
401f1d521e
Merge pull request #9131 from bpietraga/fix-outputh-pathname-folder-creation
...
Fix --output path with specified folder
2017-11-15 09:55:32 -08:00
Gilles Cornu
8333090d1d
ansible: Refuse to run unit tests with an invalid config
...
With this change, a bug like #9173 can be detected.
2017-11-10 20:40:13 +01:00
Gilles Cornu
e47deb7fd0
ansible: Fix broken 'ask_sudo_pass' option
...
This bug (invalid method call) hasn't been caught by unit tests because
Vagrant::Plugin::V2::Config catches all invalid/bad configuration calls
and save them for generating error messages during the "validate" stage.
This way, the `ask_sudo_pass=(value)` method was not interrupted and the
`@ask_become_pass` attribute was (surprisingly) correctly set (allowing
the related unit tests to pass).
In order to avoid similar problem to happen again, the deprecation
message output is now fully verified.
2017-11-09 18:17:04 +01:00
Justin Campbell
40d8dc4582
Add app.vagrantup.com to allowed auth hosts
...
This should allow users setting VAGRANT_SERVER_URL to app.vagrantup.com to authenticate to private boxes.
2017-11-07 10:35:16 -05:00
Bernard Pietraga
b026be7cb3
Fix --output path with specified folder
2017-11-04 12:00:55 +01:00
Brian Cain
228bd95257
Merge pull request #9127 from briancain/parallel-destroy-flag
...
Introduce parallel destroy for certain providers
2017-11-02 14:04:03 -07:00
Chris Roberts
9c2c83d781
Merge pull request #9135 from chrisroberts/e-ca-bundle
...
Use environment variable for CURL_CA_BUNDLE
2017-11-02 13:58:11 -07:00
Chris Roberts
06e3185eb1
Use `CURL_CA_BUNDLE` environment variable inplace of building path at runtime
2017-11-02 12:49:34 -07:00
Brian Cain
8be2ae8e6a
Add unit test for destroy command
2017-11-01 15:30:59 -07:00
Chris Roberts
d422053fbc
Check for vagrant.exe path before validating versions
2017-10-24 16:53:53 -07:00
Brian Cain
337b200d30
Update rspec tests to remove deprecation warnings
2017-10-24 12:08:38 -07:00
Chris Roberts
eaa518159c
Merge pull request #8997 from bshurts/fix/winrm-apipa
...
Adding check for APIPA in winrm helper to fix #8996
2017-10-23 16:47:32 -07:00
Vít Ondruch
7187e6f909
Use Integer instead of Fixnum for Ruby 2.4+ compatibility.
2017-10-23 10:57:36 -07:00
Brian Cain
a849cd2f7d
( #8963 ) Unify Solaris Guests
...
This commit removes some duplicated code within the Solaris11 guest
implemnentation and instead relies on the Solaris guest for the majority
of its guest capabilities.
2017-10-05 11:31:12 -07:00
Chris Roberts
32a4b73dd4
Enable documentation formatter on rspec
2017-10-05 10:17:30 -07:00
Bryce Shurts
927f653437
Adding tests for winrm_info_invalid
2017-10-05 10:28:25 -05:00
Jonathan LaBroad
73349d6ed6
Whitespace
2017-10-05 07:40:54 -04:00
Jonathan LaBroad
64f8d91888
Add slightly more clarity in test case
2017-10-05 07:33:57 -04:00
Jonathan LaBroad
79365f3789
Test that linux flags don't get passed to Windows Salt minion bootstrap
2017-10-05 06:55:53 -04:00
Jonathan LaBroad
56861296fa
Added tests and validation for python_version parameter
2017-10-05 06:25:36 -04:00
Brian Cain
87ee4f5662
Merge pull request #8995 from elatt/fix_synced_folders_spaces
...
Allow synced folders to contain spaces in the guest path
2017-09-29 15:19:39 -07:00
Erik Lattimore
28a92850ab
Allow synced folders to contain spaces in the guest path
...
It should be valid to allow paths with spaces for the synced folder
guest path but since the guest path is used to generate the ID (if one
isn't provided), this will err out in VirtualBox because it doesn't
allow spaces for the --name argument. We should simply convert ' ' to
'_' as we do with other special characters.
2017-09-29 17:24:12 -04:00
Bryce Shurts
0eaf691ea0
Adding check for APIPA in winrm helper to fix #8996
2017-09-25 16:31:37 -05:00