This fixes a fairly large tempfile leak. Vagrant uses a template
renderer to write network configuration files locally to disk. Then,
that temporarily file is uploaded to the remote host and moved into
place. Since Vagrant is such a short-lived process, GC never came along
and cleaned up those tempfiles, resulting in many temporary files being
created through regular Vagrant usage.
The Util::Tempfile class uses a block to ensure the temporary file is
deleted when the block finishes. This API required small tweaks to the
usage, but provides more safety to ensure the files are deleted.
In order to get a SUSE guest running and installing fine i have added a
correct capability for installing rsync and nfs-client.
I have included SUSE naming fixes as well because SUSe doesnt get
spelled SuSE anymore :).
When using pty=true, removing files using sudo may request confirmation,
which will hang the connection.
Similarly, sometimes assumptions about file existence may be wrong and
in those cases it seems better to continue on as long as the file does
not exist, so -f makes sense there, too.
Seth Vargo
Mitchell Hashimoto
Thomas Boerger
Leo Simons
Kalman Hazins
Philipp Franke
Deepak Seshadri