Chris Roberts
86af6501ed
Remove installer set push from default source push
2017-02-24 08:02:22 -08:00
Chris Roberts
e2acb5250a
Add command deprecation helper module
2017-02-24 06:22:39 -08:00
Chris Roberts
ccdccf06b5
Merge pull request #8194 from chrisroberts/fix/curl-credentials
...
Scrub credentials from box URLs
2017-02-23 13:51:47 -08:00
Chris Roberts
74438cc495
Merge pull request #8196 from chrisroberts/fix/expand-vagrantfile-path
...
Allow VAGRANT_DOTFILE_PATH to be expanded as expected.
2017-02-23 13:33:07 -08:00
Chris Roberts
fe055d57da
Merge pull request #8273 from chrisroberts/bundler/remote-source
...
Prefer given source if available when installing plugin
2017-02-22 11:48:19 -08:00
Chris Roberts
088829de9b
Merge pull request #8270 from chrisroberts/enhancement/process-stop
...
Add new methods to Subprocess
2017-02-16 13:45:25 -08:00
Chris Roberts
70cacb27fa
Prefer given source if available when installing plugin
2017-02-09 17:22:48 -08:00
Chris Roberts
6a4d41d0c9
Merge pull request #8252 from nsidc/fix-install-local-pre
...
Add gem_version to plugin_info for local installs
2017-02-09 09:48:54 -08:00
Chris Roberts
e7e24ee853
Merge pull request #8248 from chrisroberts/fix/env-gems-path
...
Fix environment gems_path location
2017-02-08 14:18:41 -08:00
Chris Roberts
903428e569
Add Util::Subprocess#stop and Util::Subprocess#running?
2017-02-08 14:15:47 -08:00
Michael Brandt
be63ace50f
Add gem_version to plugin_info for local installs
2017-02-02 17:58:29 -07:00
Chris Roberts
0a6d985f89
Merge pull request #8191 from chrisroberts/plugins/ext-dir
...
Set base directory to parent directory within plugin specs
2017-02-01 13:12:27 -08:00
Chris Roberts
959bdada82
Fix environment gems_path location
2017-02-01 12:43:16 -08:00
Chris Roberts
25a2bdd279
Prevent generating environment variables with invalid empty names
2017-01-12 15:12:41 -08:00
Chris Roberts
832c62f2aa
Allow VAGRANT_DOTFILE_PATH to be expanded as expected.
...
This allows custom paths that include special characters like `~`
to be properly expanded instead of resulting in joined root path
with special characters included.
2017-01-12 14:01:25 -08:00
Chris Roberts
a055978d74
Scrub credentials from box URLs
2017-01-12 13:24:46 -08:00
Chris Roberts
df00edf1a7
Set base directory to parent directory within plugin specs
...
This adjustment allows for extensions to be properly discovered after
plugin gem specifications have been activated.
2017-01-06 12:55:13 -08:00
Chris Roberts
23c41f4461
Merge pull request #7867 from bbrala/hyperv-package
...
Package Hyper-V boxes
2016-12-07 13:37:47 -08:00
Chris Roberts
23b4421309
Merge pull request #8094 from chrisroberts/bundler/env
...
Remove direct bundler usage within Env util
2016-12-07 06:56:01 -08:00
Chris Roberts
c20e160295
Remove direct bundler usage within Env util
2016-12-07 06:00:56 -08:00
Chris Roberts
c8d564e578
Prevent interaction when removing plugin gems
2016-12-06 07:07:52 -08:00
Chris Roberts
5b1b18d01a
Merge pull request #8068 from chrisroberts/bundler/install-solution-act
...
Detect load failure within solution set and retry if found
2016-12-05 13:28:58 -08:00
Chris Roberts
3dccd82a39
Explicitly require name_tuple
...
This does not get automatically loaded before usage so ensure
it is properly loaded for plugin usage.
2016-12-05 09:35:02 -08:00
Chris Roberts
ce35611c34
Detect load failure within solution set and retry if found
...
Installation solution sets in 2.2.5 can end up out of order (not seen
in 2.3.1) causing LoadErrors when the specification is in the solution
set during validation. This detects the missing spec within the solution
and if found will move spec to the start of the solution set and retry
solution activation.
2016-12-01 08:15:04 -08:00
Chris Roberts
9717432920
Add logger output when plugin loading is disabled
2016-11-28 16:55:38 -08:00
Chris Roberts
f1e623976b
Do not include default specifications within dependencies
2016-11-28 16:54:59 -08:00
Chris Roberts
d87cf25ed2
Display original exception and backtraces in logger output
2016-11-28 07:48:16 -08:00
Chris Roberts
2cc4b82198
Only read default specifications directory when within bundler context
2016-11-22 08:26:43 -08:00
Chris Roberts
a51949933f
Always apply builtin constraints within dependency restrictions
...
Include detection of running context (within Bundler or not) and
load the "buitin" gems based on that context.
2016-11-22 07:53:19 -08:00
Chris Roberts
53b9f1747c
Allow plugin_init_error to provide all information. Include final reset on specifications.
2016-11-17 16:40:51 -08:00
Chris Roberts
818f7acb7b
Provide better internal consistency of installed plugin gems.
...
Refactors reusable actions into isolated methods. Supports installation/removal
without activation to prevent unintended conflicts during upgrades and cleanup.
Introduced custom resolver set to handle multiple installed versions of gems
which enables proper cleanup.
2016-11-16 13:26:13 -08:00
Chris Roberts
06e1b2f52c
Include installed gem version plugin information. Clean after install and update.
2016-11-16 13:19:43 -08:00
Chris Roberts
fb85bb1c7b
Include plugin initialization error class
2016-11-16 13:18:35 -08:00
Chris Roberts
33c9d6183a
Provide more log information about configured plugins
2016-11-16 13:17:38 -08:00
Chris Roberts
e2d96f942f
Provide nice error output when plugin initialization fails
...
Include extra logging during initialization to display error if encountered
and solution set prior to performing activations.
2016-11-15 15:50:39 -08:00
Chris Roberts
44d3aedc5b
When bundler is in use, require `:plugins` group
2016-11-14 15:28:22 -08:00
Chris Roberts
ac74774fcb
Merge pull request #8000 from chrisroberts/plugins/updates
...
Plugin handling updates
2016-11-14 13:24:52 -08:00
Chris Roberts
0f720a4386
Merge pull request #7985 from chrisroberts/shell-provisioner/checksum
...
Add md5 and sha1 checksum support to Downloader.
2016-11-14 13:19:22 -08:00
Chris Roberts
beffa70941
Downloader checksum output information and digester usage
...
Add more output information around type of checksum being validated.
Use builtin Digest#file to read target file for generation of hexdigest.
2016-11-14 10:22:25 -08:00
Chris Roberts
174fe65d66
Sort plugins by name when generating install list
2016-11-11 15:11:45 -08:00
Chris Roberts
3edd0b57e9
Add debug logging output to Bundler implementation
2016-11-11 15:08:59 -08:00
Chris Roberts
bd3f0c442c
Only use Gem sources that are provided
2016-11-11 14:50:20 -08:00
Chris Roberts
1691e3af58
Only install from defined sources unless install is local
2016-11-11 14:44:14 -08:00
Chris Roberts
d8455c0a9a
Add custom sources if not included
2016-11-11 14:33:26 -08:00
Chris Roberts
6e40d46c50
Fix up local gem plugin installation when not published remotely
2016-11-11 14:25:03 -08:00
Chris Roberts
ea13988367
Properly support plugin auto-loading with logging information
2016-11-11 14:24:25 -08:00
Chris Roberts
1ed27faa9f
Remove usage of $vagrant_bundler_runtime within enabled check
2016-11-11 14:23:55 -08:00
Chris Roberts
da45ca707c
Add md5 and sha1 checksum support to Downloader.
...
Allows checksum validation on downloaded files via Util::Downloader
using MD5 and/or SHA1 checksums. This also integrates checksum validation
support with the shell provisioner for downloaded remote files.
2016-11-09 16:05:39 -08:00
Chris Roberts
36d88ee268
Track installed gem version and display in startup logger information
2016-11-07 20:16:46 -08:00
Chris Roberts
1f5dd35d16
Remove bundler where no longer required
2016-11-07 20:00:38 -08:00
Chris Roberts
3fb5913af1
Update .init! to attempt repair if instructed
2016-11-07 18:48:51 -08:00
Chris Roberts
d5c5561302
Allow disable of user plugins if repair command is requested
2016-11-07 18:48:51 -08:00
Chris Roberts
1fb4553d14
[core] Remove bundler usage for plugin management
2016-11-07 18:48:51 -08:00
David O'Rourke
a33892e4df
Maintain a version dir map in box_collection.
...
This is required since Gem::Version will mangle pre-release version
numbers.
To get around this, we keep a mapping of
`Gem::Version.to_s => versiondir.`
This allows us to properly sort by version when picking a box while
still returning pristine versiondirs when required.
2016-11-01 15:59:23 +00:00
David O'Rourke
7b89374dce
Fix version sorting in box_collection.rb
2016-11-01 14:57:06 +00:00
Chris Roberts
d1a778dbfb
Include error handling when subprocess commands fail
2016-10-31 07:42:30 -07:00
Chris Roberts
d490bb4b7a
Include autoloader for StringBlockEditor
2016-10-29 17:53:45 -07:00
Chris Roberts
c39b3fbb76
guests/openbsd: Check package installation after installing package
...
The `pkg_add` command will return `0` when a package requested for
installation is not found. This adds a validation check to ensure
the rsync package is actually installed on the guest.
2016-10-25 12:16:52 -07:00
Luke Bakken
52e98ffdfb
Improve detection of admin and hyper-v admin rights via using SIDs and powershell
2016-10-13 14:22:08 -07:00
Chris Roberts
28f2ed56cf
Merge pull request #7756 from alexoj/master
...
Fix Vagrant not prioritizing configured providers correctly
2016-10-07 17:14:54 -07:00
Björn Brala
6ed612e93b
Move package_setup_files to general lib to minimize code duplication
2016-10-07 17:31:15 +02:00
Bjorn Brala
5877e8fe22
Sart refactor duplicate classes
2016-10-06 08:55:59 +02:00
Chris Roberts
c3eb1e355b
Merge pull request #7802 from chrisroberts/safe_exec/windows
...
[windows] Use subprocess for safe_exec on windows
2016-09-30 14:42:40 -07:00
Chris Roberts
977733790a
Include debug notification when using subprocess
2016-09-30 12:16:53 -07:00
Chris Roberts
5872611d59
[windows] Use subprocess for safe_exec on windows
2016-09-15 13:08:58 -07:00
Jake Teton-Landis
ceb69e6266
Allow closing a Vagrant::Util::Subprocess's STDIN
...
Previously, there was no way to close the STDIN stream of a subprocess,
so commands that read from stdin in a subprocess would hang forever,
such as `/bin/sh -s`. If one tried to close the stdin, the
IO.select() call in Subprocess#execute would raise an error for calling
select() on a closed IO.
Here's a concrete example of a command that needs to close STDIN to work
properly:
```ruby
script = SOME_VERY_LONG_STRING
command = %w(ssh foo.example.com /bin/sh -s foo bar)
result = ::Vagrant::Util::Subprocess.execute(*command) do |type, data_or_io|
if type == :stdin
data_or_io.write(script)
data_or_io.write("\n")
data_or_io.close
next
end
puts "Remote: #{data_or_io}"
end
```
2016-09-04 16:45:38 -07:00
Alejandro Ojeda
50ca748b5c
Fix Vagrant not prioritizing configured providers correctly
...
Fixes #7135 : config.vm.provider not setting provider in multi-machine Vagrantfile
2016-08-25 03:34:23 +02:00
Chris Roberts
3abfbec5a6
Merge pull request #7623 from carlosefr/relative-dotfile-path
...
Support Vagrantfile-relative VAGRANT_DOTFILE_PATHs
2016-08-12 16:17:10 -07:00
Zack Train
cb70749bd8
redux of pr 7398 for ssh-agent key fix
2016-08-11 11:48:10 -07:00
Seth Vargo
1702584d1e
Merge pull request #6765 from PeterMosmans/windows-path-fix
...
Fix for #6761 (fixes incomplete #6598 )
2016-08-08 11:59:26 -04:00
Carlos Rodrigues
218b697d5e
This looks cleaner
2016-07-24 19:01:54 +01:00
Carlos Rodrigues
188a7dab0c
Another try, without string substitution
2016-07-24 18:40:09 +01:00
Carlos Rodrigues
9ebc028745
Better checks, hopefully
2016-07-22 14:59:05 +01:00
Carlos Rodrigues
92104fec72
Use match instead of start_with
2016-07-22 14:39:44 +01:00
Carlos Rodrigues
bf0486e659
Vagrantfile-relative VAGRANT_DOTFILE_PATH
2016-07-22 14:08:18 +01:00
Seth Vargo
36838d36b7
Fix failing test
2016-07-18 22:38:27 -04:00
Seth Vargo
7ed6bb5bef
Merge pull request #7569 from rossi-fi/fix/master/7568
...
Use RFC- and cURL-friendly file:/// URI. Fixes #7568 .
2016-07-18 22:20:03 -04:00
Seth Vargo
581568cf5a
Merge pull request #7571 from rossi-fi/fix/master/7570
...
Strip leading slash left in front of drive letter by uri.path
2016-07-18 22:19:55 -04:00
Seth Vargo
2acaaff801
state_file: fsync and binmode
2016-07-18 21:59:18 -04:00
Seth Vargo
ea17ad4530
Merge pull request #7550 from cgwalters/plugin-atomic-rewrite
...
plugin: Write out state file via create-new-then-rename
2016-07-18 21:58:23 -04:00
Seth Vargo
8f10dbca90
Merge pull request #7587 from alexmv/disabled-conflicts
...
Skip checking for conflicts on ports that are disabled
2016-07-18 21:55:33 -04:00
Seth Vargo
3b2ffae400
guests/bsd: Print a very descriptive error when mounting vbox folders
...
BSD-based guests do not support VirtualBox shared folders. This is a
common source of confusion in Vagrant. This new error clearly explains
that this is not a bug in Vagrant and provides instructions on how to
disable them.
2016-07-18 21:12:58 -04:00
Seth Vargo
7e88266999
guests/linux: Properly escape and retry vbox shared folder mounting
2016-07-18 21:12:57 -04:00
Alex Vandiver
3d2fde9260
Skip checking for conflicts on ports that are disabled
...
Currently, the supported way (see GH#1922) to disable the default port
2222 port forward is:
config.vm.network :forwarded_port, guest: 22, host: 2222, disabled: true
However, the port collision detection runs on all ports, regardless of
the `disabled` flag. This leads it to attempt to connect to port
2222, notice it is taken, and abort with a port conflict -- even
though it will not be attempting to use the port at all.
Skip disabled ports when doing port conflict detection.
A workaround that does not require a Vagrant upgrade to one containing
this fix is to instead set `auto_correct` on the disabled port:
config.vm.network :forwarded_port, guest: 22, host: 2222, disabled: true, auto_correct: true
This allows the disabled port to be reshuffled off to some other
unused port.
2016-07-14 19:52:38 -07:00
Colin Walters
72c1972181
plugin: Write out state file via create-new-then-rename
...
This makes updates atomic, so it's useful generally. However
I'm making this change specifically to support rpm-ostree.
For more information, see:
https://bugzilla.redhat.com/show_bug.cgi?id=1352152
2016-07-12 16:42:24 -04:00
Markus Rossi
4730602ceb
Strip leading slash left in front of drive letter by uri.path (see GH-7570).
2016-07-12 15:20:04 +03:00
Markus Rossi
8768d7921d
Fix for #7568 Windows drive letter in config.vm.box_url is ignored
2016-07-12 12:01:23 +03:00
Seth Vargo
05aafedc6d
core/bundler: Reset specs in a way that works with new Rubygems
2016-06-20 15:19:21 -07:00
Seth Vargo
23e50c98f9
core/box_collection: Ensure removal
...
The docs for Ruby say Pathname#rmtree will recursively delete, but
apparently that is a lie, at least on Windows (see GH-7496). Switch to
using FileUtils to ensure the directory is deleted.
Fixes GH-7496
2016-06-20 07:16:08 -04:00
Seth Vargo
177b7784dd
guests/darwin: Allow ipv6 static networks
2016-06-19 12:01:52 -04:00
Seth Vargo
6284a9ac50
guests/bsd: Move NFS mounting logic into shared
...
A number of the BSD guests used very old mounting options or just
ignored some parameters entirely. This fixes that.
- Closes #7474
- Fixes #7466
2016-06-17 21:04:23 -04:00
Seth Vargo
d01ddeeb43
Check stdout instead of process output
...
Fixes GH-7465
2016-06-16 16:20:15 -04:00
Gilles Cornu
6ee69e3150
Merge pull request #7190 from electrofelix/ansible-parallel-race
...
Fix a race condition in the concurrent generations of the ansible inventory file, while running `vagrant up --parallel`.
Closes GH-6526
2016-06-09 14:56:03 +02:00
Mikhail Zholobov
db3aad3822
Require "vagrant/util/presence" in package action
2016-06-09 13:13:58 +03:00
Karl Isenberg
f084fc7d78
Revert 3f9fb2ef03
from GH-2769
...
- For compatibility with ba77d4b533
Fixes GH-7073
2016-05-31 14:52:43 -07:00
Seth Vargo
cf02135290
Merge pull request #7359 from mitchellh/sethvargo/cache_platform
...
Cache the results of common operations
2016-05-31 11:03:46 -04:00
Seth Vargo
7014aa3bab
Remove custom tempfile class
...
This is not actually providing any additional utility and also causes
namespace conflicts with people trying to use the real Tempfile class.
2016-05-30 23:21:47 -04:00
Seth Vargo
2a230a11e2
Cache the results of common operations
...
This commit changes Vagrant::Util::Platform to cache the result of some
common operations. These values are highly unlikely to change over the
course of a single Vagrant run and they are only cached for that run.
2016-05-30 18:27:12 -04:00
Seth Vargo
d44fcf2d52
Allow customization of keys_only & paranoid SSH
...
This adds two new SSH configuration options:
- `keys_only`
- `paranoid`
These values were previously hard-coded, but can now be user-specified.
Fixes GH-4275
2016-05-29 18:03:03 -04:00
Seth Vargo
159e1ec1f1
Use a real file for bundler
2016-05-29 00:41:59 -04:00