vagrant

Commit Graph

Author	SHA1	Message	Date
Fabio Rehm	54656151cf	Convert specs to RSpec 2.14.8 syntax with Transpec This conversion is done by Transpec 1.10.2 with the following command: transpec test/unit/ * 507 conversions from: obj.should to: expect(obj).to * 394 conversions from: == expected to: eq(expected) * 260 conversions from: obj.should_receive(:message) to: expect(obj).to receive(:message) * 85 conversions from: obj.stub(:message) to: allow(obj).to receive(:message) * 25 conversions from: its(:attr) { } to: describe '#attr' do subject { super().attr }; it { } end * 19 conversions from: obj.should_not to: expect(obj).not_to * 7 conversions from: obj.should_not_receive(:message) to: expect(obj).not_to receive(:message) * 3 conversions from: Klass.any_instance.should_receive(:message) to: expect_any_instance_of(Klass).to receive(:message)	2014-03-14 12:02:07 -03:00
Paul Hinze	abe0731d2e	guests/{ubuntu,debian}: fix change_host_name for trailing dots [GH-2610] When `/etc/hosts` contained a FQDN with a trailing dot, the `\b` in the sed expression would not match, since dot is not considered to be a word character. Fix this by regexp-escaping the hostname search, and matching the end of the line on optional space followed by additional characters. Also add some tests that extract the regexp used by sed and verify that it does what we want. These will hopefully serve us in the future if we ever need to test additional edge cases.	2013-12-09 18:56:45 -06:00
phinze	688bca14f5	refactoring ubuntu/debian change_host_name there's been a lot of churn around this code, so i figure it was worth trying to clean it up. - the methods were doing a lot, so make them into template methods with one helper per step - spread out /etc/hosts regexp into a couple of helper variables for clarity - remove handling for broken hostname implementations (like basing all of the checks on name.split('.')[0]), since it seems reasonable to remove code dedicated only to handling broken boxes - DRY up the shared code between debian/ubuntu implementations, which clarifies the differences as well - add unit tests around the behavior; this will help us in the future to separate flaws in our understanding from flaws in implementation - includes a new DummyCommunicator in tests which should be useful in supporting additional unit testing of this kind - manually tested this on squeeze, wheezy, precise, quantal, raring, and saucy successfully. handles the issue in #2333	2013-11-24 11:46:12 -06:00

Author

SHA1

Message

Date

Fabio Rehm

54656151cf

Convert specs to RSpec 2.14.8 syntax with Transpec

This conversion is done by Transpec 1.10.2 with the following command:
    transpec test/unit/

* 507 conversions
    from: obj.should
      to: expect(obj).to

* 394 conversions
    from: == expected
      to: eq(expected)

* 260 conversions
    from: obj.should_receive(:message)
      to: expect(obj).to receive(:message)

* 85 conversions
    from: obj.stub(:message)
      to: allow(obj).to receive(:message)

* 25 conversions
    from: its(:attr) { }
      to: describe '#attr' do subject { super().attr }; it { } end

* 19 conversions
    from: obj.should_not
      to: expect(obj).not_to

* 7 conversions
    from: obj.should_not_receive(:message)
      to: expect(obj).not_to receive(:message)

* 3 conversions
    from: Klass.any_instance.should_receive(:message)
      to: expect_any_instance_of(Klass).to receive(:message)

2014-03-14 12:02:07 -03:00

Paul Hinze

abe0731d2e

guests/{ubuntu,debian}: fix change_host_name for trailing dots [GH-2610]

When `/etc/hosts` contained a FQDN with a trailing dot, the `\b` in the
sed expression would not match, since dot is not considered to be a word
character.

Fix this by regexp-escaping the hostname search, and matching the end of
the line on optional space followed by additional characters.

Also add some tests that extract the regexp used by sed and verify that
it does what we want. These will hopefully serve us in the future if we
ever need to test additional edge cases.

2013-12-09 18:56:45 -06:00

phinze

688bca14f5

refactoring ubuntu/debian change_host_name

there's been a lot of churn around this code, so i figure it was worth
trying to clean it up.

 - the methods were doing a lot, so make them into template methods with
   one helper per step
 - spread out /etc/hosts regexp into a couple of helper variables for
   clarity
 - remove handling for broken hostname implementations (like basing all
   of the checks on name.split('.')[0]), since it seems reasonable to
   remove code dedicated only to handling broken boxes
 - DRY up the shared code between debian/ubuntu implementations, which
   clarifies the differences as well
 - add unit tests around the behavior; this will help us in the future
   to separate flaws in our understanding from flaws in implementation
 - includes a new DummyCommunicator in tests which should be useful in
   supporting additional unit testing of this kind
 - manually tested this on squeeze, wheezy, precise, quantal, raring,
   and saucy successfully.

handles the issue in #2333

2013-11-24 11:46:12 -06:00

3 Commits