Alexander Fischer
0b87184ad4
#9174 Remove masterless? config attribute
...
Remove the @config.masterless? attribute as there is no benefit from it
2018-05-11 08:49:57 +02:00
Brian Cain
728a9135c8
( #9726 ) Update netplan config generation to detect NetworkManager
...
Prior to this commit, when setting up private networks on Ubuntu using
netplan, it assumed that the guest was using systemd, the suggested
default tool to manage networking, and did not take into account devices
that could be managed with NetworkManager. This commit fixes that by
looking at the devices managed on the guest to see if its managed by
NetworkManager, and if so, use that renderer for netplan instead of
networkd.
2018-05-10 13:02:05 -07:00
Chris Yungmann
7fb9d3eb4f
propagate unset guestpath
2018-05-08 22:51:30 -05:00
Chris Roberts
3bcdd2901b
Merge pull request #9800 from chrisroberts/e-vbox-builtin
...
Support VirtualBox shared folders using builtin kernel module
2018-05-07 13:24:50 -07:00
Chris Roberts
0a523bc12b
Merge pull request #9785 from chrisroberts/f-smb-list
...
Use net.exe to fetch SMB shares when Get-SmbShare is not available
2018-05-07 13:07:47 -07:00
Chris Roberts
c571249000
Support VirtualBox shared folders using builtin kernel module
...
Check error output if initial mount command fails to determine if
the builtin module should be used for mounting instead.
2018-05-07 13:02:19 -07:00
Chris Roberts
7a4150dc3f
Use net.exe to fetch SMB shares when Get-SmbShare is not available
...
Fixes #9547
2018-05-04 14:07:33 -07:00
Chris Roberts
2730fe7ec9
Update script parameter name in option to switchid
...
Fixes #9774
2018-05-04 08:55:18 -07:00
Chris Roberts
02b9d625d3
Merge pull request #9759 from StefanScherer/wsl-remove-raise-vboxmanage-missing
...
Allow other providers in WSL
2018-05-03 12:42:16 -07:00
Chris Roberts
89d00f4204
Merge pull request #9758 from StefanScherer/wsl-rdp
...
Call mstsc.exe Windows RDP client in WSL
2018-05-03 12:40:37 -07:00
Chris Roberts
40ae8aa38d
Merge pull request #9769 from chrisroberts/e-key-perms
...
Log error and proceed when private key permissions fail
2018-05-03 12:34:50 -07:00
Chris Roberts
f0e232d739
Log error and proceed when private key permissions fail
...
Fixes #9765
2018-05-03 11:48:57 -07:00
Chris Roberts
8b398b66a3
Trim drive letter prefix from path
...
Fixes #9764
2018-05-03 09:28:19 -07:00
Brian Cain
e1129d27f9
Merge pull request #9761 from briancain/FIX-DOCKER-EXEC
...
Use Util::SafeExec if docker-exec is run with `-t` option
2018-05-02 15:47:46 -07:00
Brian Cain
79e535a7ee
( #9622 ) Use SafeExec for docker-exec
...
This commit uses the internal helper SafeExec rather than using the
Kernel class directly. It also adds a test to ensure that if the `-t`
option is used, it will call SafeExec.
2018-05-02 14:23:50 -07:00
Stefan Scherer
f14e8bcbf2
Allow other providers in WSL
2018-05-02 22:36:17 +02:00
Chris Roberts
fbcd86993b
Merge pull request #9737 from chrisroberts/e-hyper-v-addr
...
Check neighbors for valid guest address when default lookup fails
2018-05-02 08:54:57 -07:00
Chris Roberts
bf281a912c
Merge pull request #9747 from chrisroberts/e-hyper-v-checkpoints
...
Reference Hyper-V switch by ID instead of name
2018-05-02 07:47:31 -07:00
Stefan Scherer
a01d68b2e0
Call mstsc in WSL
2018-05-02 15:21:47 +02:00
Brian Cain
6fc2d9d82d
Merge pull request #9754 from briancain/DOCKER-PROV-WINDOWS
...
Update docker provisioner for windows, fix command filter behavior for `rm`
2018-05-01 13:46:33 -07:00
Brian Cain
93356d4635
Update rm filters to test for path
...
This commit updates the rm filter for winrm to operate like how rm works
in bash. If a folder doesn't exist, the command returns 0 rather than 1.
2018-05-01 13:35:45 -07:00
Chris Roberts
9f08337ce1
Ignore errors on neighbor lookup and validate result
2018-04-30 17:39:27 -07:00
Chris Roberts
39bb589f7d
Merge pull request #9739 from chrisroberts/f-midware-invalid-uri
...
Ignore URLs which cannot be parsed in the authentication middleware
2018-04-27 17:03:02 -07:00
Chris Roberts
e47e1df228
Reference Hyper-V switch by ID instead of name
...
Keep track of selected Hyper-V switch using the ID instead of name
to prevent any encoding issues that may occur switching between
PowerShell and Ruby. With the IDs staying consistent, the switch
name can be fetched from the provided ID.
Fixes #9679 #8794 #9451
2018-04-27 16:52:16 -07:00
Joe Pleso
c882d888a7
Add docker cap to windows to detect daemon and fix whitespace
2018-04-27 09:45:24 -07:00
Brian Cain
1f25b2cc22
Merge pull request #9736 from briancain/disable-loading-triggers-if-plugin-exists
...
Add warning if vagrant-triggers plugin is installed
2018-04-26 16:11:31 -07:00
Chris Roberts
97f5822dee
Ignore URLs which cannot be parsed in the authentication middleware
...
Fixes #9725
2018-04-26 15:08:06 -07:00
Brian Cain
1ef45d8073
Add warning if vagrant-triggers plugin is installed
...
To allow users to continue to use the community plugin, this commit adds
a switch that will not load the core trigger feature if it detects the
community plugin is installed. It also allows the user to disable the
warning so they can continue to use the plugin without extra output.
2018-04-26 14:59:09 -07:00
Chris Roberts
d2ec4d9312
Merge pull request #9734 from chrisroberts/f-win-smb-mount
...
Default SMB version to 2.0 for linux guest mounts on Windows hosts
2018-04-26 14:48:01 -07:00
Chris Roberts
d15ff38d5c
Check neighbors for valid guest address when default lookup fails
...
If the guest address is unavailable via Hyper-V inspection, extract
MAC address of network adapters and check neighbor information for
any currently matching known address.
2018-04-26 12:53:52 -07:00
Chris Roberts
40a1d2faf3
Default SMB version to 2.0 for linux guest mounts
...
Fixes #8959
2018-04-26 08:45:05 -07:00
Chris Roberts
5feb234665
Return original URL value when unmodified
...
Due to the behavior of URI.parse on Ruby < 2.5 returning the string
value of the parsed URI object may modify the original URL. Specifically
it will remove the `//` prefix characters from SMB paths. When no
host modifications are being made, always return the original value.
Fixes #9636
2018-04-25 16:21:21 -07:00
Brian Cain
b409f0e203
Merge pull request #9669 from dduponchel/data_bags_path
...
Support arrays for data_bags_path in chef-zero
2018-04-24 15:45:36 -07:00
Brian Cain
5643ba0c7d
Merge pull request #9713 from briancain/vagrant-triggers-config
...
Integrate vagrant-triggers plugin functionality into core Vagrant
2018-04-24 11:35:04 -07:00
Brian Cain
a9be56b356
Code updates based on PR feedback
2018-04-24 10:04:40 -07:00
Brian Cain
7f004656db
( #9718 ) Properly finalize structured_facts config option
...
This commit sets the structured_facts option to nil if its still
UNSET_VALUE at the finalize step. This was causing a bug when the facter
config was set but was not using structured facts.
2018-04-23 14:23:59 -07:00
Brian Cain
e25cb51f15
Properly print warnings on config settings that aren't supported
2018-04-20 10:51:38 -07:00
Brian Cain
12b1a3dfe4
Update triggers based on code review
2018-04-20 10:51:38 -07:00
Brian Cain
e0806f623c
Remove TODO
2018-04-20 10:51:38 -07:00
Brian Cain
0054c5aae6
Raise error if incomplete trigger block is defined
2018-04-20 10:51:38 -07:00
Brian Cain
767a315393
Trigger cleanup
2018-04-20 10:51:38 -07:00
Brian Cain
693eb2fbbb
Add machine level warning when privileged option is set for run
2018-04-20 10:51:38 -07:00
Brian Cain
3ad4f576c0
Add only_on validation for config
2018-04-20 10:51:38 -07:00
Brian Cain
ca672eb8e6
Trigger plugin cleanup
2018-04-20 10:51:38 -07:00
Brian Cain
85dedf25d9
Ensure that :all triggers don't get filtered out
2018-04-20 10:51:38 -07:00
Brian Cain
2c30eab723
Don't run local commands as sudo by default
2018-04-20 10:51:38 -07:00
Brian Cain
eac2fcf71e
Filter triggers based on only_on restraint
2018-04-20 10:51:38 -07:00
Brian Cain
372a6a7911
Initial trigger plugin scaffolding
2018-04-20 10:51:38 -07:00
Brian Cain
a5d8cc1caa
Update trigger classes with comments
2018-04-20 10:51:38 -07:00
Brian Cain
956ed004bb
Update trigger config merge function
2018-04-20 10:51:38 -07:00
Brian Cain
abb6d77442
Move location of command validator
2018-04-20 10:51:38 -07:00
Brian Cain
6cbb5d8e5d
Add unit tests for config, fix type change bug with map!
2018-04-20 10:51:38 -07:00
Brian Cain
42419bbd49
Fix rspec tests
2018-04-20 10:51:38 -07:00
Brian Cain
d0d69e59c9
Update return doc string on validate
2018-04-20 10:51:38 -07:00
Brian Cain
60c4ffa8a6
Ensure run & run_remote are Hashes before updating to shell config
2018-04-20 10:51:38 -07:00
Brian Cain
e752878de9
Update finalize method for run and run_remote objects
2018-04-20 10:51:38 -07:00
Brian Cain
d3dde739fe
Update trigger code docs
2018-04-20 10:51:38 -07:00
Brian Cain
1591ae9916
Make run and run_remote settings shell provisioner configs
2018-04-20 10:51:38 -07:00
Brian Cain
f0ec7c750b
Potential solution for trigger validation when guest is defined
...
Send the defined before and or after triggers in the merge function if
triggers exist already
2018-04-20 10:51:38 -07:00
Brian Cain
51e4118cc2
Debug commit
2018-04-20 10:51:38 -07:00
Brian Cain
0cbf6970fc
Update config class setting
2018-04-20 10:51:38 -07:00
Brian Cain
607368a66c
Introduce merge function to preserve internal state
2018-04-20 10:51:38 -07:00
Brian Cain
d26a925bd7
Update variable doc
2018-04-20 10:51:38 -07:00
Brian Cain
5ca1d1ab64
Finalize config in plugins finalize, improve docs
2018-04-20 10:51:38 -07:00
Brian Cain
b04f13657b
Move warning to logger rather than guest
2018-04-20 10:51:38 -07:00
Brian Cain
a96baad0d7
Add comments for later dev
2018-04-20 10:51:38 -07:00
Brian Cain
60ff2489c4
Display warning if vagrant command for trigger is not found
2018-04-20 10:51:38 -07:00
Brian Cain
8e72ae5bd6
Add basic validation for trigger config objects
2018-04-20 10:51:38 -07:00
Brian Cain
375e8d7153
Remove old comments
2018-04-20 10:51:38 -07:00
Brian Cain
3c5e4b2464
Fix variable doc
2018-04-20 10:51:38 -07:00
Brian Cain
50ecf45d50
Add more doc to create_trigger function
2018-04-20 10:51:38 -07:00
Brian Cain
c10ae070b6
Store correct command for trigger
2018-04-20 10:51:38 -07:00
Brian Cain
e0a5b1d647
Parse block trigger configs
2018-04-20 10:51:38 -07:00
Brian Cain
6f00eb5679
Move trigger options into own plugin class
2018-04-20 10:51:38 -07:00
Brian Cain
fdf1b58570
Introduce ids for trigger blocks
2018-04-20 10:51:38 -07:00
Brian Cain
bb2f3b35b9
Add basic unit test
2018-04-20 10:51:38 -07:00
Brian Cain
7cccddc009
Add basic scaffolding for command parsing
2018-04-20 10:51:38 -07:00
Brian Cain
01b904061d
Use proper command reference for command whitelist params
2018-04-20 10:51:38 -07:00
Brian Cain
0142722787
Add run and run_remote scaffolding
2018-04-20 10:51:38 -07:00
Brian Cain
813ffd06ec
Add more trigger config options
2018-04-20 10:51:38 -07:00
Brian Cain
a194057fc0
Add trigger config plugin
2018-04-20 10:51:38 -07:00
Jose Luis Duran
53acd20548
Fix network configuration on FreeBSD hosts
...
There was a missing space within `sed` parameters that caused the
`rc.conf` file to be wrongly created as `rc.conf-e`.
2018-04-19 16:25:16 -03:00
Isaac Freeman
de71626922
docker: use Kernel.system for docker-exec when -t is given
2018-04-18 17:50:47 -04:00
Brian Cain
9f29812db8
Merge pull request #9690 from briancain/expand_nodes_path_chef
...
File path expand all chef_zero config path options
2018-04-18 13:04:38 -07:00
Brian Cain
9660951c89
Merge pull request #9490 from jzinn/solo-rb-cookbook-path
...
Improve Windows drive letter removal hack
2018-04-18 08:31:23 -07:00
Julian Zinn
269645f63d
Improve Windows drive letter removal hack
2018-04-17 13:23:14 -07:00
Brian Cain
151095a3e9
Merge pull request #9420 from ryanwalder/salt-json
...
Add master_json_config & minion_json_config options to salt provisioner
2018-04-16 15:37:44 -07:00
Brian Cain
e8ab85e92b
( #9383 ) File path expand all chef_zero config path options
...
This commit ensures that all paths are properly file path expanded for
each config option in chef_zero.
2018-04-16 11:05:39 -07:00
Brian Cain
42df3e7185
Merge pull request #9685 from briancain/improve-hostonly-conf-error
...
Improve network collision error message
2018-04-12 15:18:50 -07:00
Brian Cain
4db3d49157
Improve network collision error message
...
This commit provides a bit more information when a non-hostonly network
collides with a host network.
2018-04-12 14:16:13 -07:00
Chris Roberts
5d7506afe3
Merge pull request #9676 from chrisroberts/e-win-file-perms
...
Update generated ssh private key file permissions on create
2018-04-10 14:56:28 -07:00
Chris Roberts
b605da0ef5
Merge pull request #9673 from chrisroberts/f-win-paths-filter
...
Fix windows command filters
2018-04-10 14:44:32 -07:00
Chris Roberts
9731720773
Update generated ssh private key file permissions on create
...
This updates the permissions on the automatically generated private
key file to only be readable by the user. Includes support for file
permission modification on Windows platform.
2018-04-10 14:15:14 -07:00
Brian Cain
f1de9821e1
Merge pull request #8099 from chrisroberts/windows/shared-folder-path
...
Fix virtualbox shared folders path
2018-04-10 09:16:06 -07:00
Chris Roberts
ddfd86f3d1
Split with shellwords and quote paths in command filter
...
This uses shellwords to split the command in the command filter
inside the winrm communicator. Using shellwords properly handles
things like quoted paths. Path arguments are also quoted to
prevent issues with paths that include spaces.
Fixes #9390
2018-04-09 17:00:30 -07:00
Brian Cain
7fe03988aa
Merge branch 'puppet_structured_facts_toyaml_on_provisioner' of git://github.com/aloyr/vagrant into aloyr-puppet_structured_facts_toyaml_on_provisioner
2018-04-09 11:01:36 -07:00
David Duponchel
d08a472610
Support arrays for data_bags_path in chef-zero
...
The pull request #6561 added the support for arrays for data_bags_path
in chef-solo and chef-zero, but missed a `.first` in chef-zero (which
only keeps the first data bag path). The documentation and the template
for chef-zero are already good (since #6561 ).
Fixes #9668 .
2018-04-09 17:46:42 +02:00
Chris Roberts
97dd9e0469
Adjust priority of network configuration file for debian guests
...
This adjusts the priority of the network configuration file from 99
to 50 making it easier for customized configuration.
Fixes #9592
2018-04-02 12:08:06 -07:00
Brian Cain
696ffa4e30
Merge pull request #9528 from artw/master
...
less specific string grep to fix PhotonOS 2.0 detection
2018-03-22 10:31:29 -07:00
Brian Cain
ab24bd2cf1
Merge pull request #9600 from kinvolk/kosy/coreos
...
Identify operating systems closely related to CoreOS
2018-03-22 10:11:43 -07:00
Brian Cain
0ce6e9891e
Merge pull request #9572 from jsoref/spelling
...
Spelling
2018-03-22 09:50:52 -07:00
Kosy Anyanwu
52a8b0c65e
Identify operating systems closely related to CoreOS
...
If the the value of ID= is not recognised, identify the OS if it is a derivative of CoreOS
https://www.freedesktop.org/software/systemd/man/os-release.html#ID_LIKE=
2018-03-20 17:51:20 +01:00
ajpaul
2c9e9e9ab8
reintroduce sleep_timeout for guests that fail the :wait_for_reboot capability check
2018-03-16 13:53:27 -04:00
Adam Paul
2dfe520eb8
add capability test before attemping to use capability
2018-03-15 11:45:42 -04:00
Adam Paul
76551a1692
Fix graceful_halt_timeout issue #8486
2018-03-15 10:38:07 -04:00
Josh Soref
1a5ddea9f4
Spelling fixes
...
* account
* addresses
* administrator
* afterwards
* because
* bridgeable
* capabilities
* capability
* checksum
* configuration
* configuration for
* configure
* criteria
* delimited
* delivered
* derivatives
* description
* detect
* directory
* display
* downloading
* during
* electric
* enabling
* encountered
* equivalent
* executable
* executed
* hashicorp
* hypervisor
* hyphens
* implementation
* incorporate
* inheritance
* initialize
* instance
* instead
* interactions
* invocable
* machine
* maximum
* message
* mounting
* overridden
* overwrite
* paramiko
* preparing
* provides
* provisioning
* recursively
* requested
* resetting
* retryable
* running
* satisfied
* searching
* sometimes
* specified
* successfully
* synced folders
* unauthorized
* underlying
* userprofile
* vagrant
* vagrantfile
* variable
* various
* version
* virtual
* windows
2018-03-14 14:41:04 +00:00
Chris Roberts
51232f9a03
When matching hostonly adapter name, force common types
...
Force a string type for comparison to prevent false positives when
the name is unset (resulting in a nil value).
2018-03-09 14:15:31 -08:00
mihab
03178bbe04
Fixes #9085 : Cannot `up` a machine with Docker Toolbox and Git Bash
2018-03-01 21:38:39 +01:00
Art Win
9c93e548af
the label changed in 2.0
2018-03-01 13:05:26 +02:00
Brian Cain
ac37b67eca
Merge pull request #9518 from briancain/fix-package-cmd-wsl
...
Convert to windows path if on WSL during vbox export
2018-02-28 08:07:56 -08:00
Brian Cain
73a5a5a8c9
( #9059 ) Convert to windows path if on WSL during vbox export
...
Prior to this commit, the incorrect path was used when determining where
to export an ovf file during the `vagrant package` step. This commit
updates that by checking if vagrant is within WSL, and if so, convert
the path to a proper windows path to be used during the export.
Fixes #9059
2018-02-27 16:02:25 -08:00
Brian Cain
0b92123163
Merge pull request #9507 from briancain/fix-hyper-v-check
...
Fix Hyper-v and VirtualBox check
2018-02-26 14:54:51 -08:00
Brian Cain
007e6f49aa
Merge pull request #9302 from eyJhb/master
...
Fixed hostonly matching not respecting :name argument
2018-02-26 14:50:45 -08:00
Brian Cain
f2954a64c6
Fix Hyper-v and VirtualBox check
...
Prior to this commit, the hyper-v and virtualbox system crash check
existed within the initialize function of the virtualbox provider. That
caused an issue when running with other providers, because the
virtualbox provider still gets initialized even if not used. This commit
changes that by placing the check inside of one of the virtualbox
provider actions that checks if virtualbox is installed and ready to
use. This action is action is used by the main vbox provider actions,
and should not be called when other providers are being used with
Vagrant.
2018-02-23 11:24:30 -08:00
Chris Roberts
a1529d5fbe
Merge pull request #8828 from mkhon/nfsv4-default-tcp
...
nfs_udp is false by default if using NFS v4
2018-02-23 09:50:49 -08:00
Chris Roberts
fc5ceafbcf
Only generate notice once
2018-02-22 14:49:44 -08:00
Chris Roberts
f2bf18e56b
Update behavior of the authentication middleware
...
Always remap old hosts to target host when encountered. When custom
vagrant server is defined, warn when tokens may be attached and allow
time for user to cancel.
Fixes #9442
2018-02-21 17:03:38 -08:00
Brian Cain
b8d8cf7572
Merge pull request #9456 from briancain/exit-if-hyperv-enabled-vbox
...
Exit if Hyper-V is enabled and VirtualBox provider is used
2018-02-14 08:49:06 -08:00
Brian Cain
279bceffb9
Merge pull request #9398 from drscream/smartos-inheritance-solaris
...
More explicit Solaris 11 and inherit SmartOS from Solaris
2018-02-12 15:02:30 -08:00
Hannes Körber
3082ea502e
Debian: Point hostname to 127.0.1.1 in /etc/hosts
...
Closes #9403
2018-02-10 20:54:51 +01:00
Brian Cain
a1932b8d21
Merge pull request #9265 from trombik/atomic_interface_restart
...
Atomically apply new hostname.if(5)
2018-02-09 14:27:07 -08:00
Brian Cain
84f929df21
Merge pull request #9351 from gclinch/salt-bootstrap-in-tmp
...
Change to a temporary directory before downloading script files
2018-02-09 11:14:17 -08:00
Brian Cain
e8708232a5
( #9258 ) Exit if Hyper-V is enabled and VirtualBox provider is used
...
This commit adds a function on windows for the VirtualBox provider to
check if Hyper-V is enabled. If so, exit and display a warning to the
user that going forward will result in a system crash.
2018-02-08 11:20:41 -08:00
Daniel Hahler
ec99b75c53
squash! salt: bootstrap-salt.sh: use -s with curl
...
Also use --show-error, and long option for --silent.
2018-02-02 00:39:32 +01:00
Daniel Hahler
6f7c383fe8
salt: bootstrap-salt.sh: use -s with curl
...
This makes it silent (no progress information), which would otherwise
result in output like the following (when the output from the bootstrap
script is displayed in verbose mode):
% Total % Recei
ved % Xferd Avera
ge Speed Time Time Time Current
Dload Upload Total Spent Left Speed
0 0
0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0
100 244k 100
244k 0 0
458k 0 --:--:-- --:--:-- --:--:-- 458k
* INFO: Running version: 2017.12.13
…
2018-02-01 21:27:27 +01:00
Daniel Hahler
496d9b24c1
salt: remove leading space with bootstrap_options
2018-02-01 21:24:15 +01:00
Hannes Körber
3fa3e995a9
Debian: Renew DHCP lease on hostname change
2018-02-01 16:46:23 +01:00
Ryan Walder
db457e6318
Add master_json_config & minion_json_config options to salt provisioner
...
* Allow use of -j/-J bootstrap options for configuring master/minion
2018-01-31 12:28:36 +00:00
Thomas Merkel
93c571adbf
Be sure solaris11 is Solaris version 11 and no distribution based on (Open)Solaris
...
`uname -sr` return also 5.11 on OmniOS, SmartOS which is not the same as Oracle Solaris 11.x. SmartOS and OmniOS are inherit from Solaris and not from Solaris 11. For that reason we need a more explicit check that a solaris11 guest is a real Solaris version 11, for that reason the /etc/release file is checked.
2018-01-25 13:28:15 +01:00
Thomas Merkel
21febf6b6a
SmartOS should be an inheritance of solaris
...
SmartOS is a distribution based on illumos which is the successor of OpenSolaris.
2018-01-25 13:26:18 +01:00
Chris Roberts
780673c6fe
Add warning message for VirtualBox shared folders option.
...
Display warning to user about the VirtualBox SharedFoldersEnableSymlinksCreate
option with link to VirtualBox documentation and instructions on how the
setting can be disabled.
2018-01-20 06:51:59 -08:00
Chris Roberts
f31badebb8
Merge pull request #9380 from chrisroberts/e-checkpoint
...
Update checkpoint integration
2018-01-19 15:06:28 -08:00
Chris Roberts
55460379f1
Merge pull request #9315 from basvandervlies/ifconfig_obsolete
...
ifconfig is replaced by ip command suite. So use "ip addr" and failback
2018-01-16 20:12:18 -08:00
Chris Roberts
0bf589861c
Merge pull request #9212 from mahaag/master
...
Use basename for setting hostname on Suse
2018-01-16 20:08:05 -08:00
Chris Roberts
b5383cffab
Merge pull request #9369 from chrisroberts/e-generic-sensitive
...
Add Vagrantfile configuration option to register sensitive values
2018-01-16 20:05:37 -08:00
Chris Roberts
a51c6c8479
Merge pull request #9367 from chrisroberts/e-sensitive-prov
...
Allow hiding environment variable values in shell provisioner
2018-01-16 20:03:00 -08:00
Chris Roberts
933694d986
Merge pull request #9365 from chrisroberts/e-smb-cred-check
...
Check SMB credentials
2018-01-16 20:00:57 -08:00
Chris Roberts
58f66ac8ce
Add full checkpoint integration
2018-01-16 14:16:49 -08:00
Chris Roberts
f2f8bc2db5
Add Vagrantfile configuration option to register sensitive values
2018-01-15 07:23:47 -08:00
Chris Roberts
3664f1a627
Allow hiding environment variable values in shell provisioner
2018-01-12 17:33:47 -08:00
Chris Roberts
b1c38c282e
Support SMB mount option overrides
2018-01-12 17:23:00 -08:00
Chris Roberts
5444271268
Move SMB credentials validation into host capability
2018-01-12 16:55:35 -08:00
Lachlan Arthur
01bc2627be
Check SMB credentials before using them
2018-01-12 15:46:31 -08:00
Chris Roberts
b0fc6a06a1
Merge pull request #9294 from chrisroberts/e-smb
...
SMB synced folders enhancements
2018-01-12 15:02:08 -08:00
Chris Roberts
0ffec9cd6f
Include explicit start to ensure start
2018-01-12 14:25:37 -08:00
Chris Roberts
15393fb725
Merge pull request #9274 from chrisroberts/f-nfs-naming
...
Update NFS service name usage for linux hosts
2018-01-12 13:14:07 -08:00
Chris Roberts
53fbf67d9f
Merge pull request #9295 from mcandre/patch-2
...
recognize solaris alternatives
2018-01-12 13:11:16 -08:00
Chris Roberts
f5888a4200
Merge pull request #9307 from wink-y/amazon-perform
...
Modify the matching pattern of guest os for amazon linux
2018-01-12 13:08:01 -08:00
Brian Cain
5bf75dcfb3
Merge pull request #9338 from chrisroberts/fix-ubuntu17-networking
...
Update Debian guest configure networks
2018-01-10 10:11:47 -08:00
Brian Cain
b16ca2e384
Introduce flag for SharedFoldersEnableSymlinksCreate
...
Prior to this commit, the virtualbox synced folder option
`SharedFoldersEnableSymlinksCreate` was always enabled. This commit
introduces a config option and an environment variable which allows
users to configure the option globally or per synced_folder in their
Vagrantfile.
2018-01-09 14:33:24 -08:00
Graham Clinch
b384361cd2
Use the short flag for better cross-platform support
2018-01-09 17:58:20 +00:00
Graham Clinch
1c2929cd84
Change to a temporary directory before downloading script files, to avoid
...
leaving junk files in the working directory (probably ~vagrant)
2018-01-09 16:01:50 +00:00
Brian Cain
11ddd0136d
( #9044 ) Show all box providers in command outdated
...
Prior to this commit, when the `--global` flag was used with the
`vagrant box outdated` command, it would ignore box providers and not
inform the user of all outdated boxes. This commit fixes that by
displaying each box within the users environment, and includes the
provider of the box in the message.
2018-01-08 09:43:28 -08:00
Bas van der Vlies
de62baed6b
as requested change to test to command:`which`
2018-01-08 08:53:33 +01:00
Brian Cain
c9e5a22bff
( #9062 ) Deprecate :paranoid in favor of :verify_host_key
...
As of `net-ssh` version 4.2.0, the key :paranoid has been deprecated in
favor of using :verify_host_key. This commit updates Vagrants ssh config
to use the new key, and deprecates the use of :paranoid.
2018-01-05 10:02:45 -08:00
Brian Cain
9c4ef88b88
Merge pull request #8863 from michaeltlombardi/FullyQualifyHyperVCmdlets
...
Ensure Hyper-V cmdlets are fully qualified
2018-01-04 10:27:09 -08:00
Chris Roberts
913b5639e5
Do better handling given netmasks
2018-01-03 17:26:08 -08:00
Chris Roberts
a36a84c85a
Only apply netplan configuration if systemd is in use
2018-01-03 16:31:49 -08:00
Chris Roberts
2f3d165079
Remove version from darwin host custom mount options
2018-01-03 14:41:53 -08:00
Chris Roberts
75a03ff9e9
Update available debian networking options
2018-01-03 13:56:01 -08:00
Chris Roberts
572f341697
Include synced folder cleanup action within hyperv provider
2018-01-03 10:29:45 -08:00
Chris Roberts
abf74e3757
Expand existing and requested paths prior to comparison
2018-01-03 10:05:05 -08:00
Chris Roberts
6e4139acd3
Include configuration for smb synced folders
2018-01-03 09:40:52 -08:00
Chris Roberts
5b7714f542
Include macOS as valid host platform
2018-01-03 09:30:44 -08:00
Chris Roberts
3eeff59329
Use custom types and messages for errors
2018-01-02 14:36:28 -08:00
Chris Roberts
30dcd9a7e5
Only add/remove shares on windows when needed
2018-01-02 14:03:54 -08:00
Chris Roberts
24d962eb72
Swap usage of share name and id for consistent behavior
2018-01-02 14:03:34 -08:00
Chris Roberts
98ec1af30e
Add smb_start capability for darwin
2018-01-02 11:21:50 -08:00
Bas van der Vlies
a5deb20dcb
ifconfig is replaced by ip command suite. So use "ip addr" and failback
...
to ifconfig
2017-12-28 20:31:04 +01:00
winky
e99c47907f
Modify the matching pattern of guest os for amazon linux
2017-12-27 13:57:47 +09:00
eyJhb
12a6832151
Fixed hostonly matching not respecting :name argument
2017-12-25 20:49:35 +01:00
Chris Roberts
68439f6bac
Use sudo for sharing lists on darwin platform
...
On systems prior to high sierra the sharing binary
requires root user for access, so use sudo to get
full list output and inspect output.
2017-12-21 14:53:55 -08:00
Chris Roberts
2caf109a03
Mark passwords as sensitive within guest capabilities
2017-12-21 12:49:34 -08:00
Andrew Pennebaker
98eb8cef03
recognize solaris alternatives
...
As the Solaris project is dead, recognize that Solaris alternatives like DilOS and SmartOS feature a Solaris compatible kernel and capabilities.
2017-12-21 13:07:00 -06:00
Chris Roberts
88d2b3676f
Remove stale comments from helper scripts
2017-12-21 10:19:28 -08:00
Chris Roberts
61bfbade48
Remove raise error logic in windows smb capability
2017-12-21 09:55:19 -08:00
Chris Roberts
81cbdae62a
Make powershell error generalized
2017-12-21 09:55:19 -08:00
Chris Roberts
f89c6a37f9
Provide namespace to error class
2017-12-21 09:55:19 -08:00
Chris Roberts
5a607d9248
Clean up SMB related errors
2017-12-21 09:55:19 -08:00
Chris Roberts
00fa50c296
SMB enhancements
2017-12-21 09:55:19 -08:00
Chris Roberts
e85ef1655b
Always remove credentials file after mount attempts
2017-12-21 09:55:19 -08:00
Brian Cain
f046482cfb
[WIP] systemd networkd for debian guests
2017-12-20 16:42:51 -08:00
Brian Cain
b9581ed213
Merge pull request #9251 from briancain/9137/master/exit-0-destroy-not-created
...
Exit 0 if vagrant destroy finds no running vms
2017-12-20 16:42:36 -08:00
Michael T Lombardi
9e1d05641f
Ensure Hyper-V cmdlets are fully qualified
...
+ This disambuguates calls to the Hyper-V functions for the Hyper-V provider.
The ambiguity of some commands - such as `Get-VM` - causes the Hyper-V provider
to fail on systems where VMware PowerCLI is installed. This change ensures that
all calls to Hyper-V specific cmdlets or functions are prepended by `Hyper-V\`.
This ensures the correct cmdlet calls are being made.
+ Resolves #8862 .
2017-12-15 08:30:38 -06:00
Zachary Flower
4a4183398b
Add a clean error message for invalid IP addresses
2017-12-14 14:57:21 -07:00
Brian Cain
d4d4ed6473
( #9137 ) Exit 0 if vagrant destroy finds no running vms
...
This commit reverts the behavior of `vagrant destroy` to exit 0 if no
running vms were found when the destroy command is run.
2017-12-14 12:48:22 -08:00
Gilles Cornu
43bcf2aaf7
Merge pull request #9173 from hashicorp/gildegoma/fix-ansible-ask-sudo-pass-deprecation
...
Ansible Provisioner: Fix broken 'ask_sudo_pass' option
2017-12-14 21:46:23 +01:00
Chris Roberts
120722ab08
Update NFS service name usage for linux hosts
...
Provides simple nfs service name detection via systemd or sys-v. Defaults
are provided if no match is found. Service name is defined via method
allowing derivative guests to only need to provide an updated name.
2017-12-14 08:35:07 -08:00
Chris Roberts
3a5729015a
Add documentation entry for init command --template flag
2017-12-13 15:59:45 -08:00
Chris Roberts
0c40fd3161
Merge pull request #9202 from zachflower/vagrantfile_templates
...
Support for custom Vagrantfile templates
2017-12-13 15:54:06 -08:00
Chris Roberts
04e35784e7
Merge pull request #9205 from mcandre/patch-1
...
dragonflybsd: extend FreeBSD
2017-12-13 15:42:25 -08:00
Chris Roberts
b4444aeaab
Merge pull request #9245 from kallisti5/haiku-improvements
...
haiku: Improve capabilities. (public keys, halt)
2017-12-13 15:38:13 -08:00
Tomoyuki Sakurai
35d3be865f
Atomically apply new hostname.if(5)
...
This fixes an issue when the interface being configured is the
interface through which ssh traffic is forwarded.
In a complex scenario, one needs to disable the default interface for
NAT, and use other interface for ssh. In this case, when vagrant run
`ifconfig #{ifname} inet delete`, the second ifconfig that is supposed
to restore interface settings will never be called. This might be a rare
need, but it is also strongly recommended to use `netstart` when
reconfiguring interfaces after updating `hostname.if(5)`.
The issue can be triggered when ssh connection has issues between two
`ifconfig` commands.
2017-12-13 18:34:17 +09:00
Andrew Hardy
ad0a47bedf
Removed rogue $ from string in hyperv import.rb
2017-12-10 11:09:49 +10:00
Brian Cain
a724a19a5d
Merge pull request #8992 from BenjaminSchiborr/fix/master/fix_salt_windows_bootstrap
...
provisioners/salt: Fixes timeout issue in salt bootstrapping for windows
2017-12-07 11:27:55 -08:00
Alexander von Gluck IV
263a2c4d9b
haiku: Improve capabilities. (public keys, halt)
2017-12-05 18:19:15 -06:00
Brian Cain
c3a4f8d72a
Merge pull request #7805 from kallisti5/master
...
Add support for the Haiku operating system
2017-12-05 14:03:43 -08:00
Matthias Haag
a139dd2b59
use basename for setting hostname
2017-11-22 11:09:51 +01:00
Andrew Pennebaker
2b87d12925
dragonflybsd: extend FreeBSD
...
Reuse FreeBSD guest code for installing rsync, etc., as dragonfly- and freebsd are very similar, especially with regard to package management.
2017-11-19 19:41:25 -06:00
Zachary Flower
abb1149190
Raise an exception when the template cannot be found, and update tests accordingly
2017-11-17 12:20:03 -07:00
Zachary Flower
14d596f08e
Add --template option to init command, with graceful fallback to default Vagrantfile template behavior
2017-11-17 11:30:10 -07:00
Gilles Cornu
e47deb7fd0
ansible: Fix broken 'ask_sudo_pass' option
...
This bug (invalid method call) hasn't been caught by unit tests because
Vagrant::Plugin::V2::Config catches all invalid/bad configuration calls
and save them for generating error messages during the "validate" stage.
This way, the `ask_sudo_pass=(value)` method was not interrupted and the
`@ask_become_pass` attribute was (surprisingly) correctly set (allowing
the related unit tests to pass).
In order to avoid similar problem to happen again, the deprecation
message output is now fully verified.
2017-11-09 18:17:04 +01:00
Justin Campbell
40d8dc4582
Add app.vagrantup.com to allowed auth hosts
...
This should allow users setting VAGRANT_SERVER_URL to app.vagrantup.com to authenticate to private boxes.
2017-11-07 10:35:16 -05:00
Justin Campbell
c5266e98b8
Change allowed auth hosts to list
2017-11-07 10:32:33 -05:00
Benjamin Schiborr
ee800cc7c2
provisioners/salt: #8991 : Break if success
...
This commit ensures that we actually break when the download was
successful. Before it tried to download again for every iteration of the
loop. In addition the number of iterations have been increased. I've
experienced timeouts on third retry. Increasing to 5.
2017-11-06 13:56:11 -08:00
Brian Cain
8be2ae8e6a
Add unit test for destroy command
2017-11-01 15:30:59 -07:00
Brian Cain
d8bffd201f
Add delay for parallel destroy without force, restructure state checking
...
This commit adds better messaging to the user if the parallel flag is
used without the force flag. It also makes the state checking based on
the delta between the initial and final states of the guests due to the
fact that there is no guarantee what the "destroyed" state id will be
between providers.
2017-10-31 13:52:07 -07:00
Brian Cain
2d7858ff8a
Introduce parallel destroy for certain providers
...
This commit introduces parallel destroy using the batch action class for
the destroy command.
2017-10-31 11:29:40 -07:00
Adam Bolte
511fac8162
Attempt fetching salt bootstrap script with wget
...
On Debian installations, wget is installed even into the most minimal
environment. Even Python support on Debian cannot be guaranteed if
Standard System Utilities was not selected at installation time (or if
debootstrap was used), which is why the retrieved bootstrap-salt.sh
script takes care of installing it prior to installing Salt.
2017-10-26 13:41:40 +11:00
Brian Cain
c7ec0a42a5
( #8941 ) Include WinSSH Communicator
...
This commit requires the winssh communicator class wihtin the public_key
capability for Windows. Prior to this commit users could run into a
situation where Vagrant would check if the machine could speak in WinSSH
and fail on an uninitialized constant.
2017-10-24 12:02:01 -07:00
Chris Roberts
fc7d2a3097
Merge pull request #8921 from lookfwd/fix_8608
...
fix for issue #8608/Windows hosts
2017-10-23 16:58:39 -07:00
Chris Roberts
eaa518159c
Merge pull request #8997 from bshurts/fix/winrm-apipa
...
Adding check for APIPA in winrm helper to fix #8996
2017-10-23 16:47:32 -07:00
Chris Roberts
6eca74afc7
Merge pull request #9012 from benh57/winssh_communicator_fix
...
Fix guest network setup with winssh communicator
2017-10-23 15:41:53 -07:00
Vít Ondruch
7187e6f909
Use Integer instead of Fixnum for Ruby 2.4+ compatibility.
2017-10-23 10:57:36 -07:00
Brian Cain
e1d1ba5d55
( #8974 ) Add Errno::EPIPE exception to ssh communicator
...
This commit adds an additional exception to retry ssh on when bringing
up a machine and attempting to ssh into the guest.
2017-10-17 16:44:14 -07:00
Brian Cain
47edb88fe4
Merge pull request #9034 from briancain/unify-solaris-guests
...
Unify Solaris Guests
2017-10-11 15:37:24 -07:00
Brian Cain
c88ccb0b3d
Merge pull request #9014 from benh57/winssh_puppet_fix
...
Fix winssh communicator support in puppet provisioner
2017-10-10 09:46:59 -07:00
Brian Cain
a849cd2f7d
( #8963 ) Unify Solaris Guests
...
This commit removes some duplicated code within the Solaris11 guest
implemnentation and instead relies on the Solaris guest for the majority
of its guest capabilities.
2017-10-05 11:31:12 -07:00
Bryce Shurts
ba3c26b211
Updating winrm_info_invalid to use start_with instead of match
2017-10-05 10:28:10 -05:00
Jonathan LaBroad
56861296fa
Added tests and validation for python_version parameter
2017-10-05 06:25:36 -04:00
Jonathan LaBroad
3524eb9ef4
Merge remote-tracking branch 'upstream/master'
2017-10-04 14:59:57 -04:00
Brian Cain
fb1501d48a
Merge pull request #8874 from taliesins/HandleChefProvisionerRebootRequest
...
Handle chef provisioner reboot request
2017-10-04 09:37:02 -07:00
Brian Cain
9d360d2b21
Merge pull request #9000 from bbrala/bug-hyperv-auto-stop-action
...
Auto stop action is configured wrongly
2017-10-04 09:12:09 -07:00
Brian Cain
83310f8a56
Merge pull request #8955 from jehiah/virtualbox52_8955
...
Virtualbox 5.2 support
2017-10-03 13:25:39 -07:00
Ben Hines
e133547932
Properly call winssh communicator on windows via powershell, and fix syntax for powershell via puppet.
2017-09-29 20:53:09 -07:00
Ben Hines
ea518f6c78
test() defaults to powershell for winssh, no need to pass it
2017-09-29 19:30:07 -07:00
Ben Hines
6b4584efb6
Use the 'powershell' shell when running powershell commands. Allows winssh communicator to function
2017-09-29 19:17:49 -07:00
Brian Cain
87ee4f5662
Merge pull request #8995 from elatt/fix_synced_folders_spaces
...
Allow synced folders to contain spaces in the guest path
2017-09-29 15:19:39 -07:00
Erik Lattimore
28a92850ab
Allow synced folders to contain spaces in the guest path
...
It should be valid to allow paths with spaces for the synced folder
guest path but since the guest path is used to generate the ID (if one
isn't provided), this will err out in VirtualBox because it doesn't
allow spaces for the --name argument. We should simply convert ' ' to
'_' as we do with other special characters.
2017-09-29 17:24:12 -04:00
Björn Brala
0f743d0731
Auto stop action is configured through auto start action.
2017-09-26 16:03:35 +02:00
Bryce Shurts
0eaf691ea0
Adding check for APIPA in winrm helper to fix #8996
2017-09-25 16:31:37 -05:00
Benjamin Schiborr
c30c00508c
provisioners/salt: #8991 : Fixes timeout issue in salt bootstrapping for windows
...
Fixes #8991 .
1. When remote executing scripts one should always call powershell with
1a. "-NonInteractive", in order to prevent interactive prompts from leading to an endless waiting time for the script to return
1b. "-NoProfile", in order to prevent the loading of unknown custom profiles before execution of the script which could have unintended side effects
2. During my tests I constantly ran into 408 timeouts when downloading the salt binaries. I've prevented that by adding a simple retry mechanism and an error exit in case of multiple failures. Without this change the bootstrap script never returned (and neither did vagrant up)
2017-09-22 18:08:30 -07:00
Mikhail Bulash
508d94d466
provisioners/shell: Use ui.detail for displaying output
...
Output format of ui.info method (bold text) makes reading long script outputs really heavy on the eyes. ui.detail is a better match for this type of output.
2017-09-18 17:55:07 +03:00
Jehiah Czebotar
7d73af5637
Virtualbox 5.2 support
2017-09-14 15:07:11 -04:00
Jonathan LaBroad
6f53c3991c
Merge remote-tracking branch 'upstream/master'
2017-09-11 09:15:22 -04:00
Chris Roberts
2451c859e8
Merge pull request #8746 from mastersin/alt
...
Add ALT Linux platforms guest detection and network configuration support (#8745 )
2017-09-06 17:49:38 -07:00
Chris Roberts
d7b64dce80
Merge pull request #8938 from chrisroberts/update/host-systemd
...
Update linux host NFS capability
2017-09-06 16:57:27 -07:00
Brian Cain
b2f34a6ea9
Merge pull request #8951 from briancain/RETRYABLE-COMMANDS
...
Improving resilience of some VirtualBox commands fixup
2017-09-06 14:51:02 -07:00
Chris Roberts
34addec796
Merge pull request #8913 from mitchellh/gildegoma/6570-ansible-compatibility-mode
...
Ansible: Add "compatibility_mode" and "*become*" common options; Move "version" to common options
2017-09-06 13:18:08 -07:00
Brian Cain
4e7bd96bb0
Merge pull request #8950 from terceiro/fix-permissions
...
plugins/guests/kali: fix file permissions
2017-09-06 13:04:29 -07:00
Gilles Cornu
ac75e409a3
provisioners/ansible(both): Quote host_vars if needed
...
This patch is based on @subimage's inputs in the related GitHub issue.
Thanks again!
Fix #8597
2017-09-06 21:22:41 +02:00
Brian Cain
9b872c9e7e
Cleanup virtualbox retryable commands
...
Reverting the changes done in 7d2f7dab97
because they don't work and or update vagrant to invoke running the
vbox cli tool for every single forwarded port instead of forwarding them
all in one command.
2017-09-06 11:14:11 -07:00
Samuel Clark
2e775e8101
8468 - make more virtualbox commands retryable
...
Issue: https://github.com/mitchellh/vagrant/issues/8468
A lot of vboxmanage commands are flakey and frequently cause
bringing multiple machines up at once to fail, especially when
the host system is under heavy load. Most commands are also safe
to retry and just result in a no-op, so we can simply add
'retryable' to a lot of existing calls. For the others we need to
do a little bit of cleanup or reevaluate the parameters before
trying again.
2017-09-06 11:14:11 -07:00
nico.vanelslande
9aecd5e1a4
Improved resilience of the VirtualBox driver delete_unused_host_only_networks function by
...
ignoring VMs that may have been deleted between the calls to
'vboxmanage list vms' and 'vboxmanage showvminfo'
2017-09-06 11:13:14 -07:00
nico.vanelslande
56c8b9269a
Improved resilience of the VirtualBox driver read_used_ports function by
...
ignoring VMs that may have been deleted between the calls to
'vboxmanage list vms' and 'vboxmanage showvminfo'
2017-09-06 11:13:14 -07:00
Chris Roberts
fcd1aee9bb
Update linux host NFS capability
...
Add support for systemd detection and using correct method
for starting/checking host nfs service.
2017-09-06 09:54:06 -07:00
Brian Cain
f1eddace18
Merge pull request #8945 from briancain/4666/master/dupe-nfs-export-linux
...
Remove duplicate export folders before writing /etc/exports
2017-09-06 08:34:46 -07:00
Antonio Terceiro
acda71edd9
plugins/guests/kali: fix file permissions
...
Those Ruby files are not standalone scripts, so there is no point in
having them being executable.
2017-09-06 12:21:23 -03:00
Gilles Cornu
a0a09c6095
minor: Fix a typo in a code comment
...
[ci skip]
2017-09-06 17:12:51 +02:00
Gilles Cornu
4dc3e59b08
provisioners/ansible(both): Review of PR #8913
...
- Keep the Programming Errors with corresponding Exception class and
en.yml message template. Fix the alphabetical order in errors.rb by
the way.
- Fix English wording in the documentation and en.yml messages
- Use StandardError for unknown error rescuing.
Thanks @chrisroberts!
2017-09-06 17:12:50 +02:00