Commit Graph

1781 Commits

Author SHA1 Message Date
Gilles Cornu a7ee56459b provisioners/ansible(both): fix ansible config files presence checks
With this change, the presence of Ansible configuration files (like
playbook file, inventory path, galaxy role file, etc.) is no longer
performed by the `config` classes, but by the `provisioner` classes
(at the beginning of the provision command).

This change fixes several issues:

- Resolve #6984 as `provision` method are only executed when remote
  (ssh) communication with the guest machine is possible.
- Resolve #6763 in a better way than 4e451c6 initially did.
- Improve the general provisioner speed since the `config` checks are
  actually triggered by many vagrant actions (e.g. `destroy`,...), and
  can also be triggered multiple times during a vagrant run (e.g. on
  callback request made by the machine provider).

Unlike the former `config`-based checks, the provision action won't
collect all the invalid options, but only report the first invalid
option found and abort the execution.

Some unit tests were not implemented yet to save my scarce "open source
contribution time" for other important issues, but they should be done
at last via GH-6633.
2016-06-01 06:40:23 +02:00
Seth Vargo 37cdabc2e7
Update CHANGELOG 2016-05-31 20:10:16 -04:00
Seth Vargo 9a28a03b2c
Update CHANGELOG 2016-05-31 17:56:40 -04:00
Seth Vargo 9c5404c9b8
Update CHANGELOG 2016-05-30 21:02:09 -04:00
Seth Vargo ef2ddcec26
Update CHANGELOG 2016-05-30 17:28:11 -04:00
Seth Vargo 4236ddc021
Update CHANGELOG 2016-05-30 15:38:37 -04:00
Seth Vargo f7ffec3589
Update CHANGELOG 2016-05-29 18:48:21 -04:00
Seth Vargo 791ad7ac8e
Update CHANGELOG 2016-05-29 14:48:56 -04:00
Seth Vargo 131c8c811e
Update CHANGELOG 2016-05-29 01:20:56 -04:00
Seth Vargo 7713a52f01
Update CHANGELOG 2016-05-29 01:11:53 -04:00
Seth Vargo 71dad1d7a4
Update CHANGELOG 2016-05-29 00:59:04 -04:00
Seth Vargo 2f3973ef69
Update CHANGELOG 2016-05-29 00:56:47 -04:00
Seth Vargo d9a9a7dd1b
Update CHANGELOG 2016-05-29 00:47:37 -04:00
Seth Vargo 453fdb02d0
Update CHANGELOG 2016-05-28 17:11:32 -04:00
Seth Vargo 61f4128003
Update CHANGELOG 2016-05-27 19:09:38 -04:00
Seth Vargo 4250fb5514
Update CHANGELOG 2016-05-27 19:03:23 -04:00
Seth Vargo 9baa5baff6
Update CHANGELOG 2016-05-27 18:39:23 -04:00
Seth Vargo ef22149e9c
Update CHANGELOG 2016-05-27 17:39:06 -04:00
Seth Vargo a4803c0869
Update CHANGELOG 2016-05-27 17:17:29 -04:00
Seth Vargo a92d841e2a
Update CHANGELOG 2016-05-27 17:08:46 -04:00
Seth Vargo a735608787
Update CHANGELOG 2016-05-27 16:06:56 -04:00
Seth Vargo ee492629ac
Update CHANGELOG 2016-05-20 10:46:49 -04:00
Seth Vargo 1571879a4b
Update CHANGELOG 2016-05-19 11:34:50 -04:00
Seth Vargo f6db93d4be
Update CHANGELOG 2016-05-16 12:07:41 -04:00
Gilles Cornu cf908d35e0 provisioners/ansible_local: Run galaxy from `provisioning_path` directory
Since it is now possible to specify some Galaxy settings in an
`ansible.cfg` file, it makes sense to run `ansible-galaxy` from the
same working directory as `ansible-playbook` execution does.

See http://docs.ansible.com/ansible/intro_configuration.html#galaxy-settings
2016-04-24 00:26:59 +02:00
Gilles Cornu 327392d0fb Fix a CHANGELOG entry
[ci skip]
2016-04-21 00:37:31 +02:00
Gilles Cornu afb9af1549 Update CHANGELOG
[ci skip]
2016-04-21 00:34:19 +02:00
Seth Vargo 2c553290b8
Update CHANGELOG 2016-04-17 23:15:31 +05:30
Seth Vargo bfac44aded Update CHANGELOG 2016-04-08 10:22:54 -04:00
Seth Vargo 9c0a4bb562 Update CHANGELOG 2016-04-05 10:46:48 -04:00
Seth Vargo be9a88d2a0 Update CHANGELOG 2016-04-05 10:42:58 -04:00
Seth Vargo 4641aa767b Update CHANGELOG 2016-03-31 17:02:28 +02:00
Seth Vargo fa19783a6e Update CHANGELOG 2016-03-17 20:52:57 -05:00
Seth Vargo 197a2d8799 Update CHANGELOG 2016-03-17 20:46:26 -05:00
Seth Vargo 32c4638ffd Update CHANGELOG 2016-03-17 10:49:16 -04:00
Seth Vargo bd1df1332b Update CHANGELOG 2016-03-08 13:56:58 -05:00
Seth Vargo be1421f116 Update CHANGELOG 2016-03-07 11:01:20 -05:00
Paul Hinze ffe0ef71ad Update CHANGELOG.md 2016-03-04 11:42:13 -06:00
Seth Vargo 9623457513 Update CHANGELOG 2016-03-02 07:41:12 -07:00
Seth Vargo ebcc73f338 Update CHANGELOG 2016-02-29 07:20:47 -05:00
Seth Vargo 7574937c3f Update business address 2016-02-29 07:18:27 -05:00
Seth Vargo c851637260 Update CHANGELOG 2016-02-27 12:42:08 -05:00
Andrew Murray 98a18bbaf5 Fixed typos 2016-02-20 00:00:26 +11:00
Seth Vargo ca728df02b Update CHANGELOG 2016-02-08 10:55:44 -05:00
Seth Vargo 3c34b67ba1 Fix CHANGELOG typo 2016-02-07 13:07:15 -05:00
Seth Vargo 082e65291e Update CHANGELOG 2016-02-04 12:11:41 -05:00
Mathias Brodala 78578788c3 Fix typo in CHANGELOG 2016-02-03 17:24:50 +01:00
Seth Vargo ab26ca1c81 Update CHANGELOG 2016-02-03 10:15:25 -05:00
Seth Vargo 8ca6244b4d Update CHANGELOG 2016-02-03 10:13:03 -05:00
Seth Vargo 0034318740 Update CHANGELOG 2016-02-03 10:11:10 -05:00
Seth Vargo a82b1a6a71 Update CHANGELOG 2016-02-03 10:09:38 -05:00
Seth Vargo 29e51e7072 Update CHANGELOG 2016-02-03 10:06:54 -05:00
Seth Vargo 1bb585d89d Update CHANGELOG 2016-02-03 09:59:39 -05:00
Seth Vargo 9cd68f0927 Update CHANGELOG 2016-02-03 09:58:09 -05:00
Seth Vargo e6cd96803a Update CHANGELOG 2016-02-03 09:57:11 -05:00
Seth Vargo 982effe0c1 Update CHANGELOG 2016-02-03 09:55:41 -05:00
Seth Vargo d7b7c66302 Update CHANGELOG 2016-02-03 09:53:38 -05:00
Seth Vargo 3b252d37eb Merge pull request #6922 from mwrock/negotiate
upgrade to latest winrm and winrm-fs versions
2016-02-03 09:52:48 -05:00
Seth Vargo 3ae19c6537 Update CHANGELOG 2016-02-03 09:51:15 -05:00
Seth Vargo c08b737e0c Update CHANGELOG 2016-02-03 09:50:02 -05:00
Seth Vargo 6d36370dc8 Update CHANGELOG 2016-02-03 09:46:14 -05:00
Seth Vargo 217b0c9eaa Update CHANGELOG 2016-02-02 09:49:13 -05:00
Seth Vargo 0620dbf856 Update CHANGELOG 2016-02-02 09:44:37 -05:00
Matt Wrock 5b2566cd51 add note about potentially breaking change with uploading directories 2016-01-27 11:57:42 -08:00
Seth Vargo b454fdc8d3 Update CHANGELOG 2016-01-25 13:56:08 -05:00
Seth Vargo 1166800b65 Use SSL and HTTPS links where appropriate 2016-01-25 13:14:54 -05:00
Gilles Cornu 4e451c6e99 provisioners/ansible_local: fix #6763
Before this change, the detection of a non-existing path on the guest
machine was considered as an error and lead to interrupt the current vagrant
action. This was actually a mistake to do so, since the config checks
are performed before many other vagrant actions than `provision`.
The config.validate phase is also intended to primarily check the options
sanity, but it cannot be too strict with the guest state (which can easily
get "out of automatic control").

With this change, we still apply these checks (when possible), but only warn
about possible configuration problems. This way, the subsequent
statements will happen anyway (e.g. ansible commands will be
executed, vagrant machine will be destroyed, etc.)
2016-01-17 11:27:23 +01:00
Gilles Cornu e5e5057a06 update CHANGELOG for GH-6793 2016-01-14 00:12:24 +01:00
Gilles Cornu 1e38be237e provisioners/ansible: fix galaxy paths on Windows
Close #6757 and update previous fix for #6740 (#6741).

See also these places where the same regexp is used to address similar
"Windows cases":

 - ec85548bd6/plugins/provisioners/chef/provisioner/chef_solo.rb (L99-L103)
 - ec85548bd6/plugins/guests/windows/cap/rsync.rb (L6-L9)
2016-01-05 08:22:10 +01:00
Gilles Cornu 9a5597e1a7 Update CHANGELOG.md
ref #6741, #6740
2015-12-27 22:15:11 +01:00
Mitchell Hashimoto 984bc4ab77 up version for dev 2015-12-24 14:03:36 -08:00
Mitchell Hashimoto c1c00e2f3c v1.8.1 2015-12-24 13:26:53 -08:00
Mitchell Hashimoto 45212a9b67 core: avoid crash case with nil [GH-6730] 2015-12-24 12:38:14 -08:00
Mitchell Hashimoto cf4b03d701 core: do not convert drive letters to UNC paths [GH-6598] 2015-12-24 12:36:14 -08:00
Mitchell Hashimoto 39543973f1 update CHANGELOG 2015-12-24 12:29:57 -08:00
Mitchell Hashimoto 0de44a116b core: use env var for bundle retries [GH-6705] 2015-12-24 12:16:12 -08:00
Mitchell Hashimoto 05c2d439ac hosts/*: fix virtualbox install exception [GH-6713] 2015-12-24 12:08:31 -08:00
Mitchell Hashimoto 7133593a5f update CHANGELOG 2015-12-24 12:03:54 -08:00
Mitchell Hashimoto 6aa89584b8 update CHANGELOG 2015-12-22 13:31:13 -08:00
Seth Vargo 881bcf46de Update CHANGELOG 2015-12-22 11:56:59 -05:00
Mitchell Hashimoto 5328886423 update CHANGELOG 2015-12-21 13:12:19 -08:00
Gilles Cornu ddbd2a4cfc provisioners/ansible: prefer ssh '-i' argument
In cd93721, I relied on a suprising combination of quotes to protect ssh
execution to strip the quoted path to the private key file.
Since any ssh command line argument can be passed via
`ANSIBLE_SSH_ARGS`, it is quite more readable and easy to rely on the
`-i` argument, which is not affected like `-o IdentityFile=...` and also
supports multiple occurences.

See also http://sourceforge.net/p/fuse/mailman/message/30498048/

Finally fix #6671

Note that I decided to not squash both commits for better
documentation and traceability.
2015-12-16 10:29:13 +01:00
Gilles Cornu cd93721f8f provisioners/ansible: use quotes for the IdentityFile OpenSSH command line arguments
Surprisingly (to me at least), a simple quote enclosure was not enough
to fix the problem.

Caveat: the stringified ansible-playbook command logged in verbose mode
is wrongly formatted (no quotes are escaped).

Fix #6671
2015-12-16 09:54:53 +01:00
Mitchell Hashimoto ac3b24d93e Update CHANGELOG.md 2015-12-14 16:03:07 -08:00
Mitchell Hashimoto 6a9d25e384 Update CHANGELOG.md 2015-12-14 15:47:58 -08:00
Seth Vargo fa2db94b7d Update CHANGELOG 2015-12-10 11:26:57 -05:00
Gilles Cornu e5c5dfbacd Update CHANGELOG
- Fix reference to relevant pull request #6288
- See also #6649

[ci skip]
2015-12-08 22:11:30 +01:00
Seth Vargo af509e0a2b Update CHANGELOG 2015-12-08 11:17:11 -05:00
Seth Vargo c60a71861f Update CHANGELOG 2015-12-07 10:58:46 -05:00
Gilles Cornu c20e1bb594 provisioners/ansible: support host pattern ranges
Introduction of "unsafe" numeric or alphabetic patterns in the generated inventory

Close #3539
2015-12-05 07:11:27 +01:00
Gilles Cornu cc2d11b497 provisioners/ansible+ansible_local: inventory vars
Add support for group and host variables in the generated inventory.

Close #6619
2015-12-03 21:50:53 +01:00
Gilles Cornu 32bb316564 Update CHANGELOG.md
close #5086
2015-11-25 22:48:56 +01:00
Seth Vargo 6c40a8b66c Update CHANGELOG 2015-11-25 15:40:54 -05:00
Seth Vargo aa4dd7cd0e Update CHANGELOG 2015-11-23 20:25:09 -05:00
Seth Vargo 1fd3c955b7 Update CHANGELOG 2015-11-23 20:04:30 -05:00
Seth Vargo 2a6db90afd Update CHANGELOG 2015-11-23 19:39:13 -05:00
Seth Vargo 5ee7f805a8 Update CHANGELOG 2015-11-23 16:30:28 -05:00
Mitchell Hashimoto b23b48a614 providers/hyper-v: support more than one NIC [GH-4346] 2015-11-23 12:05:37 -08:00
Mitchell Hashimoto 601f7d41e5 synced_folders/smb: use cred files [GH-4230] 2015-11-23 11:11:50 -08:00
Gilles Cornu 1a541dc043 Update CHANGELOG
ref #6581 [ci skip]
2015-11-23 19:55:32 +01:00
Mitchell Hashimoto dbf419abad providers/virtualbox: ignore unknown status interfaces [GH-6061] 2015-11-23 10:15:32 -08:00
Mitchell Hashimoto 75faa43b7f Update CHANGELOG.md 2015-11-23 10:07:45 -08:00
Mitchell Hashimoto 1405395d81 core: catch EINVAL on setting env vars [GH-6017] 2015-11-23 09:39:51 -08:00
Mitchell Hashimoto 4e1ba3a027 core: fix file URLs from cygwin on Windows [GH-5747] 2015-11-23 09:30:27 -08:00
Gilles Cornu 43c4de3907 Update CHANGELOG
Close GH-2718
2015-11-21 05:25:40 +01:00
Mitchell Hashimoto c471f37955 core: parse line numbers for Vagrantfile syntax errors on Win [GH-6445] 2015-11-20 15:34:52 -08:00
Mitchell Hashimoto 978bca8b49 update CHANGELOG 2015-11-20 10:51:35 -08:00
Mitchell Hashimoto 2ade66443e core: retry bundler network calls a few times [GH-6097] 2015-11-19 23:57:16 -08:00
Mitchell Hashimoto 32f6accb25 commands/box: don't halt on metadata download failure [GH-6453] 2015-11-19 18:50:50 -08:00
Mitchell Hashimoto f69d9a6515 update CHANGELOG 2015-11-19 18:38:05 -08:00
Mitchell Hashimoto 240c393e69 update CHANGELOG 2015-11-19 18:20:16 -08:00
Seth Vargo 7f4d5c82de Update CHANGELOG 2015-11-19 17:07:49 -08:00
Seth Vargo 33d1bca02e Update CHANGELOG 2015-11-19 16:39:16 -08:00
Seth Vargo 6a147e1146 Update CHANGELOG 2015-11-19 16:22:03 -08:00
Mitchell Hashimoto a59dede676 update CHANGELOG 2015-11-19 16:18:57 -08:00
Mitchell Hashimoto e0ef592544 core: retry if server doesn't support byte ranges on download [GH-4479] 2015-11-19 16:14:13 -08:00
Mitchell Hashimoto 66c99ddb70 update CHANGELOG 2015-11-19 16:01:09 -08:00
Seth Vargo f040f2bbeb Update CHANGELOG 2015-11-19 15:56:18 -08:00
Seth Vargo 29a8ddd9ee Update CHANGELOG 2015-11-19 15:12:09 -08:00
Seth Vargo 9bab741cf3 Update CHANGELOG 2015-11-19 11:56:45 -08:00
Seth Vargo 38dab45aa7 Update CHANGELOG 2015-11-19 11:41:37 -08:00
Mitchell Hashimoto 4988298b0b guests/arch: configure networks should enable device [GH-5737] 2015-11-19 11:39:04 -08:00
Mitchell Hashimoto fd3e1ff592 update CHANGELOG 2015-11-19 11:22:52 -08:00
Mitchell Hashimoto 3987ce84cc update CHANGELOG 2015-11-19 11:21:14 -08:00
Seth Vargo 8b90cff984 Update CHANGELOG 2015-11-19 11:19:08 -08:00
Mitchell Hashimoto 764e151672 Update CHANGELOG.md 2015-11-19 09:29:44 -08:00
Mitchell Hashimoto 2ffbe4e6e1 core: more robust WIndows admin check [GH-5616] 2015-11-18 20:27:07 -08:00
Seth Vargo 398017ba6e Update CHANGELOG 2015-11-18 18:36:59 -08:00
Mitchell Hashimoto 13ede32aa1 update CHANGELOG 2015-11-18 18:10:45 -08:00
Mitchell Hashimoto c5add4749f update CHANGELOG 2015-11-18 18:10:06 -08:00
Mitchell Hashimoto 7c49fd1418 core: fix crash on invalid checksum type [GH-6327] 2015-11-18 17:36:52 -08:00
Mitchell Hashimoto eb5a6fc7c3 communicators/ssh: more nil guards [GH-6225] 2015-11-18 17:32:40 -08:00
Mitchell Hashimoto 6f3ed13f75 providers/virtualbox: run provisioners on suspend resume 2015-11-18 17:16:23 -08:00
Seth Vargo 2dfc96c536 Update CHANGELOG 2015-11-18 17:01:21 -08:00
Seth Vargo 733a583b69 Update CHANGELOG 2015-11-18 16:47:03 -08:00
Seth Vargo 3328fa3fb8 Update CHANGELOG 2015-11-18 16:42:18 -08:00
Seth Vargo 6af1f1e258 Update CHANGELOG 2015-11-18 16:26:14 -08:00
Seth Vargo cab2926633 Update CHANGELOG 2015-11-18 16:04:59 -08:00
Mitchell Hashimoto 0ebd600c89 update CHANGELOG 2015-11-18 15:57:30 -08:00
Mitchell Hashimoto a6f56b1592 update CHANGELOG 2015-11-18 15:15:22 -08:00
Mitchell Hashimoto 3da746feac update CHANGELOG 2015-11-18 15:01:09 -08:00
Mitchell Hashimoto c7a8edd05a update CHANGELOG 2015-11-18 14:37:17 -08:00
Mitchell Hashimoto 28f8db6e73 update CHANGELOG 2015-11-18 14:18:28 -08:00
Seth Vargo 50ce81face Update CHANGELOG 2015-11-18 14:03:35 -08:00
Mitchell Hashimoto fb11ea2a7c update CHANGELOG 2015-11-18 14:02:32 -08:00
Mitchell Hashimoto 9c2a9f198f update CHANGELOG 2015-11-18 13:59:45 -08:00
Mitchell Hashimoto 5fe58dfb1a update CHANGELOG 2015-11-18 13:47:46 -08:00
Mitchell Hashimoto cf2566f186 update CHANGELOG 2015-11-18 13:16:01 -08:00
Mitchell Hashimoto e71e60ecac website/docs: document WinRM execution time limit 2015-11-18 13:05:08 -08:00
Mitchell Hashimoto 5b3bc95388 update CHANGELOG 2015-11-18 12:55:53 -08:00