swdptap: Cleaned up the naming and and signatures of the SWDP implementation functions

This commit is contained in:
dragonmux 2022-07-16 02:21:57 +01:00 committed by Piotr Esden-Tempski
parent 1a362db5ab
commit 10d30821e5
6 changed files with 141 additions and 157 deletions

View File

@ -28,14 +28,12 @@ enum {
SWDIO_STATUS_FLOAT = 0, SWDIO_STATUS_FLOAT = 0,
SWDIO_STATUS_DRIVE SWDIO_STATUS_DRIVE
}; };
static void swdptap_turnaround(int dir) __attribute__ ((optimize(3)));
static uint32_t swdptap_seq_in(int ticks) __attribute__ ((optimize(3))); static void swdptap_turnaround(int dir) __attribute__((optimize(3)));
static bool swdptap_seq_in_parity(uint32_t *ret, int ticks) static uint32_t swdptap_seq_in(size_t clock_cycles) __attribute__((optimize(3)));
__attribute__ ((optimize(3))); static bool swdptap_seq_in_parity(uint32_t *ret, size_t clock_cycles) __attribute__((optimize(3)));
static void swdptap_seq_out(uint32_t MS, int ticks) static void swdptap_seq_out(uint32_t tms_states, size_t clock_cycles) __attribute__((optimize(3)));
__attribute__ ((optimize(3))); static void swdptap_seq_out_parity(uint32_t tms_states, size_t clock_cycles) __attribute__((optimize(3)));
static void swdptap_seq_out_parity(uint32_t MS, int ticks)
__attribute__ ((optimize(3)));
static void swdptap_turnaround(int dir) static void swdptap_turnaround(int dir)
{ {
@ -60,11 +58,11 @@ static void swdptap_turnaround(int dir)
SWDIO_MODE_DRIVE(); SWDIO_MODE_DRIVE();
} }
static uint32_t swdptap_seq_in(int ticks) static uint32_t swdptap_seq_in(size_t clock_cycles)
{ {
uint32_t index = 1; uint32_t index = 1;
uint32_t ret = 0; uint32_t ret = 0;
int len = ticks; int len = clock_cycles;
register volatile int32_t cnt; register volatile int32_t cnt;
swdptap_turnaround(SWDIO_STATUS_FLOAT); swdptap_turnaround(SWDIO_STATUS_FLOAT);
@ -96,7 +94,7 @@ static uint32_t swdptap_seq_in(int ticks)
return ret; return ret;
} }
static bool swdptap_seq_in_parity(uint32_t *ret, int ticks) static bool swdptap_seq_in_parity(uint32_t *ret, size_t ticks)
{ {
uint32_t index = 1; uint32_t index = 1;
uint32_t res = 0; uint32_t res = 0;
@ -141,59 +139,59 @@ static bool swdptap_seq_in_parity(uint32_t *ret, int ticks)
return (parity & 1); return (parity & 1);
} }
static void swdptap_seq_out(uint32_t MS, int ticks) static void swdptap_seq_out(uint32_t tms_states, size_t ticks)
{ {
#ifdef DEBUG_SWD_BITS #ifdef DEBUG_SWD_BITS
for (int i = 0; i < ticks; i++) for (int i = 0; i < ticks; i++)
DEBUG("%d", (MS & (1 << i)) ? 1 : 0); DEBUG("%d", (tms_states & (1 << i)) ? 1 : 0);
#endif #endif
register volatile int32_t cnt; register volatile int32_t cnt;
swdptap_turnaround(SWDIO_STATUS_DRIVE); swdptap_turnaround(SWDIO_STATUS_DRIVE);
gpio_set_val(SWDIO_PORT, SWDIO_PIN, MS & 1); gpio_set_val(SWDIO_PORT, SWDIO_PIN, tms_states & 1);
if (swd_delay_cnt) { if (swd_delay_cnt) {
while (ticks--) { while (ticks--) {
gpio_set(SWCLK_PORT, SWCLK_PIN); gpio_set(SWCLK_PORT, SWCLK_PIN);
for(cnt = swd_delay_cnt; --cnt > 0;); for(cnt = swd_delay_cnt; --cnt > 0;);
MS >>= 1; tms_states >>= 1;
gpio_set_val(SWDIO_PORT, SWDIO_PIN, MS & 1); gpio_set_val(SWDIO_PORT, SWDIO_PIN, tms_states & 1);
gpio_clear(SWCLK_PORT, SWCLK_PIN); gpio_clear(SWCLK_PORT, SWCLK_PIN);
for(cnt = swd_delay_cnt; --cnt > 0;); for(cnt = swd_delay_cnt; --cnt > 0;);
} }
} else { } else {
while (ticks--) { while (ticks--) {
gpio_set(SWCLK_PORT, SWCLK_PIN); gpio_set(SWCLK_PORT, SWCLK_PIN);
MS >>= 1; tms_states >>= 1;
gpio_set_val(SWDIO_PORT, SWDIO_PIN, MS & 1); gpio_set_val(SWDIO_PORT, SWDIO_PIN, tms_states & 1);
gpio_clear(SWCLK_PORT, SWCLK_PIN); gpio_clear(SWCLK_PORT, SWCLK_PIN);
} }
} }
} }
static void swdptap_seq_out_parity(uint32_t MS, int ticks) static void swdptap_seq_out_parity(uint32_t tms_states, size_t ticks)
{ {
int parity = __builtin_popcount(MS); int parity = __builtin_popcount(tms_states);
#ifdef DEBUG_SWD_BITS #ifdef DEBUG_SWD_BITS
for (int i = 0; i < ticks; i++) for (int i = 0; i < ticks; i++)
DEBUG("%d", (MS & (1 << i)) ? 1 : 0); DEBUG("%d", (tms_states & (1 << i)) ? 1 : 0);
#endif #endif
register volatile int32_t cnt; register volatile int32_t cnt;
swdptap_turnaround(SWDIO_STATUS_DRIVE); swdptap_turnaround(SWDIO_STATUS_DRIVE);
gpio_set_val(SWDIO_PORT, SWDIO_PIN, MS & 1); gpio_set_val(SWDIO_PORT, SWDIO_PIN, tms_states & 1);
MS >>= 1; tms_states >>= 1;
if (swd_delay_cnt) { if (swd_delay_cnt) {
while (ticks--) { while (ticks--) {
gpio_set(SWCLK_PORT, SWCLK_PIN); gpio_set(SWCLK_PORT, SWCLK_PIN);
for(cnt = swd_delay_cnt; --cnt > 0;); for(cnt = swd_delay_cnt; --cnt > 0;);
gpio_set_val(SWDIO_PORT, SWDIO_PIN, MS & 1); gpio_set_val(SWDIO_PORT, SWDIO_PIN, tms_states & 1);
MS >>= 1; tms_states >>= 1;
gpio_clear(SWCLK_PORT, SWCLK_PIN); gpio_clear(SWCLK_PORT, SWCLK_PIN);
for(cnt = swd_delay_cnt; --cnt > 0;); for(cnt = swd_delay_cnt; --cnt > 0;);
} }
} else { } else {
while (ticks--) { while (ticks--) {
gpio_set(SWCLK_PORT, SWCLK_PIN); gpio_set(SWCLK_PORT, SWCLK_PIN);
gpio_set_val(SWDIO_PORT, SWDIO_PIN, MS & 1); gpio_set_val(SWDIO_PORT, SWDIO_PIN, tms_states & 1);
MS >>= 1; tms_states >>= 1;
gpio_clear(SWCLK_PORT, SWCLK_PIN); gpio_clear(SWCLK_PORT, SWCLK_PIN);
} }
} }

View File

@ -764,7 +764,7 @@ int dap_jtag_configure(void)
return 0; return 0;
} }
void dap_swdptap_seq_out(uint32_t tms_states, int clock_cycles) void dap_swdptap_seq_out(uint32_t tms_states, size_t clock_cycles)
{ {
/* clang-format off */ /* clang-format off */
uint8_t buf[64] = { uint8_t buf[64] = {
@ -781,7 +781,7 @@ void dap_swdptap_seq_out(uint32_t tms_states, int clock_cycles)
DEBUG_WARN("dap_swdptap_seq_out error\n"); DEBUG_WARN("dap_swdptap_seq_out error\n");
} }
void dap_swdptap_seq_out_parity(uint32_t tms_states, int clock_cycles) void dap_swdptap_seq_out_parity(uint32_t tms_states, size_t clock_cycles)
{ {
/* clang-format off */ /* clang-format off */
uint8_t buf[] = { uint8_t buf[] = {

View File

@ -83,7 +83,7 @@ void dap_write_single(ADIv5_AP_t *ap, uint32_t dest, const void *src, enum align
int dbg_dap_cmd(uint8_t *data, int size, int rsize); int dbg_dap_cmd(uint8_t *data, int size, int rsize);
void dap_jtagtap_tdi_tdo_seq(uint8_t *data_out, bool final_tms, const uint8_t *tms, const uint8_t *data_in, size_t clock_cycles); void dap_jtagtap_tdi_tdo_seq(uint8_t *data_out, bool final_tms, const uint8_t *tms, const uint8_t *data_in, size_t clock_cycles);
int dap_jtag_configure(void); int dap_jtag_configure(void);
void dap_swdptap_seq_out(uint32_t tms_states, int clock_cycles); void dap_swdptap_seq_out(uint32_t tms_states, size_t clock_cycles);
void dap_swdptap_seq_out_parity(uint32_t tms_states, int clock_cycles); void dap_swdptap_seq_out_parity(uint32_t tms_states, size_t clock_cycles);
#endif // _DAP_H_ #endif // _DAP_H_

View File

@ -36,12 +36,11 @@ static enum swdio_status olddir;
static bool do_mpsse; static bool do_mpsse;
static bool direct_bb_swd; static bool direct_bb_swd;
#define MPSSE_MASK (MPSSE_DO | MPSSE_DI | MPSSE_CS) #define MPSSE_MASK (MPSSE_DO | MPSSE_DI | MPSSE_CS)
#define MPSSE_TD_MASK (MPSSE_DO | MPSSE_DI) #define MPSSE_TD_MASK (MPSSE_DO | MPSSE_DI)
#define MPSSE_TMS_SHIFT (MPSSE_WRITE_TMS | MPSSE_LSB |\ #define MPSSE_TMS_SHIFT (MPSSE_WRITE_TMS | MPSSE_LSB | MPSSE_BITMODE | MPSSE_WRITE_NEG)
MPSSE_BITMODE | MPSSE_WRITE_NEG) #define MPSSE_TDO_SHIFT (MPSSE_DO_WRITE | MPSSE_LSB | MPSSE_BITMODE | MPSSE_WRITE_NEG)
#define MPSSE_TDO_SHIFT (MPSSE_DO_WRITE | MPSSE_LSB |\
MPSSE_BITMODE | MPSSE_WRITE_NEG)
static void swdptap_turnaround(enum swdio_status dir) static void swdptap_turnaround(enum swdio_status dir)
{ {
if (dir == olddir) if (dir == olddir)
@ -121,38 +120,38 @@ static void swdptap_turnaround(enum swdio_status dir)
} }
} }
static bool swdptap_seq_in_parity(uint32_t *res, int ticks); static bool swdptap_seq_in_parity(uint32_t *res, size_t clock_cycles);
static uint32_t swdptap_seq_in(int ticks); static uint32_t swdptap_seq_in(size_t clock_cycles);
static void swdptap_seq_out(uint32_t MS, int ticks); static void swdptap_seq_out(uint32_t tms_states, size_t clock_cycles);
static void swdptap_seq_out_parity(uint32_t MS, int ticks); static void swdptap_seq_out_parity(uint32_t tms_states, size_t clock_cycles);
bool libftdi_swd_possible(bool *do_mpsse, bool *direct_bb_swd) bool libftdi_swd_possible(bool *do_mpsse, bool *direct_bb_swd)
{ {
bool swd_read = const bool swd_read =
active_cable->mpsse_swd_read.set_data_low || active_cable->mpsse_swd_read.set_data_low ||
active_cable->mpsse_swd_read.clr_data_low || active_cable->mpsse_swd_read.clr_data_low ||
active_cable->mpsse_swd_read.set_data_high || active_cable->mpsse_swd_read.set_data_high ||
active_cable->mpsse_swd_read.clr_data_high; active_cable->mpsse_swd_read.clr_data_high;
bool swd_write = const bool swd_write =
active_cable->mpsse_swd_write.set_data_low || active_cable->mpsse_swd_write.set_data_low ||
active_cable->mpsse_swd_write.clr_data_low || active_cable->mpsse_swd_write.clr_data_low ||
active_cable->mpsse_swd_write.set_data_high || active_cable->mpsse_swd_write.set_data_high ||
active_cable->mpsse_swd_write.clr_data_high; active_cable->mpsse_swd_write.clr_data_high;
bool mpsse = swd_read && swd_write; const bool mpsse = swd_read && swd_write;
if (do_mpsse) if (do_mpsse)
*do_mpsse = mpsse; *do_mpsse = mpsse;
if (!mpsse) { if (!mpsse) {
bool bb_swd_read = const bool bb_swd_read =
active_cable->bb_swd_read.set_data_low || active_cable->bb_swd_read.set_data_low ||
active_cable->bb_swd_read.clr_data_low || active_cable->bb_swd_read.clr_data_low ||
active_cable->bb_swd_read.set_data_high || active_cable->bb_swd_read.set_data_high ||
active_cable->bb_swd_read.clr_data_high; active_cable->bb_swd_read.clr_data_high;
bool bb_swd_write = const bool bb_swd_write =
active_cable->bb_swd_write.set_data_low || active_cable->bb_swd_write.set_data_low ||
active_cable->bb_swd_write.clr_data_low || active_cable->bb_swd_write.clr_data_low ||
active_cable->bb_swd_write.set_data_high || active_cable->bb_swd_write.set_data_high ||
active_cable->bb_swd_write.clr_data_high; active_cable->bb_swd_write.clr_data_high;
bool bb_direct_possible = const bool bb_direct_possible =
active_cable->bb_swdio_in_port_cmd == GET_BITS_LOW && active_cable->bb_swdio_in_port_cmd == GET_BITS_LOW &&
active_cable->bb_swdio_in_pin == MPSSE_CS; active_cable->bb_swdio_in_pin == MPSSE_CS;
if (!bb_swd_read && !bb_swd_write) { if (!bb_swd_read && !bb_swd_write) {
@ -257,20 +256,20 @@ void swdptap_bit_out(bool val)
} }
} }
bool swdptap_seq_in_parity(uint32_t *res, int ticks) bool swdptap_seq_in_parity(uint32_t *res, size_t clock_cycles)
{ {
assert(ticks == 32); assert(clock_cycles == 32);
swdptap_turnaround(SWDIO_STATUS_FLOAT); swdptap_turnaround(SWDIO_STATUS_FLOAT);
unsigned int parity = 0; unsigned int parity = 0;
unsigned int result = 0; unsigned int result = 0;
if (do_mpsse) { if (do_mpsse) {
uint8_t DO[5]; uint8_t DO[5];
libftdi_jtagtap_tdi_tdo_seq(DO, 0, NULL, ticks + 1); libftdi_jtagtap_tdi_tdo_seq(DO, 0, NULL, clock_cycles + 1);
result = DO[0] + (DO[1] << 8) + (DO[2] << 16) + (DO[3] << 24); result = DO[0] + (DO[1] << 8) + (DO[2] << 16) + (DO[3] << 24);
parity = __builtin_parity(result & ((1LL << ticks) - 1)) & 1; parity = __builtin_parity(result & ((1LL << clock_cycles) - 1)) & 1;
parity ^= DO[4] & 1; parity ^= DO[4] & 1;
} else { } else {
int index = ticks + 1; size_t index = clock_cycles + 1;
uint8_t cmd[4]; uint8_t cmd[4];
cmd[0] = active_cable->bb_swdio_in_port_cmd; cmd[0] = active_cable->bb_swdio_in_port_cmd;
@ -281,10 +280,10 @@ bool swdptap_seq_in_parity(uint32_t *res, int ticks)
libftdi_buffer_write(cmd, sizeof(cmd)); libftdi_buffer_write(cmd, sizeof(cmd));
} }
uint8_t data[33]; uint8_t data[33];
libftdi_buffer_read(data, ticks + 1); libftdi_buffer_read(data, clock_cycles + 1);
if (data[ticks] & active_cable->bb_swdio_in_pin) if (data[clock_cycles] & active_cable->bb_swdio_in_pin)
parity ^= 1; parity ^= 1;
index = ticks; index = clock_cycles;
while (index--) { while (index--) {
if (data[index] & active_cable->bb_swdio_in_pin) { if (data[index] & active_cable->bb_swdio_in_pin) {
parity ^= 1; parity ^= 1;
@ -296,23 +295,23 @@ bool swdptap_seq_in_parity(uint32_t *res, int ticks)
return parity; return parity;
} }
static uint32_t swdptap_seq_in(int ticks) static uint32_t swdptap_seq_in(size_t clock_cycles)
{ {
if (!ticks) if (!clock_cycles)
return 0; return 0;
uint32_t result = 0; uint32_t result = 0;
swdptap_turnaround(SWDIO_STATUS_FLOAT); swdptap_turnaround(SWDIO_STATUS_FLOAT);
if (do_mpsse) { if (do_mpsse) {
uint8_t DO[4]; uint8_t DO[4];
libftdi_jtagtap_tdi_tdo_seq(DO, 0, NULL, ticks); libftdi_jtagtap_tdi_tdo_seq(DO, 0, NULL, clock_cycles);
int bytes = ticks >> 3; int bytes = clock_cycles >> 3;
if (ticks & 7) if (clock_cycles & 7)
bytes++; bytes++;
for (int i = 0; i < bytes; i++) { for (int i = 0; i < bytes; i++) {
result |= DO[i] << (8 * i); result |= DO[i] << (8 * i);
} }
} else { } else {
int index = ticks; size_t index = clock_cycles;
uint8_t cmd[4]; uint8_t cmd[4];
cmd[0] = active_cable->bb_swdio_in_port_cmd; cmd[0] = active_cable->bb_swdio_in_port_cmd;
@ -324,8 +323,8 @@ static uint32_t swdptap_seq_in(int ticks)
libftdi_buffer_write(cmd, sizeof(cmd)); libftdi_buffer_write(cmd, sizeof(cmd));
} }
uint8_t data[32]; uint8_t data[32];
libftdi_buffer_read(data, ticks); libftdi_buffer_read(data, clock_cycles);
index = ticks; index = clock_cycles;
while (index--) { while (index--) {
if (data[index] & active_cable->bb_swdio_in_pin) if (data[index] & active_cable->bb_swdio_in_pin)
result |= (1 << index); result |= (1 << index);
@ -334,32 +333,32 @@ static uint32_t swdptap_seq_in(int ticks)
return result; return result;
} }
static void swdptap_seq_out(uint32_t MS, int ticks) static void swdptap_seq_out(uint32_t tms_states, size_t clock_cycles)
{ {
if (!ticks) if (!clock_cycles)
return; return;
swdptap_turnaround(SWDIO_STATUS_DRIVE); swdptap_turnaround(SWDIO_STATUS_DRIVE);
if (do_mpsse) { if (do_mpsse) {
uint8_t DI[4]; uint8_t DI[4];
DI[0] = (MS >> 0) & 0xff; DI[0] = (tms_states >> 0) & 0xff;
DI[1] = (MS >> 8) & 0xff; DI[1] = (tms_states >> 8) & 0xff;
DI[2] = (MS >> 16) & 0xff; DI[2] = (tms_states >> 16) & 0xff;
DI[3] = (MS >> 24) & 0xff; DI[3] = (tms_states >> 24) & 0xff;
libftdi_jtagtap_tdi_tdo_seq(NULL, 0, DI, ticks); libftdi_jtagtap_tdi_tdo_seq(NULL, 0, DI, clock_cycles);
} else { } else {
uint8_t cmd[16]; uint8_t cmd[16];
unsigned int index = 0; size_t index = 0;
while (ticks) { while (clock_cycles) {
cmd[index++] = MPSSE_TMS_SHIFT; cmd[index++] = MPSSE_TMS_SHIFT;
if (ticks >= 7) { if (clock_cycles >= 7) {
cmd[index++] = 6; cmd[index++] = 6;
cmd[index++] = MS & 0x7f; cmd[index++] = tms_states & 0x7f;
MS >>= 7; tms_states >>= 7;
ticks -= 7; clock_cycles -= 7;
} else { } else {
cmd[index++] = ticks - 1; cmd[index++] = clock_cycles - 1;
cmd[index++] = MS & 0x7f; cmd[index++] = tms_states & 0x7f;
ticks = 0; clock_cycles = 0;
} }
} }
libftdi_buffer_write(cmd, index); libftdi_buffer_write(cmd, index);
@ -375,33 +374,33 @@ static void swdptap_seq_out(uint32_t MS, int ticks)
* Implement last option to favour correctness over * Implement last option to favour correctness over
* slight speed decrease * slight speed decrease
*/ */
static void swdptap_seq_out_parity(uint32_t MS, int ticks) static void swdptap_seq_out_parity(uint32_t tms_states, size_t clock_cycles)
{ {
(void) ticks; (void) clock_cycles;
int parity = __builtin_parity(MS) & 1; int parity = __builtin_parity(tms_states) & 1;
unsigned int index = 0; size_t index = 0;
swdptap_turnaround(SWDIO_STATUS_DRIVE); swdptap_turnaround(SWDIO_STATUS_DRIVE);
if (do_mpsse) { if (do_mpsse) {
uint8_t DI[8]; uint8_t DI[8];
DI[0] = (MS >> 0) & 0xff; DI[0] = (tms_states >> 0) & 0xff;
DI[1] = (MS >> 8) & 0xff; DI[1] = (tms_states >> 8) & 0xff;
DI[2] = (MS >> 16) & 0xff; DI[2] = (tms_states >> 16) & 0xff;
DI[3] = (MS >> 24) & 0xff; DI[3] = (tms_states >> 24) & 0xff;
DI[4] = parity; DI[4] = parity;
DI[5] = 0; DI[5] = 0;
libftdi_jtagtap_tdi_tdo_seq(NULL, 0, DI, 32 + 1 + 8); libftdi_jtagtap_tdi_tdo_seq(NULL, 0, DI, 32 + 1 + 8);
} else { } else {
uint8_t cmd[32]; uint8_t cmd[32];
int steps = ticks; size_t steps = clock_cycles;
while (steps) { while (steps) {
cmd[index++] = MPSSE_TMS_SHIFT; cmd[index++] = MPSSE_TMS_SHIFT;
cmd[index++] = 6; cmd[index++] = 6;
if (steps >= 7) { if (steps >= 7) {
cmd[index++] = MS & 0x7f; cmd[index++] = tms_states & 0x7f;
MS >>= 7; tms_states >>= 7;
steps -= 7; steps -= 7;
} else { } else {
cmd[index++] = (MS & 0x7f) | (parity << 4); cmd[index++] = (tms_states & 0x7f) | (parity << 4);
steps = 0; steps = 0;
} }
} }

View File

@ -30,110 +30,97 @@
#include "remote.h" #include "remote.h"
#include "bmp_remote.h" #include "bmp_remote.h"
static bool swdptap_seq_in_parity(uint32_t *res, int ticks); static bool swdptap_seq_in_parity(uint32_t *res, size_t clock_cycles);
static uint32_t swdptap_seq_in(int ticks); static uint32_t swdptap_seq_in(size_t clock_cycles);
static void swdptap_seq_out(uint32_t MS, int ticks); static void swdptap_seq_out(uint32_t tms_states, size_t clock_cycles);
static void swdptap_seq_out_parity(uint32_t MS, int ticks); static void swdptap_seq_out_parity(uint32_t tms_states, size_t clock_cycles);
int remote_swdptap_init(ADIv5_DP_t *dp) int remote_swdptap_init(ADIv5_DP_t *dp)
{ {
DEBUG_WIRE("remote_swdptap_init\n"); DEBUG_WIRE("remote_swdptap_init\n");
uint8_t construct[REMOTE_MAX_MSG_SIZE]; uint8_t construct[REMOTE_MAX_MSG_SIZE];
int s; int s = sprintf((char *)construct, "%s", REMOTE_SWDP_INIT_STR);
s = sprintf((char *)construct,"%s", REMOTE_SWDP_INIT_STR);
platform_buffer_write(construct, s); platform_buffer_write(construct, s);
s = platform_buffer_read(construct, REMOTE_MAX_MSG_SIZE); s = platform_buffer_read(construct, REMOTE_MAX_MSG_SIZE);
if ((!s) || (construct[0] == REMOTE_RESP_ERR)) { if ((!s) || (construct[0] == REMOTE_RESP_ERR)) {
DEBUG_WARN("swdptap_init failed, error %s\n", DEBUG_WARN("swdptap_init failed, error %s\n", s ? (char *)&(construct[1]) : "unknown");
s ? (char *)&(construct[1]) : "unknown");
exit(-1); exit(-1);
} }
dp->seq_in = swdptap_seq_in; dp->seq_in = swdptap_seq_in;
dp->seq_in_parity = swdptap_seq_in_parity; dp->seq_in_parity = swdptap_seq_in_parity;
dp->seq_out = swdptap_seq_out; dp->seq_out = swdptap_seq_out;
dp->seq_out_parity = swdptap_seq_out_parity; dp->seq_out_parity = swdptap_seq_out_parity;
dp->dp_read = firmware_swdp_read; dp->dp_read = firmware_swdp_read;
dp->error = firmware_swdp_error; dp->error = firmware_swdp_error;
dp->low_access = firmware_swdp_low_access; dp->low_access = firmware_swdp_low_access;
dp->abort = firmware_swdp_abort; dp->abort = firmware_swdp_abort;
return 0; return 0;
} }
static bool swdptap_seq_in_parity(uint32_t *res, int ticks) static bool swdptap_seq_in_parity(uint32_t *res, size_t clock_cycles)
{ {
uint8_t construct[REMOTE_MAX_MSG_SIZE]; uint8_t construct[REMOTE_MAX_MSG_SIZE];
int s;
s = sprintf((char *)construct, REMOTE_SWDP_IN_PAR_STR, ticks); int s = sprintf((char *)construct, REMOTE_SWDP_IN_PAR_STR, clock_cycles);
platform_buffer_write(construct, s); platform_buffer_write(construct, s);
s = platform_buffer_read(construct, REMOTE_MAX_MSG_SIZE); s = platform_buffer_read(construct, REMOTE_MAX_MSG_SIZE);
if ((s<2) || (construct[0] == REMOTE_RESP_ERR)) { if ((s < 2) || (construct[0] == REMOTE_RESP_ERR)) {
DEBUG_WARN("swdptap_seq_in_parity failed, error %s\n", DEBUG_WARN("swdptap_seq_in_parity failed, error %s\n", s ? (char *)&(construct[1]) : "short response");
s ? (char *)&(construct[1]) : "short response");
exit(-1); exit(-1);
} }
*res=remotehston(-1, (char *)&construct[1]); *res = remotehston(-1, (char *)&construct[1]);
DEBUG_PROBE("swdptap_seq_in_parity %2d ticks: %08" PRIx32 " %s\n", DEBUG_PROBE("swdptap_seq_in_parity %2d clock_cycles: %08" PRIx32 " %s\n", clock_cycles, *res,
ticks, *res, (construct[0] != REMOTE_RESP_OK) ? "ERR" : "OK"); (construct[0] != REMOTE_RESP_OK) ? "ERR" : "OK");
return (construct[0] != REMOTE_RESP_OK); return (construct[0] != REMOTE_RESP_OK);
} }
static uint32_t swdptap_seq_in(int ticks) static uint32_t swdptap_seq_in(size_t clock_cycles)
{ {
uint8_t construct[REMOTE_MAX_MSG_SIZE]; uint8_t construct[REMOTE_MAX_MSG_SIZE];
int s;
s = sprintf((char *)construct, REMOTE_SWDP_IN_STR, ticks); int s = sprintf((char *)construct, REMOTE_SWDP_IN_STR, clock_cycles);
platform_buffer_write(construct,s); platform_buffer_write(construct, s);
s = platform_buffer_read(construct, REMOTE_MAX_MSG_SIZE); s = platform_buffer_read(construct, REMOTE_MAX_MSG_SIZE);
if ((s<2) || (construct[0] == REMOTE_RESP_ERR)) { if ((s < 2) || (construct[0] == REMOTE_RESP_ERR)) {
DEBUG_WARN("swdptap_seq_in failed, error %s\n", DEBUG_WARN("swdptap_seq_in failed, error %s\n", s ? (char *)construct + 1 : "short response");
s ? (char *)&(construct[1]) : "short response"); exit(-1);
exit(-1); }
} uint32_t res = remotehston(-1, (char *)&construct[1]);
uint32_t res = remotehston(-1,(char *)&construct[1]); DEBUG_PROBE("swdptap_seq_in %2d clock_cycles: %08" PRIx32 "\n", clock_cycles, res);
DEBUG_PROBE("swdptap_seq_in %2d ticks: %08" PRIx32 "\n",
ticks, res);
return res; return res;
} }
static void swdptap_seq_out(uint32_t MS, int ticks) static void swdptap_seq_out(uint32_t tms_states, size_t clock_cycles)
{ {
uint8_t construct[REMOTE_MAX_MSG_SIZE]; uint8_t construct[REMOTE_MAX_MSG_SIZE];
int s;
DEBUG_PROBE("swdptap_seq_out %2d ticks: %08" PRIx32 "\n", DEBUG_PROBE("swdptap_seq_out %2d clock_cycles: %08" PRIx32 "\n", clock_cycles, tms_states);
ticks, MS); int s = sprintf((char *)construct, REMOTE_SWDP_OUT_STR, clock_cycles, tms_states);
s = sprintf((char *)construct,REMOTE_SWDP_OUT_STR, ticks, MS);
platform_buffer_write(construct, s);
s=platform_buffer_read(construct, REMOTE_MAX_MSG_SIZE);
if ((s < 1) || (construct[0] == REMOTE_RESP_ERR)) {
DEBUG_WARN("swdptap_seq_out failed, error %s\n",
s ? (char *)&(construct[1]) : "short response");
exit(-1);
}
}
static void swdptap_seq_out_parity(uint32_t MS, int ticks)
{
uint8_t construct[REMOTE_MAX_MSG_SIZE];
int s;
DEBUG_PROBE("swdptap_seq_out_parity %2d ticks: %08" PRIx32 "\n",
ticks, MS);
s = sprintf((char *)construct, REMOTE_SWDP_OUT_PAR_STR, ticks, MS);
platform_buffer_write(construct, s); platform_buffer_write(construct, s);
s = platform_buffer_read(construct, REMOTE_MAX_MSG_SIZE); s = platform_buffer_read(construct, REMOTE_MAX_MSG_SIZE);
if ((s < 1) || (construct[1] == REMOTE_RESP_ERR)){ if ((s < 1) || (construct[0] == REMOTE_RESP_ERR)) {
DEBUG_WARN("swdptap_seq_out_parity failed, error %s\n", DEBUG_WARN("swdptap_seq_out failed, error %s\n", s ? (char *)construct + 1 : "short response");
s ? (char *)&(construct[2]) : "short response"); exit(-1);
exit(-1); }
} }
static void swdptap_seq_out_parity(uint32_t tms_states, size_t clock_cycles)
{
uint8_t construct[REMOTE_MAX_MSG_SIZE];
DEBUG_PROBE("swdptap_seq_out_parity %2d clock_cycles: %08" PRIx32 "\n", clock_cycles, tms_states);
int s = sprintf((char *)construct, REMOTE_SWDP_OUT_PAR_STR, clock_cycles, tms_states);
platform_buffer_write(construct, s);
s = platform_buffer_read(construct, REMOTE_MAX_MSG_SIZE);
if ((s < 1) || (construct[1] == REMOTE_RESP_ERR)) {
DEBUG_WARN("swdptap_seq_out_parity failed, error %s\n", s ? (char *)construct + 2 : "short response");
exit(-1);
}
} }

View File

@ -171,10 +171,10 @@ typedef struct ADIv5_DP_s {
uint32_t idcode; uint32_t idcode;
uint32_t targetid; /* Contains IDCODE for DPv2 devices.*/ uint32_t targetid; /* Contains IDCODE for DPv2 devices.*/
void (*seq_out)(uint32_t MS, int ticks); void (*seq_out)(uint32_t tms_states, size_t clock_cycles);
void (*seq_out_parity)(uint32_t MS, int ticks); void (*seq_out_parity)(uint32_t tms_states, size_t clock_cycles);
uint32_t (*seq_in)(int ticks); uint32_t (*seq_in)(size_t clock_cycles);
bool (*seq_in_parity)(uint32_t *ret, int ticks); bool (*seq_in_parity)(uint32_t *ret, size_t clock_cycles);
/* dp_low_write returns true if no OK resonse, but ignores errors */ /* dp_low_write returns true if no OK resonse, but ignores errors */
bool (*dp_low_write)(struct ADIv5_DP_s *dp, uint16_t addr, bool (*dp_low_write)(struct ADIv5_DP_s *dp, uint16_t addr,
const uint32_t data); const uint32_t data);