sys64738
/
blackmagic
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fix lpc11xx magic number programming when chunks overlap 

In the case where the vectors are in a separate section smaller than
the chunksize, the lpc11xx magic number calculation could generate an
incorrect value.
This commit is contained in:
none 2014-06-10 21:23:17 -07:00
parent 72ae78a185
commit 3543e560af
1 changed files with 15 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
src/lpc11xx.c
View File

@ -220,26 +220,26 @@ lpc11xx_flash_write(struct target_s *target, uint32_t dest, const uint8_t *src,
copylen = len;
memcpy(&flash_pgm.data[chunk_offset], src, copylen);
/* if we are programming the vectors, calculate the magic number */
if ((chunk == 0) && (chunk_offset == 0)) {
if (copylen < 32) {
/* we have to be programming at least the first 8 vectors... */
return -1;
}
uint32_t *w = (uint32_t *)(&flash_pgm.data[0]);
uint32_t sum = 0;
for (unsigned i = 0; i < 7; i++)
sum += w[i];
w[7] = ~sum + 1;
}
/* update to suit */
len -= copylen;
src += copylen;
chunk_offset = 0;
/* if we are programming the vectors, calculate the magic number */
if (chunk * IAP_PGM_CHUNKSIZE == 0) {
uint32_t *w = (uint32_t *)(&flash_pgm.data[0]);
uint32_t sum = 0;
if (copylen >= 7) {
for (unsigned i = 0; i < 7; i++)
sum += w[i];
w[7] = 0 - sum;
} else {
/* We can't possibly calculate the magic number */
return -1;
}
}
} else {
/* interior chunk, must be aligned and full-sized */