sys64738
/
blackmagic
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

hosted/remote_jtagtap: Refactored jtagtap_tms_seq and cleaned up

This commit is contained in:
dragonmux 2022-07-22 14:33:34 +01:00 committed by Piotr Esden-Tempski
parent 267dabacb1
commit 5876c7674b
1 changed files with 9 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
src/platforms/hosted/remote_jtagtap.c
View File

@ -37,7 +37,7 @@
#include "bmp_remote.h" #include "bmp_remote.h"
static void jtagtap_reset(void); static void jtagtap_reset(void);
static void jtagtap_tms_seq(uint32_t MS, size_t ticks); static void jtagtap_tms_seq(uint32_t tms_states, size_t ticks);
static void jtagtap_tdi_tdo_seq(uint8_t *data_out, bool final_tms, const uint8_t *data_in, size_t clock_cycles); static void jtagtap_tdi_tdo_seq(uint8_t *data_out, bool final_tms, const uint8_t *data_in, size_t clock_cycles);
static void jtagtap_tdi_seq(bool final_tms, const uint8_t *data_in, size_t clock_cycles); static void jtagtap_tdi_seq(bool final_tms, const uint8_t *data_in, size_t clock_cycles);
static bool jtagtap_next(bool tms, bool tdi); static bool jtagtap_next(bool tms, bool tdi);
@ -95,22 +95,20 @@ static void jtagtap_reset(void)
} }
} }
static void jtagtap_tms_seq(uint32_t MS, size_t ticks) static void jtagtap_tms_seq(uint32_t tms_states, size_t clock_cycles)
{ {
uint8_t construct[REMOTE_MAX_MSG_SIZE]; char buffer[REMOTE_MAX_MSG_SIZE];
int s; int length = snprintf(buffer, REMOTE_MAX_MSG_SIZE, REMOTE_JTAG_TMS_STR, clock_cycles, tms_states);
platform_buffer_write((uint8_t *)buffer, length);
s = snprintf((char *)construct, REMOTE_MAX_MSG_SIZE, REMOTE_JTAG_TMS_STR, ticks, MS); length = platform_buffer_read((uint8_t *)buffer, REMOTE_MAX_MSG_SIZE);
platform_buffer_write(construct, s); if (!length || buffer[0] == REMOTE_RESP_ERR) {
DEBUG_WARN("jtagtap_tms_seq failed, error %s\n", length ? buffer + 1 : "unknown");
s = platform_buffer_read(construct, REMOTE_MAX_MSG_SIZE);
if ((!s) || (construct[0] == REMOTE_RESP_ERR)) {
DEBUG_WARN("jtagtap_tms_seq failed, error %s\n", s ? (char *)&(construct[1]) : "unknown");
exit(-1); exit(-1);
} }
} }
/* At least up to v1.7.1-233, remote handles only up to 32 ticks in one /* At least up to v1.7.1-233, remote handles only up to 32 clock cycles in one
* call. Break up large calls. * call. Break up large calls.
* *
* FIXME: Provide and test faster call and keep fallback * FIXME: Provide and test faster call and keep fallback