sys64738
/
blackmagic
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

adiv5: Revert f010a56 as it makes bad assumptions about APs that use the same base address

This commit is contained in:
dragonmux 2022-08-29 00:40:09 +01:00 committed by Piotr Esden-Tempski
parent e59ebb0e1d
commit cfa9e9858d
1 changed files with 0 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
src/target/adiv5.c
View File

@ -833,7 +833,6 @@ void adiv5_dp_init(ADIv5_DP_t *dp, const uint32_t idcode)
} }
/* Probe for APs on this DP */ /* Probe for APs on this DP */
uint32_t last_base = 0;
size_t invalid_aps = 0; size_t invalid_aps = 0;
dp->refcnt++; dp->refcnt++;
for (size_t i = 0; i < 256 && invalid_aps < 8; ++i) { for (size_t i = 0; i < 256 && invalid_aps < 8; ++i) {
@ -855,18 +854,6 @@ void adiv5_dp_init(ADIv5_DP_t *dp, const uint32_t idcode)
} }
continue; continue;
} }
if (ap->base == last_base) {
DEBUG_WARN("AP %d: Duplicate base\n", i);
#if PC_HOSTED == 1
if (dp->ap_cleanup)
dp->ap_cleanup(i);
#endif
adiv5_ap_unref(ap);
adiv5_dp_unref(dp);
/* FIXME: Should we expect valid APs behind duplicate ones? */
return;
}
last_base = ap->base;
kinetis_mdm_probe(ap); kinetis_mdm_probe(ap);
nrf51_mdm_probe(ap); nrf51_mdm_probe(ap);