sys64738
/
blackmagic
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

gdb_if: Fix USB flow control. 

The introduction of the double buffering broke USB flow control, causing
loss of data when a new packet arrived with the previous still present in
the double buffer.

With this patch the endpoint is kept in NAK until the double buffer is empty.
This commit is contained in:
Vegard Storheil Eriksen 2013-03-06 20:36:49 +01:00
parent 530ee15153
commit e8f9d52d2f
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/platforms/stm32/gdb_if.c
View File

@ -54,8 +54,12 @@ void gdb_if_putchar(unsigned char c, int flush)
void gdb_usb_out_cb(usbd_device *dev, uint8_t ep) void gdb_usb_out_cb(usbd_device *dev, uint8_t ep)
{ {
(void)ep; (void)ep;
usbd_ep_nak_set(dev, CDCACM_GDB_ENDPOINT, 1);
count_new = usbd_ep_read_packet(dev, CDCACM_GDB_ENDPOINT, count_new = usbd_ep_read_packet(dev, CDCACM_GDB_ENDPOINT,
double_buffer_out, CDCACM_PACKET_SIZE); double_buffer_out, CDCACM_PACKET_SIZE);
if(!count_new) {
usbd_ep_nak_set(dev, CDCACM_GDB_ENDPOINT, 0);
}
} }
unsigned char gdb_if_getchar(void) unsigned char gdb_if_getchar(void)
@ -72,6 +76,7 @@ unsigned char gdb_if_getchar(void)
count_out = count_new; count_out = count_new;
count_new = 0; count_new = 0;
out_ptr = 0; out_ptr = 0;
usbd_ep_nak_set(usbdev, CDCACM_GDB_ENDPOINT, 0);
} }
} }
@ -93,6 +98,7 @@ unsigned char gdb_if_getchar_to(int timeout)
count_out = count_new; count_out = count_new;
count_new = 0; count_new = 0;
out_ptr = 0; out_ptr = 0;
usbd_ep_nak_set(usbdev, CDCACM_GDB_ENDPOINT, 0);
} }
} while(timeout_counter && !(out_ptr < count_out)); } while(timeout_counter && !(out_ptr < count_out));