BLAHAJ
/
libsigrok
10
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

beaglelogic: fixup use of uninitialized data in TCP routines 

Make sure that failure to communicate via TCP results in access to
uninitialized data.

This was reported by clang's scan-build.
This commit is contained in:
Gerhard Sittig 2018-02-08 22:31:48 +01:00 committed by Uwe Hermann
parent 71f2000bfb
commit 05b0cc416f
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/hardware/beaglelogic/beaglelogic_tcp.c
View File

@ -172,6 +172,7 @@ static int beaglelogic_tcp_get_string(struct dev_context *devc, const char *cmd,
int len; int len;
gint64 timeout; gint64 timeout;
*tcp_resp = NULL;
if (cmd) { if (cmd) {
if (beaglelogic_tcp_send_cmd(devc, cmd) != SR_OK) if (beaglelogic_tcp_send_cmd(devc, cmd) != SR_OK)
return SR_ERR; return SR_ERR;
@ -288,9 +289,11 @@ static int beaglelogic_get_samplerate(struct dev_context *devc)
int arg, err; int arg, err;
err = beaglelogic_tcp_get_int(devc, "samplerate", &arg); err = beaglelogic_tcp_get_int(devc, "samplerate", &arg);
devc->cur_samplerate = arg; if (err)
return err;
return err; devc->cur_samplerate = arg;
return SR_OK;
} }
static int beaglelogic_set_samplerate(struct dev_context *devc) static int beaglelogic_set_samplerate(struct dev_context *devc)