BLAHAJ
/
libsigrok
10
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

lcr/es51919: clean but don't free dev context in cleanup callback 

The es51919_serial_clean() routine is called by std_dev_clear_with_callback().
Common code unconditionally frees the 'priv' part. The cleanup callback only
shall release descending resources which are local to the callee and opaque
to the caller.

This fixes a double free error. Tested with PeakTech 2170.

  $ sigrok-cli -d peaktech-2170:conn=/dev/ttyUSB0 --show
This commit is contained in:
Gerhard Sittig 2017-08-18 20:07:23 +02:00 committed by Uwe Hermann
parent 1503d4571b
commit 12788e7e40
1 changed files with 0 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/lcr/es51919.c
View File

@ -726,7 +726,6 @@ SR_PRIV void es51919_serial_clean(void *priv)
return; return;
dev_buffer_destroy(devc->buf); dev_buffer_destroy(devc->buf);
g_free(devc);
} }
SR_PRIV struct sr_dev_inst *es51919_serial_scan(GSList *options, SR_PRIV struct sr_dev_inst *es51919_serial_scan(GSList *options,